Skip to content

Fix remaining build issues on Windows, re-enable Windows pybind preset build CI job - #13702

Merged
GregoryComer merged 6 commits into
mainfrom
gh/GregoryComer/145/head
Aug 27, 2025
Merged

Fix remaining build issues on Windows, re-enable Windows pybind preset build CI job#13702
GregoryComer merged 6 commits into
mainfrom
gh/GregoryComer/145/head

Conversation

@GregoryComer

@GregoryComerGregoryComer commented Aug 26, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Note: This is a cherry-pick of #13564 and #13259. I inadvertently broke the ghstack when attempting to re-order the stack, leading to the old PR being merged by ghstack into the ghstack-created branch (not main).

Add mman_windows.cpp to the CMake sources. Fix a few build-blocking issues with XNNPACK on Windows. Enable XNNPACK on the Windows preset. This also gives CI coverage.

I've disabled 4 microkernel families that don't build currently. These likely need to be gated or fixed upstream, but I'm disabling them locally for now to unblock usage. They are relatively niche and should have little to no perf impact on the average user.

With this change, the pybind preset works and we can re-enable it in CI.

@GregoryComer
Update
d6a70d6
[ghstack-poisoned]
@GregoryComer
Update
18866f4
[ghstack-poisoned]
@GregoryComer

GregoryComer commented Aug 26, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-botBot commented Aug 26, 2025•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13702

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 27 Pending

As of commit 7010cf3 with merge base 8dff86a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-clameta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2025
GregoryComer added a commit that referenced this pull request Aug 26, 2025
@GregoryComer
Fix remaining build issues on Windows, re-enable Windows pybind prese…
44d9946
…t build CI job
ghstack-source-id: 1d47e65
ghstack-comment-id: 3225985999
Pull-Request: #13702
@GregoryComerGregoryComer mentioned this pull request Aug 26, 2025
Merged
@GregoryComer
Update
e7423a4
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 26, 2025
@GregoryComer
Fix remaining build issues on Windows, re-enable Windows pybind prese…
d5aa2b9
…t build CI job
ghstack-source-id: cb7f753
ghstack-comment-id: 3225985999
Pull-Request: #13702
@GregoryComerGregoryComer mentioned this pull request Aug 26, 2025
Merged
@GregoryComer
GregoryComer marked this pull request as ready for review August 26, 2025 23:32
@GregoryComer
Update
bca23f5
[ghstack-poisoned]
@GregoryComer
Update
ab69e35
[ghstack-poisoned]
@mergennachin

mergennachin commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

Thank you!

Base automatically changed from gh/GregoryComer/144/head to mainAugust 27, 2025 18:00
@GregoryComer
Update
7010cf3
[ghstack-poisoned]
@GregoryComerGregoryComer added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Aug 27, 2025
@GregoryComer
GregoryComer merged commit 4c4cbdf into mainAug 27, 2025
113 of 120 checks passed
@GregoryComer
GregoryComer deleted the gh/GregoryComer/145/head branch August 27, 2025 18:33
This was referenced Aug 27, 2025
Closed
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergennachinmergennachinmergennachin approved these changes
@JacobSzwejbkaJacobSzwejbkaAwaiting requested review from JacobSzwejbka
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@kirklandsignkirklandsignAwaiting requested review from kirklandsignkirklandsign is a code owner
@digantdesaidigantdesaiAwaiting requested review from digantdesaidigantdesai is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandales
@swolchokswolchokAwaiting requested review from swolchok

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GregoryComer@mergennachin