Skip to content

[Windows] Re-enable tokenizers - #14180

Closed
GregoryComer wants to merge 3 commits into
pytorch:mainfrom
GregoryComer:reenable-tokenizers-windows
Closed

[Windows] Re-enable tokenizers#14180
GregoryComer wants to merge 3 commits into
pytorch:mainfrom
GregoryComer:reenable-tokenizers-windows

Conversation

@GregoryComer

@GregoryComerGregoryComer commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Summary

After meta-pytorch/tokenizers#121 and #13888, we should be able to enable tokenizers on Windows.

Test plan

CI. Also verified that install functions on a local Windows machine.

cc @larryliu0820

@pytorch-bot

pytorch-botBot commented Sep 10, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14180

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit caafb73 with merge base f1ca55a (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-clameta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2025
@GregoryComerGregoryComer added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: windows labels Sep 10, 2025
@GregoryComerGregoryComer added this to the 1.0.0 milestone Sep 10, 2025
@GregoryComerGregoryComer mentioned this pull request Sep 11, 2025
20 tasks
@GregoryComer

Copy link
Copy Markdown
ContributorAuthor

I'm seeing some path length issues when building tokenizers in-place. I'm going to see if I can set up a symlink in the windows setup CI script.

@GregoryComer
GregoryComerforce-pushed the reenable-tokenizers-windows branch from f07394e to 3434543CompareSeptember 11, 2025 21:13
@GregoryComer

Copy link
Copy Markdown
ContributorAuthor

Rebasing to test with #13923 to be safe, but will land today if everything looks good.

@GregoryComer
GregoryComerforce-pushed the reenable-tokenizers-windows branch 8 times, most recently from 679527d to 80da2d4CompareSeptember 12, 2025 04:09
@GregoryComer
GregoryComerforce-pushed the reenable-tokenizers-windows branch from 80da2d4 to caafb73CompareSeptember 12, 2025 04:27
@GregoryComerGregoryComer removed this from the 1.0.0 milestone Sep 12, 2025
@GregoryComer

Copy link
Copy Markdown
ContributorAuthor

Removing 1.0 milestone from this PR in favor of using the pip package, when available. I'd need to make some more aggressive infra changes to the wheel build to make this work when building from source.

@github-actions

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actionsgithub-actionsBot added the Stale PRs inactive for over 60 days label Nov 12, 2025
@github-actions

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

1 similar comment
@github-actions

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.module: build/installIssues related to the cmake and buck2 builds, and to installing ExecuTorchrelease notes: windowsStalePRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@GregoryComer@mergennachin