Uh oh!
There was an error while loading. Please reload this page.
Reapply "[Windows] Run native unit tests in CI (#13923)" - #14287
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14287
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Cancelled Jobs, 1 Unrelated FailureAs of commit bfb3fca with merge base 10e93fb ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
commented
Sep 12, 2025
Contributor
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D82345075. |
GregoryComer
marked this pull request as ready for review
September 12, 2025 22:59
GregoryComer
requested review from
JacobSzwejbka, kirklandsign, larryliu0820, lucylq, manuelcandales and swolchok
as code ownersSeptember 12, 2025 22:59
JacobSzwejbka
approved these changes
Sep 12, 2025
Uh oh!
There was an error while loading. Please reload this page.
StrycekSimon pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
Differential Revision: D82345075 Pull Request resolved: pytorch#14287
jirioc pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
Differential Revision: D82345075 Pull Request resolved: pytorch#14287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a re-land of #13923, fixing Meta-internal build errors. It looks like I just need to add the
c10::namespace tois_reduced_floating_point_vin one spot. It looks like this is defined in the executorch::runtime namespace when in portable mode, but not in ATen mode:executorch/runtime/core/exec_aten/util/scalar_type_util.h
Line 85 in 233063c
Test plan
CI. I'm importing the diff to validate correctness.