Add -fexceptions to quantized kernel generated libs by Daksh-Shami · Pull Request #14962 · pytorch/executorch

Daksh-Shami · 2025-10-09T20:50:24Z

Summary:
Added compiling with -fexceptions since quantized kernels have exception based code in them. Example error:

buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable
77 | } catch (const std::exception& ex) {
|

This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets.

Differential Revision: D84284541

pytorch-bot · 2025-10-09T20:50:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14962

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 84b053b with merge base 39f474f ():

NEW FAILURE - The following job has failed:

pull / test-samsung-models-linux / linux-job (gh)
RuntimeError: Command docker exec -t 79b55dd6be0979d22ac0fc7d642293e1615a680203588c5c658a19843b5b9526 /exec failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / unittest-editable / windows / windows-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-10-09T20:50:31Z

@Daksh-Shami has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84284541.

github-actions · 2025-10-09T20:51:07Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Daksh-Shami · 2025-10-09T22:23:19Z

@pytorchbot label "release notes: build warnings"

pytorch-bot · 2025-10-09T22:23:22Z

Didn't find following labels among repository labels: release notes: build warnings

Summary: Added compiling with `-fexceptions` since quantized kernels have exception based code in them. Example error: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

…14962) Summary: Explicitly turning exception generated code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly turn them off. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

Summary: Explicitly declaring generated libs with exception code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the existing generated code uses exceptions in its code, so when we use these kernels with -fno-exceptions downstream, the build fails. After this diff, we can use the exception free kernels with 'no_exceptions' suffix -- `//xplat/executorch/kernels/quantized:generated_lib_no_exceptions` or `//xplat/executorch/kernels/quantized:generated_lib_aten_no_exceptions` as appropriate. We still have `//xplat/executorch/kernels/quantized:generated_lib` and `//xplat/executorch/kernels/quantized:generated_lib_aten` available, same as before, so no downstream side effects are expected. Reviewed By: swolchok Differential Revision: D84284541

Differential Revision: D84284541 Pull Request resolved: pytorch#14962

Daksh-Shami · 2025-10-09T20:50:24Z

Summary:
Added compiling with -fexceptions since quantized kernels have exception based code in them. Example error:

buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable
77 | } catch (const std::exception& ex) {
|

This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets.

Differential Revision: D84284541

pytorch-bot · 2025-10-09T20:50:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14962

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 84b053b with merge base 39f474f ():

NEW FAILURE - The following job has failed:

pull / test-samsung-models-linux / linux-job (gh)
RuntimeError: Command docker exec -t 79b55dd6be0979d22ac0fc7d642293e1615a680203588c5c658a19843b5b9526 /exec failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / unittest-editable / windows / windows-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-10-09T20:50:31Z

@Daksh-Shami has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84284541.

github-actions · 2025-10-09T20:51:07Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Daksh-Shami · 2025-10-09T22:23:19Z

@pytorchbot label "release notes: build warnings"

pytorch-bot · 2025-10-09T22:23:22Z

Didn't find following labels among repository labels: release notes: build warnings

Summary: Added compiling with `-fexceptions` since quantized kernels have exception based code in them. Example error: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

…14962) Summary: Explicitly turning exception generated code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly turn them off. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

Summary: Explicitly declaring generated libs with exception code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the existing generated code uses exceptions in its code, so when we use these kernels with -fno-exceptions downstream, the build fails. After this diff, we can use the exception free kernels with 'no_exceptions' suffix -- `//xplat/executorch/kernels/quantized:generated_lib_no_exceptions` or `//xplat/executorch/kernels/quantized:generated_lib_aten_no_exceptions` as appropriate. We still have `//xplat/executorch/kernels/quantized:generated_lib` and `//xplat/executorch/kernels/quantized:generated_lib_aten` available, same as before, so no downstream side effects are expected. Reviewed By: swolchok Differential Revision: D84284541

Differential Revision: D84284541 Pull Request resolved: pytorch#14962

Daksh-Shami · 2025-10-09T20:50:24Z

Summary:
Added compiling with -fexceptions since quantized kernels have exception based code in them. Example error:

buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable
77 | } catch (const std::exception& ex) {
|

This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets.

Differential Revision: D84284541

pytorch-bot · 2025-10-09T20:50:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14962

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 84b053b with merge base 39f474f ():

NEW FAILURE - The following job has failed:

pull / test-samsung-models-linux / linux-job (gh)
RuntimeError: Command docker exec -t 79b55dd6be0979d22ac0fc7d642293e1615a680203588c5c658a19843b5b9526 /exec failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / unittest-editable / windows / windows-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-10-09T20:50:31Z

@Daksh-Shami has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84284541.

github-actions · 2025-10-09T20:51:07Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Daksh-Shami · 2025-10-09T22:23:19Z

@pytorchbot label "release notes: build warnings"

pytorch-bot · 2025-10-09T22:23:22Z

Didn't find following labels among repository labels: release notes: build warnings

Summary: Added compiling with `-fexceptions` since quantized kernels have exception based code in them. Example error: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

…14962) Summary: Explicitly turning exception generated code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly turn them off. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

Summary: Explicitly declaring generated libs with exception code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the existing generated code uses exceptions in its code, so when we use these kernels with -fno-exceptions downstream, the build fails. After this diff, we can use the exception free kernels with 'no_exceptions' suffix -- `//xplat/executorch/kernels/quantized:generated_lib_no_exceptions` or `//xplat/executorch/kernels/quantized:generated_lib_aten_no_exceptions` as appropriate. We still have `//xplat/executorch/kernels/quantized:generated_lib` and `//xplat/executorch/kernels/quantized:generated_lib_aten` available, same as before, so no downstream side effects are expected. Reviewed By: swolchok Differential Revision: D84284541

Differential Revision: D84284541 Pull Request resolved: pytorch#14962

Daksh-Shami · 2025-10-09T20:50:24Z

Summary:
Added compiling with -fexceptions since quantized kernels have exception based code in them. Example error:

buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable
77 | } catch (const std::exception& ex) {
|

This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets.

Differential Revision: D84284541

pytorch-bot · 2025-10-09T20:50:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14962

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 84b053b with merge base 39f474f ():

NEW FAILURE - The following job has failed:

pull / test-samsung-models-linux / linux-job (gh)
RuntimeError: Command docker exec -t 79b55dd6be0979d22ac0fc7d642293e1615a680203588c5c658a19843b5b9526 /exec failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / unittest-editable / windows / windows-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-10-09T20:50:31Z

@Daksh-Shami has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84284541.

github-actions · 2025-10-09T20:51:07Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Daksh-Shami · 2025-10-09T22:23:19Z

@pytorchbot label "release notes: build warnings"

pytorch-bot · 2025-10-09T22:23:22Z

Didn't find following labels among repository labels: release notes: build warnings

Summary: Added compiling with `-fexceptions` since quantized kernels have exception based code in them. Example error: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

…14962) Summary: Explicitly turning exception generated code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly turn them off. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

Summary: Explicitly declaring generated libs with exception code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the existing generated code uses exceptions in its code, so when we use these kernels with -fno-exceptions downstream, the build fails. After this diff, we can use the exception free kernels with 'no_exceptions' suffix -- `//xplat/executorch/kernels/quantized:generated_lib_no_exceptions` or `//xplat/executorch/kernels/quantized:generated_lib_aten_no_exceptions` as appropriate. We still have `//xplat/executorch/kernels/quantized:generated_lib` and `//xplat/executorch/kernels/quantized:generated_lib_aten` available, same as before, so no downstream side effects are expected. Reviewed By: swolchok Differential Revision: D84284541

Differential Revision: D84284541 Pull Request resolved: pytorch#14962

Daksh-Shami · 2025-10-09T20:50:24Z

Summary:
Added compiling with -fexceptions since quantized kernels have exception based code in them. Example error:

buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable
77 | } catch (const std::exception& ex) {
|

This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets.

Differential Revision: D84284541

pytorch-bot · 2025-10-09T20:50:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14962

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 84b053b with merge base 39f474f ():

NEW FAILURE - The following job has failed:

pull / test-samsung-models-linux / linux-job (gh)
RuntimeError: Command docker exec -t 79b55dd6be0979d22ac0fc7d642293e1615a680203588c5c658a19843b5b9526 /exec failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / unittest-editable / windows / windows-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-10-09T20:50:31Z

@Daksh-Shami has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84284541.

github-actions · 2025-10-09T20:51:07Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Daksh-Shami · 2025-10-09T22:23:19Z

@pytorchbot label "release notes: build warnings"

pytorch-bot · 2025-10-09T22:23:22Z

Didn't find following labels among repository labels: release notes: build warnings

Summary: Added compiling with `-fexceptions` since quantized kernels have exception based code in them. Example error: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

…14962) Summary: Explicitly turning exception generated code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly turn them off. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

Summary: Explicitly declaring generated libs with exception code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the existing generated code uses exceptions in its code, so when we use these kernels with -fno-exceptions downstream, the build fails. After this diff, we can use the exception free kernels with 'no_exceptions' suffix -- `//xplat/executorch/kernels/quantized:generated_lib_no_exceptions` or `//xplat/executorch/kernels/quantized:generated_lib_aten_no_exceptions` as appropriate. We still have `//xplat/executorch/kernels/quantized:generated_lib` and `//xplat/executorch/kernels/quantized:generated_lib_aten` available, same as before, so no downstream side effects are expected. Reviewed By: swolchok Differential Revision: D84284541

Differential Revision: D84284541 Pull Request resolved: pytorch#14962

Daksh-Shami · 2025-10-09T20:50:24Z

Summary:
Added compiling with -fexceptions since quantized kernels have exception based code in them. Example error:

buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable
77 | } catch (const std::exception& ex) {
|

This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets.

Differential Revision: D84284541

pytorch-bot · 2025-10-09T20:50:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14962

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 84b053b with merge base 39f474f ():

NEW FAILURE - The following job has failed:

pull / test-samsung-models-linux / linux-job (gh)
RuntimeError: Command docker exec -t 79b55dd6be0979d22ac0fc7d642293e1615a680203588c5c658a19843b5b9526 /exec failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / unittest-editable / windows / windows-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-10-09T20:50:31Z

@Daksh-Shami has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84284541.

github-actions · 2025-10-09T20:51:07Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Daksh-Shami · 2025-10-09T22:23:19Z

@pytorchbot label "release notes: build warnings"

pytorch-bot · 2025-10-09T22:23:22Z

Didn't find following labels among repository labels: release notes: build warnings

Summary: Added compiling with `-fexceptions` since quantized kernels have exception based code in them. Example error: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

…14962) Summary: Explicitly turning exception generated code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly turn them off. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

Summary: Explicitly declaring generated libs with exception code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the existing generated code uses exceptions in its code, so when we use these kernels with -fno-exceptions downstream, the build fails. After this diff, we can use the exception free kernels with 'no_exceptions' suffix -- `//xplat/executorch/kernels/quantized:generated_lib_no_exceptions` or `//xplat/executorch/kernels/quantized:generated_lib_aten_no_exceptions` as appropriate. We still have `//xplat/executorch/kernels/quantized:generated_lib` and `//xplat/executorch/kernels/quantized:generated_lib_aten` available, same as before, so no downstream side effects are expected. Reviewed By: swolchok Differential Revision: D84284541

Differential Revision: D84284541 Pull Request resolved: pytorch#14962

Daksh-Shami · 2025-10-09T20:50:24Z

Summary:
Added compiling with -fexceptions since quantized kernels have exception based code in them. Example error:

buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable
77 | } catch (const std::exception& ex) {
|

This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets.

Differential Revision: D84284541

pytorch-bot · 2025-10-09T20:50:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14962

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 84b053b with merge base 39f474f ():

NEW FAILURE - The following job has failed:

pull / test-samsung-models-linux / linux-job (gh)
RuntimeError: Command docker exec -t 79b55dd6be0979d22ac0fc7d642293e1615a680203588c5c658a19843b5b9526 /exec failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / unittest-editable / windows / windows-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-10-09T20:50:31Z

@Daksh-Shami has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84284541.

github-actions · 2025-10-09T20:51:07Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Daksh-Shami · 2025-10-09T22:23:19Z

@pytorchbot label "release notes: build warnings"

pytorch-bot · 2025-10-09T22:23:22Z

Didn't find following labels among repository labels: release notes: build warnings

Summary: Added compiling with `-fexceptions` since quantized kernels have exception based code in them. Example error: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

…14962) Summary: Explicitly turning exception generated code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly turn them off. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

Summary: Explicitly declaring generated libs with exception code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the existing generated code uses exceptions in its code, so when we use these kernels with -fno-exceptions downstream, the build fails. After this diff, we can use the exception free kernels with 'no_exceptions' suffix -- `//xplat/executorch/kernels/quantized:generated_lib_no_exceptions` or `//xplat/executorch/kernels/quantized:generated_lib_aten_no_exceptions` as appropriate. We still have `//xplat/executorch/kernels/quantized:generated_lib` and `//xplat/executorch/kernels/quantized:generated_lib_aten` available, same as before, so no downstream side effects are expected. Reviewed By: swolchok Differential Revision: D84284541

Differential Revision: D84284541 Pull Request resolved: pytorch#14962

Daksh-Shami · 2025-10-09T20:50:24Z

Summary:
Added compiling with -fexceptions since quantized kernels have exception based code in them. Example error:

buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable
77 | } catch (const std::exception& ex) {
|

This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets.

Differential Revision: D84284541

pytorch-bot · 2025-10-09T20:50:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14962

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 84b053b with merge base 39f474f ():

NEW FAILURE - The following job has failed:

pull / test-samsung-models-linux / linux-job (gh)
RuntimeError: Command docker exec -t 79b55dd6be0979d22ac0fc7d642293e1615a680203588c5c658a19843b5b9526 /exec failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / unittest-editable / windows / windows-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-10-09T20:50:31Z

@Daksh-Shami has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84284541.

github-actions · 2025-10-09T20:51:07Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Daksh-Shami · 2025-10-09T22:23:19Z

@pytorchbot label "release notes: build warnings"

pytorch-bot · 2025-10-09T22:23:22Z

Didn't find following labels among repository labels: release notes: build warnings

Summary: Added compiling with `-fexceptions` since quantized kernels have exception based code in them. Example error: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

…14962) Summary: Explicitly turning exception generated code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly turn them off. Differential Revision: D84284541

swolchok

Review automatically exported from Phabricator review in Meta.

Summary: Explicitly declaring generated libs with exception code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the existing generated code uses exceptions in its code, so when we use these kernels with -fno-exceptions downstream, the build fails. After this diff, we can use the exception free kernels with 'no_exceptions' suffix -- `//xplat/executorch/kernels/quantized:generated_lib_no_exceptions` or `//xplat/executorch/kernels/quantized:generated_lib_aten_no_exceptions` as appropriate. We still have `//xplat/executorch/kernels/quantized:generated_lib` and `//xplat/executorch/kernels/quantized:generated_lib_aten` available, same as before, so no downstream side effects are expected. Reviewed By: swolchok Differential Revision: D84284541

Differential Revision: D84284541 Pull Request resolved: pytorch#14962

Daksh-Shami requested review from manuelcandales and swolchok as code owners October 9, 2025 20:50

meta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2025

meta-codesyncBot added fb-exported meta-exported labels Oct 9, 2025

Daksh-Shami marked this pull request as draft October 9, 2025 21:43

Daksh-Shami marked this pull request as ready for review October 10, 2025 11:34

Daksh-Shami force-pushed the export-D84284541 branch from 3a0b7cb to 6dfc3b3Compare October 10, 2025 13:29

swolchok suggested changes Oct 10, 2025
View reviewed changes

Daksh-Shami force-pushed the export-D84284541 branch from 6dfc3b3 to 600c480Compare October 10, 2025 20:42

swolchok approved these changes Oct 15, 2025
View reviewed changes

Daksh-Shami force-pushed the export-D84284541 branch from 55b19c3 to 303979cCompare October 15, 2025 17:09

Daksh-Shami force-pushed the export-D84284541 branch from 303979c to 0cb6227Compare October 15, 2025 22:37

Daksh-Shami force-pushed the export-D84284541 branch from 0cb6227 to 74fec03Compare October 15, 2025 22:40

Daksh-Shami force-pushed the export-D84284541 branch from 74fec03 to 8efb1aeCompare October 16, 2025 14:43

Daksh-Shami force-pushed the export-D84284541 branch from 8efb1ae to be7c7c7Compare October 16, 2025 14:58

Daksh-Shami force-pushed the export-D84284541 branch from be7c7c7 to 84b053bCompare October 16, 2025 18:50

meta-codesyncBot merged commit e3e8e60 into pytorch:mainOct 16, 2025
126 of 129 checks passed

jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025
Add -fexceptions to quantized kernel generated libs
e975958
Differential Revision: D84284541 Pull Request resolved: pytorch#14962