[Executorch] Make module constructors uniform across by kimishpatel · Pull Request #15709 · pytorch/executorch

kimishpatel · 2025-11-10T17:18:16Z

Stack from ghstack (oldest at bottom):

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator.
Fix that.

Differential Revision: D86120037

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator. Fix that. Differential Revision: [D86120037](https://our.internmc.facebook.com/intern/diff/D86120037/) [ghstack-poisoned]

pytorch-bot · 2025-11-10T17:18:20Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15709

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures

As of commit 799c34b with merge base aba44fd ():

NEW FAILURES - The following jobs have failed:

Apple / build-demo-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Apple / build-frameworks-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Build Presets / apple (ios) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (llm) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (profiling) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / windows (pybind) / build (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest / windows / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-editable / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest-editable / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh)
/pytorch/executorch/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/__memory/unique_ptr.h:767:30: error: no matching constructor for initialization of 'executorch::extension::module::Module'
Test Metal Backend / export-voxtral-metal-artifact / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2025-11-10T17:19:11Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka · 2025-11-10T17:38:21Z

 explicit Module(
 const std::string& file_path,
 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,


nit: method_allocator

oh I see. This is supposed to be called method_allocator?

JacobSzwejbka · 2025-11-10T17:38:34Z

 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,
+ std::unique_ptr<runtime::MemoryAllocator> temp_allocator = nullptr,
 std::unique_ptr<runtime::EventTracer> event_tracer = nullptr);


This is technically a bc breaking change

That is true. Is this part of core API btw given that it is in extension?
I do think we should unify the interface though.

github-actions · 2026-01-11T00:51:52Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2026-03-13T00:54:24Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

kimishpatel · 2025-11-10T17:18:16Z

Stack from ghstack (oldest at bottom):

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator.
Fix that.

Differential Revision: D86120037

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator. Fix that. Differential Revision: [D86120037](https://our.internmc.facebook.com/intern/diff/D86120037/) [ghstack-poisoned]

pytorch-bot · 2025-11-10T17:18:20Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15709

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures

As of commit 799c34b with merge base aba44fd ():

NEW FAILURES - The following jobs have failed:

Apple / build-demo-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Apple / build-frameworks-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Build Presets / apple (ios) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (llm) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (profiling) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / windows (pybind) / build (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest / windows / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-editable / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest-editable / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh)
/pytorch/executorch/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/__memory/unique_ptr.h:767:30: error: no matching constructor for initialization of 'executorch::extension::module::Module'
Test Metal Backend / export-voxtral-metal-artifact / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2025-11-10T17:19:11Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka · 2025-11-10T17:38:21Z

 explicit Module(
 const std::string& file_path,
 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,


nit: method_allocator

oh I see. This is supposed to be called method_allocator?

JacobSzwejbka · 2025-11-10T17:38:34Z

 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,
+ std::unique_ptr<runtime::MemoryAllocator> temp_allocator = nullptr,
 std::unique_ptr<runtime::EventTracer> event_tracer = nullptr);


This is technically a bc breaking change

That is true. Is this part of core API btw given that it is in extension?
I do think we should unify the interface though.

github-actions · 2026-01-11T00:51:52Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2026-03-13T00:54:24Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

kimishpatel · 2025-11-10T17:18:16Z

Stack from ghstack (oldest at bottom):

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator.
Fix that.

Differential Revision: D86120037

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator. Fix that. Differential Revision: [D86120037](https://our.internmc.facebook.com/intern/diff/D86120037/) [ghstack-poisoned]

pytorch-bot · 2025-11-10T17:18:20Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15709

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures

As of commit 799c34b with merge base aba44fd ():

NEW FAILURES - The following jobs have failed:

Apple / build-demo-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Apple / build-frameworks-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Build Presets / apple (ios) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (llm) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (profiling) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / windows (pybind) / build (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest / windows / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-editable / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest-editable / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh)
/pytorch/executorch/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/__memory/unique_ptr.h:767:30: error: no matching constructor for initialization of 'executorch::extension::module::Module'
Test Metal Backend / export-voxtral-metal-artifact / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2025-11-10T17:19:11Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka · 2025-11-10T17:38:21Z

 explicit Module(
 const std::string& file_path,
 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,


nit: method_allocator

oh I see. This is supposed to be called method_allocator?

JacobSzwejbka · 2025-11-10T17:38:34Z

 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,
+ std::unique_ptr<runtime::MemoryAllocator> temp_allocator = nullptr,
 std::unique_ptr<runtime::EventTracer> event_tracer = nullptr);


This is technically a bc breaking change

That is true. Is this part of core API btw given that it is in extension?
I do think we should unify the interface though.

github-actions · 2026-01-11T00:51:52Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2026-03-13T00:54:24Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

kimishpatel · 2025-11-10T17:18:16Z

Stack from ghstack (oldest at bottom):

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator.
Fix that.

Differential Revision: D86120037

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator. Fix that. Differential Revision: [D86120037](https://our.internmc.facebook.com/intern/diff/D86120037/) [ghstack-poisoned]

pytorch-bot · 2025-11-10T17:18:20Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15709

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures

As of commit 799c34b with merge base aba44fd ():

NEW FAILURES - The following jobs have failed:

Apple / build-demo-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Apple / build-frameworks-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Build Presets / apple (ios) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (llm) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (profiling) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / windows (pybind) / build (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest / windows / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-editable / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest-editable / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh)
/pytorch/executorch/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/__memory/unique_ptr.h:767:30: error: no matching constructor for initialization of 'executorch::extension::module::Module'
Test Metal Backend / export-voxtral-metal-artifact / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2025-11-10T17:19:11Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka · 2025-11-10T17:38:21Z

 explicit Module(
 const std::string& file_path,
 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,


nit: method_allocator

oh I see. This is supposed to be called method_allocator?

JacobSzwejbka · 2025-11-10T17:38:34Z

 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,
+ std::unique_ptr<runtime::MemoryAllocator> temp_allocator = nullptr,
 std::unique_ptr<runtime::EventTracer> event_tracer = nullptr);


This is technically a bc breaking change

That is true. Is this part of core API btw given that it is in extension?
I do think we should unify the interface though.

github-actions · 2026-01-11T00:51:52Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2026-03-13T00:54:24Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

kimishpatel · 2025-11-10T17:18:16Z

Stack from ghstack (oldest at bottom):

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator.
Fix that.

Differential Revision: D86120037

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator. Fix that. Differential Revision: [D86120037](https://our.internmc.facebook.com/intern/diff/D86120037/) [ghstack-poisoned]

pytorch-bot · 2025-11-10T17:18:20Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15709

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures

As of commit 799c34b with merge base aba44fd ():

NEW FAILURES - The following jobs have failed:

Apple / build-demo-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Apple / build-frameworks-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Build Presets / apple (ios) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (llm) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (profiling) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / windows (pybind) / build (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest / windows / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-editable / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest-editable / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh)
/pytorch/executorch/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/__memory/unique_ptr.h:767:30: error: no matching constructor for initialization of 'executorch::extension::module::Module'
Test Metal Backend / export-voxtral-metal-artifact / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2025-11-10T17:19:11Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka · 2025-11-10T17:38:21Z

 explicit Module(
 const std::string& file_path,
 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,


nit: method_allocator

oh I see. This is supposed to be called method_allocator?

JacobSzwejbka · 2025-11-10T17:38:34Z

 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,
+ std::unique_ptr<runtime::MemoryAllocator> temp_allocator = nullptr,
 std::unique_ptr<runtime::EventTracer> event_tracer = nullptr);


This is technically a bc breaking change

That is true. Is this part of core API btw given that it is in extension?
I do think we should unify the interface though.

github-actions · 2026-01-11T00:51:52Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2026-03-13T00:54:24Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

kimishpatel · 2025-11-10T17:18:16Z

Stack from ghstack (oldest at bottom):

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator.
Fix that.

Differential Revision: D86120037

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator. Fix that. Differential Revision: [D86120037](https://our.internmc.facebook.com/intern/diff/D86120037/) [ghstack-poisoned]

pytorch-bot · 2025-11-10T17:18:20Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15709

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures

As of commit 799c34b with merge base aba44fd ():

NEW FAILURES - The following jobs have failed:

Apple / build-demo-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Apple / build-frameworks-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Build Presets / apple (ios) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (llm) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (profiling) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / windows (pybind) / build (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest / windows / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-editable / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest-editable / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh)
/pytorch/executorch/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/__memory/unique_ptr.h:767:30: error: no matching constructor for initialization of 'executorch::extension::module::Module'
Test Metal Backend / export-voxtral-metal-artifact / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2025-11-10T17:19:11Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka · 2025-11-10T17:38:21Z

 explicit Module(
 const std::string& file_path,
 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,


nit: method_allocator

oh I see. This is supposed to be called method_allocator?

JacobSzwejbka · 2025-11-10T17:38:34Z

 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,
+ std::unique_ptr<runtime::MemoryAllocator> temp_allocator = nullptr,
 std::unique_ptr<runtime::EventTracer> event_tracer = nullptr);


This is technically a bc breaking change

That is true. Is this part of core API btw given that it is in extension?
I do think we should unify the interface though.

github-actions · 2026-01-11T00:51:52Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2026-03-13T00:54:24Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

kimishpatel · 2025-11-10T17:18:16Z

Stack from ghstack (oldest at bottom):

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator.
Fix that.

Differential Revision: D86120037

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator. Fix that. Differential Revision: [D86120037](https://our.internmc.facebook.com/intern/diff/D86120037/) [ghstack-poisoned]

pytorch-bot · 2025-11-10T17:18:20Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15709

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures

As of commit 799c34b with merge base aba44fd ():

NEW FAILURES - The following jobs have failed:

Apple / build-demo-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Apple / build-frameworks-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Build Presets / apple (ios) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (llm) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (profiling) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / windows (pybind) / build (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest / windows / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-editable / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest-editable / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh)
/pytorch/executorch/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/__memory/unique_ptr.h:767:30: error: no matching constructor for initialization of 'executorch::extension::module::Module'
Test Metal Backend / export-voxtral-metal-artifact / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2025-11-10T17:19:11Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka · 2025-11-10T17:38:21Z

 explicit Module(
 const std::string& file_path,
 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,


nit: method_allocator

oh I see. This is supposed to be called method_allocator?

JacobSzwejbka · 2025-11-10T17:38:34Z

 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,
+ std::unique_ptr<runtime::MemoryAllocator> temp_allocator = nullptr,
 std::unique_ptr<runtime::EventTracer> event_tracer = nullptr);


This is technically a bc breaking change

That is true. Is this part of core API btw given that it is in extension?
I do think we should unify the interface though.

github-actions · 2026-01-11T00:51:52Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2026-03-13T00:54:24Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

kimishpatel · 2025-11-10T17:18:16Z

Stack from ghstack (oldest at bottom):

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator.
Fix that.

Differential Revision: D86120037

Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator. Fix that. Differential Revision: [D86120037](https://our.internmc.facebook.com/intern/diff/D86120037/) [ghstack-poisoned]

pytorch-bot · 2025-11-10T17:18:20Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15709

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures

As of commit 799c34b with merge base aba44fd ():

NEW FAILURES - The following jobs have failed:

Apple / build-demo-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Apple / build-frameworks-ios / macos-job (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts/. No artifacts will be uploaded.
Build Presets / apple (ios) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (llm) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / apple (profiling) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 128
Build Presets / windows (pybind) / build (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest / windows / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-editable / linux / linux-job (gh)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
pull / unittest-editable / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 128
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh)
/pytorch/executorch/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/__memory/unique_ptr.h:767:30: error: no matching constructor for initialization of 'executorch::extension::module::Module'
Test Metal Backend / export-voxtral-metal-artifact / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2025-11-10T17:19:11Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka · 2025-11-10T17:38:21Z

 explicit Module(
 const std::string& file_path,
 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,


nit: method_allocator

oh I see. This is supposed to be called method_allocator?

JacobSzwejbka · 2025-11-10T17:38:34Z

 const LoadMode load_mode = LoadMode::File,
+ std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr,
+ std::unique_ptr<runtime::MemoryAllocator> temp_allocator = nullptr,
 std::unique_ptr<runtime::EventTracer> event_tracer = nullptr);


This is technically a bc breaking change

That is true. Is this part of core API btw given that it is in extension?
I do think we should unify the interface though.

github-actions · 2026-01-11T00:51:52Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2026-03-13T00:54:24Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

kimishpatel requested a review from shoumikhin as a code owner November 10, 2025 17:18

meta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2025

JacobSzwejbka reviewed Nov 10, 2025
View reviewed changes

github-actionsBot added the Stale PRs inactive for over 60 days label Jan 11, 2026

github-actionsBot closed this Apr 29, 2026

kimishpatel requested a review from shoumikhin as a code owner November 10, 2025 17:18

meta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2025

JacobSzwejbka reviewed Nov 10, 2025
View reviewed changes

github-actionsBot added the Stale PRs inactive for over 60 days label Jan 11, 2026

github-actionsBot closed this Apr 29, 2026

kimishpatel requested a review from shoumikhin as a code owner November 10, 2025 17:18

meta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2025

JacobSzwejbka reviewed Nov 10, 2025
View reviewed changes

github-actionsBot added the Stale PRs inactive for over 60 days label Jan 11, 2026

github-actionsBot closed this Apr 29, 2026

kimishpatel requested a review from shoumikhin as a code owner November 10, 2025 17:18

meta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2025

JacobSzwejbka reviewed Nov 10, 2025
View reviewed changes

github-actionsBot added the Stale PRs inactive for over 60 days label Jan 11, 2026

github-actionsBot closed this Apr 29, 2026

kimishpatel requested a review from shoumikhin as a code owner November 10, 2025 17:18

meta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2025

JacobSzwejbka reviewed Nov 10, 2025
View reviewed changes

github-actionsBot added the Stale PRs inactive for over 60 days label Jan 11, 2026

github-actionsBot closed this Apr 29, 2026

kimishpatel requested a review from shoumikhin as a code owner November 10, 2025 17:18

meta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2025

JacobSzwejbka reviewed Nov 10, 2025
View reviewed changes

github-actionsBot added the Stale PRs inactive for over 60 days label Jan 11, 2026

github-actionsBot closed this Apr 29, 2026

kimishpatel requested a review from shoumikhin as a code owner November 10, 2025 17:18

meta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2025

JacobSzwejbka reviewed Nov 10, 2025
View reviewed changes

github-actionsBot added the Stale PRs inactive for over 60 days label Jan 11, 2026

github-actionsBot closed this Apr 29, 2026

kimishpatel requested a review from shoumikhin as a code owner November 10, 2025 17:18

meta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2025

JacobSzwejbka reviewed Nov 10, 2025
View reviewed changes

github-actionsBot added the Stale PRs inactive for over 60 days label Jan 11, 2026

github-actionsBot closed this Apr 29, 2026

Uh oh!

Conversation

kimishpatel commented Nov 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-botBot commented Nov 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15709

❌ 14 New Failures

Uh oh!

github-actionsBot commented Nov 10, 2025

This PR needs a release notes: label

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jan 11, 2026

Uh oh!

github-actionsBot commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kimishpatel commented Nov 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-botBot commented Nov 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15709

❌ 14 New Failures

Uh oh!

github-actionsBot commented Nov 10, 2025

This PR needs a release notes: label

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jan 11, 2026

Uh oh!

github-actionsBot commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kimishpatel commented Nov 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-botBot commented Nov 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15709

❌ 14 New Failures

Uh oh!

github-actionsBot commented Nov 10, 2025

kimishpatel commented Nov 10, 2025•
edited
Loading

pytorch-botBot commented Nov 10, 2025•
edited
Loading

This PR needs a `release notes:` label

kimishpatel commented Nov 10, 2025•
edited
Loading

pytorch-botBot commented Nov 10, 2025•
edited
Loading

This PR needs a `release notes:` label

kimishpatel commented Nov 10, 2025•
edited
Loading

pytorch-botBot commented Nov 10, 2025•
edited
Loading

This PR needs a `release notes:` label

kimishpatel commented Nov 10, 2025•
edited
Loading

pytorch-botBot commented Nov 10, 2025•
edited
Loading

This PR needs a `release notes:` label