Save external constant tensors to custom filename by lucylq · Pull Request #15862 · pytorch/executorch

lucylq · 2025-11-18T01:27:12Z

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to.
The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass.

Differential Revision: D87280747

pytorch-bot · 2025-11-18T01:27:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15862

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 96efb61 with merge base d2c011e ():

NEW FAILURES - The following jobs have failed:

pull / android / run-emulator (gh)
The process '/usr/bin/sh' failed with exit code 255
pull / unittest / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module
pull / unittest-editable / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module

CANCELLED JOB - The following job was cancelled. Please retry:

pull / unittest-wasm-bindings / linux-job (gh)

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / test-static-llama-qnn-linux (stories_260k_bc) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
Test CUDA Builds / test-models-cuda (resnet18) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-11-18T01:27:22Z

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87280747.

github-actions · 2025-11-18T01:28:01Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull Request Overview

This PR adds support for customizing external constant tensor storage by allowing a Callable option in the ExecutorchBackendConfig.external_constants field. Previously, this field only accepted a boolean value to determine whether all constants should be externalized. Now it can also accept a function that determines which constants to externalize and which filename to use for storage.

Key changes:

Extended external_constants to accept either bool or Callable[[torch.fx.Node], Optional[str]]
Updated the conditional logic in to_executorch() to handle both bool and callable cases
Added test coverage for the custom callable scenario

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
exir/capture/_config.py	Extended type annotation and documentation for `external_constants` to support Callable option
exir/program/_program.py	Updated conditional logic to handle both bool and callable `external_constants` values
exir/emit/test/test_emit.py	Added test case for custom callable `external_constants` behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Differential Revision: D87280747

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Reviewed By: ethansfng Differential Revision: D87280747

JacobSzwejbka

Review automatically exported from Phabricator review in Meta.

Differential Revision: D87280747 Pull Request resolved: pytorch#15862

lucylq · 2025-11-18T01:27:12Z

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to.
The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass.

Differential Revision: D87280747

pytorch-bot · 2025-11-18T01:27:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15862

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 96efb61 with merge base d2c011e ():

NEW FAILURES - The following jobs have failed:

pull / android / run-emulator (gh)
The process '/usr/bin/sh' failed with exit code 255
pull / unittest / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module
pull / unittest-editable / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module

CANCELLED JOB - The following job was cancelled. Please retry:

pull / unittest-wasm-bindings / linux-job (gh)

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / test-static-llama-qnn-linux (stories_260k_bc) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
Test CUDA Builds / test-models-cuda (resnet18) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-11-18T01:27:22Z

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87280747.

github-actions · 2025-11-18T01:28:01Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull Request Overview

This PR adds support for customizing external constant tensor storage by allowing a Callable option in the ExecutorchBackendConfig.external_constants field. Previously, this field only accepted a boolean value to determine whether all constants should be externalized. Now it can also accept a function that determines which constants to externalize and which filename to use for storage.

Key changes:

Extended external_constants to accept either bool or Callable[[torch.fx.Node], Optional[str]]
Updated the conditional logic in to_executorch() to handle both bool and callable cases
Added test coverage for the custom callable scenario

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
exir/capture/_config.py	Extended type annotation and documentation for `external_constants` to support Callable option
exir/program/_program.py	Updated conditional logic to handle both bool and callable `external_constants` values
exir/emit/test/test_emit.py	Added test case for custom callable `external_constants` behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Differential Revision: D87280747

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Reviewed By: ethansfng Differential Revision: D87280747

JacobSzwejbka

Review automatically exported from Phabricator review in Meta.

Differential Revision: D87280747 Pull Request resolved: pytorch#15862

lucylq · 2025-11-18T01:27:12Z

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to.
The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass.

Differential Revision: D87280747

pytorch-bot · 2025-11-18T01:27:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15862

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 96efb61 with merge base d2c011e ():

NEW FAILURES - The following jobs have failed:

pull / android / run-emulator (gh)
The process '/usr/bin/sh' failed with exit code 255
pull / unittest / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module
pull / unittest-editable / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module

CANCELLED JOB - The following job was cancelled. Please retry:

pull / unittest-wasm-bindings / linux-job (gh)

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / test-static-llama-qnn-linux (stories_260k_bc) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
Test CUDA Builds / test-models-cuda (resnet18) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-11-18T01:27:22Z

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87280747.

github-actions · 2025-11-18T01:28:01Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull Request Overview

This PR adds support for customizing external constant tensor storage by allowing a Callable option in the ExecutorchBackendConfig.external_constants field. Previously, this field only accepted a boolean value to determine whether all constants should be externalized. Now it can also accept a function that determines which constants to externalize and which filename to use for storage.

Key changes:

Extended external_constants to accept either bool or Callable[[torch.fx.Node], Optional[str]]
Updated the conditional logic in to_executorch() to handle both bool and callable cases
Added test coverage for the custom callable scenario

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
exir/capture/_config.py	Extended type annotation and documentation for `external_constants` to support Callable option
exir/program/_program.py	Updated conditional logic to handle both bool and callable `external_constants` values
exir/emit/test/test_emit.py	Added test case for custom callable `external_constants` behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Differential Revision: D87280747

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Reviewed By: ethansfng Differential Revision: D87280747

JacobSzwejbka

Review automatically exported from Phabricator review in Meta.

Differential Revision: D87280747 Pull Request resolved: pytorch#15862

lucylq · 2025-11-18T01:27:12Z

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to.
The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass.

Differential Revision: D87280747

pytorch-bot · 2025-11-18T01:27:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15862

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 96efb61 with merge base d2c011e ():

NEW FAILURES - The following jobs have failed:

pull / android / run-emulator (gh)
The process '/usr/bin/sh' failed with exit code 255
pull / unittest / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module
pull / unittest-editable / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module

CANCELLED JOB - The following job was cancelled. Please retry:

pull / unittest-wasm-bindings / linux-job (gh)

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / test-static-llama-qnn-linux (stories_260k_bc) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
Test CUDA Builds / test-models-cuda (resnet18) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-11-18T01:27:22Z

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87280747.

github-actions · 2025-11-18T01:28:01Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull Request Overview

This PR adds support for customizing external constant tensor storage by allowing a Callable option in the ExecutorchBackendConfig.external_constants field. Previously, this field only accepted a boolean value to determine whether all constants should be externalized. Now it can also accept a function that determines which constants to externalize and which filename to use for storage.

Key changes:

Extended external_constants to accept either bool or Callable[[torch.fx.Node], Optional[str]]
Updated the conditional logic in to_executorch() to handle both bool and callable cases
Added test coverage for the custom callable scenario

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
exir/capture/_config.py	Extended type annotation and documentation for `external_constants` to support Callable option
exir/program/_program.py	Updated conditional logic to handle both bool and callable `external_constants` values
exir/emit/test/test_emit.py	Added test case for custom callable `external_constants` behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Differential Revision: D87280747

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Reviewed By: ethansfng Differential Revision: D87280747

JacobSzwejbka

Review automatically exported from Phabricator review in Meta.

Differential Revision: D87280747 Pull Request resolved: pytorch#15862

lucylq · 2025-11-18T01:27:12Z

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to.
The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass.

Differential Revision: D87280747

pytorch-bot · 2025-11-18T01:27:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15862

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 96efb61 with merge base d2c011e ():

NEW FAILURES - The following jobs have failed:

pull / android / run-emulator (gh)
The process '/usr/bin/sh' failed with exit code 255
pull / unittest / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module
pull / unittest-editable / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module

CANCELLED JOB - The following job was cancelled. Please retry:

pull / unittest-wasm-bindings / linux-job (gh)

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / test-static-llama-qnn-linux (stories_260k_bc) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
Test CUDA Builds / test-models-cuda (resnet18) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-11-18T01:27:22Z

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87280747.

github-actions · 2025-11-18T01:28:01Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull Request Overview

This PR adds support for customizing external constant tensor storage by allowing a Callable option in the ExecutorchBackendConfig.external_constants field. Previously, this field only accepted a boolean value to determine whether all constants should be externalized. Now it can also accept a function that determines which constants to externalize and which filename to use for storage.

Key changes:

Extended external_constants to accept either bool or Callable[[torch.fx.Node], Optional[str]]
Updated the conditional logic in to_executorch() to handle both bool and callable cases
Added test coverage for the custom callable scenario

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
exir/capture/_config.py	Extended type annotation and documentation for `external_constants` to support Callable option
exir/program/_program.py	Updated conditional logic to handle both bool and callable `external_constants` values
exir/emit/test/test_emit.py	Added test case for custom callable `external_constants` behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Differential Revision: D87280747

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Reviewed By: ethansfng Differential Revision: D87280747

JacobSzwejbka

Review automatically exported from Phabricator review in Meta.

Differential Revision: D87280747 Pull Request resolved: pytorch#15862

lucylq · 2025-11-18T01:27:12Z

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to.
The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass.

Differential Revision: D87280747

pytorch-bot · 2025-11-18T01:27:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15862

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 96efb61 with merge base d2c011e ():

NEW FAILURES - The following jobs have failed:

pull / android / run-emulator (gh)
The process '/usr/bin/sh' failed with exit code 255
pull / unittest / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module
pull / unittest-editable / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module

CANCELLED JOB - The following job was cancelled. Please retry:

pull / unittest-wasm-bindings / linux-job (gh)

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / test-static-llama-qnn-linux (stories_260k_bc) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
Test CUDA Builds / test-models-cuda (resnet18) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-11-18T01:27:22Z

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87280747.

github-actions · 2025-11-18T01:28:01Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull Request Overview

This PR adds support for customizing external constant tensor storage by allowing a Callable option in the ExecutorchBackendConfig.external_constants field. Previously, this field only accepted a boolean value to determine whether all constants should be externalized. Now it can also accept a function that determines which constants to externalize and which filename to use for storage.

Key changes:

Extended external_constants to accept either bool or Callable[[torch.fx.Node], Optional[str]]
Updated the conditional logic in to_executorch() to handle both bool and callable cases
Added test coverage for the custom callable scenario

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
exir/capture/_config.py	Extended type annotation and documentation for `external_constants` to support Callable option
exir/program/_program.py	Updated conditional logic to handle both bool and callable `external_constants` values
exir/emit/test/test_emit.py	Added test case for custom callable `external_constants` behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Differential Revision: D87280747

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Reviewed By: ethansfng Differential Revision: D87280747

JacobSzwejbka

Review automatically exported from Phabricator review in Meta.

Differential Revision: D87280747 Pull Request resolved: pytorch#15862

lucylq · 2025-11-18T01:27:12Z

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to.
The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass.

Differential Revision: D87280747

pytorch-bot · 2025-11-18T01:27:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15862

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 96efb61 with merge base d2c011e ():

NEW FAILURES - The following jobs have failed:

pull / android / run-emulator (gh)
The process '/usr/bin/sh' failed with exit code 255
pull / unittest / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module
pull / unittest-editable / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module

CANCELLED JOB - The following job was cancelled. Please retry:

pull / unittest-wasm-bindings / linux-job (gh)

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / test-static-llama-qnn-linux (stories_260k_bc) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
Test CUDA Builds / test-models-cuda (resnet18) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-11-18T01:27:22Z

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87280747.

github-actions · 2025-11-18T01:28:01Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull Request Overview

This PR adds support for customizing external constant tensor storage by allowing a Callable option in the ExecutorchBackendConfig.external_constants field. Previously, this field only accepted a boolean value to determine whether all constants should be externalized. Now it can also accept a function that determines which constants to externalize and which filename to use for storage.

Key changes:

Extended external_constants to accept either bool or Callable[[torch.fx.Node], Optional[str]]
Updated the conditional logic in to_executorch() to handle both bool and callable cases
Added test coverage for the custom callable scenario

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
exir/capture/_config.py	Extended type annotation and documentation for `external_constants` to support Callable option
exir/program/_program.py	Updated conditional logic to handle both bool and callable `external_constants` values
exir/emit/test/test_emit.py	Added test case for custom callable `external_constants` behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Differential Revision: D87280747

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Reviewed By: ethansfng Differential Revision: D87280747

JacobSzwejbka

Review automatically exported from Phabricator review in Meta.

Differential Revision: D87280747 Pull Request resolved: pytorch#15862

lucylq · 2025-11-18T01:27:12Z

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to.
The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass.

Differential Revision: D87280747

pytorch-bot · 2025-11-18T01:27:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15862

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 96efb61 with merge base d2c011e ():

NEW FAILURES - The following jobs have failed:

pull / android / run-emulator (gh)
The process '/usr/bin/sh' failed with exit code 255
pull / unittest / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module
pull / unittest-editable / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module

CANCELLED JOB - The following job was cancelled. Please retry:

pull / unittest-wasm-bindings / linux-job (gh)

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / test-static-llama-qnn-linux (stories_260k_bc) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
Test CUDA Builds / test-models-cuda (resnet18) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-11-18T01:27:22Z

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87280747.

github-actions · 2025-11-18T01:28:01Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull Request Overview

This PR adds support for customizing external constant tensor storage by allowing a Callable option in the ExecutorchBackendConfig.external_constants field. Previously, this field only accepted a boolean value to determine whether all constants should be externalized. Now it can also accept a function that determines which constants to externalize and which filename to use for storage.

Key changes:

Extended external_constants to accept either bool or Callable[[torch.fx.Node], Optional[str]]
Updated the conditional logic in to_executorch() to handle both bool and callable cases
Added test coverage for the custom callable scenario

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
exir/capture/_config.py	Extended type annotation and documentation for `external_constants` to support Callable option
exir/program/_program.py	Updated conditional logic to handle both bool and callable `external_constants` values
exir/emit/test/test_emit.py	Added test case for custom callable `external_constants` behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Differential Revision: D87280747

Summary: Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass. Reviewed By: ethansfng Differential Revision: D87280747

JacobSzwejbka

Review automatically exported from Phabricator review in Meta.

Differential Revision: D87280747 Pull Request resolved: pytorch#15862

lucylq requested review from JacobSzwejbka and larryliu0820 as code owners November 18, 2025 01:27

meta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2025

meta-codesyncBot added fb-exported meta-exported labels Nov 18, 2025

mergennachin requested a review from Copilot November 18, 2025 15:16

Copilotstarted reviewing on behalf of mergennachin November 18, 2025 15:17 View session

Copilotfinished reviewing on behalf of mergennachin November 18, 2025 15:18

CopilotAI reviewed Nov 18, 2025
View reviewed changes

Comment threadexir/program/_program.py Outdated
Comment threadexir/capture/_config.py Outdated

lucylq force-pushed the export-D87280747 branch from 5b8b7a1 to 5781904Compare November 18, 2025 18:34

lucylq force-pushed the export-D87280747 branch from 5781904 to 3c0743fCompare November 18, 2025 20:43

ethansfng approved these changes Nov 20, 2025
View reviewed changes

lucylq force-pushed the export-D87280747 branch from 3c0743f to 96efb61Compare November 20, 2025 21:14

JacobSzwejbka approved these changes Nov 21, 2025
View reviewed changes

meta-codesyncBot merged commit 17744b7 into pytorch:mainNov 21, 2025
146 of 154 checks passed

jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025
Save external constant tensors to custom filename
41db544
Differential Revision: D87280747 Pull Request resolved: pytorch#15862