Allow symints to be created for arguments - #16620

Merged
per merged 1 commit into
pytorch:mainfrom
per:symint_handling_for_args
Jan 22, 2026
Merged

Allow symints to be created for arguments#16620
per merged 1 commit into
pytorch:mainfrom
per:symint_handling_for_args

Conversation

@per

@perper commented Jan 15, 2026•
edited by pytorch-bot Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

Add test for creating args of SymInt type to be able to use them in view_copy nodes together with the fix to make the test pass.

Test plan

Tested through CI tests.

cc @freddan80@zingo@oscarandersson8218@digantdesai

@pytorch-bot

pytorch-botBot commented Jan 15, 2026•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16620

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f350cc2 with merge base 7492d0d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-clameta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2026
@per
per requested review from SS-JIA, lucylq, ydwu4 and zingo and removed request for JacobSzwejbka and larryliu0820January 15, 2026 10:09
@perper added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Jan 15, 2026
@zingozingo added this to the 1.1.0 milestone Jan 15, 2026
@per
Allow symints to be created for arguments
f350cc2
Add test for creating args of SymInt type to be able to use them
in view_copy nodes in the Arm TOSA backend together with the
fix to make the pass work.
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: Ia947b8426af1b473df415a17e10f3db1582b84fd
@per
perforce-pushed the symint_handling_for_args branch from 00a24ad to f350cc2CompareJanuary 19, 2026 08:50
@zingo

zingo commented Jan 19, 2026

Copy link
Copy Markdown
Collaborator

Hi @SS-JIA / @metascroy this is touching files outside Arm code and need a review if possible

@perper added the release notes: none Do not include this in the release notes label Jan 20, 2026
mergennachin
mergennachin reviewed Jan 20, 2026
View reviewed changes
Comment threadexir/pass_base.py
if not hasattr(a, "constant") or a.constant is None:
raise ExportPassBaseError(f"Cannot add {a} to graph.")
a = a.constant
elif isinstance(a, torch.SymInt):

@mergennachinmergennachinJan 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

elif isinstance(a, (torch.SymInt, torch.SymFloat, torch.SymBool)):

and add corresponding unit test for symfloat and symbool please

thank you for finding this bug btw @per

@perperJan 20, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to trigger the SymFloat and SymBool paths here, since it comes from the dynamic shape export, which implies SymInts only, right?

@mergennachinmergennachinJan 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@per

SymFloat - https://gist.github.com/mergennachin/db34d1272f06b3be61ed1910b5dc6eaa
SymBool - https://gist.github.com/mergennachin/48326573d23293865d6447ab3dad622f

@perperJan 21, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the proposed tests doesn't trigger the bug, since the symbool/symfloat aren't part of a list argument (as the shape argument is in view_copy). The tests you linked to are properly handled already (scalars and tensors).
The only alternative I've come up with is to manually construct a symbol with a shape_env, but that feels like a really constructed way to trigger the bug:

 shape_env = ShapeEnv()
sym_bool = shape_env.create_unbacked_symbool()
tracer_owner = ExportPass()
tracer = tracer_owner.tracer
tracer.create_arg([sym_bool])

I've haven't been able to track down any operator that takes a list of bools or list of floats as argument, so IMHO it makes sense to keep the test as is, since that is what is exercised through the normal export flow. Or am I missing something?

@mergennachinmergennachinJan 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you for explaining and walking me through the code

@SS-JIA

SS-JIA commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Other than Mergen's comment, LGTM 👍

@per
per requested a review from mergennachinJanuary 21, 2026 09:14
@per
per merged commit 5dbbec3 into pytorch:mainJan 22, 2026
308 checks passed
@zingo

zingo commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

@pytorchbot cherry-pick --onto release/1.1 -c fixnewfeature

@pytorchbot

pytorchbot commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

Cherry picking #16620

The cherry pick PR is at #16774 and it is recommended to link a fixnewfeature cherry pick PR with an issue.

Details for Dev Infra team Raised by workflow job

@perper mentioned this pull request Jan 22, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergennachinmergennachinmergennachin approved these changes
@lucylqlucylqAwaiting requested review from lucylq
@ydwu4ydwu4Awaiting requested review from ydwu4
@SS-JIASS-JIAAwaiting requested review from SS-JIA
@zingozingoAwaiting requested review from zingo

Assignees

No one assigned

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.partner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Armrelease notes: noneDo not include this in the release notes

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@per@zingo@SS-JIA@pytorchbot@mergennachin
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Allow symints to be created for arguments - #16620
Merged
per merged 1 commit into
pytorch:mainfrom 
per:symint_handling_for_args
Jan 22, 2026
Merged
Allow symints to be created for arguments#16620
per merged 1 commit into
pytorch:mainfrom 
per:symint_handling_for_args
Conversation
@per
@perper
commented
Jan 15, 2026•

edited by pytorch-bot
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
Add test for creating args of SymInt type to be able to use them in view_copy nodes together with the fix to make the test pass.
Test plan
Tested through CI tests.
cc @freddan80@zingo@oscarandersson8218@digantdesai
@pytorch-bot
pytorch-botBot
commented
Jan 15, 2026•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16620
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit f350cc2 with merge base 7492d0d (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-clameta-claBot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 15, 2026
@per
per
requested review from
SS-JIA, lucylq, ydwu4 and zingo
and removed request for
JacobSzwejbka and larryliu0820January 15, 2026 10:09
@perper
added

partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
ciflow/trunk

labels
Jan 15, 2026
@zingozingo
added this to the 1.1.0 milestone
Jan 15, 2026
@per
Allow symints to be created for arguments
f350cc2
Add test for creating args of SymInt type to be able to use them
in view_copy nodes in the Arm TOSA backend together with the
fix to make the pass work.
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: Ia947b8426af1b473df415a17e10f3db1582b84fd
@per
perforce-pushed
the
symint_handling_for_args
branch
from
00a24ad to
f350cc2CompareJanuary 19, 2026 08:50
@zingo
zingo
commented
Jan 19, 2026

Copy link


Copy Markdown

Collaborator
Hi @SS-JIA / @metascroy this is touching files outside Arm code and need a review if possible
@perper
added
the 
release notes: none
Do not include this in the release notes
label
Jan 20, 2026
mergennachin
mergennachin
reviewed
Jan 20, 2026
View reviewed changes
Comment threadexir/pass_base.py
 if not hasattr(a, "constant") or a.constant is None:
 raise ExportPassBaseError(f"Cannot add {a} to graph.")
 a = a.constant
 elif isinstance(a, torch.SymInt):
@mergennachinmergennachinJan 20, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elif isinstance(a, (torch.SymInt, torch.SymFloat, torch.SymBool)):

and add corresponding unit test for symfloat and symbool please
thank you for finding this bug btw @per
@perperJan 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to trigger the SymFloat and SymBool paths here, since it comes from the dynamic shape export, which implies SymInts only, right?
@mergennachinmergennachinJan 21, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@per
SymFloat - https://gist.github.com/mergennachin/db34d1272f06b3be61ed1910b5dc6eaa

SymBool - https://gist.github.com/mergennachin/48326573d23293865d6447ab3dad622f
@perperJan 21, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the proposed tests doesn't trigger the bug, since the symbool/symfloat aren't part of a list argument (as the shape argument is in view_copy). The tests you linked to are properly handled already (scalars and tensors).

The only alternative I've come up with is to manually construct a symbol with a shape_env, but that feels like a really constructed way to trigger the bug:
 shape_env = ShapeEnv()
sym_bool = shape_env.create_unbacked_symbool()
tracer_owner = ExportPass()
tracer = tracer_owner.tracer
tracer.create_arg([sym_bool])

I've haven't been able to track down any operator that takes a list of bools or list of floats as argument, so IMHO it makes sense to keep the test as is, since that is what is exercised through the normal export flow. Or am I missing something?
@mergennachinmergennachinJan 21, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you for explaining and walking me through the code
@SS-JIA
SS-JIA
commented
Jan 20, 2026

Copy link


Copy Markdown

Contributor
Other than Mergen's comment, LGTM 👍
@per
per
requested a review
from mergennachinJanuary 21, 2026 09:14
@per
per
merged commit 5dbbec3
into
pytorch:mainJan 22, 2026

308 checks passed

@zingo
zingo
commented
Jan 22, 2026

Copy link


Copy Markdown

Collaborator
@pytorchbot cherry-pick --onto release/1.1 -c fixnewfeature
@pytorchbot
pytorchbot
commented
Jan 22, 2026

Copy link


Copy Markdown

Collaborator
Cherry picking #16620
The cherry pick PR is at #16774 and it is recommended to link a fixnewfeature cherry pick PR with an issue.
Details for Dev Infra team
Raised by workflow job
@perper
mentioned this pull request
Jan 22, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mergennachinmergennachinmergennachin approved these changes
@lucylqlucylqAwaiting requested review from lucylq
@ydwu4ydwu4Awaiting requested review from ydwu4
@SS-JIASS-JIAAwaiting requested review from SS-JIA
@zingozingoAwaiting requested review from zingo

Assignees


No one assigned


Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.partner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Armrelease notes: noneDo not include this in the release notes

Projects


None yet


Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@per@zingo@SS-JIA@pytorchbot@mergennachin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Allow symints to be created for arguments - #16620
Merged
per merged 1 commit into
pytorch:mainfrom 
per:symint_handling_for_args
Jan 22, 2026
Merged
Allow symints to be created for arguments#16620
per merged 1 commit into
pytorch:mainfrom 
per:symint_handling_for_args
Conversation
@per
@perper
commented
Jan 15, 2026•

edited by pytorch-bot
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
Add test for creating args of SymInt type to be able to use them in view_copy nodes together with the fix to make the test pass.
Test plan
Tested through CI tests.
cc @freddan80@zingo@oscarandersson8218@digantdesai
@pytorch-bot
pytorch-botBot
commented
Jan 15, 2026•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16620
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit f350cc2 with merge base 7492d0d (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-clameta-claBot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 15, 2026
@per
per
requested review from
SS-JIA, lucylq, ydwu4 and zingo
and removed request for
JacobSzwejbka and larryliu0820January 15, 2026 10:09
@perper
added

partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
ciflow/trunk

labels
Jan 15, 2026
@zingozingo
added this to the 1.1.0 milestone
Jan 15, 2026
@per
Allow symints to be created for arguments
f350cc2
Add test for creating args of SymInt type to be able to use them
in view_copy nodes in the Arm TOSA backend together with the
fix to make the pass work.
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: Ia947b8426af1b473df415a17e10f3db1582b84fd
@per
perforce-pushed
the
symint_handling_for_args
branch
from
00a24ad to
f350cc2CompareJanuary 19, 2026 08:50
@zingo
zingo
commented
Jan 19, 2026

Copy link


Copy Markdown

Collaborator
Hi @SS-JIA / @metascroy this is touching files outside Arm code and need a review if possible
@perper
added
the 
release notes: none
Do not include this in the release notes
label
Jan 20, 2026
mergennachin
mergennachin
reviewed
Jan 20, 2026
View reviewed changes
Comment threadexir/pass_base.py
 if not hasattr(a, "constant") or a.constant is None:
 raise ExportPassBaseError(f"Cannot add {a} to graph.")
 a = a.constant
 elif isinstance(a, torch.SymInt):
@mergennachinmergennachinJan 20, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elif isinstance(a, (torch.SymInt, torch.SymFloat, torch.SymBool)):

and add corresponding unit test for symfloat and symbool please
thank you for finding this bug btw @per
@perperJan 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to trigger the SymFloat and SymBool paths here, since it comes from the dynamic shape export, which implies SymInts only, right?
@mergennachinmergennachinJan 21, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@per
SymFloat - https://gist.github.com/mergennachin/db34d1272f06b3be61ed1910b5dc6eaa

SymBool - https://gist.github.com/mergennachin/48326573d23293865d6447ab3dad622f
@perperJan 21, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the proposed tests doesn't trigger the bug, since the symbool/symfloat aren't part of a list argument (as the shape argument is in view_copy). The tests you linked to are properly handled already (scalars and tensors).

The only alternative I've come up with is to manually construct a symbol with a shape_env, but that feels like a really constructed way to trigger the bug:
 shape_env = ShapeEnv()
sym_bool = shape_env.create_unbacked_symbool()
tracer_owner = ExportPass()
tracer = tracer_owner.tracer
tracer.create_arg([sym_bool])

I've haven't been able to track down any operator that takes a list of bools or list of floats as argument, so IMHO it makes sense to keep the test as is, since that is what is exercised through the normal export flow. Or am I missing something?
@mergennachinmergennachinJan 21, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you for explaining and walking me through the code
@SS-JIA
SS-JIA
commented
Jan 20, 2026

Copy link


Copy Markdown

Contributor
Other than Mergen's comment, LGTM 👍
@per
per
requested a review
from mergennachinJanuary 21, 2026 09:14
@per
per
merged commit 5dbbec3
into
pytorch:mainJan 22, 2026

308 checks passed

@zingo
zingo
commented
Jan 22, 2026

Copy link


Copy Markdown

Collaborator
@pytorchbot cherry-pick --onto release/1.1 -c fixnewfeature
@pytorchbot
pytorchbot
commented
Jan 22, 2026

Copy link


Copy Markdown

Collaborator
Cherry picking #16620
The cherry pick PR is at #16774 and it is recommended to link a fixnewfeature cherry pick PR with an issue.
Details for Dev Infra team
Raised by workflow job
@perper
mentioned this pull request
Jan 22, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mergennachinmergennachinmergennachin approved these changes
@lucylqlucylqAwaiting requested review from lucylq
@ydwu4ydwu4Awaiting requested review from ydwu4
@SS-JIASS-JIAAwaiting requested review from SS-JIA
@zingozingoAwaiting requested review from zingo

Assignees


No one assigned


Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.partner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Armrelease notes: noneDo not include this in the release notes

Projects


None yet


Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@per@zingo@SS-JIA@pytorchbot@mergennachin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Allow symints to be created for arguments - #16620
Merged
per merged 1 commit into
pytorch:mainfrom 
per:symint_handling_for_args
Jan 22, 2026
Merged
Allow symints to be created for arguments#16620
per merged 1 commit into
pytorch:mainfrom 
per:symint_handling_for_args
Conversation
@per
@perper
commented
Jan 15, 2026•

edited by pytorch-bot
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
Add test for creating args of SymInt type to be able to use them in view_copy nodes together with the fix to make the test pass.
Test plan
Tested through CI tests.
cc @freddan80@zingo@oscarandersson8218@digantdesai
@pytorch-bot
pytorch-botBot
commented
Jan 15, 2026•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16620
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit f350cc2 with merge base 7492d0d (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-clameta-claBot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 15, 2026
@per
per
requested review from
SS-JIA, lucylq, ydwu4 and zingo
and removed request for
JacobSzwejbka and larryliu0820January 15, 2026 10:09
@perper
added

partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
ciflow/trunk

labels
Jan 15, 2026
@zingozingo
added this to the 1.1.0 milestone
Jan 15, 2026
@per
Allow symints to be created for arguments
f350cc2
Add test for creating args of SymInt type to be able to use them
in view_copy nodes in the Arm TOSA backend together with the
fix to make the pass work.
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: Ia947b8426af1b473df415a17e10f3db1582b84fd
@per
perforce-pushed
the
symint_handling_for_args
branch
from
00a24ad to
f350cc2CompareJanuary 19, 2026 08:50
@zingo
zingo
commented
Jan 19, 2026

Copy link


Copy Markdown

Collaborator
Hi @SS-JIA / @metascroy this is touching files outside Arm code and need a review if possible
@perper
added
the 
release notes: none
Do not include this in the release notes
label
Jan 20, 2026
mergennachin
mergennachin
reviewed
Jan 20, 2026
View reviewed changes
Comment threadexir/pass_base.py
 if not hasattr(a, "constant") or a.constant is None:
 raise ExportPassBaseError(f"Cannot add {a} to graph.")
 a = a.constant
 elif isinstance(a, torch.SymInt):
@mergennachinmergennachinJan 20, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elif isinstance(a, (torch.SymInt, torch.SymFloat, torch.SymBool)):

and add corresponding unit test for symfloat and symbool please
thank you for finding this bug btw @per
@perperJan 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to trigger the SymFloat and SymBool paths here, since it comes from the dynamic shape export, which implies SymInts only, right?
@mergennachinmergennachinJan 21, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@per
SymFloat - https://gist.github.com/mergennachin/db34d1272f06b3be61ed1910b5dc6eaa

SymBool - https://gist.github.com/mergennachin/48326573d23293865d6447ab3dad622f
@perperJan 21, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the proposed tests doesn't trigger the bug, since the symbool/symfloat aren't part of a list argument (as the shape argument is in view_copy). The tests you linked to are properly handled already (scalars and tensors).

The only alternative I've come up with is to manually construct a symbol with a shape_env, but that feels like a really constructed way to trigger the bug:
 shape_env = ShapeEnv()
sym_bool = shape_env.create_unbacked_symbool()
tracer_owner = ExportPass()
tracer = tracer_owner.tracer
tracer.create_arg([sym_bool])

I've haven't been able to track down any operator that takes a list of bools or list of floats as argument, so IMHO it makes sense to keep the test as is, since that is what is exercised through the normal export flow. Or am I missing something?
@mergennachinmergennachinJan 21, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you for explaining and walking me through the code
@SS-JIA
SS-JIA
commented
Jan 20, 2026

Copy link


Copy Markdown

Contributor
Other than Mergen's comment, LGTM 👍
@per
per
requested a review
from mergennachinJanuary 21, 2026 09:14
@per
per
merged commit 5dbbec3
into
pytorch:mainJan 22, 2026

308 checks passed

@zingo
zingo
commented
Jan 22, 2026

Copy link


Copy Markdown

Collaborator
@pytorchbot cherry-pick --onto release/1.1 -c fixnewfeature
@pytorchbot
pytorchbot
commented
Jan 22, 2026

Copy link


Copy Markdown

Collaborator
Cherry picking #16620
The cherry pick PR is at #16774 and it is recommended to link a fixnewfeature cherry pick PR with an issue.
Details for Dev Infra team
Raised by workflow job
@perper
mentioned this pull request
Jan 22, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mergennachinmergennachinmergennachin approved these changes
@lucylqlucylqAwaiting requested review from lucylq
@ydwu4ydwu4Awaiting requested review from ydwu4
@SS-JIASS-JIAAwaiting requested review from SS-JIA
@zingozingoAwaiting requested review from zingo

Assignees


No one assigned


Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.partner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Armrelease notes: noneDo not include this in the release notes

Projects


None yet


Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@per@zingo@SS-JIA@pytorchbot@mergennachin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Allow symints to be created for arguments - #16620
Merged
per merged 1 commit into
pytorch:mainfrom 
per:symint_handling_for_args
Jan 22, 2026
Merged
Allow symints to be created for arguments#16620
per merged 1 commit into
pytorch:mainfrom 
per:symint_handling_for_args
Conversation
@per
@perper
commented
Jan 15, 2026•

edited by pytorch-bot
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
Add test for creating args of SymInt type to be able to use them in view_copy nodes together with the fix to make the test pass.
Test plan
Tested through CI tests.
cc @freddan80@zingo@oscarandersson8218@digantdesai
@pytorch-bot
pytorch-botBot
commented
Jan 15, 2026•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16620
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit f350cc2 with merge base 7492d0d (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-clameta-claBot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 15, 2026
@per
per
requested review from
SS-JIA, lucylq, ydwu4 and zingo
and removed request for
JacobSzwejbka and larryliu0820January 15, 2026 10:09
@perper
added

partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
ciflow/trunk

labels
Jan 15, 2026
@zingozingo
added this to the 1.1.0 milestone
Jan 15, 2026
@per
Allow symints to be created for arguments
f350cc2
Add test for creating args of SymInt type to be able to use them
in view_copy nodes in the Arm TOSA backend together with the
fix to make the pass work.
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: Ia947b8426af1b473df415a17e10f3db1582b84fd
@per
perforce-pushed
the
symint_handling_for_args
branch
from
00a24ad to
f350cc2CompareJanuary 19, 2026 08:50
@zingo
zingo
commented
Jan 19, 2026

Copy link


Copy Markdown

Collaborator
Hi @SS-JIA / @metascroy this is touching files outside Arm code and need a review if possible
@perper
added
the 
release notes: none
Do not include this in the release notes
label
Jan 20, 2026
mergennachin
mergennachin
reviewed
Jan 20, 2026
View reviewed changes
Comment threadexir/pass_base.py
 if not hasattr(a, "constant") or a.constant is None:
 raise ExportPassBaseError(f"Cannot add {a} to graph.")
 a = a.constant
 elif isinstance(a, torch.SymInt):
@mergennachinmergennachinJan 20, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elif isinstance(a, (torch.SymInt, torch.SymFloat, torch.SymBool)):

and add corresponding unit test for symfloat and symbool please
thank you for finding this bug btw @per
@perperJan 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to trigger the SymFloat and SymBool paths here, since it comes from the dynamic shape export, which implies SymInts only, right?
@mergennachinmergennachinJan 21, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@per
SymFloat - https://gist.github.com/mergennachin/db34d1272f06b3be61ed1910b5dc6eaa

SymBool - https://gist.github.com/mergennachin/48326573d23293865d6447ab3dad622f
@perperJan 21, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the proposed tests doesn't trigger the bug, since the symbool/symfloat aren't part of a list argument (as the shape argument is in view_copy). The tests you linked to are properly handled already (scalars and tensors).

The only alternative I've come up with is to manually construct a symbol with a shape_env, but that feels like a really constructed way to trigger the bug:
 shape_env = ShapeEnv()
sym_bool = shape_env.create_unbacked_symbool()
tracer_owner = ExportPass()
tracer = tracer_owner.tracer
tracer.create_arg([sym_bool])

I've haven't been able to track down any operator that takes a list of bools or list of floats as argument, so IMHO it makes sense to keep the test as is, since that is what is exercised through the normal export flow. Or am I missing something?
@mergennachinmergennachinJan 21, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you for explaining and walking me through the code
@SS-JIA
SS-JIA
commented
Jan 20, 2026

Copy link


Copy Markdown

Contributor
Other than Mergen's comment, LGTM 👍
@per
per
requested a review
from mergennachinJanuary 21, 2026 09:14
@per
per
merged commit 5dbbec3
into
pytorch:mainJan 22, 2026

308 checks passed

@zingo
zingo
commented
Jan 22, 2026

Copy link


Copy Markdown

Collaborator
@pytorchbot cherry-pick --onto release/1.1 -c fixnewfeature
@pytorchbot
pytorchbot
commented
Jan 22, 2026

Copy link


Copy Markdown

Collaborator
Cherry picking #16620
The cherry pick PR is at #16774 and it is recommended to link a fixnewfeature cherry pick PR with an issue.
Details for Dev Infra team
Raised by workflow job
@perper
mentioned this pull request
Jan 22, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mergennachinmergennachinmergennachin approved these changes
@lucylqlucylqAwaiting requested review from lucylq
@ydwu4ydwu4Awaiting requested review from ydwu4
@SS-JIASS-JIAAwaiting requested review from SS-JIA
@zingozingoAwaiting requested review from zingo

Assignees


No one assigned


Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.partner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Armrelease notes: noneDo not include this in the release notes

Projects


None yet


Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@per@zingo@SS-JIA@pytorchbot@mergennachin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Allow symints to be created for arguments - #16620
Merged
per merged 1 commit into
pytorch:mainfrom 
per:symint_handling_for_args
Jan 22, 2026
Merged
Allow symints to be created for arguments#16620
per merged 1 commit into
pytorch:mainfrom 
per:symint_handling_for_args
Conversation
@per
@perper
commented
Jan 15, 2026•

edited by pytorch-bot
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
Add test for creating args of SymInt type to be able to use them in view_copy nodes together with the fix to make the test pass.
Test plan
Tested through CI tests.
cc @freddan80@zingo@oscarandersson8218@digantdesai
@pytorch-bot
pytorch-botBot
commented
Jan 15, 2026•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16620
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit f350cc2 with merge base 7492d0d (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-clameta-claBot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 15, 2026
@per
per
requested review from
SS-JIA, lucylq, ydwu4 and zingo
and removed request for
JacobSzwejbka and larryliu0820January 15, 2026 10:09
@perper
added

partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
ciflow/trunk

labels
Jan 15, 2026
@zingozingo
added this to the 1.1.0 milestone
Jan 15, 2026
@per
Allow symints to be created for arguments
f350cc2
Add test for creating args of SymInt type to be able to use them
in view_copy nodes in the Arm TOSA backend together with the
fix to make the pass work.
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: Ia947b8426af1b473df415a17e10f3db1582b84fd
@per
perforce-pushed
the
symint_handling_for_args
branch
from
00a24ad to
f350cc2CompareJanuary 19, 2026 08:50
@zingo
zingo
commented
Jan 19, 2026

Copy link


Copy Markdown

Collaborator
Hi @SS-JIA / @metascroy this is touching files outside Arm code and need a review if possible
@perper
added
the 
release notes: none
Do not include this in the release notes
label
Jan 20, 2026
mergennachin
mergennachin
reviewed
Jan 20, 2026
View reviewed changes
Comment threadexir/pass_base.py
 if not hasattr(a, "constant") or a.constant is None:
 raise ExportPassBaseError(f"Cannot add {a} to graph.")
 a = a.constant
 elif isinstance(a, torch.SymInt):
@mergennachinmergennachinJan 20, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elif isinstance(a, (torch.SymInt, torch.SymFloat, torch.SymBool)):

and add corresponding unit test for symfloat and symbool please
thank you for finding this bug btw @per
@perperJan 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to trigger the SymFloat and SymBool paths here, since it comes from the dynamic shape export, which implies SymInts only, right?
@mergennachinmergennachinJan 21, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@per
SymFloat - https://gist.github.com/mergennachin/db34d1272f06b3be61ed1910b5dc6eaa

SymBool - https://gist.github.com/mergennachin/48326573d23293865d6447ab3dad622f
@perperJan 21, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the proposed tests doesn't trigger the bug, since the symbool/symfloat aren't part of a list argument (as the shape argument is in view_copy). The tests you linked to are properly handled already (scalars and tensors).

The only alternative I've come up with is to manually construct a symbol with a shape_env, but that feels like a really constructed way to trigger the bug:
 shape_env = ShapeEnv()
sym_bool = shape_env.create_unbacked_symbool()
tracer_owner = ExportPass()
tracer = tracer_owner.tracer
tracer.create_arg([sym_bool])

I've haven't been able to track down any operator that takes a list of bools or list of floats as argument, so IMHO it makes sense to keep the test as is, since that is what is exercised through the normal export flow. Or am I missing something?
@mergennachinmergennachinJan 21, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you for explaining and walking me through the code
@SS-JIA
SS-JIA
commented
Jan 20, 2026

Copy link


Copy Markdown

Contributor
Other than Mergen's comment, LGTM 👍
@per
per
requested a review
from mergennachinJanuary 21, 2026 09:14
@per
per
merged commit 5dbbec3
into
pytorch:mainJan 22, 2026

308 checks passed

@zingo
zingo
commented
Jan 22, 2026

Copy link


Copy Markdown

Collaborator
@pytorchbot cherry-pick --onto release/1.1 -c fixnewfeature
@pytorchbot
pytorchbot
commented
Jan 22, 2026

Copy link


Copy Markdown

Collaborator
Cherry picking #16620
The cherry pick PR is at #16774 and it is recommended to link a fixnewfeature cherry pick PR with an issue.
Details for Dev Infra team
Raised by workflow job
@perper
mentioned this pull request
Jan 22, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mergennachinmergennachinmergennachin approved these changes
@lucylqlucylqAwaiting requested review from lucylq
@ydwu4ydwu4Awaiting requested review from ydwu4
@SS-JIASS-JIAAwaiting requested review from SS-JIA
@zingozingoAwaiting requested review from zingo

Assignees


No one assigned


Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.partner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Armrelease notes: noneDo not include this in the release notes

Projects


None yet


Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@per@zingo@SS-JIA@pytorchbot@mergennachin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Allow symints to be created for arguments - #16620
Merged
per merged 1 commit into
pytorch:mainfrom 
per:symint_handling_for_args
Jan 22, 2026
Merged
Allow symints to be created for arguments#16620
per merged 1 commit into
pytorch:mainfrom 
per:symint_handling_for_args
Conversation
@per
@perper
commented
Jan 15, 2026•

edited by pytorch-bot
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
Add test for creating args of SymInt type to be able to use them in view_copy nodes together with the fix to make the test pass.
Test plan
Tested through CI tests.
cc @freddan80@zingo@oscarandersson8218@digantdesai
@pytorch-bot
pytorch-botBot
commented
Jan 15, 2026•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16620
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit f350cc2 with merge base 7492d0d (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-clameta-claBot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 15, 2026
@per
per
requested review from
SS-JIA, lucylq, ydwu4 and zingo
and removed request for
JacobSzwejbka and larryliu0820January 15, 2026 10:09
@perper
added

partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
ciflow/trunk

labels
Jan 15, 2026
@zingozingo
added this to the 1.1.0 milestone
Jan 15, 2026
@per
Allow symints to be created for arguments
f350cc2
Add test for creating args of SymInt type to be able to use them
in view_copy nodes in the Arm TOSA backend together with the
fix to make the pass work.
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: Ia947b8426af1b473df415a17e10f3db1582b84fd
@per
perforce-pushed
the
symint_handling_for_args
branch
from
00a24ad to
f350cc2CompareJanuary 19, 2026 08:50
@zingo
zingo
commented
Jan 19, 2026

Copy link


Copy Markdown

Collaborator
Hi @SS-JIA / @metascroy this is touching files outside Arm code and need a review if possible
@perper
added
the 
release notes: none
Do not include this in the release notes
label
Jan 20, 2026
mergennachin
mergennachin
reviewed
Jan 20, 2026
View reviewed changes
Comment threadexir/pass_base.py
 if not hasattr(a, "constant") or a.constant is None:
 raise ExportPassBaseError(f"Cannot add {a} to graph.")
 a = a.constant
 elif isinstance(a, torch.SymInt):
@mergennachinmergennachinJan 20, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elif isinstance(a, (torch.SymInt, torch.SymFloat, torch.SymBool)):

and add corresponding unit test for symfloat and symbool please
thank you for finding this bug btw @per
@perperJan 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to trigger the SymFloat and SymBool paths here, since it comes from the dynamic shape export, which implies SymInts only, right?
@mergennachinmergennachinJan 21, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@per
SymFloat - https://gist.github.com/mergennachin/db34d1272f06b3be61ed1910b5dc6eaa

SymBool - https://gist.github.com/mergennachin/48326573d23293865d6447ab3dad622f
@perperJan 21, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the proposed tests doesn't trigger the bug, since the symbool/symfloat aren't part of a list argument (as the shape argument is in view_copy). The tests you linked to are properly handled already (scalars and tensors).

The only alternative I've come up with is to manually construct a symbol with a shape_env, but that feels like a really constructed way to trigger the bug:
 shape_env = ShapeEnv()
sym_bool = shape_env.create_unbacked_symbool()
tracer_owner = ExportPass()
tracer = tracer_owner.tracer
tracer.create_arg([sym_bool])

I've haven't been able to track down any operator that takes a list of bools or list of floats as argument, so IMHO it makes sense to keep the test as is, since that is what is exercised through the normal export flow. Or am I missing something?
@mergennachinmergennachinJan 21, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you for explaining and walking me through the code
@SS-JIA
SS-JIA
commented
Jan 20, 2026

Copy link


Copy Markdown

Contributor
Other than Mergen's comment, LGTM 👍
@per
per
requested a review
from mergennachinJanuary 21, 2026 09:14
@per
per
merged commit 5dbbec3
into
pytorch:mainJan 22, 2026

308 checks passed

@zingo
zingo
commented
Jan 22, 2026

Copy link


Copy Markdown

Collaborator
@pytorchbot cherry-pick --onto release/1.1 -c fixnewfeature
@pytorchbot
pytorchbot
commented
Jan 22, 2026

Copy link


Copy Markdown

Collaborator
Cherry picking #16620
The cherry pick PR is at #16774 and it is recommended to link a fixnewfeature cherry pick PR with an issue.
Details for Dev Infra team
Raised by workflow job
@perper
mentioned this pull request
Jan 22, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mergennachinmergennachinmergennachin approved these changes
@lucylqlucylqAwaiting requested review from lucylq
@ydwu4ydwu4Awaiting requested review from ydwu4
@SS-JIASS-JIAAwaiting requested review from SS-JIA
@zingozingoAwaiting requested review from zingo

Assignees


No one assigned


Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.partner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Armrelease notes: noneDo not include this in the release notes

Projects


None yet


Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@per@zingo@SS-JIA@pytorchbot@mergennachin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Allow symints to be created for arguments - #16620
Merged
per merged 1 commit into
pytorch:mainfrom 
per:symint_handling_for_args
Jan 22, 2026
Merged
Allow symints to be created for arguments#16620
per merged 1 commit into
pytorch:mainfrom 
per:symint_handling_for_args
Conversation
@per
@perper
commented
Jan 15, 2026•

edited by pytorch-bot
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
Add test for creating args of SymInt type to be able to use them in view_copy nodes together with the fix to make the test pass.
Test plan
Tested through CI tests.
cc @freddan80@zingo@oscarandersson8218@digantdesai
@pytorch-bot
pytorch-botBot
commented
Jan 15, 2026•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16620
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit f350cc2 with merge base 7492d0d (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-clameta-claBot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 15, 2026
@per
per
requested review from
SS-JIA, lucylq, ydwu4 and zingo
and removed request for
JacobSzwejbka and larryliu0820January 15, 2026 10:09
@perper
added

partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
ciflow/trunk

labels
Jan 15, 2026
@zingozingo
added this to the 1.1.0 milestone
Jan 15, 2026
@per
Allow symints to be created for arguments
f350cc2
Add test for creating args of SymInt type to be able to use them
in view_copy nodes in the Arm TOSA backend together with the
fix to make the pass work.
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: Ia947b8426af1b473df415a17e10f3db1582b84fd
@per
perforce-pushed
the
symint_handling_for_args
branch
from
00a24ad to
f350cc2CompareJanuary 19, 2026 08:50
@zingo
zingo
commented
Jan 19, 2026

Copy link


Copy Markdown

Collaborator
Hi @SS-JIA / @metascroy this is touching files outside Arm code and need a review if possible
@perper
added
the 
release notes: none
Do not include this in the release notes
label
Jan 20, 2026
mergennachin
mergennachin
reviewed
Jan 20, 2026
View reviewed changes
Comment threadexir/pass_base.py
 if not hasattr(a, "constant") or a.constant is None:
 raise ExportPassBaseError(f"Cannot add {a} to graph.")
 a = a.constant
 elif isinstance(a, torch.SymInt):
@mergennachinmergennachinJan 20, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elif isinstance(a, (torch.SymInt, torch.SymFloat, torch.SymBool)):

and add corresponding unit test for symfloat and symbool please
thank you for finding this bug btw @per
@perperJan 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to trigger the SymFloat and SymBool paths here, since it comes from the dynamic shape export, which implies SymInts only, right?
@mergennachinmergennachinJan 21, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@per
SymFloat - https://gist.github.com/mergennachin/db34d1272f06b3be61ed1910b5dc6eaa

SymBool - https://gist.github.com/mergennachin/48326573d23293865d6447ab3dad622f
@perperJan 21, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the proposed tests doesn't trigger the bug, since the symbool/symfloat aren't part of a list argument (as the shape argument is in view_copy). The tests you linked to are properly handled already (scalars and tensors).

The only alternative I've come up with is to manually construct a symbol with a shape_env, but that feels like a really constructed way to trigger the bug:
 shape_env = ShapeEnv()
sym_bool = shape_env.create_unbacked_symbool()
tracer_owner = ExportPass()
tracer = tracer_owner.tracer
tracer.create_arg([sym_bool])

I've haven't been able to track down any operator that takes a list of bools or list of floats as argument, so IMHO it makes sense to keep the test as is, since that is what is exercised through the normal export flow. Or am I missing something?
@mergennachinmergennachinJan 21, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you for explaining and walking me through the code
@SS-JIA
SS-JIA
commented
Jan 20, 2026

Copy link


Copy Markdown

Contributor
Other than Mergen's comment, LGTM 👍
@per
per
requested a review
from mergennachinJanuary 21, 2026 09:14
@per
per
merged commit 5dbbec3
into
pytorch:mainJan 22, 2026

308 checks passed

@zingo
zingo
commented
Jan 22, 2026

Copy link


Copy Markdown

Collaborator
@pytorchbot cherry-pick --onto release/1.1 -c fixnewfeature
@pytorchbot
pytorchbot
commented
Jan 22, 2026

Copy link


Copy Markdown

Collaborator
Cherry picking #16620
The cherry pick PR is at #16774 and it is recommended to link a fixnewfeature cherry pick PR with an issue.
Details for Dev Infra team
Raised by workflow job
@perper
mentioned this pull request
Jan 22, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mergennachinmergennachinmergennachin approved these changes
@lucylqlucylqAwaiting requested review from lucylq
@ydwu4ydwu4Awaiting requested review from ydwu4
@SS-JIASS-JIAAwaiting requested review from SS-JIA
@zingozingoAwaiting requested review from zingo

Assignees


No one assigned


Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.partner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Armrelease notes: noneDo not include this in the release notes

Projects


None yet


Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@per@zingo@SS-JIA@pytorchbot@mergennachin