Fix embedding lowering crash when QNN_SDK_ROOT is unset - #21051

Merged
psiddh merged 1 commit into
pytorch:mainfrom
psiddh:export-D112944232
Jul 21, 2026
Merged

Fix embedding lowering crash when QNN_SDK_ROOT is unset#21051
psiddh merged 1 commit into
pytorch:mainfrom
psiddh:export-D112944232

Conversation

@psiddh

@psiddhpsiddh commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary:
D110960687 (#20686) rewrote Embedding.define_node to
select between the optimized and legacy pcq-embedding lowerings based on
is_qnn_sdk_version_less_than("2.48"). That helper resolves the SDK version via
get_sdk_build_id, which builds a path from os.environ["QNN_SDK_ROOT"].

define_node runs during AOT partitioning (is_node_supported), and AOT-only
environments do not necessarily have QNN_SDK_ROOT set. In that case
os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...) raised
TypeError: expected str, bytes or os.PathLike object, not NoneType, breaking
every QNN lowering that contains an embedding — including the internal
test_dummy_llama_qnn_16a4w_aot_and_runtime.

Fall back to the legacy embedding lowering (valid on all QNN versions) when
QNN_SDK_ROOT is unavailable, so the version-gated optimization is only taken
when the SDK version can actually be determined. Also make get_sdk_build_id
raise a clear EnvironmentError instead of a cryptic TypeError when the
environment variable is missing.

This diff was authored with Claude Code.

Differential Revision: D112944232

@psiddh@facebook-github-bot
Fix embedding lowering crash when QNN_SDK_ROOT is unset
fdd05f2
Summary:
D110960687 (pytorch#20686) rewrote `Embedding.define_node` to
select between the optimized and legacy pcq-embedding lowerings based on
`is_qnn_sdk_version_less_than("2.48")`. That helper resolves the SDK version via
`get_sdk_build_id`, which builds a path from `os.environ["QNN_SDK_ROOT"]`.
`define_node` runs during AOT partitioning (`is_node_supported`), and AOT-only
environments do not necessarily have `QNN_SDK_ROOT` set. In that case
`os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...)` raised
`TypeError: expected str, bytes or os.PathLike object, not NoneType`, breaking
every QNN lowering that contains an embedding — including the internal
`test_dummy_llama_qnn_16a4w_aot_and_runtime`.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
`QNN_SDK_ROOT` is unavailable, so the version-gated optimization is only taken
when the SDK version can actually be determined. Also make `get_sdk_build_id`
raise a clear `EnvironmentError` instead of a cryptic `TypeError` when the
environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
CopilotAI review requested due to automatic review settings July 21, 2026 02:26
@pytorch-bot

pytorch-botBot commented Jul 21, 2026•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21051

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit fdd05f2 with merge base a19d1ba (image):

NEW FAILURES - The following jobs have failed:

  • Cadence Build & Test / hifi-build / hifi4 (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • pull / unittest-buck / linux / linux-job (gh)
    RuntimeError: Command docker exec -t d3fb35a27f1173eb9a0dcbfe1d00e801a77d9c6e4e2edf7535fd571b0fd0cb7f /exec failed with exit code 3

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-clameta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2026
@meta-codesync

meta-codesyncBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112944232.

@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

shewu-quic
shewu-quic approved these changes Jul 21, 2026
View reviewed changes

@shewu-quicshewu-quic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

CopilotAI reviewed Jul 21, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a crash in Qualcomm QNN embedding lowering during AOT partitioning when QNN_SDK_ROOT is unset, by preventing SDK-version probing in environments that don’t have an SDK path configured and by improving the error raised when the build-id helper is called without the required environment variable.

Changes:

  • Make get_sdk_build_id() explicitly raise EnvironmentError with a clear message when QNN_SDK_ROOT is missing.
  • Update embedding lowering to fall back to the legacy lowering when QNN_SDK_ROOT is unset, and only attempt the QNN 2.48+ optimized lowering when the SDK root is available.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
backends/qualcomm/utils/check_qnn_version.pyAdds an explicit environment-variable check and clearer exception for SDK build-id lookup.
backends/qualcomm/builders/op_embedding.pyAvoids version-gated optimized embedding lowering when SDK root is unavailable to prevent AOT partitioning crashes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadbackends/qualcomm/builders/op_embedding.py
Comment on lines +246 to 251
# The optimized pattern requires QNN 2.48+. Resolving the SDK version
# relies on QNN_SDK_ROOT; when it is unavailable (e.g. AOT-only
# environments) fall back to the legacy lowering, which is valid on all
# QNN versions.
if not os.environ.get("QNN_SDK_ROOT") or is_qnn_sdk_version_less_than("2.48"):
return self.define_node_legacy(node, nodes_to_wrappers)
@psiddh
psiddh merged commit 5ed466e into pytorch:mainJul 21, 2026
195 of 203 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@metascroymetascroymetascroy approved these changes
@abhinaykukkadapuabhinaykukkadapuAwaiting requested review from abhinaykukkadapuabhinaykukkadapu is a code owner
@haowhsu-quichaowhsu-quicAwaiting requested review from haowhsu-quic
@winskuo-quicwinskuo-quicAwaiting requested review from winskuo-quic
@chenweng-quicchenweng-quicAwaiting requested review from chenweng-quic
+1 more reviewer
@shewu-quicshewu-quicshewu-quic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@psiddh@shewu-quic@metascroy
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fix embedding lowering crash when QNN_SDK_ROOT is unset - #21051
Merged
psiddh merged 1 commit into
pytorch:mainfrom 
psiddh:export-D112944232
Jul 21, 2026
Merged
Fix embedding lowering crash when QNN_SDK_ROOT is unset#21051
psiddh merged 1 commit into
pytorch:mainfrom 
psiddh:export-D112944232
Conversation
@psiddh
@psiddhpsiddh
commented
Jul 21, 2026

Copy link


Copy Markdown

Contributor
Summary:

D110960687 (#20686) rewrote Embedding.define_node to

select between the optimized and legacy pcq-embedding lowerings based on
is_qnn_sdk_version_less_than("2.48"). That helper resolves the SDK version via
get_sdk_build_id, which builds a path from os.environ["QNN_SDK_ROOT"].
define_node runs during AOT partitioning (is_node_supported), and AOT-only

environments do not necessarily have QNN_SDK_ROOT set. In that case
os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...) raised
TypeError: expected str, bytes or os.PathLike object, not NoneType, breaking

every QNN lowering that contains an embedding — including the internal
test_dummy_llama_qnn_16a4w_aot_and_runtime.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
QNN_SDK_ROOT is unavailable, so the version-gated optimization is only taken

when the SDK version can actually be determined. Also make get_sdk_build_id

raise a clear EnvironmentError instead of a cryptic TypeError when the

environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
@psiddh@facebook-github-bot
Fix embedding lowering crash when QNN_SDK_ROOT is unset
fdd05f2
Summary:
D110960687 (pytorch#20686) rewrote `Embedding.define_node` to
select between the optimized and legacy pcq-embedding lowerings based on
`is_qnn_sdk_version_less_than("2.48")`. That helper resolves the SDK version via
`get_sdk_build_id`, which builds a path from `os.environ["QNN_SDK_ROOT"]`.
`define_node` runs during AOT partitioning (`is_node_supported`), and AOT-only
environments do not necessarily have `QNN_SDK_ROOT` set. In that case
`os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...)` raised
`TypeError: expected str, bytes or os.PathLike object, not NoneType`, breaking
every QNN lowering that contains an embedding — including the internal
`test_dummy_llama_qnn_16a4w_aot_and_runtime`.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
`QNN_SDK_ROOT` is unavailable, so the version-gated optimization is only taken
when the SDK version can actually be determined. Also make `get_sdk_build_id`
raise a clear `EnvironmentError` instead of a cryptic `TypeError` when the
environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
CopilotAI
review requested due to automatic review settings
July 21, 2026 02:26
@pytorch-bot
pytorch-botBot
commented
Jul 21, 2026•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21051
Note: Links to docs will display an error until the docs builds have been completed.
❌ 3 New Failures, 1 Unrelated Failure
As of commit fdd05f2 with merge base a19d1ba (image):
NEW FAILURES - The following jobs have failed:
  • Cadence Build & Test / hifi-build / hifi4 (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • pull / unittest-buck / linux / linux-job (gh)
    RuntimeError: Command docker exec -t d3fb35a27f1173eb9a0dcbfe1d00e801a77d9c6e4e2edf7535fd571b0fd0cb7f /exec failed with exit code 3
BROKEN TRUNK - The following job failed but were present on the merge base:
👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-clameta-claBot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jul 21, 2026
@meta-codesync
meta-codesyncBot
commented
Jul 21, 2026

Copy link


Copy Markdown

Contributor
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112944232.
@github-actions
github-actionsBot
commented
Jul 21, 2026

Copy link


Copy Markdown

This PR needs a release notes: label
If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.
To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"
For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.
shewu-quic
shewu-quic
approved these changes
Jul 21, 2026
View reviewed changes
@shewu-quicshewu-quic
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
CopilotAI
reviewed
Jul 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR fixes a crash in Qualcomm QNN embedding lowering during AOT partitioning when QNN_SDK_ROOT is unset, by preventing SDK-version probing in environments that don’t have an SDK path configured and by improving the error raised when the build-id helper is called without the required environment variable.
Changes:
  • Make get_sdk_build_id() explicitly raise EnvironmentError with a clear message when QNN_SDK_ROOT is missing.
  • Update embedding lowering to fall back to the legacy lowering when QNN_SDK_ROOT is unset, and only attempt the QNN 2.48+ optimized lowering when the SDK root is available.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
FileDescription
backends/qualcomm/utils/check_qnn_version.pyAdds an explicit environment-variable check and clearer exception for SDK build-id lookup.
backends/qualcomm/builders/op_embedding.pyAvoids version-gated optimized embedding lowering when SDK root is unavailable to prevent AOT partitioning crashes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadbackends/qualcomm/builders/op_embedding.py

Comment on lines

+246
 to 
251

 # The optimized pattern requires QNN 2.48+. Resolving the SDK version
 # relies on QNN_SDK_ROOT; when it is unavailable (e.g. AOT-only
 # environments) fall back to the legacy lowering, which is valid on all
 # QNN versions.
 if not os.environ.get("QNN_SDK_ROOT") or is_qnn_sdk_version_less_than("2.48"):
 return self.define_node_legacy(node, nodes_to_wrappers)
@psiddh
psiddh
merged commit 5ed466e
into
pytorch:mainJul 21, 2026

195 of 203 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@metascroymetascroymetascroy approved these changes
@abhinaykukkadapuabhinaykukkadapuAwaiting requested review from abhinaykukkadapuabhinaykukkadapu is a code owner
@haowhsu-quichaowhsu-quicAwaiting requested review from haowhsu-quic
@winskuo-quicwinskuo-quicAwaiting requested review from winskuo-quic
@chenweng-quicchenweng-quicAwaiting requested review from chenweng-quic

+1 more reviewer

@shewu-quicshewu-quicshewu-quic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.meta-exported

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@psiddh@shewu-quic@metascroy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix embedding lowering crash when QNN_SDK_ROOT is unset - #21051
Merged
psiddh merged 1 commit into
pytorch:mainfrom 
psiddh:export-D112944232
Jul 21, 2026
Merged
Fix embedding lowering crash when QNN_SDK_ROOT is unset#21051
psiddh merged 1 commit into
pytorch:mainfrom 
psiddh:export-D112944232
Conversation
@psiddh
@psiddhpsiddh
commented
Jul 21, 2026

Copy link


Copy Markdown

Contributor
Summary:

D110960687 (#20686) rewrote Embedding.define_node to

select between the optimized and legacy pcq-embedding lowerings based on
is_qnn_sdk_version_less_than("2.48"). That helper resolves the SDK version via
get_sdk_build_id, which builds a path from os.environ["QNN_SDK_ROOT"].
define_node runs during AOT partitioning (is_node_supported), and AOT-only

environments do not necessarily have QNN_SDK_ROOT set. In that case
os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...) raised
TypeError: expected str, bytes or os.PathLike object, not NoneType, breaking

every QNN lowering that contains an embedding — including the internal
test_dummy_llama_qnn_16a4w_aot_and_runtime.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
QNN_SDK_ROOT is unavailable, so the version-gated optimization is only taken

when the SDK version can actually be determined. Also make get_sdk_build_id

raise a clear EnvironmentError instead of a cryptic TypeError when the

environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
@psiddh@facebook-github-bot
Fix embedding lowering crash when QNN_SDK_ROOT is unset
fdd05f2
Summary:
D110960687 (pytorch#20686) rewrote `Embedding.define_node` to
select between the optimized and legacy pcq-embedding lowerings based on
`is_qnn_sdk_version_less_than("2.48")`. That helper resolves the SDK version via
`get_sdk_build_id`, which builds a path from `os.environ["QNN_SDK_ROOT"]`.
`define_node` runs during AOT partitioning (`is_node_supported`), and AOT-only
environments do not necessarily have `QNN_SDK_ROOT` set. In that case
`os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...)` raised
`TypeError: expected str, bytes or os.PathLike object, not NoneType`, breaking
every QNN lowering that contains an embedding — including the internal
`test_dummy_llama_qnn_16a4w_aot_and_runtime`.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
`QNN_SDK_ROOT` is unavailable, so the version-gated optimization is only taken
when the SDK version can actually be determined. Also make `get_sdk_build_id`
raise a clear `EnvironmentError` instead of a cryptic `TypeError` when the
environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
CopilotAI
review requested due to automatic review settings
July 21, 2026 02:26
@pytorch-bot
pytorch-botBot
commented
Jul 21, 2026•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21051
Note: Links to docs will display an error until the docs builds have been completed.
❌ 3 New Failures, 1 Unrelated Failure
As of commit fdd05f2 with merge base a19d1ba (image):
NEW FAILURES - The following jobs have failed:
  • Cadence Build & Test / hifi-build / hifi4 (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • pull / unittest-buck / linux / linux-job (gh)
    RuntimeError: Command docker exec -t d3fb35a27f1173eb9a0dcbfe1d00e801a77d9c6e4e2edf7535fd571b0fd0cb7f /exec failed with exit code 3
BROKEN TRUNK - The following job failed but were present on the merge base:
👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-clameta-claBot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jul 21, 2026
@meta-codesync
meta-codesyncBot
commented
Jul 21, 2026

Copy link


Copy Markdown

Contributor
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112944232.
@github-actions
github-actionsBot
commented
Jul 21, 2026

Copy link


Copy Markdown

This PR needs a release notes: label
If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.
To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"
For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.
shewu-quic
shewu-quic
approved these changes
Jul 21, 2026
View reviewed changes
@shewu-quicshewu-quic
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
CopilotAI
reviewed
Jul 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR fixes a crash in Qualcomm QNN embedding lowering during AOT partitioning when QNN_SDK_ROOT is unset, by preventing SDK-version probing in environments that don’t have an SDK path configured and by improving the error raised when the build-id helper is called without the required environment variable.
Changes:
  • Make get_sdk_build_id() explicitly raise EnvironmentError with a clear message when QNN_SDK_ROOT is missing.
  • Update embedding lowering to fall back to the legacy lowering when QNN_SDK_ROOT is unset, and only attempt the QNN 2.48+ optimized lowering when the SDK root is available.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
FileDescription
backends/qualcomm/utils/check_qnn_version.pyAdds an explicit environment-variable check and clearer exception for SDK build-id lookup.
backends/qualcomm/builders/op_embedding.pyAvoids version-gated optimized embedding lowering when SDK root is unavailable to prevent AOT partitioning crashes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadbackends/qualcomm/builders/op_embedding.py

Comment on lines

+246
 to 
251

 # The optimized pattern requires QNN 2.48+. Resolving the SDK version
 # relies on QNN_SDK_ROOT; when it is unavailable (e.g. AOT-only
 # environments) fall back to the legacy lowering, which is valid on all
 # QNN versions.
 if not os.environ.get("QNN_SDK_ROOT") or is_qnn_sdk_version_less_than("2.48"):
 return self.define_node_legacy(node, nodes_to_wrappers)
@psiddh
psiddh
merged commit 5ed466e
into
pytorch:mainJul 21, 2026

195 of 203 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@metascroymetascroymetascroy approved these changes
@abhinaykukkadapuabhinaykukkadapuAwaiting requested review from abhinaykukkadapuabhinaykukkadapu is a code owner
@haowhsu-quichaowhsu-quicAwaiting requested review from haowhsu-quic
@winskuo-quicwinskuo-quicAwaiting requested review from winskuo-quic
@chenweng-quicchenweng-quicAwaiting requested review from chenweng-quic

+1 more reviewer

@shewu-quicshewu-quicshewu-quic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.meta-exported

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@psiddh@shewu-quic@metascroy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix embedding lowering crash when QNN_SDK_ROOT is unset - #21051
Merged
psiddh merged 1 commit into
pytorch:mainfrom 
psiddh:export-D112944232
Jul 21, 2026
Merged
Fix embedding lowering crash when QNN_SDK_ROOT is unset#21051
psiddh merged 1 commit into
pytorch:mainfrom 
psiddh:export-D112944232
Conversation
@psiddh
@psiddhpsiddh
commented
Jul 21, 2026

Copy link


Copy Markdown

Contributor
Summary:

D110960687 (#20686) rewrote Embedding.define_node to

select between the optimized and legacy pcq-embedding lowerings based on
is_qnn_sdk_version_less_than("2.48"). That helper resolves the SDK version via
get_sdk_build_id, which builds a path from os.environ["QNN_SDK_ROOT"].
define_node runs during AOT partitioning (is_node_supported), and AOT-only

environments do not necessarily have QNN_SDK_ROOT set. In that case
os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...) raised
TypeError: expected str, bytes or os.PathLike object, not NoneType, breaking

every QNN lowering that contains an embedding — including the internal
test_dummy_llama_qnn_16a4w_aot_and_runtime.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
QNN_SDK_ROOT is unavailable, so the version-gated optimization is only taken

when the SDK version can actually be determined. Also make get_sdk_build_id

raise a clear EnvironmentError instead of a cryptic TypeError when the

environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
@psiddh@facebook-github-bot
Fix embedding lowering crash when QNN_SDK_ROOT is unset
fdd05f2
Summary:
D110960687 (pytorch#20686) rewrote `Embedding.define_node` to
select between the optimized and legacy pcq-embedding lowerings based on
`is_qnn_sdk_version_less_than("2.48")`. That helper resolves the SDK version via
`get_sdk_build_id`, which builds a path from `os.environ["QNN_SDK_ROOT"]`.
`define_node` runs during AOT partitioning (`is_node_supported`), and AOT-only
environments do not necessarily have `QNN_SDK_ROOT` set. In that case
`os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...)` raised
`TypeError: expected str, bytes or os.PathLike object, not NoneType`, breaking
every QNN lowering that contains an embedding — including the internal
`test_dummy_llama_qnn_16a4w_aot_and_runtime`.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
`QNN_SDK_ROOT` is unavailable, so the version-gated optimization is only taken
when the SDK version can actually be determined. Also make `get_sdk_build_id`
raise a clear `EnvironmentError` instead of a cryptic `TypeError` when the
environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
CopilotAI
review requested due to automatic review settings
July 21, 2026 02:26
@pytorch-bot
pytorch-botBot
commented
Jul 21, 2026•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21051
Note: Links to docs will display an error until the docs builds have been completed.
❌ 3 New Failures, 1 Unrelated Failure
As of commit fdd05f2 with merge base a19d1ba (image):
NEW FAILURES - The following jobs have failed:
  • Cadence Build & Test / hifi-build / hifi4 (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • pull / unittest-buck / linux / linux-job (gh)
    RuntimeError: Command docker exec -t d3fb35a27f1173eb9a0dcbfe1d00e801a77d9c6e4e2edf7535fd571b0fd0cb7f /exec failed with exit code 3
BROKEN TRUNK - The following job failed but were present on the merge base:
👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-clameta-claBot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jul 21, 2026
@meta-codesync
meta-codesyncBot
commented
Jul 21, 2026

Copy link


Copy Markdown

Contributor
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112944232.
@github-actions
github-actionsBot
commented
Jul 21, 2026

Copy link


Copy Markdown

This PR needs a release notes: label
If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.
To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"
For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.
shewu-quic
shewu-quic
approved these changes
Jul 21, 2026
View reviewed changes
@shewu-quicshewu-quic
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
CopilotAI
reviewed
Jul 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR fixes a crash in Qualcomm QNN embedding lowering during AOT partitioning when QNN_SDK_ROOT is unset, by preventing SDK-version probing in environments that don’t have an SDK path configured and by improving the error raised when the build-id helper is called without the required environment variable.
Changes:
  • Make get_sdk_build_id() explicitly raise EnvironmentError with a clear message when QNN_SDK_ROOT is missing.
  • Update embedding lowering to fall back to the legacy lowering when QNN_SDK_ROOT is unset, and only attempt the QNN 2.48+ optimized lowering when the SDK root is available.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
FileDescription
backends/qualcomm/utils/check_qnn_version.pyAdds an explicit environment-variable check and clearer exception for SDK build-id lookup.
backends/qualcomm/builders/op_embedding.pyAvoids version-gated optimized embedding lowering when SDK root is unavailable to prevent AOT partitioning crashes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadbackends/qualcomm/builders/op_embedding.py

Comment on lines

+246
 to 
251

 # The optimized pattern requires QNN 2.48+. Resolving the SDK version
 # relies on QNN_SDK_ROOT; when it is unavailable (e.g. AOT-only
 # environments) fall back to the legacy lowering, which is valid on all
 # QNN versions.
 if not os.environ.get("QNN_SDK_ROOT") or is_qnn_sdk_version_less_than("2.48"):
 return self.define_node_legacy(node, nodes_to_wrappers)
@psiddh
psiddh
merged commit 5ed466e
into
pytorch:mainJul 21, 2026

195 of 203 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@metascroymetascroymetascroy approved these changes
@abhinaykukkadapuabhinaykukkadapuAwaiting requested review from abhinaykukkadapuabhinaykukkadapu is a code owner
@haowhsu-quichaowhsu-quicAwaiting requested review from haowhsu-quic
@winskuo-quicwinskuo-quicAwaiting requested review from winskuo-quic
@chenweng-quicchenweng-quicAwaiting requested review from chenweng-quic

+1 more reviewer

@shewu-quicshewu-quicshewu-quic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.meta-exported

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@psiddh@shewu-quic@metascroy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fix embedding lowering crash when QNN_SDK_ROOT is unset - #21051
Merged
psiddh merged 1 commit into
pytorch:mainfrom 
psiddh:export-D112944232
Jul 21, 2026
Merged
Fix embedding lowering crash when QNN_SDK_ROOT is unset#21051
psiddh merged 1 commit into
pytorch:mainfrom 
psiddh:export-D112944232
Conversation
@psiddh
@psiddhpsiddh
commented
Jul 21, 2026

Copy link


Copy Markdown

Contributor
Summary:

D110960687 (#20686) rewrote Embedding.define_node to

select between the optimized and legacy pcq-embedding lowerings based on
is_qnn_sdk_version_less_than("2.48"). That helper resolves the SDK version via
get_sdk_build_id, which builds a path from os.environ["QNN_SDK_ROOT"].
define_node runs during AOT partitioning (is_node_supported), and AOT-only

environments do not necessarily have QNN_SDK_ROOT set. In that case
os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...) raised
TypeError: expected str, bytes or os.PathLike object, not NoneType, breaking

every QNN lowering that contains an embedding — including the internal
test_dummy_llama_qnn_16a4w_aot_and_runtime.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
QNN_SDK_ROOT is unavailable, so the version-gated optimization is only taken

when the SDK version can actually be determined. Also make get_sdk_build_id

raise a clear EnvironmentError instead of a cryptic TypeError when the

environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
@psiddh@facebook-github-bot
Fix embedding lowering crash when QNN_SDK_ROOT is unset
fdd05f2
Summary:
D110960687 (pytorch#20686) rewrote `Embedding.define_node` to
select between the optimized and legacy pcq-embedding lowerings based on
`is_qnn_sdk_version_less_than("2.48")`. That helper resolves the SDK version via
`get_sdk_build_id`, which builds a path from `os.environ["QNN_SDK_ROOT"]`.
`define_node` runs during AOT partitioning (`is_node_supported`), and AOT-only
environments do not necessarily have `QNN_SDK_ROOT` set. In that case
`os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...)` raised
`TypeError: expected str, bytes or os.PathLike object, not NoneType`, breaking
every QNN lowering that contains an embedding — including the internal
`test_dummy_llama_qnn_16a4w_aot_and_runtime`.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
`QNN_SDK_ROOT` is unavailable, so the version-gated optimization is only taken
when the SDK version can actually be determined. Also make `get_sdk_build_id`
raise a clear `EnvironmentError` instead of a cryptic `TypeError` when the
environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
CopilotAI
review requested due to automatic review settings
July 21, 2026 02:26
@pytorch-bot
pytorch-botBot
commented
Jul 21, 2026•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21051
Note: Links to docs will display an error until the docs builds have been completed.
❌ 3 New Failures, 1 Unrelated Failure
As of commit fdd05f2 with merge base a19d1ba (image):
NEW FAILURES - The following jobs have failed:
  • Cadence Build & Test / hifi-build / hifi4 (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • pull / unittest-buck / linux / linux-job (gh)
    RuntimeError: Command docker exec -t d3fb35a27f1173eb9a0dcbfe1d00e801a77d9c6e4e2edf7535fd571b0fd0cb7f /exec failed with exit code 3
BROKEN TRUNK - The following job failed but were present on the merge base:
👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-clameta-claBot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jul 21, 2026
@meta-codesync
meta-codesyncBot
commented
Jul 21, 2026

Copy link


Copy Markdown

Contributor
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112944232.
@github-actions
github-actionsBot
commented
Jul 21, 2026

Copy link


Copy Markdown

This PR needs a release notes: label
If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.
To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"
For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.
shewu-quic
shewu-quic
approved these changes
Jul 21, 2026
View reviewed changes
@shewu-quicshewu-quic
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
CopilotAI
reviewed
Jul 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR fixes a crash in Qualcomm QNN embedding lowering during AOT partitioning when QNN_SDK_ROOT is unset, by preventing SDK-version probing in environments that don’t have an SDK path configured and by improving the error raised when the build-id helper is called without the required environment variable.
Changes:
  • Make get_sdk_build_id() explicitly raise EnvironmentError with a clear message when QNN_SDK_ROOT is missing.
  • Update embedding lowering to fall back to the legacy lowering when QNN_SDK_ROOT is unset, and only attempt the QNN 2.48+ optimized lowering when the SDK root is available.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
FileDescription
backends/qualcomm/utils/check_qnn_version.pyAdds an explicit environment-variable check and clearer exception for SDK build-id lookup.
backends/qualcomm/builders/op_embedding.pyAvoids version-gated optimized embedding lowering when SDK root is unavailable to prevent AOT partitioning crashes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadbackends/qualcomm/builders/op_embedding.py

Comment on lines

+246
 to 
251

 # The optimized pattern requires QNN 2.48+. Resolving the SDK version
 # relies on QNN_SDK_ROOT; when it is unavailable (e.g. AOT-only
 # environments) fall back to the legacy lowering, which is valid on all
 # QNN versions.
 if not os.environ.get("QNN_SDK_ROOT") or is_qnn_sdk_version_less_than("2.48"):
 return self.define_node_legacy(node, nodes_to_wrappers)
@psiddh
psiddh
merged commit 5ed466e
into
pytorch:mainJul 21, 2026

195 of 203 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@metascroymetascroymetascroy approved these changes
@abhinaykukkadapuabhinaykukkadapuAwaiting requested review from abhinaykukkadapuabhinaykukkadapu is a code owner
@haowhsu-quichaowhsu-quicAwaiting requested review from haowhsu-quic
@winskuo-quicwinskuo-quicAwaiting requested review from winskuo-quic
@chenweng-quicchenweng-quicAwaiting requested review from chenweng-quic

+1 more reviewer

@shewu-quicshewu-quicshewu-quic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.meta-exported

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@psiddh@shewu-quic@metascroy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix embedding lowering crash when QNN_SDK_ROOT is unset - #21051
Merged
psiddh merged 1 commit into
pytorch:mainfrom 
psiddh:export-D112944232
Jul 21, 2026
Merged
Fix embedding lowering crash when QNN_SDK_ROOT is unset#21051
psiddh merged 1 commit into
pytorch:mainfrom 
psiddh:export-D112944232
Conversation
@psiddh
@psiddhpsiddh
commented
Jul 21, 2026

Copy link


Copy Markdown

Contributor
Summary:

D110960687 (#20686) rewrote Embedding.define_node to

select between the optimized and legacy pcq-embedding lowerings based on
is_qnn_sdk_version_less_than("2.48"). That helper resolves the SDK version via
get_sdk_build_id, which builds a path from os.environ["QNN_SDK_ROOT"].
define_node runs during AOT partitioning (is_node_supported), and AOT-only

environments do not necessarily have QNN_SDK_ROOT set. In that case
os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...) raised
TypeError: expected str, bytes or os.PathLike object, not NoneType, breaking

every QNN lowering that contains an embedding — including the internal
test_dummy_llama_qnn_16a4w_aot_and_runtime.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
QNN_SDK_ROOT is unavailable, so the version-gated optimization is only taken

when the SDK version can actually be determined. Also make get_sdk_build_id

raise a clear EnvironmentError instead of a cryptic TypeError when the

environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
@psiddh@facebook-github-bot
Fix embedding lowering crash when QNN_SDK_ROOT is unset
fdd05f2
Summary:
D110960687 (pytorch#20686) rewrote `Embedding.define_node` to
select between the optimized and legacy pcq-embedding lowerings based on
`is_qnn_sdk_version_less_than("2.48")`. That helper resolves the SDK version via
`get_sdk_build_id`, which builds a path from `os.environ["QNN_SDK_ROOT"]`.
`define_node` runs during AOT partitioning (`is_node_supported`), and AOT-only
environments do not necessarily have `QNN_SDK_ROOT` set. In that case
`os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...)` raised
`TypeError: expected str, bytes or os.PathLike object, not NoneType`, breaking
every QNN lowering that contains an embedding — including the internal
`test_dummy_llama_qnn_16a4w_aot_and_runtime`.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
`QNN_SDK_ROOT` is unavailable, so the version-gated optimization is only taken
when the SDK version can actually be determined. Also make `get_sdk_build_id`
raise a clear `EnvironmentError` instead of a cryptic `TypeError` when the
environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
CopilotAI
review requested due to automatic review settings
July 21, 2026 02:26
@pytorch-bot
pytorch-botBot
commented
Jul 21, 2026•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21051
Note: Links to docs will display an error until the docs builds have been completed.
❌ 3 New Failures, 1 Unrelated Failure
As of commit fdd05f2 with merge base a19d1ba (image):
NEW FAILURES - The following jobs have failed:
  • Cadence Build & Test / hifi-build / hifi4 (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • pull / unittest-buck / linux / linux-job (gh)
    RuntimeError: Command docker exec -t d3fb35a27f1173eb9a0dcbfe1d00e801a77d9c6e4e2edf7535fd571b0fd0cb7f /exec failed with exit code 3
BROKEN TRUNK - The following job failed but were present on the merge base:
👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-clameta-claBot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jul 21, 2026
@meta-codesync
meta-codesyncBot
commented
Jul 21, 2026

Copy link


Copy Markdown

Contributor
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112944232.
@github-actions
github-actionsBot
commented
Jul 21, 2026

Copy link


Copy Markdown

This PR needs a release notes: label
If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.
To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"
For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.
shewu-quic
shewu-quic
approved these changes
Jul 21, 2026
View reviewed changes
@shewu-quicshewu-quic
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
CopilotAI
reviewed
Jul 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR fixes a crash in Qualcomm QNN embedding lowering during AOT partitioning when QNN_SDK_ROOT is unset, by preventing SDK-version probing in environments that don’t have an SDK path configured and by improving the error raised when the build-id helper is called without the required environment variable.
Changes:
  • Make get_sdk_build_id() explicitly raise EnvironmentError with a clear message when QNN_SDK_ROOT is missing.
  • Update embedding lowering to fall back to the legacy lowering when QNN_SDK_ROOT is unset, and only attempt the QNN 2.48+ optimized lowering when the SDK root is available.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
FileDescription
backends/qualcomm/utils/check_qnn_version.pyAdds an explicit environment-variable check and clearer exception for SDK build-id lookup.
backends/qualcomm/builders/op_embedding.pyAvoids version-gated optimized embedding lowering when SDK root is unavailable to prevent AOT partitioning crashes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadbackends/qualcomm/builders/op_embedding.py

Comment on lines

+246
 to 
251

 # The optimized pattern requires QNN 2.48+. Resolving the SDK version
 # relies on QNN_SDK_ROOT; when it is unavailable (e.g. AOT-only
 # environments) fall back to the legacy lowering, which is valid on all
 # QNN versions.
 if not os.environ.get("QNN_SDK_ROOT") or is_qnn_sdk_version_less_than("2.48"):
 return self.define_node_legacy(node, nodes_to_wrappers)
@psiddh
psiddh
merged commit 5ed466e
into
pytorch:mainJul 21, 2026

195 of 203 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@metascroymetascroymetascroy approved these changes
@abhinaykukkadapuabhinaykukkadapuAwaiting requested review from abhinaykukkadapuabhinaykukkadapu is a code owner
@haowhsu-quichaowhsu-quicAwaiting requested review from haowhsu-quic
@winskuo-quicwinskuo-quicAwaiting requested review from winskuo-quic
@chenweng-quicchenweng-quicAwaiting requested review from chenweng-quic

+1 more reviewer

@shewu-quicshewu-quicshewu-quic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.meta-exported

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@psiddh@shewu-quic@metascroy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix embedding lowering crash when QNN_SDK_ROOT is unset - #21051
Merged
psiddh merged 1 commit into
pytorch:mainfrom 
psiddh:export-D112944232
Jul 21, 2026
Merged
Fix embedding lowering crash when QNN_SDK_ROOT is unset#21051
psiddh merged 1 commit into
pytorch:mainfrom 
psiddh:export-D112944232
Conversation
@psiddh
@psiddhpsiddh
commented
Jul 21, 2026

Copy link


Copy Markdown

Contributor
Summary:

D110960687 (#20686) rewrote Embedding.define_node to

select between the optimized and legacy pcq-embedding lowerings based on
is_qnn_sdk_version_less_than("2.48"). That helper resolves the SDK version via
get_sdk_build_id, which builds a path from os.environ["QNN_SDK_ROOT"].
define_node runs during AOT partitioning (is_node_supported), and AOT-only

environments do not necessarily have QNN_SDK_ROOT set. In that case
os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...) raised
TypeError: expected str, bytes or os.PathLike object, not NoneType, breaking

every QNN lowering that contains an embedding — including the internal
test_dummy_llama_qnn_16a4w_aot_and_runtime.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
QNN_SDK_ROOT is unavailable, so the version-gated optimization is only taken

when the SDK version can actually be determined. Also make get_sdk_build_id

raise a clear EnvironmentError instead of a cryptic TypeError when the

environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
@psiddh@facebook-github-bot
Fix embedding lowering crash when QNN_SDK_ROOT is unset
fdd05f2
Summary:
D110960687 (pytorch#20686) rewrote `Embedding.define_node` to
select between the optimized and legacy pcq-embedding lowerings based on
`is_qnn_sdk_version_less_than("2.48")`. That helper resolves the SDK version via
`get_sdk_build_id`, which builds a path from `os.environ["QNN_SDK_ROOT"]`.
`define_node` runs during AOT partitioning (`is_node_supported`), and AOT-only
environments do not necessarily have `QNN_SDK_ROOT` set. In that case
`os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...)` raised
`TypeError: expected str, bytes or os.PathLike object, not NoneType`, breaking
every QNN lowering that contains an embedding — including the internal
`test_dummy_llama_qnn_16a4w_aot_and_runtime`.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
`QNN_SDK_ROOT` is unavailable, so the version-gated optimization is only taken
when the SDK version can actually be determined. Also make `get_sdk_build_id`
raise a clear `EnvironmentError` instead of a cryptic `TypeError` when the
environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
CopilotAI
review requested due to automatic review settings
July 21, 2026 02:26
@pytorch-bot
pytorch-botBot
commented
Jul 21, 2026•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21051
Note: Links to docs will display an error until the docs builds have been completed.
❌ 3 New Failures, 1 Unrelated Failure
As of commit fdd05f2 with merge base a19d1ba (image):
NEW FAILURES - The following jobs have failed:
  • Cadence Build & Test / hifi-build / hifi4 (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • pull / unittest-buck / linux / linux-job (gh)
    RuntimeError: Command docker exec -t d3fb35a27f1173eb9a0dcbfe1d00e801a77d9c6e4e2edf7535fd571b0fd0cb7f /exec failed with exit code 3
BROKEN TRUNK - The following job failed but were present on the merge base:
👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-clameta-claBot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jul 21, 2026
@meta-codesync
meta-codesyncBot
commented
Jul 21, 2026

Copy link


Copy Markdown

Contributor
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112944232.
@github-actions
github-actionsBot
commented
Jul 21, 2026

Copy link


Copy Markdown

This PR needs a release notes: label
If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.
To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"
For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.
shewu-quic
shewu-quic
approved these changes
Jul 21, 2026
View reviewed changes
@shewu-quicshewu-quic
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
CopilotAI
reviewed
Jul 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR fixes a crash in Qualcomm QNN embedding lowering during AOT partitioning when QNN_SDK_ROOT is unset, by preventing SDK-version probing in environments that don’t have an SDK path configured and by improving the error raised when the build-id helper is called without the required environment variable.
Changes:
  • Make get_sdk_build_id() explicitly raise EnvironmentError with a clear message when QNN_SDK_ROOT is missing.
  • Update embedding lowering to fall back to the legacy lowering when QNN_SDK_ROOT is unset, and only attempt the QNN 2.48+ optimized lowering when the SDK root is available.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
FileDescription
backends/qualcomm/utils/check_qnn_version.pyAdds an explicit environment-variable check and clearer exception for SDK build-id lookup.
backends/qualcomm/builders/op_embedding.pyAvoids version-gated optimized embedding lowering when SDK root is unavailable to prevent AOT partitioning crashes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadbackends/qualcomm/builders/op_embedding.py

Comment on lines

+246
 to 
251

 # The optimized pattern requires QNN 2.48+. Resolving the SDK version
 # relies on QNN_SDK_ROOT; when it is unavailable (e.g. AOT-only
 # environments) fall back to the legacy lowering, which is valid on all
 # QNN versions.
 if not os.environ.get("QNN_SDK_ROOT") or is_qnn_sdk_version_less_than("2.48"):
 return self.define_node_legacy(node, nodes_to_wrappers)
@psiddh
psiddh
merged commit 5ed466e
into
pytorch:mainJul 21, 2026

195 of 203 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@metascroymetascroymetascroy approved these changes
@abhinaykukkadapuabhinaykukkadapuAwaiting requested review from abhinaykukkadapuabhinaykukkadapu is a code owner
@haowhsu-quichaowhsu-quicAwaiting requested review from haowhsu-quic
@winskuo-quicwinskuo-quicAwaiting requested review from winskuo-quic
@chenweng-quicchenweng-quicAwaiting requested review from chenweng-quic

+1 more reviewer

@shewu-quicshewu-quicshewu-quic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.meta-exported

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@psiddh@shewu-quic@metascroy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fix embedding lowering crash when QNN_SDK_ROOT is unset - #21051
Merged
psiddh merged 1 commit into
pytorch:mainfrom 
psiddh:export-D112944232
Jul 21, 2026
Merged
Fix embedding lowering crash when QNN_SDK_ROOT is unset#21051
psiddh merged 1 commit into
pytorch:mainfrom 
psiddh:export-D112944232
Conversation
@psiddh
@psiddhpsiddh
commented
Jul 21, 2026

Copy link


Copy Markdown

Contributor
Summary:

D110960687 (#20686) rewrote Embedding.define_node to

select between the optimized and legacy pcq-embedding lowerings based on
is_qnn_sdk_version_less_than("2.48"). That helper resolves the SDK version via
get_sdk_build_id, which builds a path from os.environ["QNN_SDK_ROOT"].
define_node runs during AOT partitioning (is_node_supported), and AOT-only

environments do not necessarily have QNN_SDK_ROOT set. In that case
os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...) raised
TypeError: expected str, bytes or os.PathLike object, not NoneType, breaking

every QNN lowering that contains an embedding — including the internal
test_dummy_llama_qnn_16a4w_aot_and_runtime.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
QNN_SDK_ROOT is unavailable, so the version-gated optimization is only taken

when the SDK version can actually be determined. Also make get_sdk_build_id

raise a clear EnvironmentError instead of a cryptic TypeError when the

environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
@psiddh@facebook-github-bot
Fix embedding lowering crash when QNN_SDK_ROOT is unset
fdd05f2
Summary:
D110960687 (pytorch#20686) rewrote `Embedding.define_node` to
select between the optimized and legacy pcq-embedding lowerings based on
`is_qnn_sdk_version_less_than("2.48")`. That helper resolves the SDK version via
`get_sdk_build_id`, which builds a path from `os.environ["QNN_SDK_ROOT"]`.
`define_node` runs during AOT partitioning (`is_node_supported`), and AOT-only
environments do not necessarily have `QNN_SDK_ROOT` set. In that case
`os.path.join(os.environ.get("QNN_SDK_ROOT", None), ...)` raised
`TypeError: expected str, bytes or os.PathLike object, not NoneType`, breaking
every QNN lowering that contains an embedding — including the internal
`test_dummy_llama_qnn_16a4w_aot_and_runtime`.
Fall back to the legacy embedding lowering (valid on all QNN versions) when
`QNN_SDK_ROOT` is unavailable, so the version-gated optimization is only taken
when the SDK version can actually be determined. Also make `get_sdk_build_id`
raise a clear `EnvironmentError` instead of a cryptic `TypeError` when the
environment variable is missing.
This diff was authored with Claude Code.
Differential Revision: D112944232
CopilotAI
review requested due to automatic review settings
July 21, 2026 02:26
@pytorch-bot
pytorch-botBot
commented
Jul 21, 2026•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21051
Note: Links to docs will display an error until the docs builds have been completed.
❌ 3 New Failures, 1 Unrelated Failure
As of commit fdd05f2 with merge base a19d1ba (image):
NEW FAILURES - The following jobs have failed:
  • Cadence Build & Test / hifi-build / hifi4 (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • pull / unittest-buck / linux / linux-job (gh)
    RuntimeError: Command docker exec -t d3fb35a27f1173eb9a0dcbfe1d00e801a77d9c6e4e2edf7535fd571b0fd0cb7f /exec failed with exit code 3
BROKEN TRUNK - The following job failed but were present on the merge base:
👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-clameta-claBot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jul 21, 2026
@meta-codesync
meta-codesyncBot
commented
Jul 21, 2026

Copy link


Copy Markdown

Contributor
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112944232.
@github-actions
github-actionsBot
commented
Jul 21, 2026

Copy link


Copy Markdown

This PR needs a release notes: label
If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.
To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"
For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.
shewu-quic
shewu-quic
approved these changes
Jul 21, 2026
View reviewed changes
@shewu-quicshewu-quic
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
CopilotAI
reviewed
Jul 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR fixes a crash in Qualcomm QNN embedding lowering during AOT partitioning when QNN_SDK_ROOT is unset, by preventing SDK-version probing in environments that don’t have an SDK path configured and by improving the error raised when the build-id helper is called without the required environment variable.
Changes:
  • Make get_sdk_build_id() explicitly raise EnvironmentError with a clear message when QNN_SDK_ROOT is missing.
  • Update embedding lowering to fall back to the legacy lowering when QNN_SDK_ROOT is unset, and only attempt the QNN 2.48+ optimized lowering when the SDK root is available.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
FileDescription
backends/qualcomm/utils/check_qnn_version.pyAdds an explicit environment-variable check and clearer exception for SDK build-id lookup.
backends/qualcomm/builders/op_embedding.pyAvoids version-gated optimized embedding lowering when SDK root is unavailable to prevent AOT partitioning crashes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadbackends/qualcomm/builders/op_embedding.py

Comment on lines

+246
 to 
251

 # The optimized pattern requires QNN 2.48+. Resolving the SDK version
 # relies on QNN_SDK_ROOT; when it is unavailable (e.g. AOT-only
 # environments) fall back to the legacy lowering, which is valid on all
 # QNN versions.
 if not os.environ.get("QNN_SDK_ROOT") or is_qnn_sdk_version_less_than("2.48"):
 return self.define_node_legacy(node, nodes_to_wrappers)
@psiddh
psiddh
merged commit 5ed466e
into
pytorch:mainJul 21, 2026

195 of 203 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@metascroymetascroymetascroy approved these changes
@abhinaykukkadapuabhinaykukkadapuAwaiting requested review from abhinaykukkadapuabhinaykukkadapu is a code owner
@haowhsu-quichaowhsu-quicAwaiting requested review from haowhsu-quic
@winskuo-quicwinskuo-quicAwaiting requested review from winskuo-quic
@chenweng-quicchenweng-quicAwaiting requested review from chenweng-quic

+1 more reviewer

@shewu-quicshewu-quicshewu-quic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.meta-exported

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@psiddh@shewu-quic@metascroy