Uh oh!
There was an error while loading. Please reload this page.
[ExecuTorch][WebGPU] Lift FastVLM dispatch limits and harden graph construction - #21602
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21602
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ab3d0de with merge base ad3a71f ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a |
…nstruction Pull Request resolved: #21602 **Run production FastVLM shapes with exception-safe WebGPU graph construction** Production FastVLM tensors exceeded WebGPU one-dimensional dispatch limits, while several parameter buffers were not graph-owned before fallible pipeline construction. The runtime now folds flat dispatches across x/y, owns parameters immediately, rejects ambiguous `BOOL`/byte-integer casts, and compiles timestamp validation only in profiling builds. Key changes: - `GELU` and `expand_copy` use overflow-safe folded dispatch and live resize updates. - `Compare`, `expand_copy`, and `to_copy` create graph-owned parameter buffers before pipeline construction, mirroring Vulkan `ComputeGraph` ownership. - `to_copy` rejects `BOOL`-to/from-`INT8` or `UINT8` before same-width flat-copy routing. - Production builds exclude timestamp-query validation and symbols. - Boundary, failure, and real FastVLM encoder coverage exercise the final combined behavior. Kernel math and below-limit one-dimensional dispatch behavior are unchanged. Co-authored-with: Claude Code. ghstack-source-id: 411059172 @exported-using-ghexport Differential Revision: [D114936147](https://our.internmc.facebook.com/intern/diff/D114936147/)
Uh oh!
There was an error while loading. Please reload this page.
…nstruction Pull Request resolved: #21602 **Run production FastVLM shapes with exception-safe WebGPU graph construction** Production FastVLM tensors exceeded WebGPU one-dimensional dispatch limits, while several parameter buffers were not graph-owned before fallible pipeline construction. The runtime now folds flat dispatches across x/y, owns parameters immediately, rejects ambiguous `BOOL`/byte-integer casts, and compiles timestamp validation only in profiling builds. Key changes: - `GELU` and `expand_copy` use overflow-safe folded dispatch and live resize updates. - `Compare`, `expand_copy`, and `to_copy` create graph-owned parameter buffers before pipeline construction, mirroring Vulkan `ComputeGraph` ownership. - `to_copy` rejects `BOOL`-to/from-`INT8` or `UINT8` before same-width flat-copy routing. - Production builds exclude timestamp-query validation and symbols. - Boundary, failure, and real FastVLM encoder coverage exercise the final combined behavior. Kernel math and below-limit one-dimensional dispatch behavior are unchanged. Co-authored-with: Claude Code. ghstack-source-id: 411059172 @exported-using-ghexport Differential Revision: [D114936147](https://our.internmc.facebook.com/intern/diff/D114936147/)
Stack from ghstack (oldest at bottom):
Run production FastVLM shapes with exception-safe WebGPU graph construction
Production FastVLM tensors exceeded WebGPU one-dimensional dispatch limits, while several parameter buffers were not graph-owned before fallible pipeline construction. The runtime now folds flat dispatches across x/y, owns parameters immediately, rejects ambiguous
BOOL/byte-integer casts, and compiles timestamp validation only in profiling builds.Key changes:
GELUandexpand_copyuse overflow-safe folded dispatch and live resize updates.Compare,expand_copy, andto_copycreate graph-owned parameter buffers before pipeline construction, mirroring VulkanComputeGraphownership.to_copyrejectsBOOL-to/from-INT8orUINT8before same-width flat-copy routing.Kernel math and below-limit one-dimensional dispatch behavior are unchanged.
Co-authored-with: Claude Code.
Differential Revision: D114936147