Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner - #3056

Closed
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2
Closed

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner#3056
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2

Conversation

@robell

@robellrobell commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator
  • Builds on TOSA support for mv2
  • Currently has accuracy issues for on-target execution.
  • Adding support mv2 from examples/models (torchvision mv2)
  • Adds ability to use portable Q/DQ ops to enable float signature quantized models (to be improved with int signature when possible to enable integer images rather than int -> float -> quant flow.
  • Adds permute for ethos-u backend to enable NCHW to NHWC (which we'll aim to replace with a compiler pass on entry/exit of the subgraph, or the NHWC support when available.
  • small fix to enable qantized ops in runtime for the IOQDQ pass, and build/register those kernels/ops in bare metal build

@pytorch-bot

pytorch-botBot commented Apr 16, 2024•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3056

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6f4ce19 with merge base cc12d9b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2024
@robell
robell requested a review from digantdesaiApril 16, 2024 11:54
@robellrobell self-assigned this Apr 16, 2024
@robellrobell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Apr 16, 2024
@robellrobell changed the title Add support of mv2 in arm baremetal runnerAdd support for MobileNet v2 in Ethos-U55 and arm baremetal runnerApr 16, 2024
digantdesai
digantdesai approved these changes Apr 16, 2024
View reviewed changes

@digantdesaidigantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks @robell.

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_partitioner.py
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadexamples/arm/run.sh
@facebook-github-bot

facebook-github-bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot

facebook-github-bot commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robell
robellforce-pushed the mv2_rebase2 branch 3 times, most recently from f346e0f to c2442c4CompareApril 23, 2024 17:33
@digantdesai

digantdesai commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Sigh.. can you rebase please?

@robell
robellforce-pushed the mv2_rebase2 branch 5 times, most recently from 5996cbf to 0790d93CompareApril 26, 2024 10:23
@facebook-github-bot

facebook-github-bot commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot

facebook-github-bot commented May 1, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

robell added 8 commits May 2, 2024 08:51
@robell
Adding mn2 invocation to run.sh and use correct model section
77b5666
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add flag to register custom ops (like q/dq nodes) in aot_arm_compiler
c2c3544
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add pass to maintain IO quantization
1f28d1d
Currently only enabled in the aot_ compile flow as this requires
AoT kernel registration.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: I0c41b3a34613c900fc3f350f4f83b41378ac0add
@robell
Enable mv2 quantized to run on Corstone-300 * NOTE: this has accuracy…
4deed60
… issues until further fixes * enable further input types and layouts * add optional temp support for reordering NCHW * include portable quantized ops for IOQDQ fallback
Optional reordering will be removed once NHWC support is introduced.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: Iba2d4954fa14bc937584e59cb2ce82f4cdc1205d
@robell
Fix for ambiguous operator overload.
d100313
The templated function with this change has an ambigious overload, making it unambiguous by casting up to the templated type in this quantized function
@robell
lintfix
3d848fe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
documented permute and quantize_io compilespec properties
9b1a964
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
popping arm_partition metadata after use
fb4befe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
robell added 2 commits May 2, 2024 08:54
@robell
Refactor ArmBackend permute for readability
ebfd6ea
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add FVP option to increase ITCM
467c3a5
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Moving aot lib build to cmake
6f4ce19
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell

robell commented May 2, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@digantdesai or @mergennachin could we import this now, thanks to the fix in #3449 this now passes when rebased.

@robellrobell mentioned this pull request May 2, 2024
Closed
@facebook-github-bot

facebook-github-bot commented May 2, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented May 3, 2024

Copy link
Copy Markdown
Contributor

@digantdesai merged this pull request in 623f0e0.

@oscarandersson8218oscarandersson8218 mentioned this pull request Jul 3, 2024
Closed
@freddan80freddan80 mentioned this pull request Aug 15, 2024
Closed
@robell
robell deleted the mv2_rebase2 branch October 1, 2024 10:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees

@robellrobell

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner - #3056

Closed
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2
Closed

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner#3056
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2

Conversation

@robell

@robellrobell commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator
  • Builds on TOSA support for mv2
  • Currently has accuracy issues for on-target execution.
  • Adding support mv2 from examples/models (torchvision mv2)
  • Adds ability to use portable Q/DQ ops to enable float signature quantized models (to be improved with int signature when possible to enable integer images rather than int -> float -> quant flow.
  • Adds permute for ethos-u backend to enable NCHW to NHWC (which we'll aim to replace with a compiler pass on entry/exit of the subgraph, or the NHWC support when available.
  • small fix to enable qantized ops in runtime for the IOQDQ pass, and build/register those kernels/ops in bare metal build

@pytorch-bot

pytorch-botBot commented Apr 16, 2024•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3056

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6f4ce19 with merge base cc12d9b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2024
@robell
robell requested a review from digantdesaiApril 16, 2024 11:54
@robellrobell self-assigned this Apr 16, 2024
@robellrobell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Apr 16, 2024
@robellrobell changed the title Add support of mv2 in arm baremetal runnerAdd support for MobileNet v2 in Ethos-U55 and arm baremetal runnerApr 16, 2024
digantdesai
digantdesai approved these changes Apr 16, 2024
View reviewed changes

@digantdesaidigantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks @robell.

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_partitioner.py
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadexamples/arm/run.sh
@facebook-github-bot

facebook-github-bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot

facebook-github-bot commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robell
robellforce-pushed the mv2_rebase2 branch 3 times, most recently from f346e0f to c2442c4CompareApril 23, 2024 17:33
@digantdesai

digantdesai commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Sigh.. can you rebase please?

@robell
robellforce-pushed the mv2_rebase2 branch 5 times, most recently from 5996cbf to 0790d93CompareApril 26, 2024 10:23
@facebook-github-bot

facebook-github-bot commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot

facebook-github-bot commented May 1, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

robell added 8 commits May 2, 2024 08:51
@robell
Adding mn2 invocation to run.sh and use correct model section
77b5666
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add flag to register custom ops (like q/dq nodes) in aot_arm_compiler
c2c3544
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add pass to maintain IO quantization
1f28d1d
Currently only enabled in the aot_ compile flow as this requires
AoT kernel registration.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: I0c41b3a34613c900fc3f350f4f83b41378ac0add
@robell
Enable mv2 quantized to run on Corstone-300 * NOTE: this has accuracy…
4deed60
… issues until further fixes * enable further input types and layouts * add optional temp support for reordering NCHW * include portable quantized ops for IOQDQ fallback
Optional reordering will be removed once NHWC support is introduced.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: Iba2d4954fa14bc937584e59cb2ce82f4cdc1205d
@robell
Fix for ambiguous operator overload.
d100313
The templated function with this change has an ambigious overload, making it unambiguous by casting up to the templated type in this quantized function
@robell
lintfix
3d848fe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
documented permute and quantize_io compilespec properties
9b1a964
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
popping arm_partition metadata after use
fb4befe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
robell added 2 commits May 2, 2024 08:54
@robell
Refactor ArmBackend permute for readability
ebfd6ea
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add FVP option to increase ITCM
467c3a5
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Moving aot lib build to cmake
6f4ce19
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell

robell commented May 2, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@digantdesai or @mergennachin could we import this now, thanks to the fix in #3449 this now passes when rebased.

@robellrobell mentioned this pull request May 2, 2024
Closed
@facebook-github-bot

facebook-github-bot commented May 2, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented May 3, 2024

Copy link
Copy Markdown
Contributor

@digantdesai merged this pull request in 623f0e0.

@oscarandersson8218oscarandersson8218 mentioned this pull request Jul 3, 2024
Closed
@freddan80freddan80 mentioned this pull request Aug 15, 2024
Closed
@robell
robell deleted the mv2_rebase2 branch October 1, 2024 10:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees

@robellrobell

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner - #3056

Closed
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2
Closed

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner#3056
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2

Conversation

@robell

@robellrobell commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator
  • Builds on TOSA support for mv2
  • Currently has accuracy issues for on-target execution.
  • Adding support mv2 from examples/models (torchvision mv2)
  • Adds ability to use portable Q/DQ ops to enable float signature quantized models (to be improved with int signature when possible to enable integer images rather than int -> float -> quant flow.
  • Adds permute for ethos-u backend to enable NCHW to NHWC (which we'll aim to replace with a compiler pass on entry/exit of the subgraph, or the NHWC support when available.
  • small fix to enable qantized ops in runtime for the IOQDQ pass, and build/register those kernels/ops in bare metal build

@pytorch-bot

pytorch-botBot commented Apr 16, 2024•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3056

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6f4ce19 with merge base cc12d9b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2024
@robell
robell requested a review from digantdesaiApril 16, 2024 11:54
@robellrobell self-assigned this Apr 16, 2024
@robellrobell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Apr 16, 2024
@robellrobell changed the title Add support of mv2 in arm baremetal runnerAdd support for MobileNet v2 in Ethos-U55 and arm baremetal runnerApr 16, 2024
digantdesai
digantdesai approved these changes Apr 16, 2024
View reviewed changes

@digantdesaidigantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks @robell.

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_partitioner.py
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadexamples/arm/run.sh
@facebook-github-bot

facebook-github-bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot

facebook-github-bot commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robell
robellforce-pushed the mv2_rebase2 branch 3 times, most recently from f346e0f to c2442c4CompareApril 23, 2024 17:33
@digantdesai

digantdesai commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Sigh.. can you rebase please?

@robell
robellforce-pushed the mv2_rebase2 branch 5 times, most recently from 5996cbf to 0790d93CompareApril 26, 2024 10:23
@facebook-github-bot

facebook-github-bot commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot

facebook-github-bot commented May 1, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

robell added 8 commits May 2, 2024 08:51
@robell
Adding mn2 invocation to run.sh and use correct model section
77b5666
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add flag to register custom ops (like q/dq nodes) in aot_arm_compiler
c2c3544
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add pass to maintain IO quantization
1f28d1d
Currently only enabled in the aot_ compile flow as this requires
AoT kernel registration.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: I0c41b3a34613c900fc3f350f4f83b41378ac0add
@robell
Enable mv2 quantized to run on Corstone-300 * NOTE: this has accuracy…
4deed60
… issues until further fixes * enable further input types and layouts * add optional temp support for reordering NCHW * include portable quantized ops for IOQDQ fallback
Optional reordering will be removed once NHWC support is introduced.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: Iba2d4954fa14bc937584e59cb2ce82f4cdc1205d
@robell
Fix for ambiguous operator overload.
d100313
The templated function with this change has an ambigious overload, making it unambiguous by casting up to the templated type in this quantized function
@robell
lintfix
3d848fe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
documented permute and quantize_io compilespec properties
9b1a964
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
popping arm_partition metadata after use
fb4befe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
robell added 2 commits May 2, 2024 08:54
@robell
Refactor ArmBackend permute for readability
ebfd6ea
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add FVP option to increase ITCM
467c3a5
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Moving aot lib build to cmake
6f4ce19
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell

robell commented May 2, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@digantdesai or @mergennachin could we import this now, thanks to the fix in #3449 this now passes when rebased.

@robellrobell mentioned this pull request May 2, 2024
Closed
@facebook-github-bot

facebook-github-bot commented May 2, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented May 3, 2024

Copy link
Copy Markdown
Contributor

@digantdesai merged this pull request in 623f0e0.

@oscarandersson8218oscarandersson8218 mentioned this pull request Jul 3, 2024
Closed
@freddan80freddan80 mentioned this pull request Aug 15, 2024
Closed
@robell
robell deleted the mv2_rebase2 branch October 1, 2024 10:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees

@robellrobell

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner - #3056

Closed
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2
Closed

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner#3056
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2

Conversation

@robell

@robellrobell commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator
  • Builds on TOSA support for mv2
  • Currently has accuracy issues for on-target execution.
  • Adding support mv2 from examples/models (torchvision mv2)
  • Adds ability to use portable Q/DQ ops to enable float signature quantized models (to be improved with int signature when possible to enable integer images rather than int -> float -> quant flow.
  • Adds permute for ethos-u backend to enable NCHW to NHWC (which we'll aim to replace with a compiler pass on entry/exit of the subgraph, or the NHWC support when available.
  • small fix to enable qantized ops in runtime for the IOQDQ pass, and build/register those kernels/ops in bare metal build

@pytorch-bot

pytorch-botBot commented Apr 16, 2024•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3056

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6f4ce19 with merge base cc12d9b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2024
@robell
robell requested a review from digantdesaiApril 16, 2024 11:54
@robellrobell self-assigned this Apr 16, 2024
@robellrobell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Apr 16, 2024
@robellrobell changed the title Add support of mv2 in arm baremetal runnerAdd support for MobileNet v2 in Ethos-U55 and arm baremetal runnerApr 16, 2024
digantdesai
digantdesai approved these changes Apr 16, 2024
View reviewed changes

@digantdesaidigantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks @robell.

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_partitioner.py
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadexamples/arm/run.sh
@facebook-github-bot

facebook-github-bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot

facebook-github-bot commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robell
robellforce-pushed the mv2_rebase2 branch 3 times, most recently from f346e0f to c2442c4CompareApril 23, 2024 17:33
@digantdesai

digantdesai commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Sigh.. can you rebase please?

@robell
robellforce-pushed the mv2_rebase2 branch 5 times, most recently from 5996cbf to 0790d93CompareApril 26, 2024 10:23
@facebook-github-bot

facebook-github-bot commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot

facebook-github-bot commented May 1, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

robell added 8 commits May 2, 2024 08:51
@robell
Adding mn2 invocation to run.sh and use correct model section
77b5666
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add flag to register custom ops (like q/dq nodes) in aot_arm_compiler
c2c3544
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add pass to maintain IO quantization
1f28d1d
Currently only enabled in the aot_ compile flow as this requires
AoT kernel registration.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: I0c41b3a34613c900fc3f350f4f83b41378ac0add
@robell
Enable mv2 quantized to run on Corstone-300 * NOTE: this has accuracy…
4deed60
… issues until further fixes * enable further input types and layouts * add optional temp support for reordering NCHW * include portable quantized ops for IOQDQ fallback
Optional reordering will be removed once NHWC support is introduced.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: Iba2d4954fa14bc937584e59cb2ce82f4cdc1205d
@robell
Fix for ambiguous operator overload.
d100313
The templated function with this change has an ambigious overload, making it unambiguous by casting up to the templated type in this quantized function
@robell
lintfix
3d848fe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
documented permute and quantize_io compilespec properties
9b1a964
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
popping arm_partition metadata after use
fb4befe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
robell added 2 commits May 2, 2024 08:54
@robell
Refactor ArmBackend permute for readability
ebfd6ea
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add FVP option to increase ITCM
467c3a5
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Moving aot lib build to cmake
6f4ce19
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell

robell commented May 2, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@digantdesai or @mergennachin could we import this now, thanks to the fix in #3449 this now passes when rebased.

@robellrobell mentioned this pull request May 2, 2024
Closed
@facebook-github-bot

facebook-github-bot commented May 2, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented May 3, 2024

Copy link
Copy Markdown
Contributor

@digantdesai merged this pull request in 623f0e0.

@oscarandersson8218oscarandersson8218 mentioned this pull request Jul 3, 2024
Closed
@freddan80freddan80 mentioned this pull request Aug 15, 2024
Closed
@robell
robell deleted the mv2_rebase2 branch October 1, 2024 10:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees

@robellrobell

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner - #3056

Closed
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2
Closed

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner#3056
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2

Conversation

@robell

@robellrobell commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator
  • Builds on TOSA support for mv2
  • Currently has accuracy issues for on-target execution.
  • Adding support mv2 from examples/models (torchvision mv2)
  • Adds ability to use portable Q/DQ ops to enable float signature quantized models (to be improved with int signature when possible to enable integer images rather than int -> float -> quant flow.
  • Adds permute for ethos-u backend to enable NCHW to NHWC (which we'll aim to replace with a compiler pass on entry/exit of the subgraph, or the NHWC support when available.
  • small fix to enable qantized ops in runtime for the IOQDQ pass, and build/register those kernels/ops in bare metal build

@pytorch-bot

pytorch-botBot commented Apr 16, 2024•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3056

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6f4ce19 with merge base cc12d9b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2024
@robell
robell requested a review from digantdesaiApril 16, 2024 11:54
@robellrobell self-assigned this Apr 16, 2024
@robellrobell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Apr 16, 2024
@robellrobell changed the title Add support of mv2 in arm baremetal runnerAdd support for MobileNet v2 in Ethos-U55 and arm baremetal runnerApr 16, 2024
digantdesai
digantdesai approved these changes Apr 16, 2024
View reviewed changes

@digantdesaidigantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks @robell.

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_partitioner.py
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadexamples/arm/run.sh
@facebook-github-bot

facebook-github-bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot

facebook-github-bot commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robell
robellforce-pushed the mv2_rebase2 branch 3 times, most recently from f346e0f to c2442c4CompareApril 23, 2024 17:33
@digantdesai

digantdesai commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Sigh.. can you rebase please?

@robell
robellforce-pushed the mv2_rebase2 branch 5 times, most recently from 5996cbf to 0790d93CompareApril 26, 2024 10:23
@facebook-github-bot

facebook-github-bot commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot

facebook-github-bot commented May 1, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

robell added 8 commits May 2, 2024 08:51
@robell
Adding mn2 invocation to run.sh and use correct model section
77b5666
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add flag to register custom ops (like q/dq nodes) in aot_arm_compiler
c2c3544
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add pass to maintain IO quantization
1f28d1d
Currently only enabled in the aot_ compile flow as this requires
AoT kernel registration.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: I0c41b3a34613c900fc3f350f4f83b41378ac0add
@robell
Enable mv2 quantized to run on Corstone-300 * NOTE: this has accuracy…
4deed60
… issues until further fixes * enable further input types and layouts * add optional temp support for reordering NCHW * include portable quantized ops for IOQDQ fallback
Optional reordering will be removed once NHWC support is introduced.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: Iba2d4954fa14bc937584e59cb2ce82f4cdc1205d
@robell
Fix for ambiguous operator overload.
d100313
The templated function with this change has an ambigious overload, making it unambiguous by casting up to the templated type in this quantized function
@robell
lintfix
3d848fe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
documented permute and quantize_io compilespec properties
9b1a964
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
popping arm_partition metadata after use
fb4befe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
robell added 2 commits May 2, 2024 08:54
@robell
Refactor ArmBackend permute for readability
ebfd6ea
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add FVP option to increase ITCM
467c3a5
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Moving aot lib build to cmake
6f4ce19
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell

robell commented May 2, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@digantdesai or @mergennachin could we import this now, thanks to the fix in #3449 this now passes when rebased.

@robellrobell mentioned this pull request May 2, 2024
Closed
@facebook-github-bot

facebook-github-bot commented May 2, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented May 3, 2024

Copy link
Copy Markdown
Contributor

@digantdesai merged this pull request in 623f0e0.

@oscarandersson8218oscarandersson8218 mentioned this pull request Jul 3, 2024
Closed
@freddan80freddan80 mentioned this pull request Aug 15, 2024
Closed
@robell
robell deleted the mv2_rebase2 branch October 1, 2024 10:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees

@robellrobell

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner - #3056

Closed
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2
Closed

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner#3056
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2

Conversation

@robell

@robellrobell commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator
  • Builds on TOSA support for mv2
  • Currently has accuracy issues for on-target execution.
  • Adding support mv2 from examples/models (torchvision mv2)
  • Adds ability to use portable Q/DQ ops to enable float signature quantized models (to be improved with int signature when possible to enable integer images rather than int -> float -> quant flow.
  • Adds permute for ethos-u backend to enable NCHW to NHWC (which we'll aim to replace with a compiler pass on entry/exit of the subgraph, or the NHWC support when available.
  • small fix to enable qantized ops in runtime for the IOQDQ pass, and build/register those kernels/ops in bare metal build

@pytorch-bot

pytorch-botBot commented Apr 16, 2024•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3056

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6f4ce19 with merge base cc12d9b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2024
@robell
robell requested a review from digantdesaiApril 16, 2024 11:54
@robellrobell self-assigned this Apr 16, 2024
@robellrobell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Apr 16, 2024
@robellrobell changed the title Add support of mv2 in arm baremetal runnerAdd support for MobileNet v2 in Ethos-U55 and arm baremetal runnerApr 16, 2024
digantdesai
digantdesai approved these changes Apr 16, 2024
View reviewed changes

@digantdesaidigantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks @robell.

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_partitioner.py
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadexamples/arm/run.sh
@facebook-github-bot

facebook-github-bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot

facebook-github-bot commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robell
robellforce-pushed the mv2_rebase2 branch 3 times, most recently from f346e0f to c2442c4CompareApril 23, 2024 17:33
@digantdesai

digantdesai commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Sigh.. can you rebase please?

@robell
robellforce-pushed the mv2_rebase2 branch 5 times, most recently from 5996cbf to 0790d93CompareApril 26, 2024 10:23
@facebook-github-bot

facebook-github-bot commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot

facebook-github-bot commented May 1, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

robell added 8 commits May 2, 2024 08:51
@robell
Adding mn2 invocation to run.sh and use correct model section
77b5666
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add flag to register custom ops (like q/dq nodes) in aot_arm_compiler
c2c3544
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add pass to maintain IO quantization
1f28d1d
Currently only enabled in the aot_ compile flow as this requires
AoT kernel registration.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: I0c41b3a34613c900fc3f350f4f83b41378ac0add
@robell
Enable mv2 quantized to run on Corstone-300 * NOTE: this has accuracy…
4deed60
… issues until further fixes * enable further input types and layouts * add optional temp support for reordering NCHW * include portable quantized ops for IOQDQ fallback
Optional reordering will be removed once NHWC support is introduced.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: Iba2d4954fa14bc937584e59cb2ce82f4cdc1205d
@robell
Fix for ambiguous operator overload.
d100313
The templated function with this change has an ambigious overload, making it unambiguous by casting up to the templated type in this quantized function
@robell
lintfix
3d848fe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
documented permute and quantize_io compilespec properties
9b1a964
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
popping arm_partition metadata after use
fb4befe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
robell added 2 commits May 2, 2024 08:54
@robell
Refactor ArmBackend permute for readability
ebfd6ea
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add FVP option to increase ITCM
467c3a5
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Moving aot lib build to cmake
6f4ce19
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell

robell commented May 2, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@digantdesai or @mergennachin could we import this now, thanks to the fix in #3449 this now passes when rebased.

@robellrobell mentioned this pull request May 2, 2024
Closed
@facebook-github-bot

facebook-github-bot commented May 2, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented May 3, 2024

Copy link
Copy Markdown
Contributor

@digantdesai merged this pull request in 623f0e0.

@oscarandersson8218oscarandersson8218 mentioned this pull request Jul 3, 2024
Closed
@freddan80freddan80 mentioned this pull request Aug 15, 2024
Closed
@robell
robell deleted the mv2_rebase2 branch October 1, 2024 10:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees

@robellrobell

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner - #3056

Closed
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2
Closed

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner#3056
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2

Conversation

@robell

@robellrobell commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator
  • Builds on TOSA support for mv2
  • Currently has accuracy issues for on-target execution.
  • Adding support mv2 from examples/models (torchvision mv2)
  • Adds ability to use portable Q/DQ ops to enable float signature quantized models (to be improved with int signature when possible to enable integer images rather than int -> float -> quant flow.
  • Adds permute for ethos-u backend to enable NCHW to NHWC (which we'll aim to replace with a compiler pass on entry/exit of the subgraph, or the NHWC support when available.
  • small fix to enable qantized ops in runtime for the IOQDQ pass, and build/register those kernels/ops in bare metal build

@pytorch-bot

pytorch-botBot commented Apr 16, 2024•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3056

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6f4ce19 with merge base cc12d9b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2024
@robell
robell requested a review from digantdesaiApril 16, 2024 11:54
@robellrobell self-assigned this Apr 16, 2024
@robellrobell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Apr 16, 2024
@robellrobell changed the title Add support of mv2 in arm baremetal runnerAdd support for MobileNet v2 in Ethos-U55 and arm baremetal runnerApr 16, 2024
digantdesai
digantdesai approved these changes Apr 16, 2024
View reviewed changes

@digantdesaidigantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks @robell.

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_partitioner.py
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadexamples/arm/run.sh
@facebook-github-bot

facebook-github-bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot

facebook-github-bot commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robell
robellforce-pushed the mv2_rebase2 branch 3 times, most recently from f346e0f to c2442c4CompareApril 23, 2024 17:33
@digantdesai

digantdesai commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Sigh.. can you rebase please?

@robell
robellforce-pushed the mv2_rebase2 branch 5 times, most recently from 5996cbf to 0790d93CompareApril 26, 2024 10:23
@facebook-github-bot

facebook-github-bot commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot

facebook-github-bot commented May 1, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

robell added 8 commits May 2, 2024 08:51
@robell
Adding mn2 invocation to run.sh and use correct model section
77b5666
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add flag to register custom ops (like q/dq nodes) in aot_arm_compiler
c2c3544
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add pass to maintain IO quantization
1f28d1d
Currently only enabled in the aot_ compile flow as this requires
AoT kernel registration.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: I0c41b3a34613c900fc3f350f4f83b41378ac0add
@robell
Enable mv2 quantized to run on Corstone-300 * NOTE: this has accuracy…
4deed60
… issues until further fixes * enable further input types and layouts * add optional temp support for reordering NCHW * include portable quantized ops for IOQDQ fallback
Optional reordering will be removed once NHWC support is introduced.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: Iba2d4954fa14bc937584e59cb2ce82f4cdc1205d
@robell
Fix for ambiguous operator overload.
d100313
The templated function with this change has an ambigious overload, making it unambiguous by casting up to the templated type in this quantized function
@robell
lintfix
3d848fe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
documented permute and quantize_io compilespec properties
9b1a964
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
popping arm_partition metadata after use
fb4befe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
robell added 2 commits May 2, 2024 08:54
@robell
Refactor ArmBackend permute for readability
ebfd6ea
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add FVP option to increase ITCM
467c3a5
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Moving aot lib build to cmake
6f4ce19
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell

robell commented May 2, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@digantdesai or @mergennachin could we import this now, thanks to the fix in #3449 this now passes when rebased.

@robellrobell mentioned this pull request May 2, 2024
Closed
@facebook-github-bot

facebook-github-bot commented May 2, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented May 3, 2024

Copy link
Copy Markdown
Contributor

@digantdesai merged this pull request in 623f0e0.

@oscarandersson8218oscarandersson8218 mentioned this pull request Jul 3, 2024
Closed
@freddan80freddan80 mentioned this pull request Aug 15, 2024
Closed
@robell
robell deleted the mv2_rebase2 branch October 1, 2024 10:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees

@robellrobell

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner - #3056

Closed
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2
Closed

Add support for MobileNet v2 in Ethos-U55 and arm baremetal runner#3056
robell wants to merge 11 commits into
pytorch:mainfrom
robell:mv2_rebase2

Conversation

@robell

@robellrobell commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator
  • Builds on TOSA support for mv2
  • Currently has accuracy issues for on-target execution.
  • Adding support mv2 from examples/models (torchvision mv2)
  • Adds ability to use portable Q/DQ ops to enable float signature quantized models (to be improved with int signature when possible to enable integer images rather than int -> float -> quant flow.
  • Adds permute for ethos-u backend to enable NCHW to NHWC (which we'll aim to replace with a compiler pass on entry/exit of the subgraph, or the NHWC support when available.
  • small fix to enable qantized ops in runtime for the IOQDQ pass, and build/register those kernels/ops in bare metal build

@pytorch-bot

pytorch-botBot commented Apr 16, 2024•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3056

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6f4ce19 with merge base cc12d9b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2024
@robell
robell requested a review from digantdesaiApril 16, 2024 11:54
@robellrobell self-assigned this Apr 16, 2024
@robellrobell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Apr 16, 2024
@robellrobell changed the title Add support of mv2 in arm baremetal runnerAdd support for MobileNet v2 in Ethos-U55 and arm baremetal runnerApr 16, 2024
digantdesai
digantdesai approved these changes Apr 16, 2024
View reviewed changes

@digantdesaidigantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks @robell.

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_partitioner.py
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadexamples/arm/run.sh
@facebook-github-bot

facebook-github-bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot

facebook-github-bot commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robell
robellforce-pushed the mv2_rebase2 branch 3 times, most recently from f346e0f to c2442c4CompareApril 23, 2024 17:33
@digantdesai

digantdesai commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Sigh.. can you rebase please?

@robell
robellforce-pushed the mv2_rebase2 branch 5 times, most recently from 5996cbf to 0790d93CompareApril 26, 2024 10:23
@facebook-github-bot

facebook-github-bot commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot

facebook-github-bot commented May 1, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

robell added 8 commits May 2, 2024 08:51
@robell
Adding mn2 invocation to run.sh and use correct model section
77b5666
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add flag to register custom ops (like q/dq nodes) in aot_arm_compiler
c2c3544
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add pass to maintain IO quantization
1f28d1d
Currently only enabled in the aot_ compile flow as this requires
AoT kernel registration.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: I0c41b3a34613c900fc3f350f4f83b41378ac0add
@robell
Enable mv2 quantized to run on Corstone-300 * NOTE: this has accuracy…
4deed60
… issues until further fixes * enable further input types and layouts * add optional temp support for reordering NCHW * include portable quantized ops for IOQDQ fallback
Optional reordering will be removed once NHWC support is introduced.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: Iba2d4954fa14bc937584e59cb2ce82f4cdc1205d
@robell
Fix for ambiguous operator overload.
d100313
The templated function with this change has an ambigious overload, making it unambiguous by casting up to the templated type in this quantized function
@robell
lintfix
3d848fe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
documented permute and quantize_io compilespec properties
9b1a964
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
popping arm_partition metadata after use
fb4befe
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
robell added 2 commits May 2, 2024 08:54
@robell
Refactor ArmBackend permute for readability
ebfd6ea
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add FVP option to increase ITCM
467c3a5
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Moving aot lib build to cmake
6f4ce19
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell

robell commented May 2, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@digantdesai or @mergennachin could we import this now, thanks to the fix in #3449 this now passes when rebased.

@robellrobell mentioned this pull request May 2, 2024
Closed
@facebook-github-bot

facebook-github-bot commented May 2, 2024

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented May 3, 2024

Copy link
Copy Markdown
Contributor

@digantdesai merged this pull request in 623f0e0.

@oscarandersson8218oscarandersson8218 mentioned this pull request Jul 3, 2024
Closed
@freddan80freddan80 mentioned this pull request Aug 15, 2024
Closed
@robell
robell deleted the mv2_rebase2 branch October 1, 2024 10:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees

@robellrobell

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai