Uh oh!
There was an error while loading. Please reload this page.
Break flag bc - #3128
Closed
mcr229 wants to merge 1 commit into
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3128
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0a79fd1 with merge base fff20a7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
commented
Apr 18, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D56271242 |
facebook-github-bot
commented
May 8, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D56271242 |
mcr229 added a commit
to mcr229/executorch
that referenced
this pull request
May 8, 2024
Summary: Pull Request resolved: pytorch#3128 XNNPACK broke Backwards Compatibility by forcing pooling operations to reduce dims, and introducing a flag to allow these operation to keep the dims. This is backwards breaking because previously XNNPACK would not keep the dims if no flag was given, now a flag must be specified to keep the dims. While initially we proposed the inverse to maintain backwards compatibility, they have encountered breakages and have decided to commit to this breakage. As we are a downstream dependency, and will have to accept this breakages ourselves, it is important that we break early before this is used in any production code. As a result we break BC Here by accepting XNNPACK's change. ``` git diff roll_back_commit > rollback.patch cd fbsource/fbcode/xplat/third-party/XNNPACK/XNNPACK git apply ../../../../../../rollback.patch ``` We have to update the change in ExecuTorch, as a result we change the XNNPACK dep we are pointing to the branch containing these changes here: https://github.com/digantdesai/XNNPACK/commits/et_v21/ Reviewed By: digantdesai Differential Revision: D56271242
facebook-github-bot
commented
May 9, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D56271242 |
mcr229 added a commit
to mcr229/executorch
that referenced
this pull request
May 9, 2024
Summary: Pull Request resolved: pytorch#3128 XNNPACK broke Backwards Compatibility by forcing pooling operations to reduce dims, and introducing a flag to allow these operation to keep the dims. This is backwards breaking because previously XNNPACK would not keep the dims if no flag was given, now a flag must be specified to keep the dims. While initially we proposed the inverse to maintain backwards compatibility, they have encountered breakages and have decided to commit to this breakage. As we are a downstream dependency, and will have to accept this breakages ourselves, it is important that we break early before this is used in any production code. As a result we break BC Here by accepting XNNPACK's change. ``` git diff roll_back_commit > rollback.patch cd fbsource/fbcode/xplat/third-party/XNNPACK/XNNPACK git apply ../../../../../../rollback.patch ``` We have to update the change in ExecuTorch, as a result we change the XNNPACK dep we are pointing to the branch containing these changes here: https://github.com/digantdesai/XNNPACK/commits/et_v21/ Reviewed By: digantdesai Differential Revision: D56271242
Summary: Pull Request resolved: pytorch#3128 XNNPACK broke Backwards Compatibility by forcing pooling operations to reduce dims, and introducing a flag to allow these operation to keep the dims. This is backwards breaking because previously XNNPACK would not keep the dims if no flag was given, now a flag must be specified to keep the dims. While initially we proposed the inverse to maintain backwards compatibility, they have encountered breakages and have decided to commit to this breakage. As we are a downstream dependency, and will have to accept this breakages ourselves, it is important that we break early before this is used in any production code. As a result we break BC Here by accepting XNNPACK's change. ``` git diff roll_back_commit > rollback.patch cd fbsource/fbcode/xplat/third-party/XNNPACK/XNNPACK git apply ../../../../../../rollback.patch ``` We have to update the change in ExecuTorch, as a result we change the XNNPACK dep we are pointing to the branch containing these changes here: https://github.com/digantdesai/XNNPACK/commits/et_v21/ Reviewed By: digantdesai Differential Revision: D56271242
facebook-github-bot
commented
May 9, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D56271242 |
digantdesai
approved these changes
May 9, 2024
facebook-github-bot
commented
May 9, 2024
Contributor
This pull request has been merged in 6c56122. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
XNNPACK broke Backwards Compatibility by forcing pooling operations to reduce dims, and introducing a flag to allow these operation to keep the dims.
This is backwards breaking because previously XNNPACK would not keep the dims if no flag was given, now a flag must be specified to keep the dims. While initially we proposed the inverse to maintain backwards compatibility, they have encountered breakages and have decided to commit to this breakage. As we are a downstream dependency, and will have to accept this breakages ourselves, it is important that we break early before this is used in any production code.
As a result we break BC Here by accepting XNNPACK's change.
Differential Revision: D56271242