Uh oh!
There was an error while loading. Please reload this page.
[executorch] Take Tensor for start_pos in llama custom SDPA - #3580
Closed
swolchok wants to merge 1 commit into
Closed
[executorch] Take Tensor for start_pos in llama custom SDPA#3580swolchok wants to merge 1 commit into
swolchok wants to merge 1 commit into
Conversation
Several different runtimes don't seem to like the custom SDPA taking a single scalar pulled from a Tensor as an argument: - dynamo doesn't support item() - CoreML doesn't seem to like this either So, just take a Tensor. Differential Revision: [D57233278](https://our.internmc.facebook.com/intern/diff/D57233278/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3580
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9ea21d0 with merge base dd81fc7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok added a commit
that referenced
this pull request
May 10, 2024
Several different runtimes don't seem to like the custom SDPA taking a single scalar pulled from a Tensor as an argument: - dynamo doesn't support item() - CoreML doesn't seem to like this either So, just take a Tensor. Differential Revision: [D57233278](https://our.internmc.facebook.com/intern/diff/D57233278/) ghstack-source-id: 225980366 Pull Request resolved: #3580
facebook-github-bot
commented
May 10, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D57233278 |
JacobSzwejbka
approved these changes
May 13, 2024
swolchok
commented
May 13, 2024
ContributorAuthor
I found out we shouldn't be using the custom SDPA op for CoreML, so we don't have "several" runtimes that want this. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Several different runtimes don't seem to like the custom SDPA taking a single scalar pulled from a Tensor as an argument:
So, just take a Tensor.
Differential Revision: D57233278