Updating cadence ops with new name space, rebasing 6 optimized ops by dijopaul · Pull Request #6407 · pytorch/executorch

dijopaul · 2024-10-21T19:29:03Z

Adding 'cadence' name space in all ops
Rebasing all ops add,sub,div,mul,sigmoid,tanh as there are major merge conflicts
The ops are already reviewed under Added HiFi optimizations for add sub mul and div operators #5483

* Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Incorporated feedback from Meta team. * lint errors fixed * Adding Sub operator optimized version * Add optimization for add, mul operators * Adding Div operator * Modified div mod to cover truncate and floor modes --------- Co-authored-by: cad-audio <86048415+cad-audio@users.noreply.github.com> Co-authored-by: cad-audio <cad_audio_tflm@cadence.com>

Adding add sub mul and div optimizations

Adding sigmoid and tanh optimizations

Fixing review comments in 5483

Namespace update as per review comments

Adding cflags to prevent compilation halts

pytorch-bot · 2024-10-21T19:29:08Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6407

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a1340f7 with merge base 324f021 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mcremon-meta · 2024-10-22T03:47:59Z

 kernels:
 - arg_meta: null
- kernel_name: torch::executor::add_out
+ kernel_name: impl::HiFi::add_out


probably should be cadence::impl::HiFi too, but we can do that in a follow up if this can be merged

I will create a new PR for this

…d ops (#6407)" This reverts commit 979708d. Broke internal tests

#6482) Revert "Updating cadence ops with new name space, rebasing 6 optimized ops (#6407)" This reverts commit 979708d. Broke internal tests

kirklandsign · 2024-10-24T02:48:08Z

Hi @dijopaul sorry I reverted this because it seems to break our internal CI. Maybe we need to import to internal repo first and run CI there

kirklandsign · 2024-10-24T07:02:44Z

xplat/executorch/backends/cadence/hifi/operators/op_tanh.cpp:10:10: fatal error: 'executorch/kernels/portable/cpu/pattern/pattern.h' file not found
#include <executorch/kernels/portable/cpu/pattern/pattern.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

kirklandsign · 2024-10-24T07:02:51Z

@mcremon-meta need to update BUCK

zonglinpeng · 2024-10-24T16:12:05Z

@kirklandsign #6477 the fix is landing internally. thanks for the heads up. cc. @mcremon-meta

dijopaul · 2024-10-21T19:29:03Z

Adding 'cadence' name space in all ops
Rebasing all ops add,sub,div,mul,sigmoid,tanh as there are major merge conflicts
The ops are already reviewed under Added HiFi optimizations for add sub mul and div operators #5483

* Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Incorporated feedback from Meta team. * lint errors fixed * Adding Sub operator optimized version * Add optimization for add, mul operators * Adding Div operator * Modified div mod to cover truncate and floor modes --------- Co-authored-by: cad-audio <86048415+cad-audio@users.noreply.github.com> Co-authored-by: cad-audio <cad_audio_tflm@cadence.com>

Adding add sub mul and div optimizations

Adding sigmoid and tanh optimizations

Fixing review comments in 5483

Namespace update as per review comments

Adding cflags to prevent compilation halts

pytorch-bot · 2024-10-21T19:29:08Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6407

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a1340f7 with merge base 324f021 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mcremon-meta · 2024-10-22T03:47:59Z

 kernels:
 - arg_meta: null
- kernel_name: torch::executor::add_out
+ kernel_name: impl::HiFi::add_out


probably should be cadence::impl::HiFi too, but we can do that in a follow up if this can be merged

I will create a new PR for this

…d ops (#6407)" This reverts commit 979708d. Broke internal tests

#6482) Revert "Updating cadence ops with new name space, rebasing 6 optimized ops (#6407)" This reverts commit 979708d. Broke internal tests

kirklandsign · 2024-10-24T02:48:08Z

Hi @dijopaul sorry I reverted this because it seems to break our internal CI. Maybe we need to import to internal repo first and run CI there

kirklandsign · 2024-10-24T07:02:44Z

xplat/executorch/backends/cadence/hifi/operators/op_tanh.cpp:10:10: fatal error: 'executorch/kernels/portable/cpu/pattern/pattern.h' file not found
#include <executorch/kernels/portable/cpu/pattern/pattern.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

kirklandsign · 2024-10-24T07:02:51Z

@mcremon-meta need to update BUCK

zonglinpeng · 2024-10-24T16:12:05Z

@kirklandsign #6477 the fix is landing internally. thanks for the heads up. cc. @mcremon-meta

dijopaul · 2024-10-21T19:29:03Z

Adding 'cadence' name space in all ops
Rebasing all ops add,sub,div,mul,sigmoid,tanh as there are major merge conflicts
The ops are already reviewed under Added HiFi optimizations for add sub mul and div operators #5483

* Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Incorporated feedback from Meta team. * lint errors fixed * Adding Sub operator optimized version * Add optimization for add, mul operators * Adding Div operator * Modified div mod to cover truncate and floor modes --------- Co-authored-by: cad-audio <86048415+cad-audio@users.noreply.github.com> Co-authored-by: cad-audio <cad_audio_tflm@cadence.com>

Adding add sub mul and div optimizations

Adding sigmoid and tanh optimizations

Fixing review comments in 5483

Namespace update as per review comments

Adding cflags to prevent compilation halts

pytorch-bot · 2024-10-21T19:29:08Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6407

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a1340f7 with merge base 324f021 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mcremon-meta · 2024-10-22T03:47:59Z

 kernels:
 - arg_meta: null
- kernel_name: torch::executor::add_out
+ kernel_name: impl::HiFi::add_out


probably should be cadence::impl::HiFi too, but we can do that in a follow up if this can be merged

I will create a new PR for this

…d ops (#6407)" This reverts commit 979708d. Broke internal tests

#6482) Revert "Updating cadence ops with new name space, rebasing 6 optimized ops (#6407)" This reverts commit 979708d. Broke internal tests

kirklandsign · 2024-10-24T02:48:08Z

Hi @dijopaul sorry I reverted this because it seems to break our internal CI. Maybe we need to import to internal repo first and run CI there

kirklandsign · 2024-10-24T07:02:44Z

xplat/executorch/backends/cadence/hifi/operators/op_tanh.cpp:10:10: fatal error: 'executorch/kernels/portable/cpu/pattern/pattern.h' file not found
#include <executorch/kernels/portable/cpu/pattern/pattern.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

kirklandsign · 2024-10-24T07:02:51Z

@mcremon-meta need to update BUCK

zonglinpeng · 2024-10-24T16:12:05Z

@kirklandsign #6477 the fix is landing internally. thanks for the heads up. cc. @mcremon-meta

dijopaul · 2024-10-21T19:29:03Z

Adding 'cadence' name space in all ops
Rebasing all ops add,sub,div,mul,sigmoid,tanh as there are major merge conflicts
The ops are already reviewed under Added HiFi optimizations for add sub mul and div operators #5483

* Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Incorporated feedback from Meta team. * lint errors fixed * Adding Sub operator optimized version * Add optimization for add, mul operators * Adding Div operator * Modified div mod to cover truncate and floor modes --------- Co-authored-by: cad-audio <86048415+cad-audio@users.noreply.github.com> Co-authored-by: cad-audio <cad_audio_tflm@cadence.com>

Adding add sub mul and div optimizations

Adding sigmoid and tanh optimizations

Fixing review comments in 5483

Namespace update as per review comments

Adding cflags to prevent compilation halts

pytorch-bot · 2024-10-21T19:29:08Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6407

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a1340f7 with merge base 324f021 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mcremon-meta · 2024-10-22T03:47:59Z

 kernels:
 - arg_meta: null
- kernel_name: torch::executor::add_out
+ kernel_name: impl::HiFi::add_out


probably should be cadence::impl::HiFi too, but we can do that in a follow up if this can be merged

I will create a new PR for this

…d ops (#6407)" This reverts commit 979708d. Broke internal tests

#6482) Revert "Updating cadence ops with new name space, rebasing 6 optimized ops (#6407)" This reverts commit 979708d. Broke internal tests

kirklandsign · 2024-10-24T02:48:08Z

Hi @dijopaul sorry I reverted this because it seems to break our internal CI. Maybe we need to import to internal repo first and run CI there

kirklandsign · 2024-10-24T07:02:44Z

xplat/executorch/backends/cadence/hifi/operators/op_tanh.cpp:10:10: fatal error: 'executorch/kernels/portable/cpu/pattern/pattern.h' file not found
#include <executorch/kernels/portable/cpu/pattern/pattern.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

kirklandsign · 2024-10-24T07:02:51Z

@mcremon-meta need to update BUCK

zonglinpeng · 2024-10-24T16:12:05Z

@kirklandsign #6477 the fix is landing internally. thanks for the heads up. cc. @mcremon-meta

dijopaul · 2024-10-21T19:29:03Z

Adding 'cadence' name space in all ops
Rebasing all ops add,sub,div,mul,sigmoid,tanh as there are major merge conflicts
The ops are already reviewed under Added HiFi optimizations for add sub mul and div operators #5483

* Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Incorporated feedback from Meta team. * lint errors fixed * Adding Sub operator optimized version * Add optimization for add, mul operators * Adding Div operator * Modified div mod to cover truncate and floor modes --------- Co-authored-by: cad-audio <86048415+cad-audio@users.noreply.github.com> Co-authored-by: cad-audio <cad_audio_tflm@cadence.com>

Adding add sub mul and div optimizations

Adding sigmoid and tanh optimizations

Fixing review comments in 5483

Namespace update as per review comments

Adding cflags to prevent compilation halts

pytorch-bot · 2024-10-21T19:29:08Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6407

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a1340f7 with merge base 324f021 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mcremon-meta · 2024-10-22T03:47:59Z

 kernels:
 - arg_meta: null
- kernel_name: torch::executor::add_out
+ kernel_name: impl::HiFi::add_out


probably should be cadence::impl::HiFi too, but we can do that in a follow up if this can be merged

I will create a new PR for this

…d ops (#6407)" This reverts commit 979708d. Broke internal tests

#6482) Revert "Updating cadence ops with new name space, rebasing 6 optimized ops (#6407)" This reverts commit 979708d. Broke internal tests

kirklandsign · 2024-10-24T02:48:08Z

Hi @dijopaul sorry I reverted this because it seems to break our internal CI. Maybe we need to import to internal repo first and run CI there

kirklandsign · 2024-10-24T07:02:44Z

xplat/executorch/backends/cadence/hifi/operators/op_tanh.cpp:10:10: fatal error: 'executorch/kernels/portable/cpu/pattern/pattern.h' file not found
#include <executorch/kernels/portable/cpu/pattern/pattern.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

kirklandsign · 2024-10-24T07:02:51Z

@mcremon-meta need to update BUCK

zonglinpeng · 2024-10-24T16:12:05Z

@kirklandsign #6477 the fix is landing internally. thanks for the heads up. cc. @mcremon-meta

dijopaul · 2024-10-21T19:29:03Z

Adding 'cadence' name space in all ops
Rebasing all ops add,sub,div,mul,sigmoid,tanh as there are major merge conflicts
The ops are already reviewed under Added HiFi optimizations for add sub mul and div operators #5483

* Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Incorporated feedback from Meta team. * lint errors fixed * Adding Sub operator optimized version * Add optimization for add, mul operators * Adding Div operator * Modified div mod to cover truncate and floor modes --------- Co-authored-by: cad-audio <86048415+cad-audio@users.noreply.github.com> Co-authored-by: cad-audio <cad_audio_tflm@cadence.com>

Adding add sub mul and div optimizations

Adding sigmoid and tanh optimizations

Fixing review comments in 5483

Namespace update as per review comments

Adding cflags to prevent compilation halts

pytorch-bot · 2024-10-21T19:29:08Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6407

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a1340f7 with merge base 324f021 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mcremon-meta · 2024-10-22T03:47:59Z

 kernels:
 - arg_meta: null
- kernel_name: torch::executor::add_out
+ kernel_name: impl::HiFi::add_out


probably should be cadence::impl::HiFi too, but we can do that in a follow up if this can be merged

I will create a new PR for this

…d ops (#6407)" This reverts commit 979708d. Broke internal tests

#6482) Revert "Updating cadence ops with new name space, rebasing 6 optimized ops (#6407)" This reverts commit 979708d. Broke internal tests

kirklandsign · 2024-10-24T02:48:08Z

Hi @dijopaul sorry I reverted this because it seems to break our internal CI. Maybe we need to import to internal repo first and run CI there

kirklandsign · 2024-10-24T07:02:44Z

xplat/executorch/backends/cadence/hifi/operators/op_tanh.cpp:10:10: fatal error: 'executorch/kernels/portable/cpu/pattern/pattern.h' file not found
#include <executorch/kernels/portable/cpu/pattern/pattern.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

kirklandsign · 2024-10-24T07:02:51Z

@mcremon-meta need to update BUCK

zonglinpeng · 2024-10-24T16:12:05Z

@kirklandsign #6477 the fix is landing internally. thanks for the heads up. cc. @mcremon-meta

dijopaul · 2024-10-21T19:29:03Z

Adding 'cadence' name space in all ops
Rebasing all ops add,sub,div,mul,sigmoid,tanh as there are major merge conflicts
The ops are already reviewed under Added HiFi optimizations for add sub mul and div operators #5483

* Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Incorporated feedback from Meta team. * lint errors fixed * Adding Sub operator optimized version * Add optimization for add, mul operators * Adding Div operator * Modified div mod to cover truncate and floor modes --------- Co-authored-by: cad-audio <86048415+cad-audio@users.noreply.github.com> Co-authored-by: cad-audio <cad_audio_tflm@cadence.com>

Adding add sub mul and div optimizations

Adding sigmoid and tanh optimizations

Fixing review comments in 5483

Namespace update as per review comments

Adding cflags to prevent compilation halts

pytorch-bot · 2024-10-21T19:29:08Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6407

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a1340f7 with merge base 324f021 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mcremon-meta · 2024-10-22T03:47:59Z

 kernels:
 - arg_meta: null
- kernel_name: torch::executor::add_out
+ kernel_name: impl::HiFi::add_out


probably should be cadence::impl::HiFi too, but we can do that in a follow up if this can be merged

I will create a new PR for this

…d ops (#6407)" This reverts commit 979708d. Broke internal tests

#6482) Revert "Updating cadence ops with new name space, rebasing 6 optimized ops (#6407)" This reverts commit 979708d. Broke internal tests

kirklandsign · 2024-10-24T02:48:08Z

Hi @dijopaul sorry I reverted this because it seems to break our internal CI. Maybe we need to import to internal repo first and run CI there

kirklandsign · 2024-10-24T07:02:44Z

xplat/executorch/backends/cadence/hifi/operators/op_tanh.cpp:10:10: fatal error: 'executorch/kernels/portable/cpu/pattern/pattern.h' file not found
#include <executorch/kernels/portable/cpu/pattern/pattern.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

kirklandsign · 2024-10-24T07:02:51Z

@mcremon-meta need to update BUCK

zonglinpeng · 2024-10-24T16:12:05Z

@kirklandsign #6477 the fix is landing internally. thanks for the heads up. cc. @mcremon-meta

dijopaul · 2024-10-21T19:29:03Z

Adding 'cadence' name space in all ops
Rebasing all ops add,sub,div,mul,sigmoid,tanh as there are major merge conflicts
The ops are already reviewed under Added HiFi optimizations for add sub mul and div operators #5483

* Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Incorporated feedback from Meta team. * lint errors fixed * Adding Sub operator optimized version * Add optimization for add, mul operators * Adding Div operator * Modified div mod to cover truncate and floor modes --------- Co-authored-by: cad-audio <86048415+cad-audio@users.noreply.github.com> Co-authored-by: cad-audio <cad_audio_tflm@cadence.com>

Adding add sub mul and div optimizations

Adding sigmoid and tanh optimizations

Fixing review comments in 5483

Namespace update as per review comments

Adding cflags to prevent compilation halts

pytorch-bot · 2024-10-21T19:29:08Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6407

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a1340f7 with merge base 324f021 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mcremon-meta · 2024-10-22T03:47:59Z

 kernels:
 - arg_meta: null
- kernel_name: torch::executor::add_out
+ kernel_name: impl::HiFi::add_out


probably should be cadence::impl::HiFi too, but we can do that in a follow up if this can be merged

I will create a new PR for this

…d ops (#6407)" This reverts commit 979708d. Broke internal tests

#6482) Revert "Updating cadence ops with new name space, rebasing 6 optimized ops (#6407)" This reverts commit 979708d. Broke internal tests

kirklandsign · 2024-10-24T02:48:08Z

Hi @dijopaul sorry I reverted this because it seems to break our internal CI. Maybe we need to import to internal repo first and run CI there

kirklandsign · 2024-10-24T07:02:44Z

xplat/executorch/backends/cadence/hifi/operators/op_tanh.cpp:10:10: fatal error: 'executorch/kernels/portable/cpu/pattern/pattern.h' file not found
#include <executorch/kernels/portable/cpu/pattern/pattern.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

kirklandsign · 2024-10-24T07:02:51Z

@mcremon-meta need to update BUCK

zonglinpeng · 2024-10-24T16:12:05Z

@kirklandsign #6477 the fix is landing internally. thanks for the heads up. cc. @mcremon-meta

dijopauland others added 17 commits September 19, 2024 12:20

Merge pull request#7from dijopaul/main
71d78a1
Adding add sub mul and div optimizations

Adding sigmoid optimizations
6ad490a

Adding tanh optimizations
c0b1005

Merge pull request#8from dijopaul/main
41d7533
Adding sigmoid and tanh optimizations

Fixing review comments in 5483
a8c4f66

Adding cflags to prevent compilation halts
99a772c

Merge pull request#9from dijopaul/main
8064895
Fixing review comments in 5483

Adding cflags to prevent compilation halts
9543622

Changing name space of optimized ops; Remove unused ops from file
d45e25d

Merge branch 'main' ofhttps://github.com/dijopaul/executorch
a3581f1

Merge pull request#11from dijopaul/main
fd955cf
Namespace update as per review comments

Merge pull request#10from dijopaul/main_cflags
5851fca
Adding cflags to prevent compilation halts

Merge branch 'main' into main
605f374

fixed lint issues.
4e89e2a

Merge branch 'main' into main
e9d9f6c

Namespace updates for cadence ops, adding 6 optimized ops
a1340f7

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2024

mcremon-meta approved these changes Oct 22, 2024
View reviewed changes

mcremon-meta merged commit 979708d into pytorch:mainOct 22, 2024

dijopaul mentioned this pull request Oct 22, 2024
Updating add operator with name space changes #6433
Merged

kirklandsign added a commit that referenced this pull request Oct 24, 2024
Revert "Updating cadence ops with new name space, rebasing 6 optimize…
f9238e3
…d ops (#6407)" This reverts commit 979708d. Broke internal tests

kirklandsign mentioned this pull request Oct 24, 2024
Revert "Updating cadence ops with new name space, rebasing 6 optimize… #6482
Merged