Initial framework of an ethos-u runtime backend #3 - #659

Closed
robell wants to merge 25 commits into
pytorch:mainfrom
robell:rebase_test
Closed

Initial framework of an ethos-u runtime backend #3#659
robell wants to merge 25 commits into
pytorch:mainfrom
robell:rebase_test

Conversation

@robell

@robellrobell commented Oct 6, 2023

Copy link
Copy Markdown
Collaborator

Cleaned up ethos-u runtime flow, replaces #595

Added shell of runtime Arm Backend for Ethos-U

./backends/arm/cmake/build.sh will pull the appropriate compiler and build the ethos-u driver and delegate and produce the libraries needed to link an application in, which can run a delegated .pte with the revised vela_bin_stream form contained in these patches.

Currently supports .pte files stored in SRAM.

robell added 18 commits October 6, 2023 07:46
@robell
Initial Ethos-U runtime backend
225c115
 - Basic runtime targeting Corstone-300 with U55
- cross compile support with a cmake toolchain (Arm baremetal build)
- support for a few models AoT -> TOSA -> Vela -> U55 hardware
- dependencies on the ethos-u core driver and cmsis (submodules)
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed error messages on runtime init
a7aa848
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintrunner cleanup
f95fead
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add ArmBackend to example scripts
524afc6
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add delegate test and FVP output
2bfdb5f
 * There is a toolchain/linking issue mixing hard and soft float ABI
which is causing the test to fail, but the structure is there and the
delegate is registered.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fix delegate runner patch
8267612
@robell
cmake compiler and log behaviour fixing
6b398fe
 * Override the default CPU in cmake which was causing a mixture of FPU
and ABI flags to be passed to different compilation stages.
* Updated fallback logging implementation in delegate app to fix
sporadic crash
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Minimal example of AoT with ArmPartitioner+Vela
6ca9b26
 * uses the simple_add model to run through the AoT flow and the various
debug options for looking at export.
* produces a .pte file for runtime delegation on the ArmBackend for
Ethos-U55 platforms
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Generate pte for delegate test on the fly
f40ab5f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Added support for variable input output patterns
d10d620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Handle multiple delegate inputs with SRAM offsets
b812898
 * export the list of offset from AoT floq
* appropriately copy inputs and ouputs to/from SRAM
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add TOSA ref model and Vela dependencies
44a46a1
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Cleanup from lintrunner and other bits of tidyup
cb16e68
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Removed ethos u driver build and cmsis dependency
8aa80d0
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
renamed lib ethos_u to executorch_delegate_ethos_u
3a5fd4f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
e676620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidied delegate_runner output
4b1125e
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed some merge issues
7afc5e4
 * File moved to new path in examples
* fix arg handling and md5sum for setup scripts
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@netlify

netlifyBot commented Oct 6, 2023•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for resplendent-gnome-14e531 canceled.

NameLink
🔨 Latest commit709a688
🔍 Latest deploy loghttps://app.netlify.com/sites/resplendent-gnome-14e531/deploys/652072de622f4c00082b4740

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2023
@robell
Test fixes for compiler output choice
e340b5c
 * Introduction of BI_INT to have a small set of pure int tests
* added either vela or tosa output from compilation
* Fixed tosa e2e tests to use tosa output form
* unit tests currently use tosa due to missing vela dependency
* vela e2e testing runs with default compile flags and emits to .pte
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robellrobell mentioned this pull request Oct 6, 2023
Closed
digantdesai
digantdesai reviewed Oct 6, 2023
View reviewed changes

@digantdesaidigantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know since you are waiting I am submitting these as I go. Just finished looked at the AoT python code. And next looking at the runtime bits.

Comment threadCMakeLists.txt
Comment threadbackends/arm/CMakeLists.txt Outdated
Comment threadbackends/arm/CMakeLists.txt
Comment threadbackends/arm/arm_backend.py Outdated
Comment threadbackends/arm/arm_backend.py Outdated
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py Outdated
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
robell
robell commented Oct 6, 2023
View reviewed changes
Comment threadbackends/arm/cmake/arm-none-eabi-gcc.cmake Outdated
@robell
review fixes
6b7a18a
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
digantdesai
digantdesai reviewed Oct 6, 2023
View reviewed changes

@digantdesaidigantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

round 2 for delegate runtime

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp Outdated
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
digantdesai
digantdesai reviewed Oct 6, 2023
View reviewed changes

@digantdesaidigantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is it. Not sure if I missed anything, I am not the biggest fan of this GH UI :\

Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_tosa.py
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh Outdated
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh Outdated
@robell
review feedback/improvements
c453e43
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidy up example scripts
1917b54
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@digantdesaidigantdesai mentioned this pull request Oct 6, 2023
Closed
digantdesai
digantdesai approved these changes Oct 6, 2023
View reviewed changes

@digantdesaidigantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks @robell - this was a difficult one.
Created Issue #666 as a follow up.

@robell
further review comments
20bf2eb
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
revised path for ethosu_minimal
468d6fc
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
709a688
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@facebook-github-bot

facebook-github-bot commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Jerry-GeJerry-Ge mentioned this pull request Oct 6, 2023
Closed
@tatwaichongtatwaichong mentioned this pull request Oct 6, 2023
Closed
digantdesai
digantdesai reviewed Oct 7, 2023
View reviewed changes
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp

#include <cstring>
#include <memory>
#include <vector>

@digantdesaidigantdesaiOct 7, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to see if we can get away without this std::container. It will be better from size and portability point of view. Other than input/output we aren't using it anywhere else so should be easy to get rid of it.

@digantdesaidigantdesaiOct 7, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#677 FYI

@digantdesaidigantdesai mentioned this pull request Oct 7, 2023
Closed
@facebook-github-bot

facebook-github-bot commented Oct 7, 2023

Copy link
Copy Markdown
Contributor

@digantdesai merged this pull request in 78197a3.

@robellrobell added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jul 4, 2024
Gasoonjia pushed a commit that referenced this pull request Jul 30, 2024
@mikekgfb@malfet
Update quantization.md (#659)
e9def32
Update support tables and explanatory text.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Initial framework of an ethos-u runtime backend #3 - #659
Closed
robell wants to merge 25 commits into
pytorch:mainfrom 
robell:rebase_test
Closed
Initial framework of an ethos-u runtime backend #3#659
robell wants to merge 25 commits into
pytorch:mainfrom 
robell:rebase_test
Conversation
@robell
@robellrobell
commented
Oct 6, 2023

Copy link


Copy Markdown

Collaborator
Cleaned up ethos-u runtime flow, replaces #595
Added shell of runtime Arm Backend for Ethos-U
./backends/arm/cmake/build.sh will pull the appropriate compiler and build the ethos-u driver and delegate and produce the libraries needed to link an application in, which can run a delegated .pte with the revised vela_bin_stream form contained in these patches.
Currently supports .pte files stored in SRAM.
robell
added 18 commits
October 6, 2023 07:46
@robell
Initial Ethos-U runtime backend
225c115
 - Basic runtime targeting Corstone-300 with U55
- cross compile support with a cmake toolchain (Arm baremetal build)
- support for a few models AoT -> TOSA -> Vela -> U55 hardware
- dependencies on the ethos-u core driver and cmsis (submodules)
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed error messages on runtime init
a7aa848
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintrunner cleanup
f95fead
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add ArmBackend to example scripts
524afc6
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add delegate test and FVP output
2bfdb5f
 * There is a toolchain/linking issue mixing hard and soft float ABI
which is causing the test to fail, but the structure is there and the
delegate is registered.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fix delegate runner patch
8267612
@robell
cmake compiler and log behaviour fixing
6b398fe
 * Override the default CPU in cmake which was causing a mixture of FPU
and ABI flags to be passed to different compilation stages.
* Updated fallback logging implementation in delegate app to fix
sporadic crash
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Minimal example of AoT with ArmPartitioner+Vela
6ca9b26
 * uses the simple_add model to run through the AoT flow and the various
debug options for looking at export.
* produces a .pte file for runtime delegation on the ArmBackend for
Ethos-U55 platforms
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Generate pte for delegate test on the fly
f40ab5f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Added support for variable input output patterns
d10d620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Handle multiple delegate inputs with SRAM offsets
b812898
 * export the list of offset from AoT floq
* appropriately copy inputs and ouputs to/from SRAM
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add TOSA ref model and Vela dependencies
44a46a1
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Cleanup from lintrunner and other bits of tidyup
cb16e68
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Removed ethos u driver build and cmsis dependency
8aa80d0
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
renamed lib ethos_u to executorch_delegate_ethos_u
3a5fd4f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
e676620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidied delegate_runner output
4b1125e
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed some merge issues
7afc5e4
 * File moved to new path in examples
* fix arg handling and md5sum for setup scripts
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@netlify
netlifyBot
commented
Oct 6, 2023•

edited

Loading

Copy link


Copy Markdown

✅ Deploy Preview for resplendent-gnome-14e531 canceled.
NameLink
🔨 Latest commit709a688
🔍 Latest deploy loghttps://app.netlify.com/sites/resplendent-gnome-14e531/deploys/652072de622f4c00082b4740
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 6, 2023
@robell
Test fixes for compiler output choice
e340b5c
 * Introduction of BI_INT to have a small set of pure int tests
* added either vela or tosa output from compilation
* Fixed tosa e2e tests to use tosa output form
* unit tests currently use tosa due to missing vela dependency
* vela e2e testing runs with default compile flags and emits to .pte
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robellrobell
mentioned this pull request
Oct 6, 2023
 Closed

digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know since you are waiting I am submitting these as I go. Just finished looked at the AoT python code. And next looking at the runtime bits.
Comment threadCMakeLists.txt
Comment threadbackends/arm/CMakeLists.txt
Outdated

Comment threadbackends/arm/CMakeLists.txt
Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
robell
robell
commented
Oct 6, 2023
View reviewed changes
Comment threadbackends/arm/cmake/arm-none-eabi-gcc.cmake
Outdated

@robell
review fixes
6b7a18a
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

round 2 for delegate runtime
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is it. Not sure if I missed anything, I am not the biggest fan of this GH UI :\
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_tosa.py
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Outdated

Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Outdated

@robell
review feedback/improvements
c453e43
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidy up example scripts
1917b54
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@digantdesaidigantdesai
mentioned this pull request
Oct 6, 2023

Closed

digantdesai
digantdesai
approved these changes
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks @robell - this was a difficult one.

Created Issue #666 as a follow up.
@robell
further review comments
20bf2eb
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
revised path for ethosu_minimal
468d6fc
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
709a688
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@facebook-github-bot
facebook-github-bot
commented
Oct 6, 2023

Copy link


Copy Markdown

Contributor
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@Jerry-GeJerry-Ge
mentioned this pull request
Oct 6, 2023
 Closed

@tatwaichongtatwaichong
mentioned this pull request
Oct 6, 2023
 Closed

digantdesai
digantdesai
reviewed
Oct 7, 2023
View reviewed changes
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp

#include <cstring>
#include <memory>
#include <vector>
@digantdesaidigantdesaiOct 7, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to see if we can get away without this std::container. It will be better from size and portability point of view. Other than input/output we aren't using it anywhere else so should be easy to get rid of it.
@digantdesaidigantdesaiOct 7, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#677 FYI
@digantdesaidigantdesai
mentioned this pull request
Oct 7, 2023

Closed

@facebook-github-bot
facebook-github-bot
commented
Oct 7, 2023

Copy link


Copy Markdown

Contributor
@digantdesai merged this pull request in 78197a3.
@robellrobell
added
the 
partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
label
Jul 4, 2024
Gasoonjia pushed a commit
that referenced
this pull request
Jul 30, 2024
@mikekgfb@malfet
Update quantization.md (#659)
e9def32
Update support tables and explanatory text.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Initial framework of an ethos-u runtime backend #3 - #659
Closed
robell wants to merge 25 commits into
pytorch:mainfrom 
robell:rebase_test
Closed
Initial framework of an ethos-u runtime backend #3#659
robell wants to merge 25 commits into
pytorch:mainfrom 
robell:rebase_test
Conversation
@robell
@robellrobell
commented
Oct 6, 2023

Copy link


Copy Markdown

Collaborator
Cleaned up ethos-u runtime flow, replaces #595
Added shell of runtime Arm Backend for Ethos-U
./backends/arm/cmake/build.sh will pull the appropriate compiler and build the ethos-u driver and delegate and produce the libraries needed to link an application in, which can run a delegated .pte with the revised vela_bin_stream form contained in these patches.
Currently supports .pte files stored in SRAM.
robell
added 18 commits
October 6, 2023 07:46
@robell
Initial Ethos-U runtime backend
225c115
 - Basic runtime targeting Corstone-300 with U55
- cross compile support with a cmake toolchain (Arm baremetal build)
- support for a few models AoT -> TOSA -> Vela -> U55 hardware
- dependencies on the ethos-u core driver and cmsis (submodules)
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed error messages on runtime init
a7aa848
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintrunner cleanup
f95fead
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add ArmBackend to example scripts
524afc6
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add delegate test and FVP output
2bfdb5f
 * There is a toolchain/linking issue mixing hard and soft float ABI
which is causing the test to fail, but the structure is there and the
delegate is registered.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fix delegate runner patch
8267612
@robell
cmake compiler and log behaviour fixing
6b398fe
 * Override the default CPU in cmake which was causing a mixture of FPU
and ABI flags to be passed to different compilation stages.
* Updated fallback logging implementation in delegate app to fix
sporadic crash
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Minimal example of AoT with ArmPartitioner+Vela
6ca9b26
 * uses the simple_add model to run through the AoT flow and the various
debug options for looking at export.
* produces a .pte file for runtime delegation on the ArmBackend for
Ethos-U55 platforms
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Generate pte for delegate test on the fly
f40ab5f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Added support for variable input output patterns
d10d620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Handle multiple delegate inputs with SRAM offsets
b812898
 * export the list of offset from AoT floq
* appropriately copy inputs and ouputs to/from SRAM
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add TOSA ref model and Vela dependencies
44a46a1
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Cleanup from lintrunner and other bits of tidyup
cb16e68
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Removed ethos u driver build and cmsis dependency
8aa80d0
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
renamed lib ethos_u to executorch_delegate_ethos_u
3a5fd4f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
e676620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidied delegate_runner output
4b1125e
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed some merge issues
7afc5e4
 * File moved to new path in examples
* fix arg handling and md5sum for setup scripts
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@netlify
netlifyBot
commented
Oct 6, 2023•

edited

Loading

Copy link


Copy Markdown

✅ Deploy Preview for resplendent-gnome-14e531 canceled.
NameLink
🔨 Latest commit709a688
🔍 Latest deploy loghttps://app.netlify.com/sites/resplendent-gnome-14e531/deploys/652072de622f4c00082b4740
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 6, 2023
@robell
Test fixes for compiler output choice
e340b5c
 * Introduction of BI_INT to have a small set of pure int tests
* added either vela or tosa output from compilation
* Fixed tosa e2e tests to use tosa output form
* unit tests currently use tosa due to missing vela dependency
* vela e2e testing runs with default compile flags and emits to .pte
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robellrobell
mentioned this pull request
Oct 6, 2023
 Closed

digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know since you are waiting I am submitting these as I go. Just finished looked at the AoT python code. And next looking at the runtime bits.
Comment threadCMakeLists.txt
Comment threadbackends/arm/CMakeLists.txt
Outdated

Comment threadbackends/arm/CMakeLists.txt
Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
robell
robell
commented
Oct 6, 2023
View reviewed changes
Comment threadbackends/arm/cmake/arm-none-eabi-gcc.cmake
Outdated

@robell
review fixes
6b7a18a
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

round 2 for delegate runtime
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is it. Not sure if I missed anything, I am not the biggest fan of this GH UI :\
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_tosa.py
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Outdated

Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Outdated

@robell
review feedback/improvements
c453e43
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidy up example scripts
1917b54
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@digantdesaidigantdesai
mentioned this pull request
Oct 6, 2023

Closed

digantdesai
digantdesai
approved these changes
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks @robell - this was a difficult one.

Created Issue #666 as a follow up.
@robell
further review comments
20bf2eb
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
revised path for ethosu_minimal
468d6fc
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
709a688
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@facebook-github-bot
facebook-github-bot
commented
Oct 6, 2023

Copy link


Copy Markdown

Contributor
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@Jerry-GeJerry-Ge
mentioned this pull request
Oct 6, 2023
 Closed

@tatwaichongtatwaichong
mentioned this pull request
Oct 6, 2023
 Closed

digantdesai
digantdesai
reviewed
Oct 7, 2023
View reviewed changes
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp

#include <cstring>
#include <memory>
#include <vector>
@digantdesaidigantdesaiOct 7, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to see if we can get away without this std::container. It will be better from size and portability point of view. Other than input/output we aren't using it anywhere else so should be easy to get rid of it.
@digantdesaidigantdesaiOct 7, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#677 FYI
@digantdesaidigantdesai
mentioned this pull request
Oct 7, 2023

Closed

@facebook-github-bot
facebook-github-bot
commented
Oct 7, 2023

Copy link


Copy Markdown

Contributor
@digantdesai merged this pull request in 78197a3.
@robellrobell
added
the 
partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
label
Jul 4, 2024
Gasoonjia pushed a commit
that referenced
this pull request
Jul 30, 2024
@mikekgfb@malfet
Update quantization.md (#659)
e9def32
Update support tables and explanatory text.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Initial framework of an ethos-u runtime backend #3 - #659
Closed
robell wants to merge 25 commits into
pytorch:mainfrom 
robell:rebase_test
Closed
Initial framework of an ethos-u runtime backend #3#659
robell wants to merge 25 commits into
pytorch:mainfrom 
robell:rebase_test
Conversation
@robell
@robellrobell
commented
Oct 6, 2023

Copy link


Copy Markdown

Collaborator
Cleaned up ethos-u runtime flow, replaces #595
Added shell of runtime Arm Backend for Ethos-U
./backends/arm/cmake/build.sh will pull the appropriate compiler and build the ethos-u driver and delegate and produce the libraries needed to link an application in, which can run a delegated .pte with the revised vela_bin_stream form contained in these patches.
Currently supports .pte files stored in SRAM.
robell
added 18 commits
October 6, 2023 07:46
@robell
Initial Ethos-U runtime backend
225c115
 - Basic runtime targeting Corstone-300 with U55
- cross compile support with a cmake toolchain (Arm baremetal build)
- support for a few models AoT -> TOSA -> Vela -> U55 hardware
- dependencies on the ethos-u core driver and cmsis (submodules)
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed error messages on runtime init
a7aa848
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintrunner cleanup
f95fead
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add ArmBackend to example scripts
524afc6
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add delegate test and FVP output
2bfdb5f
 * There is a toolchain/linking issue mixing hard and soft float ABI
which is causing the test to fail, but the structure is there and the
delegate is registered.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fix delegate runner patch
8267612
@robell
cmake compiler and log behaviour fixing
6b398fe
 * Override the default CPU in cmake which was causing a mixture of FPU
and ABI flags to be passed to different compilation stages.
* Updated fallback logging implementation in delegate app to fix
sporadic crash
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Minimal example of AoT with ArmPartitioner+Vela
6ca9b26
 * uses the simple_add model to run through the AoT flow and the various
debug options for looking at export.
* produces a .pte file for runtime delegation on the ArmBackend for
Ethos-U55 platforms
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Generate pte for delegate test on the fly
f40ab5f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Added support for variable input output patterns
d10d620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Handle multiple delegate inputs with SRAM offsets
b812898
 * export the list of offset from AoT floq
* appropriately copy inputs and ouputs to/from SRAM
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add TOSA ref model and Vela dependencies
44a46a1
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Cleanup from lintrunner and other bits of tidyup
cb16e68
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Removed ethos u driver build and cmsis dependency
8aa80d0
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
renamed lib ethos_u to executorch_delegate_ethos_u
3a5fd4f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
e676620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidied delegate_runner output
4b1125e
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed some merge issues
7afc5e4
 * File moved to new path in examples
* fix arg handling and md5sum for setup scripts
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@netlify
netlifyBot
commented
Oct 6, 2023•

edited

Loading

Copy link


Copy Markdown

✅ Deploy Preview for resplendent-gnome-14e531 canceled.
NameLink
🔨 Latest commit709a688
🔍 Latest deploy loghttps://app.netlify.com/sites/resplendent-gnome-14e531/deploys/652072de622f4c00082b4740
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 6, 2023
@robell
Test fixes for compiler output choice
e340b5c
 * Introduction of BI_INT to have a small set of pure int tests
* added either vela or tosa output from compilation
* Fixed tosa e2e tests to use tosa output form
* unit tests currently use tosa due to missing vela dependency
* vela e2e testing runs with default compile flags and emits to .pte
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robellrobell
mentioned this pull request
Oct 6, 2023
 Closed

digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know since you are waiting I am submitting these as I go. Just finished looked at the AoT python code. And next looking at the runtime bits.
Comment threadCMakeLists.txt
Comment threadbackends/arm/CMakeLists.txt
Outdated

Comment threadbackends/arm/CMakeLists.txt
Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
robell
robell
commented
Oct 6, 2023
View reviewed changes
Comment threadbackends/arm/cmake/arm-none-eabi-gcc.cmake
Outdated

@robell
review fixes
6b7a18a
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

round 2 for delegate runtime
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is it. Not sure if I missed anything, I am not the biggest fan of this GH UI :\
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_tosa.py
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Outdated

Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Outdated

@robell
review feedback/improvements
c453e43
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidy up example scripts
1917b54
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@digantdesaidigantdesai
mentioned this pull request
Oct 6, 2023

Closed

digantdesai
digantdesai
approved these changes
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks @robell - this was a difficult one.

Created Issue #666 as a follow up.
@robell
further review comments
20bf2eb
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
revised path for ethosu_minimal
468d6fc
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
709a688
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@facebook-github-bot
facebook-github-bot
commented
Oct 6, 2023

Copy link


Copy Markdown

Contributor
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@Jerry-GeJerry-Ge
mentioned this pull request
Oct 6, 2023
 Closed

@tatwaichongtatwaichong
mentioned this pull request
Oct 6, 2023
 Closed

digantdesai
digantdesai
reviewed
Oct 7, 2023
View reviewed changes
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp

#include <cstring>
#include <memory>
#include <vector>
@digantdesaidigantdesaiOct 7, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to see if we can get away without this std::container. It will be better from size and portability point of view. Other than input/output we aren't using it anywhere else so should be easy to get rid of it.
@digantdesaidigantdesaiOct 7, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#677 FYI
@digantdesaidigantdesai
mentioned this pull request
Oct 7, 2023

Closed

@facebook-github-bot
facebook-github-bot
commented
Oct 7, 2023

Copy link


Copy Markdown

Contributor
@digantdesai merged this pull request in 78197a3.
@robellrobell
added
the 
partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
label
Jul 4, 2024
Gasoonjia pushed a commit
that referenced
this pull request
Jul 30, 2024
@mikekgfb@malfet
Update quantization.md (#659)
e9def32
Update support tables and explanatory text.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Initial framework of an ethos-u runtime backend #3 - #659
Closed
robell wants to merge 25 commits into
pytorch:mainfrom 
robell:rebase_test
Closed
Initial framework of an ethos-u runtime backend #3#659
robell wants to merge 25 commits into
pytorch:mainfrom 
robell:rebase_test
Conversation
@robell
@robellrobell
commented
Oct 6, 2023

Copy link


Copy Markdown

Collaborator
Cleaned up ethos-u runtime flow, replaces #595
Added shell of runtime Arm Backend for Ethos-U
./backends/arm/cmake/build.sh will pull the appropriate compiler and build the ethos-u driver and delegate and produce the libraries needed to link an application in, which can run a delegated .pte with the revised vela_bin_stream form contained in these patches.
Currently supports .pte files stored in SRAM.
robell
added 18 commits
October 6, 2023 07:46
@robell
Initial Ethos-U runtime backend
225c115
 - Basic runtime targeting Corstone-300 with U55
- cross compile support with a cmake toolchain (Arm baremetal build)
- support for a few models AoT -> TOSA -> Vela -> U55 hardware
- dependencies on the ethos-u core driver and cmsis (submodules)
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed error messages on runtime init
a7aa848
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintrunner cleanup
f95fead
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add ArmBackend to example scripts
524afc6
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add delegate test and FVP output
2bfdb5f
 * There is a toolchain/linking issue mixing hard and soft float ABI
which is causing the test to fail, but the structure is there and the
delegate is registered.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fix delegate runner patch
8267612
@robell
cmake compiler and log behaviour fixing
6b398fe
 * Override the default CPU in cmake which was causing a mixture of FPU
and ABI flags to be passed to different compilation stages.
* Updated fallback logging implementation in delegate app to fix
sporadic crash
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Minimal example of AoT with ArmPartitioner+Vela
6ca9b26
 * uses the simple_add model to run through the AoT flow and the various
debug options for looking at export.
* produces a .pte file for runtime delegation on the ArmBackend for
Ethos-U55 platforms
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Generate pte for delegate test on the fly
f40ab5f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Added support for variable input output patterns
d10d620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Handle multiple delegate inputs with SRAM offsets
b812898
 * export the list of offset from AoT floq
* appropriately copy inputs and ouputs to/from SRAM
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add TOSA ref model and Vela dependencies
44a46a1
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Cleanup from lintrunner and other bits of tidyup
cb16e68
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Removed ethos u driver build and cmsis dependency
8aa80d0
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
renamed lib ethos_u to executorch_delegate_ethos_u
3a5fd4f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
e676620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidied delegate_runner output
4b1125e
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed some merge issues
7afc5e4
 * File moved to new path in examples
* fix arg handling and md5sum for setup scripts
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@netlify
netlifyBot
commented
Oct 6, 2023•

edited

Loading

Copy link


Copy Markdown

✅ Deploy Preview for resplendent-gnome-14e531 canceled.
NameLink
🔨 Latest commit709a688
🔍 Latest deploy loghttps://app.netlify.com/sites/resplendent-gnome-14e531/deploys/652072de622f4c00082b4740
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 6, 2023
@robell
Test fixes for compiler output choice
e340b5c
 * Introduction of BI_INT to have a small set of pure int tests
* added either vela or tosa output from compilation
* Fixed tosa e2e tests to use tosa output form
* unit tests currently use tosa due to missing vela dependency
* vela e2e testing runs with default compile flags and emits to .pte
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robellrobell
mentioned this pull request
Oct 6, 2023
 Closed

digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know since you are waiting I am submitting these as I go. Just finished looked at the AoT python code. And next looking at the runtime bits.
Comment threadCMakeLists.txt
Comment threadbackends/arm/CMakeLists.txt
Outdated

Comment threadbackends/arm/CMakeLists.txt
Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
robell
robell
commented
Oct 6, 2023
View reviewed changes
Comment threadbackends/arm/cmake/arm-none-eabi-gcc.cmake
Outdated

@robell
review fixes
6b7a18a
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

round 2 for delegate runtime
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is it. Not sure if I missed anything, I am not the biggest fan of this GH UI :\
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_tosa.py
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Outdated

Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Outdated

@robell
review feedback/improvements
c453e43
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidy up example scripts
1917b54
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@digantdesaidigantdesai
mentioned this pull request
Oct 6, 2023

Closed

digantdesai
digantdesai
approved these changes
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks @robell - this was a difficult one.

Created Issue #666 as a follow up.
@robell
further review comments
20bf2eb
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
revised path for ethosu_minimal
468d6fc
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
709a688
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@facebook-github-bot
facebook-github-bot
commented
Oct 6, 2023

Copy link


Copy Markdown

Contributor
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@Jerry-GeJerry-Ge
mentioned this pull request
Oct 6, 2023
 Closed

@tatwaichongtatwaichong
mentioned this pull request
Oct 6, 2023
 Closed

digantdesai
digantdesai
reviewed
Oct 7, 2023
View reviewed changes
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp

#include <cstring>
#include <memory>
#include <vector>
@digantdesaidigantdesaiOct 7, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to see if we can get away without this std::container. It will be better from size and portability point of view. Other than input/output we aren't using it anywhere else so should be easy to get rid of it.
@digantdesaidigantdesaiOct 7, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#677 FYI
@digantdesaidigantdesai
mentioned this pull request
Oct 7, 2023

Closed

@facebook-github-bot
facebook-github-bot
commented
Oct 7, 2023

Copy link


Copy Markdown

Contributor
@digantdesai merged this pull request in 78197a3.
@robellrobell
added
the 
partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
label
Jul 4, 2024
Gasoonjia pushed a commit
that referenced
this pull request
Jul 30, 2024
@mikekgfb@malfet
Update quantization.md (#659)
e9def32
Update support tables and explanatory text.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Initial framework of an ethos-u runtime backend #3 - #659
Closed
robell wants to merge 25 commits into
pytorch:mainfrom 
robell:rebase_test
Closed
Initial framework of an ethos-u runtime backend #3#659
robell wants to merge 25 commits into
pytorch:mainfrom 
robell:rebase_test
Conversation
@robell
@robellrobell
commented
Oct 6, 2023

Copy link


Copy Markdown

Collaborator
Cleaned up ethos-u runtime flow, replaces #595
Added shell of runtime Arm Backend for Ethos-U
./backends/arm/cmake/build.sh will pull the appropriate compiler and build the ethos-u driver and delegate and produce the libraries needed to link an application in, which can run a delegated .pte with the revised vela_bin_stream form contained in these patches.
Currently supports .pte files stored in SRAM.
robell
added 18 commits
October 6, 2023 07:46
@robell
Initial Ethos-U runtime backend
225c115
 - Basic runtime targeting Corstone-300 with U55
- cross compile support with a cmake toolchain (Arm baremetal build)
- support for a few models AoT -> TOSA -> Vela -> U55 hardware
- dependencies on the ethos-u core driver and cmsis (submodules)
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed error messages on runtime init
a7aa848
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintrunner cleanup
f95fead
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add ArmBackend to example scripts
524afc6
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add delegate test and FVP output
2bfdb5f
 * There is a toolchain/linking issue mixing hard and soft float ABI
which is causing the test to fail, but the structure is there and the
delegate is registered.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fix delegate runner patch
8267612
@robell
cmake compiler and log behaviour fixing
6b398fe
 * Override the default CPU in cmake which was causing a mixture of FPU
and ABI flags to be passed to different compilation stages.
* Updated fallback logging implementation in delegate app to fix
sporadic crash
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Minimal example of AoT with ArmPartitioner+Vela
6ca9b26
 * uses the simple_add model to run through the AoT flow and the various
debug options for looking at export.
* produces a .pte file for runtime delegation on the ArmBackend for
Ethos-U55 platforms
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Generate pte for delegate test on the fly
f40ab5f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Added support for variable input output patterns
d10d620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Handle multiple delegate inputs with SRAM offsets
b812898
 * export the list of offset from AoT floq
* appropriately copy inputs and ouputs to/from SRAM
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add TOSA ref model and Vela dependencies
44a46a1
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Cleanup from lintrunner and other bits of tidyup
cb16e68
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Removed ethos u driver build and cmsis dependency
8aa80d0
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
renamed lib ethos_u to executorch_delegate_ethos_u
3a5fd4f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
e676620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidied delegate_runner output
4b1125e
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed some merge issues
7afc5e4
 * File moved to new path in examples
* fix arg handling and md5sum for setup scripts
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@netlify
netlifyBot
commented
Oct 6, 2023•

edited

Loading

Copy link


Copy Markdown

✅ Deploy Preview for resplendent-gnome-14e531 canceled.
NameLink
🔨 Latest commit709a688
🔍 Latest deploy loghttps://app.netlify.com/sites/resplendent-gnome-14e531/deploys/652072de622f4c00082b4740
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 6, 2023
@robell
Test fixes for compiler output choice
e340b5c
 * Introduction of BI_INT to have a small set of pure int tests
* added either vela or tosa output from compilation
* Fixed tosa e2e tests to use tosa output form
* unit tests currently use tosa due to missing vela dependency
* vela e2e testing runs with default compile flags and emits to .pte
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robellrobell
mentioned this pull request
Oct 6, 2023
 Closed

digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know since you are waiting I am submitting these as I go. Just finished looked at the AoT python code. And next looking at the runtime bits.
Comment threadCMakeLists.txt
Comment threadbackends/arm/CMakeLists.txt
Outdated

Comment threadbackends/arm/CMakeLists.txt
Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
robell
robell
commented
Oct 6, 2023
View reviewed changes
Comment threadbackends/arm/cmake/arm-none-eabi-gcc.cmake
Outdated

@robell
review fixes
6b7a18a
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

round 2 for delegate runtime
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is it. Not sure if I missed anything, I am not the biggest fan of this GH UI :\
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_tosa.py
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Outdated

Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Outdated

@robell
review feedback/improvements
c453e43
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidy up example scripts
1917b54
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@digantdesaidigantdesai
mentioned this pull request
Oct 6, 2023

Closed

digantdesai
digantdesai
approved these changes
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks @robell - this was a difficult one.

Created Issue #666 as a follow up.
@robell
further review comments
20bf2eb
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
revised path for ethosu_minimal
468d6fc
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
709a688
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@facebook-github-bot
facebook-github-bot
commented
Oct 6, 2023

Copy link


Copy Markdown

Contributor
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@Jerry-GeJerry-Ge
mentioned this pull request
Oct 6, 2023
 Closed

@tatwaichongtatwaichong
mentioned this pull request
Oct 6, 2023
 Closed

digantdesai
digantdesai
reviewed
Oct 7, 2023
View reviewed changes
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp

#include <cstring>
#include <memory>
#include <vector>
@digantdesaidigantdesaiOct 7, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to see if we can get away without this std::container. It will be better from size and portability point of view. Other than input/output we aren't using it anywhere else so should be easy to get rid of it.
@digantdesaidigantdesaiOct 7, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#677 FYI
@digantdesaidigantdesai
mentioned this pull request
Oct 7, 2023

Closed

@facebook-github-bot
facebook-github-bot
commented
Oct 7, 2023

Copy link


Copy Markdown

Contributor
@digantdesai merged this pull request in 78197a3.
@robellrobell
added
the 
partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
label
Jul 4, 2024
Gasoonjia pushed a commit
that referenced
this pull request
Jul 30, 2024
@mikekgfb@malfet
Update quantization.md (#659)
e9def32
Update support tables and explanatory text.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Initial framework of an ethos-u runtime backend #3 - #659
Closed
robell wants to merge 25 commits into
pytorch:mainfrom 
robell:rebase_test
Closed
Initial framework of an ethos-u runtime backend #3#659
robell wants to merge 25 commits into
pytorch:mainfrom 
robell:rebase_test
Conversation
@robell
@robellrobell
commented
Oct 6, 2023

Copy link


Copy Markdown

Collaborator
Cleaned up ethos-u runtime flow, replaces #595
Added shell of runtime Arm Backend for Ethos-U
./backends/arm/cmake/build.sh will pull the appropriate compiler and build the ethos-u driver and delegate and produce the libraries needed to link an application in, which can run a delegated .pte with the revised vela_bin_stream form contained in these patches.
Currently supports .pte files stored in SRAM.
robell
added 18 commits
October 6, 2023 07:46
@robell
Initial Ethos-U runtime backend
225c115
 - Basic runtime targeting Corstone-300 with U55
- cross compile support with a cmake toolchain (Arm baremetal build)
- support for a few models AoT -> TOSA -> Vela -> U55 hardware
- dependencies on the ethos-u core driver and cmsis (submodules)
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed error messages on runtime init
a7aa848
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintrunner cleanup
f95fead
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add ArmBackend to example scripts
524afc6
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add delegate test and FVP output
2bfdb5f
 * There is a toolchain/linking issue mixing hard and soft float ABI
which is causing the test to fail, but the structure is there and the
delegate is registered.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fix delegate runner patch
8267612
@robell
cmake compiler and log behaviour fixing
6b398fe
 * Override the default CPU in cmake which was causing a mixture of FPU
and ABI flags to be passed to different compilation stages.
* Updated fallback logging implementation in delegate app to fix
sporadic crash
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Minimal example of AoT with ArmPartitioner+Vela
6ca9b26
 * uses the simple_add model to run through the AoT flow and the various
debug options for looking at export.
* produces a .pte file for runtime delegation on the ArmBackend for
Ethos-U55 platforms
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Generate pte for delegate test on the fly
f40ab5f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Added support for variable input output patterns
d10d620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Handle multiple delegate inputs with SRAM offsets
b812898
 * export the list of offset from AoT floq
* appropriately copy inputs and ouputs to/from SRAM
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add TOSA ref model and Vela dependencies
44a46a1
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Cleanup from lintrunner and other bits of tidyup
cb16e68
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Removed ethos u driver build and cmsis dependency
8aa80d0
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
renamed lib ethos_u to executorch_delegate_ethos_u
3a5fd4f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
e676620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidied delegate_runner output
4b1125e
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed some merge issues
7afc5e4
 * File moved to new path in examples
* fix arg handling and md5sum for setup scripts
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@netlify
netlifyBot
commented
Oct 6, 2023•

edited

Loading

Copy link


Copy Markdown

✅ Deploy Preview for resplendent-gnome-14e531 canceled.
NameLink
🔨 Latest commit709a688
🔍 Latest deploy loghttps://app.netlify.com/sites/resplendent-gnome-14e531/deploys/652072de622f4c00082b4740
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 6, 2023
@robell
Test fixes for compiler output choice
e340b5c
 * Introduction of BI_INT to have a small set of pure int tests
* added either vela or tosa output from compilation
* Fixed tosa e2e tests to use tosa output form
* unit tests currently use tosa due to missing vela dependency
* vela e2e testing runs with default compile flags and emits to .pte
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robellrobell
mentioned this pull request
Oct 6, 2023
 Closed

digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know since you are waiting I am submitting these as I go. Just finished looked at the AoT python code. And next looking at the runtime bits.
Comment threadCMakeLists.txt
Comment threadbackends/arm/CMakeLists.txt
Outdated

Comment threadbackends/arm/CMakeLists.txt
Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
robell
robell
commented
Oct 6, 2023
View reviewed changes
Comment threadbackends/arm/cmake/arm-none-eabi-gcc.cmake
Outdated

@robell
review fixes
6b7a18a
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

round 2 for delegate runtime
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is it. Not sure if I missed anything, I am not the biggest fan of this GH UI :\
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_tosa.py
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Outdated

Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Outdated

@robell
review feedback/improvements
c453e43
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidy up example scripts
1917b54
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@digantdesaidigantdesai
mentioned this pull request
Oct 6, 2023

Closed

digantdesai
digantdesai
approved these changes
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks @robell - this was a difficult one.

Created Issue #666 as a follow up.
@robell
further review comments
20bf2eb
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
revised path for ethosu_minimal
468d6fc
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
709a688
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@facebook-github-bot
facebook-github-bot
commented
Oct 6, 2023

Copy link


Copy Markdown

Contributor
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@Jerry-GeJerry-Ge
mentioned this pull request
Oct 6, 2023
 Closed

@tatwaichongtatwaichong
mentioned this pull request
Oct 6, 2023
 Closed

digantdesai
digantdesai
reviewed
Oct 7, 2023
View reviewed changes
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp

#include <cstring>
#include <memory>
#include <vector>
@digantdesaidigantdesaiOct 7, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to see if we can get away without this std::container. It will be better from size and portability point of view. Other than input/output we aren't using it anywhere else so should be easy to get rid of it.
@digantdesaidigantdesaiOct 7, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#677 FYI
@digantdesaidigantdesai
mentioned this pull request
Oct 7, 2023

Closed

@facebook-github-bot
facebook-github-bot
commented
Oct 7, 2023

Copy link


Copy Markdown

Contributor
@digantdesai merged this pull request in 78197a3.
@robellrobell
added
the 
partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
label
Jul 4, 2024
Gasoonjia pushed a commit
that referenced
this pull request
Jul 30, 2024
@mikekgfb@malfet
Update quantization.md (#659)
e9def32
Update support tables and explanatory text.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Initial framework of an ethos-u runtime backend #3 - #659
Closed
robell wants to merge 25 commits into
pytorch:mainfrom 
robell:rebase_test
Closed
Initial framework of an ethos-u runtime backend #3#659
robell wants to merge 25 commits into
pytorch:mainfrom 
robell:rebase_test
Conversation
@robell
@robellrobell
commented
Oct 6, 2023

Copy link


Copy Markdown

Collaborator
Cleaned up ethos-u runtime flow, replaces #595
Added shell of runtime Arm Backend for Ethos-U
./backends/arm/cmake/build.sh will pull the appropriate compiler and build the ethos-u driver and delegate and produce the libraries needed to link an application in, which can run a delegated .pte with the revised vela_bin_stream form contained in these patches.
Currently supports .pte files stored in SRAM.
robell
added 18 commits
October 6, 2023 07:46
@robell
Initial Ethos-U runtime backend
225c115
 - Basic runtime targeting Corstone-300 with U55
- cross compile support with a cmake toolchain (Arm baremetal build)
- support for a few models AoT -> TOSA -> Vela -> U55 hardware
- dependencies on the ethos-u core driver and cmsis (submodules)
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed error messages on runtime init
a7aa848
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintrunner cleanup
f95fead
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add ArmBackend to example scripts
524afc6
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add delegate test and FVP output
2bfdb5f
 * There is a toolchain/linking issue mixing hard and soft float ABI
which is causing the test to fail, but the structure is there and the
delegate is registered.
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fix delegate runner patch
8267612
@robell
cmake compiler and log behaviour fixing
6b398fe
 * Override the default CPU in cmake which was causing a mixture of FPU
and ABI flags to be passed to different compilation stages.
* Updated fallback logging implementation in delegate app to fix
sporadic crash
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Minimal example of AoT with ArmPartitioner+Vela
6ca9b26
 * uses the simple_add model to run through the AoT flow and the various
debug options for looking at export.
* produces a .pte file for runtime delegation on the ArmBackend for
Ethos-U55 platforms
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Generate pte for delegate test on the fly
f40ab5f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Added support for variable input output patterns
d10d620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Handle multiple delegate inputs with SRAM offsets
b812898
 * export the list of offset from AoT floq
* appropriately copy inputs and ouputs to/from SRAM
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Add TOSA ref model and Vela dependencies
44a46a1
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Cleanup from lintrunner and other bits of tidyup
cb16e68
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Removed ethos u driver build and cmsis dependency
8aa80d0
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
renamed lib ethos_u to executorch_delegate_ethos_u
3a5fd4f
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
e676620
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidied delegate_runner output
4b1125e
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Fixed some merge issues
7afc5e4
 * File moved to new path in examples
* fix arg handling and md5sum for setup scripts
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@netlify
netlifyBot
commented
Oct 6, 2023•

edited

Loading

Copy link


Copy Markdown

✅ Deploy Preview for resplendent-gnome-14e531 canceled.
NameLink
🔨 Latest commit709a688
🔍 Latest deploy loghttps://app.netlify.com/sites/resplendent-gnome-14e531/deploys/652072de622f4c00082b4740
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 6, 2023
@robell
Test fixes for compiler output choice
e340b5c
 * Introduction of BI_INT to have a small set of pure int tests
* added either vela or tosa output from compilation
* Fixed tosa e2e tests to use tosa output form
* unit tests currently use tosa due to missing vela dependency
* vela e2e testing runs with default compile flags and emits to .pte
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robellrobell
mentioned this pull request
Oct 6, 2023
 Closed

digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know since you are waiting I am submitting these as I go. Just finished looked at the AoT python code. And next looking at the runtime bits.
Comment threadCMakeLists.txt
Comment threadbackends/arm/CMakeLists.txt
Outdated

Comment threadbackends/arm/CMakeLists.txt
Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
Outdated

Comment threadbackends/arm/arm_backend.py
Comment threadbackends/arm/arm_backend.py
robell
robell
commented
Oct 6, 2023
View reviewed changes
Comment threadbackends/arm/cmake/arm-none-eabi-gcc.cmake
Outdated

@robell
review fixes
6b7a18a
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

round 2 for delegate runtime
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Outdated

Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp
digantdesai
digantdesai
reviewed
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is it. Not sure if I missed anything, I am not the biggest fan of this GH UI :\
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_models.py
Comment threadbackends/arm/test/test_tosa.py
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/ethos-u-setup/core_platform/patches/0007-Add-delegate-runner-test.patch
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Outdated

Comment threadexamples/arm/run.sh
Comment threadexamples/arm/run.sh
Outdated

@robell
review feedback/improvements
c453e43
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
tidy up example scripts
1917b54
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@digantdesaidigantdesai
mentioned this pull request
Oct 6, 2023

Closed

digantdesai
digantdesai
approved these changes
Oct 6, 2023
View reviewed changes
@digantdesaidigantdesai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks @robell - this was a difficult one.

Created Issue #666 as a follow up.
@robell
further review comments
20bf2eb
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
revised path for ethosu_minimal
468d6fc
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
lintfix
709a688
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@facebook-github-bot
facebook-github-bot
commented
Oct 6, 2023

Copy link


Copy Markdown

Contributor
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@Jerry-GeJerry-Ge
mentioned this pull request
Oct 6, 2023
 Closed

@tatwaichongtatwaichong
mentioned this pull request
Oct 6, 2023
 Closed

digantdesai
digantdesai
reviewed
Oct 7, 2023
View reviewed changes
Comment threadbackends/arm/runtime/ArmBackendEthosU.cpp

#include <cstring>
#include <memory>
#include <vector>
@digantdesaidigantdesaiOct 7, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to see if we can get away without this std::container. It will be better from size and portability point of view. Other than input/output we aren't using it anywhere else so should be easy to get rid of it.
@digantdesaidigantdesaiOct 7, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#677 FYI
@digantdesaidigantdesai
mentioned this pull request
Oct 7, 2023

Closed

@facebook-github-bot
facebook-github-bot
commented
Oct 7, 2023

Copy link


Copy Markdown

Contributor
@digantdesai merged this pull request in 78197a3.
@robellrobell
added
the 
partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
label
Jul 4, 2024
Gasoonjia pushed a commit
that referenced
this pull request
Jul 30, 2024
@mikekgfb@malfet
Update quantization.md (#659)
e9def32
Update support tables and explanatory text.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Mergedpartner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@robell@facebook-github-bot@digantdesai