Tosa specification handling - #6688

Merged
freddan80 merged 5 commits into
pytorch:mainfrom
per:tosa_specification_handling
Nov 8, 2024
Merged

Tosa specification handling#6688
freddan80 merged 5 commits into
pytorch:mainfrom
per:tosa_specification_handling

Conversation

@per

@perper commented Nov 6, 2024

Copy link
Copy Markdown
Collaborator

Summary

Add TOSA specification details to the Arm Backend.

@pytorch-bot

pytorch-botBot commented Nov 6, 2024•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6688

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 51dc602 with merge base 485a5df (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2024
@perper added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Nov 6, 2024
@per
per requested a review from digantdesaiNovember 6, 2024 12:30
@freddan80
freddan80 self-requested a review November 6, 2024 12:43
@per
perforce-pushed the tosa_specification_handling branch 4 times, most recently from 9e4cbda to ea64bdaCompareNovember 7, 2024 09:49
@per
perforce-pushed the tosa_specification_handling branch 3 times, most recently from ee72d64 to fd092a9CompareNovember 8, 2024 12:13
per added 5 commits November 8, 2024 16:59
@per
Add a TOSA specification class
1dbc56b
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: I45374812daaa831f8084f6534b4903d14d6634b8
@per
Add TOSA specification handling to Arm backend
56dc56a
Mandate the need for a TOSA version in the compile spec list passed
to the Arm backend and propagate the information to node visitors
for serialization handling.
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: I43b35923f71a312e3064eab9388a4bd2756dc17f
@per
Add TOSA version string to all TOSA tests
27ad50e
Change-Id: Ia2b21c14f56793d6a9125ae7371779df93ecf9d5
@per
Adapt ADD serialization to use TOSA Specification handling
371bcfd
Adds handling of TOSA 0.80 BI and MI profile as separate serialization
handlers for ADD as an example.
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: I89e8ded90ec29bfca06a0ab9a102307cd0b005bd
@per
Add TOSA version string to max_pool tests.
51dc602
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: I14ce1d9f53396d3ff49536875f24dabd24a71c10
@per
perforce-pushed the tosa_specification_handling branch from fd092a9 to 51dc602CompareNovember 8, 2024 16:05
@freddan80
freddan80 merged commit ddc8ea6 into pytorch:mainNov 8, 2024
@per
per deleted the tosa_specification_handling branch November 15, 2024 11:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freddan80freddan80freddan80 approved these changes
@digantdesaidigantdesaiAwaiting requested review from digantdesaidigantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.partner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@per@freddan80@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Tosa specification handling - #6688

Merged
freddan80 merged 5 commits into
pytorch:mainfrom
per:tosa_specification_handling
Nov 8, 2024
Merged

Tosa specification handling#6688
freddan80 merged 5 commits into
pytorch:mainfrom
per:tosa_specification_handling

Conversation

@per

@perper commented Nov 6, 2024

Copy link
Copy Markdown
Collaborator

Summary

Add TOSA specification details to the Arm Backend.

@pytorch-bot

pytorch-botBot commented Nov 6, 2024•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6688

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 51dc602 with merge base 485a5df (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2024
@perper added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Nov 6, 2024
@per
per requested a review from digantdesaiNovember 6, 2024 12:30
@freddan80
freddan80 self-requested a review November 6, 2024 12:43
@per
perforce-pushed the tosa_specification_handling branch 4 times, most recently from 9e4cbda to ea64bdaCompareNovember 7, 2024 09:49
@per
perforce-pushed the tosa_specification_handling branch 3 times, most recently from ee72d64 to fd092a9CompareNovember 8, 2024 12:13
per added 5 commits November 8, 2024 16:59
@per
Add a TOSA specification class
1dbc56b
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: I45374812daaa831f8084f6534b4903d14d6634b8
@per
Add TOSA specification handling to Arm backend
56dc56a
Mandate the need for a TOSA version in the compile spec list passed
to the Arm backend and propagate the information to node visitors
for serialization handling.
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: I43b35923f71a312e3064eab9388a4bd2756dc17f
@per
Add TOSA version string to all TOSA tests
27ad50e
Change-Id: Ia2b21c14f56793d6a9125ae7371779df93ecf9d5
@per
Adapt ADD serialization to use TOSA Specification handling
371bcfd
Adds handling of TOSA 0.80 BI and MI profile as separate serialization
handlers for ADD as an example.
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: I89e8ded90ec29bfca06a0ab9a102307cd0b005bd
@per
Add TOSA version string to max_pool tests.
51dc602
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: I14ce1d9f53396d3ff49536875f24dabd24a71c10
@per
perforce-pushed the tosa_specification_handling branch from fd092a9 to 51dc602CompareNovember 8, 2024 16:05
@freddan80
freddan80 merged commit ddc8ea6 into pytorch:mainNov 8, 2024
@per
per deleted the tosa_specification_handling branch November 15, 2024 11:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freddan80freddan80freddan80 approved these changes
@digantdesaidigantdesaiAwaiting requested review from digantdesaidigantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.partner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@per@freddan80@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Tosa specification handling - #6688

Merged
freddan80 merged 5 commits into
pytorch:mainfrom
per:tosa_specification_handling
Nov 8, 2024
Merged

Tosa specification handling#6688
freddan80 merged 5 commits into
pytorch:mainfrom
per:tosa_specification_handling

Conversation

@per

@perper commented Nov 6, 2024

Copy link
Copy Markdown
Collaborator

Summary

Add TOSA specification details to the Arm Backend.

@pytorch-bot

pytorch-botBot commented Nov 6, 2024•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6688

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 51dc602 with merge base 485a5df (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2024
@perper added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Nov 6, 2024
@per
per requested a review from digantdesaiNovember 6, 2024 12:30
@freddan80
freddan80 self-requested a review November 6, 2024 12:43
@per
perforce-pushed the tosa_specification_handling branch 4 times, most recently from 9e4cbda to ea64bdaCompareNovember 7, 2024 09:49
@per
perforce-pushed the tosa_specification_handling branch 3 times, most recently from ee72d64 to fd092a9CompareNovember 8, 2024 12:13
per added 5 commits November 8, 2024 16:59
@per
Add a TOSA specification class
1dbc56b
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: I45374812daaa831f8084f6534b4903d14d6634b8
@per
Add TOSA specification handling to Arm backend
56dc56a
Mandate the need for a TOSA version in the compile spec list passed
to the Arm backend and propagate the information to node visitors
for serialization handling.
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: I43b35923f71a312e3064eab9388a4bd2756dc17f
@per
Add TOSA version string to all TOSA tests
27ad50e
Change-Id: Ia2b21c14f56793d6a9125ae7371779df93ecf9d5
@per
Adapt ADD serialization to use TOSA Specification handling
371bcfd
Adds handling of TOSA 0.80 BI and MI profile as separate serialization
handlers for ADD as an example.
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: I89e8ded90ec29bfca06a0ab9a102307cd0b005bd
@per
Add TOSA version string to max_pool tests.
51dc602
Signed-off-by: Per Åstrand <per.astrand@arm.com>
Change-Id: I14ce1d9f53396d3ff49536875f24dabd24a71c10
@per
perforce-pushed the tosa_specification_handling branch from fd092a9 to 51dc602CompareNovember 8, 2024 16:05
@freddan80
freddan80 merged commit ddc8ea6 into pytorch:mainNov 8, 2024
@per
per deleted the tosa_specification_handling branch November 15, 2024 11:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freddan80freddan80freddan80 approved these changes
@digantdesaidigantdesaiAwaiting requested review from digantdesaidigantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.partner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@per@freddan80@facebook-github-bot