[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. by trviv · Pull Request #7222 · pytorch/executorch

trviv · 2024-12-06T16:53:14Z

Stack from ghstack (oldest at bottom):

[ET-VK] Replace Uniform buffers with push constants for permute op #7231
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
[ET-VK] Replace Uniform buffers with push constants for view op #7229
[ET-VK] Adding convenience functions in Compute graph to get PushConstantDataInfo for various attributes of a tensor. #7224
[ET-VK] Add PushConstantDataInfo and vector to hold push constants data in DispatchNode. #7223
->[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7222
[ET-VK] Adding function to set push constants in Command buffer. #7221
[ET-VK] Removing unnecessary and redundant members from StagingBuffer. #7220
[ET-VK] Store unique ptr to StagingBuffer and SymInt in Value instead of inlined object, to reduce Value struct size from 80 to 32 bytes. #7152

This diff adds a new struct called UniformData in the vTensor class to store uniform data, which can be shared with push constants. The UniformData struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor.

Diff adds Attribute enum to Tensor class to enumerate attributes supplied to dispatch and UniformData class to store tensor data supplied as uniforms to op shaders.

The diff also adds write_attribute function to UniformData class to write attribute data to a given memory.

Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

pytorch-bot · 2024-12-06T16:53:18Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7222

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8cf16cb with merge base b9db0a3 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-12-06T16:53:39Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T21:06:32Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T22:43:25Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-09T16:53:43Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/)

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

trviv · 2024-12-06T16:53:14Z

Stack from ghstack (oldest at bottom):

[ET-VK] Replace Uniform buffers with push constants for permute op #7231
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
[ET-VK] Replace Uniform buffers with push constants for view op #7229
[ET-VK] Adding convenience functions in Compute graph to get PushConstantDataInfo for various attributes of a tensor. #7224
[ET-VK] Add PushConstantDataInfo and vector to hold push constants data in DispatchNode. #7223
->[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7222
[ET-VK] Adding function to set push constants in Command buffer. #7221
[ET-VK] Removing unnecessary and redundant members from StagingBuffer. #7220
[ET-VK] Store unique ptr to StagingBuffer and SymInt in Value instead of inlined object, to reduce Value struct size from 80 to 32 bytes. #7152

This diff adds a new struct called UniformData in the vTensor class to store uniform data, which can be shared with push constants. The UniformData struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor.

Diff adds Attribute enum to Tensor class to enumerate attributes supplied to dispatch and UniformData class to store tensor data supplied as uniforms to op shaders.

The diff also adds write_attribute function to UniformData class to write attribute data to a given memory.

Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

pytorch-bot · 2024-12-06T16:53:18Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7222

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8cf16cb with merge base b9db0a3 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-12-06T16:53:39Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T21:06:32Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T22:43:25Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-09T16:53:43Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/)

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

trviv · 2024-12-06T16:53:14Z

Stack from ghstack (oldest at bottom):

[ET-VK] Replace Uniform buffers with push constants for permute op #7231
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
[ET-VK] Replace Uniform buffers with push constants for view op #7229
[ET-VK] Adding convenience functions in Compute graph to get PushConstantDataInfo for various attributes of a tensor. #7224
[ET-VK] Add PushConstantDataInfo and vector to hold push constants data in DispatchNode. #7223
->[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7222
[ET-VK] Adding function to set push constants in Command buffer. #7221
[ET-VK] Removing unnecessary and redundant members from StagingBuffer. #7220
[ET-VK] Store unique ptr to StagingBuffer and SymInt in Value instead of inlined object, to reduce Value struct size from 80 to 32 bytes. #7152

This diff adds a new struct called UniformData in the vTensor class to store uniform data, which can be shared with push constants. The UniformData struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor.

Diff adds Attribute enum to Tensor class to enumerate attributes supplied to dispatch and UniformData class to store tensor data supplied as uniforms to op shaders.

The diff also adds write_attribute function to UniformData class to write attribute data to a given memory.

Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

pytorch-bot · 2024-12-06T16:53:18Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7222

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8cf16cb with merge base b9db0a3 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-12-06T16:53:39Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T21:06:32Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T22:43:25Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-09T16:53:43Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/)

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

trviv · 2024-12-06T16:53:14Z

Stack from ghstack (oldest at bottom):

[ET-VK] Replace Uniform buffers with push constants for permute op #7231
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
[ET-VK] Replace Uniform buffers with push constants for view op #7229
[ET-VK] Adding convenience functions in Compute graph to get PushConstantDataInfo for various attributes of a tensor. #7224
[ET-VK] Add PushConstantDataInfo and vector to hold push constants data in DispatchNode. #7223
->[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7222
[ET-VK] Adding function to set push constants in Command buffer. #7221
[ET-VK] Removing unnecessary and redundant members from StagingBuffer. #7220
[ET-VK] Store unique ptr to StagingBuffer and SymInt in Value instead of inlined object, to reduce Value struct size from 80 to 32 bytes. #7152

This diff adds a new struct called UniformData in the vTensor class to store uniform data, which can be shared with push constants. The UniformData struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor.

Diff adds Attribute enum to Tensor class to enumerate attributes supplied to dispatch and UniformData class to store tensor data supplied as uniforms to op shaders.

The diff also adds write_attribute function to UniformData class to write attribute data to a given memory.

Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

pytorch-bot · 2024-12-06T16:53:18Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7222

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8cf16cb with merge base b9db0a3 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-12-06T16:53:39Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T21:06:32Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T22:43:25Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-09T16:53:43Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/)

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

trviv · 2024-12-06T16:53:14Z

Stack from ghstack (oldest at bottom):

[ET-VK] Replace Uniform buffers with push constants for permute op #7231
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
[ET-VK] Replace Uniform buffers with push constants for view op #7229
[ET-VK] Adding convenience functions in Compute graph to get PushConstantDataInfo for various attributes of a tensor. #7224
[ET-VK] Add PushConstantDataInfo and vector to hold push constants data in DispatchNode. #7223
->[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7222
[ET-VK] Adding function to set push constants in Command buffer. #7221
[ET-VK] Removing unnecessary and redundant members from StagingBuffer. #7220
[ET-VK] Store unique ptr to StagingBuffer and SymInt in Value instead of inlined object, to reduce Value struct size from 80 to 32 bytes. #7152

This diff adds a new struct called UniformData in the vTensor class to store uniform data, which can be shared with push constants. The UniformData struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor.

Diff adds Attribute enum to Tensor class to enumerate attributes supplied to dispatch and UniformData class to store tensor data supplied as uniforms to op shaders.

The diff also adds write_attribute function to UniformData class to write attribute data to a given memory.

Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

pytorch-bot · 2024-12-06T16:53:18Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7222

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8cf16cb with merge base b9db0a3 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-12-06T16:53:39Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T21:06:32Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T22:43:25Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-09T16:53:43Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/)

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

trviv · 2024-12-06T16:53:14Z

Stack from ghstack (oldest at bottom):

[ET-VK] Replace Uniform buffers with push constants for permute op #7231
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
[ET-VK] Replace Uniform buffers with push constants for view op #7229
[ET-VK] Adding convenience functions in Compute graph to get PushConstantDataInfo for various attributes of a tensor. #7224
[ET-VK] Add PushConstantDataInfo and vector to hold push constants data in DispatchNode. #7223
->[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7222
[ET-VK] Adding function to set push constants in Command buffer. #7221
[ET-VK] Removing unnecessary and redundant members from StagingBuffer. #7220
[ET-VK] Store unique ptr to StagingBuffer and SymInt in Value instead of inlined object, to reduce Value struct size from 80 to 32 bytes. #7152

This diff adds a new struct called UniformData in the vTensor class to store uniform data, which can be shared with push constants. The UniformData struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor.

Diff adds Attribute enum to Tensor class to enumerate attributes supplied to dispatch and UniformData class to store tensor data supplied as uniforms to op shaders.

The diff also adds write_attribute function to UniformData class to write attribute data to a given memory.

Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

pytorch-bot · 2024-12-06T16:53:18Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7222

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8cf16cb with merge base b9db0a3 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-12-06T16:53:39Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T21:06:32Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T22:43:25Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-09T16:53:43Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/)

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

trviv · 2024-12-06T16:53:14Z

Stack from ghstack (oldest at bottom):

[ET-VK] Replace Uniform buffers with push constants for permute op #7231
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
[ET-VK] Replace Uniform buffers with push constants for view op #7229
[ET-VK] Adding convenience functions in Compute graph to get PushConstantDataInfo for various attributes of a tensor. #7224
[ET-VK] Add PushConstantDataInfo and vector to hold push constants data in DispatchNode. #7223
->[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7222
[ET-VK] Adding function to set push constants in Command buffer. #7221
[ET-VK] Removing unnecessary and redundant members from StagingBuffer. #7220
[ET-VK] Store unique ptr to StagingBuffer and SymInt in Value instead of inlined object, to reduce Value struct size from 80 to 32 bytes. #7152

This diff adds a new struct called UniformData in the vTensor class to store uniform data, which can be shared with push constants. The UniformData struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor.

Diff adds Attribute enum to Tensor class to enumerate attributes supplied to dispatch and UniformData class to store tensor data supplied as uniforms to op shaders.

The diff also adds write_attribute function to UniformData class to write attribute data to a given memory.

Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

pytorch-bot · 2024-12-06T16:53:18Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7222

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8cf16cb with merge base b9db0a3 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-12-06T16:53:39Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T21:06:32Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T22:43:25Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-09T16:53:43Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/)

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

trviv · 2024-12-06T16:53:14Z

Stack from ghstack (oldest at bottom):

[ET-VK] Replace Uniform buffers with push constants for permute op #7231
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
[ET-VK] Replace Uniform buffers with push constants for view op #7229
[ET-VK] Adding convenience functions in Compute graph to get PushConstantDataInfo for various attributes of a tensor. #7224
[ET-VK] Add PushConstantDataInfo and vector to hold push constants data in DispatchNode. #7223
->[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7222
[ET-VK] Adding function to set push constants in Command buffer. #7221
[ET-VK] Removing unnecessary and redundant members from StagingBuffer. #7220
[ET-VK] Store unique ptr to StagingBuffer and SymInt in Value instead of inlined object, to reduce Value struct size from 80 to 32 bytes. #7152

This diff adds a new struct called UniformData in the vTensor class to store uniform data, which can be shared with push constants. The UniformData struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor.

Diff adds Attribute enum to Tensor class to enumerate attributes supplied to dispatch and UniformData class to store tensor data supplied as uniforms to op shaders.

The diff also adds write_attribute function to UniformData class to write attribute data to a given memory.

Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

pytorch-bot · 2024-12-06T16:53:18Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7222

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8cf16cb with merge base b9db0a3 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-12-06T16:53:39Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T21:06:32Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-06T22:43:25Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]

facebook-github-bot · 2024-12-09T16:53:43Z

This pull request was exported from Phabricator. Differential Revision: D66733611

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/)

…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024

facebook-github-bot added the fb-exported label Dec 6, 2024

trviv added the release notes: backends label Dec 6, 2024

SS-JIA approved these changes Dec 6, 2024
View reviewed changes

This was referenced Dec 6, 2024
[ET-VK] Replace Uniform buffers with push constants for view op #7229
Merged
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
Merged
[ET-VK] Replace Uniform buffers with push constants for permute op #7231
Merged

facebook-github-bot merged commit 11e858f into gh/trivedivivek/21/baseDec 9, 2024

facebook-github-bot deleted the gh/trivedivivek/21/head branch December 9, 2024 18:21

facebook-github-bot temporarily deployed to cherry-pick-bot December 9, 2024 18:21 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Dec 9, 2024
[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7251
Merged

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024

facebook-github-bot added the fb-exported label Dec 6, 2024

trviv added the release notes: backends label Dec 6, 2024

SS-JIA approved these changes Dec 6, 2024
View reviewed changes

This was referenced Dec 6, 2024
[ET-VK] Replace Uniform buffers with push constants for view op #7229
Merged
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
Merged
[ET-VK] Replace Uniform buffers with push constants for permute op #7231
Merged

facebook-github-bot merged commit 11e858f into gh/trivedivivek/21/baseDec 9, 2024

facebook-github-bot deleted the gh/trivedivivek/21/head branch December 9, 2024 18:21

facebook-github-bot temporarily deployed to cherry-pick-bot December 9, 2024 18:21 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Dec 9, 2024
[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7251
Merged

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024

facebook-github-bot added the fb-exported label Dec 6, 2024

trviv added the release notes: backends label Dec 6, 2024

SS-JIA approved these changes Dec 6, 2024
View reviewed changes

This was referenced Dec 6, 2024
[ET-VK] Replace Uniform buffers with push constants for view op #7229
Merged
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
Merged
[ET-VK] Replace Uniform buffers with push constants for permute op #7231
Merged

facebook-github-bot merged commit 11e858f into gh/trivedivivek/21/baseDec 9, 2024

facebook-github-bot deleted the gh/trivedivivek/21/head branch December 9, 2024 18:21

facebook-github-bot temporarily deployed to cherry-pick-bot December 9, 2024 18:21 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Dec 9, 2024
[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7251
Merged

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024

facebook-github-bot added the fb-exported label Dec 6, 2024

trviv added the release notes: backends label Dec 6, 2024

SS-JIA approved these changes Dec 6, 2024
View reviewed changes

This was referenced Dec 6, 2024
[ET-VK] Replace Uniform buffers with push constants for view op #7229
Merged
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
Merged
[ET-VK] Replace Uniform buffers with push constants for permute op #7231
Merged

facebook-github-bot merged commit 11e858f into gh/trivedivivek/21/baseDec 9, 2024

facebook-github-bot deleted the gh/trivedivivek/21/head branch December 9, 2024 18:21

facebook-github-bot temporarily deployed to cherry-pick-bot December 9, 2024 18:21 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Dec 9, 2024
[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7251
Merged

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024

facebook-github-bot added the fb-exported label Dec 6, 2024

trviv added the release notes: backends label Dec 6, 2024

SS-JIA approved these changes Dec 6, 2024
View reviewed changes

This was referenced Dec 6, 2024
[ET-VK] Replace Uniform buffers with push constants for view op #7229
Merged
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
Merged
[ET-VK] Replace Uniform buffers with push constants for permute op #7231
Merged

facebook-github-bot merged commit 11e858f into gh/trivedivivek/21/baseDec 9, 2024

facebook-github-bot deleted the gh/trivedivivek/21/head branch December 9, 2024 18:21

facebook-github-bot temporarily deployed to cherry-pick-bot December 9, 2024 18:21 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Dec 9, 2024
[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7251
Merged

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024

facebook-github-bot added the fb-exported label Dec 6, 2024

trviv added the release notes: backends label Dec 6, 2024

SS-JIA approved these changes Dec 6, 2024
View reviewed changes

This was referenced Dec 6, 2024
[ET-VK] Replace Uniform buffers with push constants for view op #7229
Merged
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
Merged
[ET-VK] Replace Uniform buffers with push constants for permute op #7231
Merged

facebook-github-bot merged commit 11e858f into gh/trivedivivek/21/baseDec 9, 2024

facebook-github-bot deleted the gh/trivedivivek/21/head branch December 9, 2024 18:21

facebook-github-bot temporarily deployed to cherry-pick-bot December 9, 2024 18:21 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Dec 9, 2024
[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7251
Merged

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024

facebook-github-bot added the fb-exported label Dec 6, 2024

trviv added the release notes: backends label Dec 6, 2024

SS-JIA approved these changes Dec 6, 2024
View reviewed changes

This was referenced Dec 6, 2024
[ET-VK] Replace Uniform buffers with push constants for view op #7229
Merged
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
Merged
[ET-VK] Replace Uniform buffers with push constants for permute op #7231
Merged

facebook-github-bot merged commit 11e858f into gh/trivedivivek/21/baseDec 9, 2024

facebook-github-bot deleted the gh/trivedivivek/21/head branch December 9, 2024 18:21

facebook-github-bot temporarily deployed to cherry-pick-bot December 9, 2024 18:21 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Dec 9, 2024
[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7251
Merged

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024

facebook-github-bot added the fb-exported label Dec 6, 2024

trviv added the release notes: backends label Dec 6, 2024

SS-JIA approved these changes Dec 6, 2024
View reviewed changes

This was referenced Dec 6, 2024
[ET-VK] Replace Uniform buffers with push constants for view op #7229
Merged
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
Merged
[ET-VK] Replace Uniform buffers with push constants for permute op #7231
Merged

facebook-github-bot merged commit 11e858f into gh/trivedivivek/21/baseDec 9, 2024

facebook-github-bot deleted the gh/trivedivivek/21/head branch December 9, 2024 18:21

facebook-github-bot temporarily deployed to cherry-pick-bot December 9, 2024 18:21 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Dec 9, 2024
[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7251
Merged

Uh oh!

Conversation

trviv commented Dec 6, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-botBot commented Dec 6, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7222

✅ No Failures

Uh oh!

facebook-github-bot commented Dec 6, 2024

Uh oh!

facebook-github-bot commented Dec 6, 2024

Uh oh!

facebook-github-bot commented Dec 6, 2024

Uh oh!

facebook-github-bot commented Dec 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

trviv commented Dec 6, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-botBot commented Dec 6, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7222

✅ No Failures

Uh oh!

facebook-github-bot commented Dec 6, 2024

Uh oh!

facebook-github-bot commented Dec 6, 2024

Uh oh!

facebook-github-bot commented Dec 6, 2024

Uh oh!

facebook-github-bot commented Dec 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

trviv commented Dec 6, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-botBot commented Dec 6, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7222

✅ No Failures

Uh oh!

facebook-github-bot commented Dec 6, 2024

Uh oh!

facebook-github-bot commented Dec 6, 2024

Uh oh!

facebook-github-bot commented Dec 6, 2024

Uh oh!

facebook-github-bot commented Dec 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

trviv commented Dec 6, 2024•
edited
Loading

pytorch-botBot commented Dec 6, 2024•
edited
Loading

trviv commented Dec 6, 2024•
edited
Loading

pytorch-botBot commented Dec 6, 2024•
edited
Loading

trviv commented Dec 6, 2024•
edited
Loading

pytorch-botBot commented Dec 6, 2024•
edited
Loading

trviv commented Dec 6, 2024•
edited
Loading

pytorch-botBot commented Dec 6, 2024•
edited
Loading

trviv commented Dec 6, 2024•
edited
Loading

pytorch-botBot commented Dec 6, 2024•
edited
Loading