Skip to content

Update buck2 to 2024-12-16 - #7448

Merged
swolchok merged 2 commits into
mainfrom
update-buck2
Jan 7, 2025
Merged

Update buck2 to 2024-12-16#7448
swolchok merged 2 commits into
mainfrom
update-buck2

Conversation

@swolchok

@swolchokswolchok commented Dec 27, 2024

Copy link
Copy Markdown
Contributor

Summary

Fixes#7425. Filed facebook/buck2#828 to make this easier in the future.

Test plan

Relying on CI. Manually confirmed that this unblocks building on Raspberry Pi 5 (though there is at least one more build break underneath).

@pytorch-bot

pytorch-botBot commented Dec 27, 2024

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7448

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 2764f3d with merge base 62c6346 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 27, 2024
@swolchokswolchok added release notes: devtools Changes to dev tooling, for example the debugger & profiler release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. and removed release notes: devtools Changes to dev tooling, for example the debugger & profiler labels Jan 2, 2025
@swolchok

Copy link
Copy Markdown
ContributorAuthor

build-benchmark-app failure (and others?) appear to be unrelated: ```2024-12-27T17:51:57.9062520Z /Users/runner/work/_temp/44702da2-4c2d-4eb2-a2a6-7352a08c1006.sh: line 10: /Users/runner/work/_temp/github_env_12519068607: No such file or directory

Fixes#7425. Filed facebook/buck2#828 to make this easier in the future.
@swolchok

Copy link
Copy Markdown
ContributorAuthor

zstd: buck2-aarch64-apple-darwin-2024-12-16.zst: unsupported format

wat

@swolchok

Copy link
Copy Markdown
ContributorAuthor

wait, why are we fetching buck from some custom server instead of github?

@swolchok

Copy link
Copy Markdown
ContributorAuthor

wait, why are we fetching buck from some custom server instead of github?

https://github.com/pytorch/executorch/blob/main/.ci/scripts/setup-macos.sh#L31

contacting PT Dev Infra now

Comment threadthird-party/prelude

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm that this 3rd-party update is expected

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prelude versions are matched to buck versions; we have to do the update

@swolchok

Copy link
Copy Markdown
ContributorAuthor

test-demo-ios has been red for weeks. ignoring and landing.

@swolchok
swolchok merged commit 6c9b9b6 into mainJan 7, 2025
@swolchok
swolchok deleted the update-buck2 branch January 7, 2025 23:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

buck2 needs to be updated past https://github.com/facebook/buck2/pull/693 (June 28, 2024) so executorch can build on Raspberry Pi 5

4 participants

@swolchok@huydhn@mergennachin@facebook-github-bot