[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. by trviv · Pull Request #7485 · pytorch/executorch

trviv · 2025-01-03T00:12:55Z

Stack from ghstack (oldest at bottom):

->[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7485
[ET-VK] Changing texture access pattern for conv2d dw ops to improve performance. #7477
[ET-VK] Changing texture access pattern for conv2d pw op to improve performance. #7476
[ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. #7475
[ET-VK] Using vec2 to store output positions to reudce shader register footprint. #7474
[ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. #7452
[ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. #7450
[ET-VK] [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. #7447

This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation.

Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

pytorch-bot · 2025-01-03T00:12:58Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7485

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fdc9997 with merge base 45bb2dd ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-01-03T00:13:30Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) ghstack-source-id: 260053926 Pull Request resolved: #7485

…hing input texel and kernel values for reuse." This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

facebook-github-bot · 2025-01-03T20:36:37Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/)

…texel and kernel values for reuse. (#7506) * [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. Pull Request resolved: #7447 This diff reduces the precision of all int storage in the conv pw op to improve performance. The code changes include adding the extension GL_EXT_shader_explicit_arithmetic_types_int16 and changing the data type of ints to uint16. ghstack-source-id: 260166244 @exported-using-ghexport Differential Revision: [D67674212](https://our.internmc.facebook.com/intern/diff/D67674212/) * [ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. Pull Request resolved: #7450 This diff contains changes to the Convolution.cpp file in the Vulkan backend of Executorch. The changes involve updating the code to use the create_conv2d_global_wg_size function to determine the local workgroup size for the convolution operation. This is done to ensure that the correct workgroup size is used for the operation, which can improve performance. ghstack-source-id: 260166246 @exported-using-ghexport Differential Revision: [D67676422](https://our.internmc.facebook.com/intern/diff/D67676422/) * [ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. Pull Request resolved: #7452 This diff modifies the convolution 2D pointwise op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. ghstack-source-id: 260166247 @exported-using-ghexport Differential Revision: [D67683411](https://our.internmc.facebook.com/intern/diff/D67683411/) * [ET-VK] Using vec2 to store output positions to reudce shader register footprint. Pull Request resolved: #7474 The diff changes the use of `u16vec3` to `u16vec2` to store output positions in the conv2d_pw op. This change is made to reduce the shader register footprint and improve performance. ghstack-source-id: 260166245 @exported-using-ghexport Differential Revision: [D67726229](https://our.internmc.facebook.com/intern/diff/D67726229/) * [ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. Pull Request resolved: #7475 This diff introduces a shared variable to store calculated output pose in conv2d_pw op to free up registers and improve performance. The code changes include adding a shared variable to hold calculated positions and modifying the existing code to use the shared variable. ghstack-source-id: 260166242 Differential Revision: [D67742567](https://our.internmc.facebook.com/intern/diff/D67742567/) * [ET-VK] Changing texture access pattern for conv2d pw op to improve performance. Pull Request resolved: #7476 This diff changes the texture access pattern for conv2d pw op to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166241 @exported-using-ghexport Differential Revision: [D67769100](https://our.internmc.facebook.com/intern/diff/D67769100/) * [ET-VK] Changing texture access pattern for conv2d dw op to improve performance. Pull Request resolved: #7477 This diff changes the texture access pattern for convolutional depthwise (DW) operations in Executorch's Vulkan backend to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166240 @exported-using-ghexport Differential Revision: [D67770160](https://our.internmc.facebook.com/intern/diff/D67770160/) * [ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

trviv · 2025-01-03T00:12:55Z

Stack from ghstack (oldest at bottom):

->[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7485
[ET-VK] Changing texture access pattern for conv2d dw ops to improve performance. #7477
[ET-VK] Changing texture access pattern for conv2d pw op to improve performance. #7476
[ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. #7475
[ET-VK] Using vec2 to store output positions to reudce shader register footprint. #7474
[ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. #7452
[ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. #7450
[ET-VK] [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. #7447

This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation.

Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

pytorch-bot · 2025-01-03T00:12:58Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7485

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fdc9997 with merge base 45bb2dd ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-01-03T00:13:30Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) ghstack-source-id: 260053926 Pull Request resolved: #7485

…hing input texel and kernel values for reuse." This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

facebook-github-bot · 2025-01-03T20:36:37Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/)

…texel and kernel values for reuse. (#7506) * [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. Pull Request resolved: #7447 This diff reduces the precision of all int storage in the conv pw op to improve performance. The code changes include adding the extension GL_EXT_shader_explicit_arithmetic_types_int16 and changing the data type of ints to uint16. ghstack-source-id: 260166244 @exported-using-ghexport Differential Revision: [D67674212](https://our.internmc.facebook.com/intern/diff/D67674212/) * [ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. Pull Request resolved: #7450 This diff contains changes to the Convolution.cpp file in the Vulkan backend of Executorch. The changes involve updating the code to use the create_conv2d_global_wg_size function to determine the local workgroup size for the convolution operation. This is done to ensure that the correct workgroup size is used for the operation, which can improve performance. ghstack-source-id: 260166246 @exported-using-ghexport Differential Revision: [D67676422](https://our.internmc.facebook.com/intern/diff/D67676422/) * [ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. Pull Request resolved: #7452 This diff modifies the convolution 2D pointwise op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. ghstack-source-id: 260166247 @exported-using-ghexport Differential Revision: [D67683411](https://our.internmc.facebook.com/intern/diff/D67683411/) * [ET-VK] Using vec2 to store output positions to reudce shader register footprint. Pull Request resolved: #7474 The diff changes the use of `u16vec3` to `u16vec2` to store output positions in the conv2d_pw op. This change is made to reduce the shader register footprint and improve performance. ghstack-source-id: 260166245 @exported-using-ghexport Differential Revision: [D67726229](https://our.internmc.facebook.com/intern/diff/D67726229/) * [ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. Pull Request resolved: #7475 This diff introduces a shared variable to store calculated output pose in conv2d_pw op to free up registers and improve performance. The code changes include adding a shared variable to hold calculated positions and modifying the existing code to use the shared variable. ghstack-source-id: 260166242 Differential Revision: [D67742567](https://our.internmc.facebook.com/intern/diff/D67742567/) * [ET-VK] Changing texture access pattern for conv2d pw op to improve performance. Pull Request resolved: #7476 This diff changes the texture access pattern for conv2d pw op to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166241 @exported-using-ghexport Differential Revision: [D67769100](https://our.internmc.facebook.com/intern/diff/D67769100/) * [ET-VK] Changing texture access pattern for conv2d dw op to improve performance. Pull Request resolved: #7477 This diff changes the texture access pattern for convolutional depthwise (DW) operations in Executorch's Vulkan backend to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166240 @exported-using-ghexport Differential Revision: [D67770160](https://our.internmc.facebook.com/intern/diff/D67770160/) * [ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

trviv · 2025-01-03T00:12:55Z

Stack from ghstack (oldest at bottom):

->[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7485
[ET-VK] Changing texture access pattern for conv2d dw ops to improve performance. #7477
[ET-VK] Changing texture access pattern for conv2d pw op to improve performance. #7476
[ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. #7475
[ET-VK] Using vec2 to store output positions to reudce shader register footprint. #7474
[ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. #7452
[ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. #7450
[ET-VK] [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. #7447

This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation.

Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

pytorch-bot · 2025-01-03T00:12:58Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7485

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fdc9997 with merge base 45bb2dd ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-01-03T00:13:30Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) ghstack-source-id: 260053926 Pull Request resolved: #7485

…hing input texel and kernel values for reuse." This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

facebook-github-bot · 2025-01-03T20:36:37Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/)

…texel and kernel values for reuse. (#7506) * [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. Pull Request resolved: #7447 This diff reduces the precision of all int storage in the conv pw op to improve performance. The code changes include adding the extension GL_EXT_shader_explicit_arithmetic_types_int16 and changing the data type of ints to uint16. ghstack-source-id: 260166244 @exported-using-ghexport Differential Revision: [D67674212](https://our.internmc.facebook.com/intern/diff/D67674212/) * [ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. Pull Request resolved: #7450 This diff contains changes to the Convolution.cpp file in the Vulkan backend of Executorch. The changes involve updating the code to use the create_conv2d_global_wg_size function to determine the local workgroup size for the convolution operation. This is done to ensure that the correct workgroup size is used for the operation, which can improve performance. ghstack-source-id: 260166246 @exported-using-ghexport Differential Revision: [D67676422](https://our.internmc.facebook.com/intern/diff/D67676422/) * [ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. Pull Request resolved: #7452 This diff modifies the convolution 2D pointwise op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. ghstack-source-id: 260166247 @exported-using-ghexport Differential Revision: [D67683411](https://our.internmc.facebook.com/intern/diff/D67683411/) * [ET-VK] Using vec2 to store output positions to reudce shader register footprint. Pull Request resolved: #7474 The diff changes the use of `u16vec3` to `u16vec2` to store output positions in the conv2d_pw op. This change is made to reduce the shader register footprint and improve performance. ghstack-source-id: 260166245 @exported-using-ghexport Differential Revision: [D67726229](https://our.internmc.facebook.com/intern/diff/D67726229/) * [ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. Pull Request resolved: #7475 This diff introduces a shared variable to store calculated output pose in conv2d_pw op to free up registers and improve performance. The code changes include adding a shared variable to hold calculated positions and modifying the existing code to use the shared variable. ghstack-source-id: 260166242 Differential Revision: [D67742567](https://our.internmc.facebook.com/intern/diff/D67742567/) * [ET-VK] Changing texture access pattern for conv2d pw op to improve performance. Pull Request resolved: #7476 This diff changes the texture access pattern for conv2d pw op to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166241 @exported-using-ghexport Differential Revision: [D67769100](https://our.internmc.facebook.com/intern/diff/D67769100/) * [ET-VK] Changing texture access pattern for conv2d dw op to improve performance. Pull Request resolved: #7477 This diff changes the texture access pattern for convolutional depthwise (DW) operations in Executorch's Vulkan backend to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166240 @exported-using-ghexport Differential Revision: [D67770160](https://our.internmc.facebook.com/intern/diff/D67770160/) * [ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

trviv · 2025-01-03T00:12:55Z

Stack from ghstack (oldest at bottom):

->[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7485
[ET-VK] Changing texture access pattern for conv2d dw ops to improve performance. #7477
[ET-VK] Changing texture access pattern for conv2d pw op to improve performance. #7476
[ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. #7475
[ET-VK] Using vec2 to store output positions to reudce shader register footprint. #7474
[ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. #7452
[ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. #7450
[ET-VK] [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. #7447

This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation.

Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

pytorch-bot · 2025-01-03T00:12:58Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7485

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fdc9997 with merge base 45bb2dd ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-01-03T00:13:30Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) ghstack-source-id: 260053926 Pull Request resolved: #7485

…hing input texel and kernel values for reuse." This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

facebook-github-bot · 2025-01-03T20:36:37Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/)

…texel and kernel values for reuse. (#7506) * [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. Pull Request resolved: #7447 This diff reduces the precision of all int storage in the conv pw op to improve performance. The code changes include adding the extension GL_EXT_shader_explicit_arithmetic_types_int16 and changing the data type of ints to uint16. ghstack-source-id: 260166244 @exported-using-ghexport Differential Revision: [D67674212](https://our.internmc.facebook.com/intern/diff/D67674212/) * [ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. Pull Request resolved: #7450 This diff contains changes to the Convolution.cpp file in the Vulkan backend of Executorch. The changes involve updating the code to use the create_conv2d_global_wg_size function to determine the local workgroup size for the convolution operation. This is done to ensure that the correct workgroup size is used for the operation, which can improve performance. ghstack-source-id: 260166246 @exported-using-ghexport Differential Revision: [D67676422](https://our.internmc.facebook.com/intern/diff/D67676422/) * [ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. Pull Request resolved: #7452 This diff modifies the convolution 2D pointwise op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. ghstack-source-id: 260166247 @exported-using-ghexport Differential Revision: [D67683411](https://our.internmc.facebook.com/intern/diff/D67683411/) * [ET-VK] Using vec2 to store output positions to reudce shader register footprint. Pull Request resolved: #7474 The diff changes the use of `u16vec3` to `u16vec2` to store output positions in the conv2d_pw op. This change is made to reduce the shader register footprint and improve performance. ghstack-source-id: 260166245 @exported-using-ghexport Differential Revision: [D67726229](https://our.internmc.facebook.com/intern/diff/D67726229/) * [ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. Pull Request resolved: #7475 This diff introduces a shared variable to store calculated output pose in conv2d_pw op to free up registers and improve performance. The code changes include adding a shared variable to hold calculated positions and modifying the existing code to use the shared variable. ghstack-source-id: 260166242 Differential Revision: [D67742567](https://our.internmc.facebook.com/intern/diff/D67742567/) * [ET-VK] Changing texture access pattern for conv2d pw op to improve performance. Pull Request resolved: #7476 This diff changes the texture access pattern for conv2d pw op to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166241 @exported-using-ghexport Differential Revision: [D67769100](https://our.internmc.facebook.com/intern/diff/D67769100/) * [ET-VK] Changing texture access pattern for conv2d dw op to improve performance. Pull Request resolved: #7477 This diff changes the texture access pattern for convolutional depthwise (DW) operations in Executorch's Vulkan backend to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166240 @exported-using-ghexport Differential Revision: [D67770160](https://our.internmc.facebook.com/intern/diff/D67770160/) * [ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

trviv · 2025-01-03T00:12:55Z

Stack from ghstack (oldest at bottom):

->[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7485
[ET-VK] Changing texture access pattern for conv2d dw ops to improve performance. #7477
[ET-VK] Changing texture access pattern for conv2d pw op to improve performance. #7476
[ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. #7475
[ET-VK] Using vec2 to store output positions to reudce shader register footprint. #7474
[ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. #7452
[ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. #7450
[ET-VK] [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. #7447

This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation.

Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

pytorch-bot · 2025-01-03T00:12:58Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7485

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fdc9997 with merge base 45bb2dd ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-01-03T00:13:30Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) ghstack-source-id: 260053926 Pull Request resolved: #7485

…hing input texel and kernel values for reuse." This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

facebook-github-bot · 2025-01-03T20:36:37Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/)

…texel and kernel values for reuse. (#7506) * [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. Pull Request resolved: #7447 This diff reduces the precision of all int storage in the conv pw op to improve performance. The code changes include adding the extension GL_EXT_shader_explicit_arithmetic_types_int16 and changing the data type of ints to uint16. ghstack-source-id: 260166244 @exported-using-ghexport Differential Revision: [D67674212](https://our.internmc.facebook.com/intern/diff/D67674212/) * [ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. Pull Request resolved: #7450 This diff contains changes to the Convolution.cpp file in the Vulkan backend of Executorch. The changes involve updating the code to use the create_conv2d_global_wg_size function to determine the local workgroup size for the convolution operation. This is done to ensure that the correct workgroup size is used for the operation, which can improve performance. ghstack-source-id: 260166246 @exported-using-ghexport Differential Revision: [D67676422](https://our.internmc.facebook.com/intern/diff/D67676422/) * [ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. Pull Request resolved: #7452 This diff modifies the convolution 2D pointwise op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. ghstack-source-id: 260166247 @exported-using-ghexport Differential Revision: [D67683411](https://our.internmc.facebook.com/intern/diff/D67683411/) * [ET-VK] Using vec2 to store output positions to reudce shader register footprint. Pull Request resolved: #7474 The diff changes the use of `u16vec3` to `u16vec2` to store output positions in the conv2d_pw op. This change is made to reduce the shader register footprint and improve performance. ghstack-source-id: 260166245 @exported-using-ghexport Differential Revision: [D67726229](https://our.internmc.facebook.com/intern/diff/D67726229/) * [ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. Pull Request resolved: #7475 This diff introduces a shared variable to store calculated output pose in conv2d_pw op to free up registers and improve performance. The code changes include adding a shared variable to hold calculated positions and modifying the existing code to use the shared variable. ghstack-source-id: 260166242 Differential Revision: [D67742567](https://our.internmc.facebook.com/intern/diff/D67742567/) * [ET-VK] Changing texture access pattern for conv2d pw op to improve performance. Pull Request resolved: #7476 This diff changes the texture access pattern for conv2d pw op to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166241 @exported-using-ghexport Differential Revision: [D67769100](https://our.internmc.facebook.com/intern/diff/D67769100/) * [ET-VK] Changing texture access pattern for conv2d dw op to improve performance. Pull Request resolved: #7477 This diff changes the texture access pattern for convolutional depthwise (DW) operations in Executorch's Vulkan backend to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166240 @exported-using-ghexport Differential Revision: [D67770160](https://our.internmc.facebook.com/intern/diff/D67770160/) * [ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

trviv · 2025-01-03T00:12:55Z

Stack from ghstack (oldest at bottom):

->[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7485
[ET-VK] Changing texture access pattern for conv2d dw ops to improve performance. #7477
[ET-VK] Changing texture access pattern for conv2d pw op to improve performance. #7476
[ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. #7475
[ET-VK] Using vec2 to store output positions to reudce shader register footprint. #7474
[ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. #7452
[ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. #7450
[ET-VK] [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. #7447

This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation.

Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

pytorch-bot · 2025-01-03T00:12:58Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7485

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fdc9997 with merge base 45bb2dd ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-01-03T00:13:30Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) ghstack-source-id: 260053926 Pull Request resolved: #7485

…hing input texel and kernel values for reuse." This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

facebook-github-bot · 2025-01-03T20:36:37Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/)

…texel and kernel values for reuse. (#7506) * [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. Pull Request resolved: #7447 This diff reduces the precision of all int storage in the conv pw op to improve performance. The code changes include adding the extension GL_EXT_shader_explicit_arithmetic_types_int16 and changing the data type of ints to uint16. ghstack-source-id: 260166244 @exported-using-ghexport Differential Revision: [D67674212](https://our.internmc.facebook.com/intern/diff/D67674212/) * [ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. Pull Request resolved: #7450 This diff contains changes to the Convolution.cpp file in the Vulkan backend of Executorch. The changes involve updating the code to use the create_conv2d_global_wg_size function to determine the local workgroup size for the convolution operation. This is done to ensure that the correct workgroup size is used for the operation, which can improve performance. ghstack-source-id: 260166246 @exported-using-ghexport Differential Revision: [D67676422](https://our.internmc.facebook.com/intern/diff/D67676422/) * [ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. Pull Request resolved: #7452 This diff modifies the convolution 2D pointwise op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. ghstack-source-id: 260166247 @exported-using-ghexport Differential Revision: [D67683411](https://our.internmc.facebook.com/intern/diff/D67683411/) * [ET-VK] Using vec2 to store output positions to reudce shader register footprint. Pull Request resolved: #7474 The diff changes the use of `u16vec3` to `u16vec2` to store output positions in the conv2d_pw op. This change is made to reduce the shader register footprint and improve performance. ghstack-source-id: 260166245 @exported-using-ghexport Differential Revision: [D67726229](https://our.internmc.facebook.com/intern/diff/D67726229/) * [ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. Pull Request resolved: #7475 This diff introduces a shared variable to store calculated output pose in conv2d_pw op to free up registers and improve performance. The code changes include adding a shared variable to hold calculated positions and modifying the existing code to use the shared variable. ghstack-source-id: 260166242 Differential Revision: [D67742567](https://our.internmc.facebook.com/intern/diff/D67742567/) * [ET-VK] Changing texture access pattern for conv2d pw op to improve performance. Pull Request resolved: #7476 This diff changes the texture access pattern for conv2d pw op to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166241 @exported-using-ghexport Differential Revision: [D67769100](https://our.internmc.facebook.com/intern/diff/D67769100/) * [ET-VK] Changing texture access pattern for conv2d dw op to improve performance. Pull Request resolved: #7477 This diff changes the texture access pattern for convolutional depthwise (DW) operations in Executorch's Vulkan backend to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166240 @exported-using-ghexport Differential Revision: [D67770160](https://our.internmc.facebook.com/intern/diff/D67770160/) * [ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

trviv · 2025-01-03T00:12:55Z

Stack from ghstack (oldest at bottom):

->[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7485
[ET-VK] Changing texture access pattern for conv2d dw ops to improve performance. #7477
[ET-VK] Changing texture access pattern for conv2d pw op to improve performance. #7476
[ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. #7475
[ET-VK] Using vec2 to store output positions to reudce shader register footprint. #7474
[ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. #7452
[ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. #7450
[ET-VK] [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. #7447

This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation.

Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

pytorch-bot · 2025-01-03T00:12:58Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7485

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fdc9997 with merge base 45bb2dd ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-01-03T00:13:30Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) ghstack-source-id: 260053926 Pull Request resolved: #7485

…hing input texel and kernel values for reuse." This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

facebook-github-bot · 2025-01-03T20:36:37Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/)

…texel and kernel values for reuse. (#7506) * [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. Pull Request resolved: #7447 This diff reduces the precision of all int storage in the conv pw op to improve performance. The code changes include adding the extension GL_EXT_shader_explicit_arithmetic_types_int16 and changing the data type of ints to uint16. ghstack-source-id: 260166244 @exported-using-ghexport Differential Revision: [D67674212](https://our.internmc.facebook.com/intern/diff/D67674212/) * [ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. Pull Request resolved: #7450 This diff contains changes to the Convolution.cpp file in the Vulkan backend of Executorch. The changes involve updating the code to use the create_conv2d_global_wg_size function to determine the local workgroup size for the convolution operation. This is done to ensure that the correct workgroup size is used for the operation, which can improve performance. ghstack-source-id: 260166246 @exported-using-ghexport Differential Revision: [D67676422](https://our.internmc.facebook.com/intern/diff/D67676422/) * [ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. Pull Request resolved: #7452 This diff modifies the convolution 2D pointwise op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. ghstack-source-id: 260166247 @exported-using-ghexport Differential Revision: [D67683411](https://our.internmc.facebook.com/intern/diff/D67683411/) * [ET-VK] Using vec2 to store output positions to reudce shader register footprint. Pull Request resolved: #7474 The diff changes the use of `u16vec3` to `u16vec2` to store output positions in the conv2d_pw op. This change is made to reduce the shader register footprint and improve performance. ghstack-source-id: 260166245 @exported-using-ghexport Differential Revision: [D67726229](https://our.internmc.facebook.com/intern/diff/D67726229/) * [ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. Pull Request resolved: #7475 This diff introduces a shared variable to store calculated output pose in conv2d_pw op to free up registers and improve performance. The code changes include adding a shared variable to hold calculated positions and modifying the existing code to use the shared variable. ghstack-source-id: 260166242 Differential Revision: [D67742567](https://our.internmc.facebook.com/intern/diff/D67742567/) * [ET-VK] Changing texture access pattern for conv2d pw op to improve performance. Pull Request resolved: #7476 This diff changes the texture access pattern for conv2d pw op to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166241 @exported-using-ghexport Differential Revision: [D67769100](https://our.internmc.facebook.com/intern/diff/D67769100/) * [ET-VK] Changing texture access pattern for conv2d dw op to improve performance. Pull Request resolved: #7477 This diff changes the texture access pattern for convolutional depthwise (DW) operations in Executorch's Vulkan backend to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166240 @exported-using-ghexport Differential Revision: [D67770160](https://our.internmc.facebook.com/intern/diff/D67770160/) * [ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

trviv · 2025-01-03T00:12:55Z

Stack from ghstack (oldest at bottom):

->[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7485
[ET-VK] Changing texture access pattern for conv2d dw ops to improve performance. #7477
[ET-VK] Changing texture access pattern for conv2d pw op to improve performance. #7476
[ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. #7475
[ET-VK] Using vec2 to store output positions to reudce shader register footprint. #7474
[ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. #7452
[ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. #7450
[ET-VK] [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. #7447

This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation.

Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

pytorch-bot · 2025-01-03T00:12:58Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7485

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fdc9997 with merge base 45bb2dd ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-01-03T00:13:30Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) ghstack-source-id: 260053926 Pull Request resolved: #7485

…hing input texel and kernel values for reuse." This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) [ghstack-poisoned]

facebook-github-bot · 2025-01-03T20:36:37Z

This pull request was exported from Phabricator. Differential Revision: D67774359

…texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/)

…texel and kernel values for reuse. (#7506) * [ET-VK] Reduced int precision for all int storage in conv pw op to improve performance. Pull Request resolved: #7447 This diff reduces the precision of all int storage in the conv pw op to improve performance. The code changes include adding the extension GL_EXT_shader_explicit_arithmetic_types_int16 and changing the data type of ints to uint16. ghstack-source-id: 260166244 @exported-using-ghexport Differential Revision: [D67674212](https://our.internmc.facebook.com/intern/diff/D67674212/) * [ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. Pull Request resolved: #7450 This diff contains changes to the Convolution.cpp file in the Vulkan backend of Executorch. The changes involve updating the code to use the create_conv2d_global_wg_size function to determine the local workgroup size for the convolution operation. This is done to ensure that the correct workgroup size is used for the operation, which can improve performance. ghstack-source-id: 260166246 @exported-using-ghexport Differential Revision: [D67676422](https://our.internmc.facebook.com/intern/diff/D67676422/) * [ET-VK] Modify conv 2d pw op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. Pull Request resolved: #7452 This diff modifies the convolution 2D pointwise op shader and dispatch settings to linearly dispatch work accounting for linearity texture to improve performance. ghstack-source-id: 260166247 @exported-using-ghexport Differential Revision: [D67683411](https://our.internmc.facebook.com/intern/diff/D67683411/) * [ET-VK] Using vec2 to store output positions to reudce shader register footprint. Pull Request resolved: #7474 The diff changes the use of `u16vec3` to `u16vec2` to store output positions in the conv2d_pw op. This change is made to reduce the shader register footprint and improve performance. ghstack-source-id: 260166245 @exported-using-ghexport Differential Revision: [D67726229](https://our.internmc.facebook.com/intern/diff/D67726229/) * [ET-VK] Using shared variable to store calculated output pose to free up registers and improve performance. Pull Request resolved: #7475 This diff introduces a shared variable to store calculated output pose in conv2d_pw op to free up registers and improve performance. The code changes include adding a shared variable to hold calculated positions and modifying the existing code to use the shared variable. ghstack-source-id: 260166242 Differential Revision: [D67742567](https://our.internmc.facebook.com/intern/diff/D67742567/) * [ET-VK] Changing texture access pattern for conv2d pw op to improve performance. Pull Request resolved: #7476 This diff changes the texture access pattern for conv2d pw op to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166241 @exported-using-ghexport Differential Revision: [D67769100](https://our.internmc.facebook.com/intern/diff/D67769100/) * [ET-VK] Changing texture access pattern for conv2d dw op to improve performance. Pull Request resolved: #7477 This diff changes the texture access pattern for convolutional depthwise (DW) operations in Executorch's Vulkan backend to iterate first on x axis then y and then z to improve performance. ghstack-source-id: 260166240 @exported-using-ghexport Differential Revision: [D67770160](https://our.internmc.facebook.com/intern/diff/D67770160/) * [ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. Pull Request resolved: #7485 This diff adds batch processing to the conv2d dw shader by caching input texel and kernel values for reuse. This optimization reduces the number of texture lookups and kernel computations, improving the performance of the convolution operation. ghstack-source-id: 260166243 @exported-using-ghexport Differential Revision: [D67774359](https://our.internmc.facebook.com/intern/diff/D67774359/) --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025

facebook-github-bot added the fb-exported label Jan 3, 2025

SS-JIA approved these changes Jan 3, 2025
View reviewed changes

SS-JIA added the topic: not user facing label Jan 3, 2025

facebook-github-bot merged commit 3ead5c9 into gh/trivedivivek/36/baseJan 3, 2025

facebook-github-bot deleted the gh/trivedivivek/36/head branch January 3, 2025 22:47

pytorchbot mentioned this pull request Jan 3, 2025
[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7506
Merged

facebook-github-bot temporarily deployed to cherry-pick-bot January 3, 2025 22:47 — with GitHub Actions Inactive

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025

facebook-github-bot added the fb-exported label Jan 3, 2025

SS-JIA approved these changes Jan 3, 2025
View reviewed changes

SS-JIA added the topic: not user facing label Jan 3, 2025

facebook-github-bot merged commit 3ead5c9 into gh/trivedivivek/36/baseJan 3, 2025

facebook-github-bot deleted the gh/trivedivivek/36/head branch January 3, 2025 22:47

pytorchbot mentioned this pull request Jan 3, 2025
[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7506
Merged

facebook-github-bot temporarily deployed to cherry-pick-bot January 3, 2025 22:47 — with GitHub Actions Inactive

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025

facebook-github-bot added the fb-exported label Jan 3, 2025

SS-JIA approved these changes Jan 3, 2025
View reviewed changes

SS-JIA added the topic: not user facing label Jan 3, 2025

facebook-github-bot merged commit 3ead5c9 into gh/trivedivivek/36/baseJan 3, 2025

facebook-github-bot deleted the gh/trivedivivek/36/head branch January 3, 2025 22:47

pytorchbot mentioned this pull request Jan 3, 2025
[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7506
Merged

facebook-github-bot temporarily deployed to cherry-pick-bot January 3, 2025 22:47 — with GitHub Actions Inactive

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025

facebook-github-bot added the fb-exported label Jan 3, 2025

SS-JIA approved these changes Jan 3, 2025
View reviewed changes

SS-JIA added the topic: not user facing label Jan 3, 2025

facebook-github-bot merged commit 3ead5c9 into gh/trivedivivek/36/baseJan 3, 2025

facebook-github-bot deleted the gh/trivedivivek/36/head branch January 3, 2025 22:47

pytorchbot mentioned this pull request Jan 3, 2025
[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7506
Merged

facebook-github-bot temporarily deployed to cherry-pick-bot January 3, 2025 22:47 — with GitHub Actions Inactive

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025

facebook-github-bot added the fb-exported label Jan 3, 2025

SS-JIA approved these changes Jan 3, 2025
View reviewed changes

SS-JIA added the topic: not user facing label Jan 3, 2025

facebook-github-bot merged commit 3ead5c9 into gh/trivedivivek/36/baseJan 3, 2025

facebook-github-bot deleted the gh/trivedivivek/36/head branch January 3, 2025 22:47

pytorchbot mentioned this pull request Jan 3, 2025
[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7506
Merged

facebook-github-bot temporarily deployed to cherry-pick-bot January 3, 2025 22:47 — with GitHub Actions Inactive

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025

facebook-github-bot added the fb-exported label Jan 3, 2025

SS-JIA approved these changes Jan 3, 2025
View reviewed changes

SS-JIA added the topic: not user facing label Jan 3, 2025

facebook-github-bot merged commit 3ead5c9 into gh/trivedivivek/36/baseJan 3, 2025

facebook-github-bot deleted the gh/trivedivivek/36/head branch January 3, 2025 22:47

pytorchbot mentioned this pull request Jan 3, 2025
[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7506
Merged

facebook-github-bot temporarily deployed to cherry-pick-bot January 3, 2025 22:47 — with GitHub Actions Inactive

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025

facebook-github-bot added the fb-exported label Jan 3, 2025

SS-JIA approved these changes Jan 3, 2025
View reviewed changes

SS-JIA added the topic: not user facing label Jan 3, 2025

facebook-github-bot merged commit 3ead5c9 into gh/trivedivivek/36/baseJan 3, 2025

facebook-github-bot deleted the gh/trivedivivek/36/head branch January 3, 2025 22:47

pytorchbot mentioned this pull request Jan 3, 2025
[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7506
Merged

facebook-github-bot temporarily deployed to cherry-pick-bot January 3, 2025 22:47 — with GitHub Actions Inactive

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025

facebook-github-bot added the fb-exported label Jan 3, 2025

SS-JIA approved these changes Jan 3, 2025
View reviewed changes

SS-JIA added the topic: not user facing label Jan 3, 2025

facebook-github-bot merged commit 3ead5c9 into gh/trivedivivek/36/baseJan 3, 2025

facebook-github-bot deleted the gh/trivedivivek/36/head branch January 3, 2025 22:47

pytorchbot mentioned this pull request Jan 3, 2025
[ET-VK] Adding batch processing to conv2d dw shader by caching input texel and kernel values for reuse. #7506
Merged

facebook-github-bot temporarily deployed to cherry-pick-bot January 3, 2025 22:47 — with GitHub Actions Inactive

Uh oh!

Conversation

trviv commented Jan 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-botBot commented Jan 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7485

✅ No Failures

Uh oh!

facebook-github-bot commented Jan 3, 2025

Uh oh!

facebook-github-bot commented Jan 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

trviv commented Jan 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-botBot commented Jan 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7485

✅ No Failures

Uh oh!

facebook-github-bot commented Jan 3, 2025

Uh oh!

facebook-github-bot commented Jan 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

trviv commented Jan 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-botBot commented Jan 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7485

✅ No Failures

Uh oh!

facebook-github-bot commented Jan 3, 2025

Uh oh!

facebook-github-bot commented Jan 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

trviv commented Jan 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-botBot commented Jan 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7485

✅ No Failures

Uh oh!

trviv commented Jan 3, 2025•
edited
Loading

pytorch-botBot commented Jan 3, 2025•
edited
Loading

trviv commented Jan 3, 2025•
edited
Loading

pytorch-botBot commented Jan 3, 2025•
edited
Loading

trviv commented Jan 3, 2025•
edited
Loading

pytorch-botBot commented Jan 3, 2025•
edited
Loading

trviv commented Jan 3, 2025•
edited
Loading

pytorch-botBot commented Jan 3, 2025•
edited
Loading

trviv commented Jan 3, 2025•
edited
Loading

pytorch-botBot commented Jan 3, 2025•
edited
Loading

trviv commented Jan 3, 2025•
edited
Loading

pytorch-botBot commented Jan 3, 2025•
edited
Loading