Uh oh!
There was an error while loading. Please reload this page.
Upgrade numpy version requirement to 2.0 - #7599
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7599
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 PendingAs of commit b058bf1 with merge base b412ddc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mergennachinforce-pushed
the
numpy_version
branch
2 times, most recently
from
January 10, 2025 21:14
a4a3564 to
b96f76eCompare| numpy==1.21.3; python_version == '3.10' | ||
| numpy==1.23.2; python_version == '3.11' | ||
| numpy; python_version >= '3.12' | ||
| numpy==2.0.0; python_version >= '3.10' |
Contributor
There was a problem hiding this comment.
Just for the context, last time we had to tweak these was to satisfy coremltools, and in their latest release 8.1 they're using numpy 2.0 for python > 3.9 https://github.com/apple/coremltools/blob/release/8.1/reqs/build.pip#L3
shoumikhin
approved these changes
Jan 10, 2025
mergennachinforce-pushed
the
numpy_version
branch
2 times, most recently
from
January 10, 2025 22:00
85d4387 to
0ec8d85Compareguangy10
commented
Jan 10, 2025
Contributor
On-demand benchmark jobs to cover llama3 on HF w/ SpinQuant, QLora, Core ML ANE: https://github.com/pytorch/executorch/actions/runs/12718060694 |
huydhn
approved these changes
Jan 10, 2025
guangy10temporarily deployed
to
upload-benchmark-results
January 10, 2025 23:18 — with 
GitHub Actions
Inactive
guangy10temporarily deployed
to
upload-benchmark-results
January 10, 2025 23:43 — with GitHub Actions
Inactive
mergennachinforce-pushed
the
numpy_version
branch
from
January 13, 2025 19:18
0ec8d85 to
d2ac415Compareguangy10
approved these changes
Jan 13, 2025
mergennachinforce-pushed
the
numpy_version
branch
from
January 14, 2025 18:59
d2ac415 to
9278974Comparecccclai
commented
Jan 14, 2025
Contributor
@shewu-quic@winskuo-quic any chance you know the CI error message? It seems like the graph is invalid |
ContributorAuthor
Looks like I need to upgrade pybind11 to 2.12 (or higher) based on this issue pybind/pybind11#5009 Let me update to 2.13.6 and run the CI again |
Summary: 1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0 We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip We had to upgrade to the latest transformers as well
mergennachinforce-pushed
the
numpy_version
branch
from
January 14, 2025 20:31
9278974 to
b058bf1Comparemergennachin
commented
Jan 14, 2025
ContributorAuthor
@pytorchbot cherry-pick --onto release/0.5 -c release |
pytorchbot pushed a commit
that referenced
this pull request
Jan 14, 2025
Upgrade numpy version requirement to Summary: 1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0 We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip We had to upgrade to the latest transformers as well (cherry picked from commit a7b5297)
pytorchbot
commented
Jan 14, 2025
Collaborator
Cherry picking #7599The cherry pick PR is at #7659 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
digantdesai pushed a commit
that referenced
this pull request
Jan 16, 2025
Upgrade numpy version requirement to Summary: 1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0 We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip We had to upgrade to the latest transformers as well (cherry picked from commit a7b5297)
per pushed a commit
to per/executorch
that referenced
this pull request
Jan 16, 2025
Upgrade numpy version requirement to Summary: 1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0 We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip We had to upgrade to the latest transformers as well (cherry picked from commit a7b5297)
mergennachin added a commit
that referenced
this pull request
Jan 17, 2025
Upgrade numpy version requirement to Summary: 1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0 We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip We had to upgrade to the latest transformers as well (cherry picked from commit a7b5297)
mergennachin added a commit
that referenced
this pull request
Jan 17, 2025
* Install torchao by default (#7470) Summary: Now that torchao is not experimental anymore, we can rely on torchao directly via git submodule. Part of #7460 (cherry picked from commit a861294) * Upgrade numpy version requirement to 2.0 (#7599) Upgrade numpy version requirement to Summary: 1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0 We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip We had to upgrade to the latest transformers as well (cherry picked from commit a7b5297) * Update torchtune pin (#7670) (cherry picked from commit a18f6e8) * [Arm] TOSA reference model update * Install release version of torchtune --------- Co-authored-by: Sicheng Stephen Jia <ssjia@meta.com>
YIWENX14 pushed a commit
that referenced
this pull request
Jan 28, 2025
Upgrade numpy version requirement to Summary: 1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0 We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip We had to upgrade to the latest transformers as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade numpy version requirement to 2.0.0
Summary:
1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0
We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip
We had to upgrade to the latest transformers as well
Fixes:
#6639
Test Plan (pending)