install_requirements.py: use argparse, minor cleanup by swolchok · Pull Request #7703 · pytorch/executorch

swolchok · 2025-01-16T17:30:36Z

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Test Plan: (with debug print of args.pybind to save time)
install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml
install_requirements.sh --pybind xnnpack mps coreml
install_requirements.sh --clean

CI should cover use-pt-pinned-commit

[ghstack-poisoned]

swolchok · 2025-01-16T17:30:37Z

Stack from ghstack (oldest at bottom):

pytorch-bot · 2025-01-16T17:30:40Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7703

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 1d4dfab with merge base 1b7b10e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mergennachin

See inline

mergennachin · 2025-01-16T17:50:00Z

- elif arg == "--use-pt-pinned-commit":
+ for pybind_arg in args.pybind:
+ if pybind_arg not in ["coreml", "mps", "xnnpack"]:
+ continue


raise exception here?

whoops! I misinterpreted the original code after I'd made some modifications to it. will fix.

mergennachin · 2025-01-16T17:50:36Z

+ EXECUTORCH_BUILD_PYBIND = "ON"
+ CMAKE_ARGS += f" -DEXECUTORCH_BUILD_{pybind_arg.upper()}=ON"
+
+ if args.clean:


do this if statement first?

[ghstack-poisoned]

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

This reverts commit 007ea3e.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself. Test Plan: (with debug print of args.pybind to save time) install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml install_requirements.sh --pybind xnnpack mps coreml install_requirements.sh --clean CI should cover use-pt-pinned-commit ghstack-source-id: dff674a ghstack-comment-id: 2596312894 Pull Request resolved: pytorch/executorch#7703

swolchok · 2025-01-16T17:30:36Z

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Test Plan: (with debug print of args.pybind to save time)
install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml
install_requirements.sh --pybind xnnpack mps coreml
install_requirements.sh --clean

CI should cover use-pt-pinned-commit

[ghstack-poisoned]

swolchok · 2025-01-16T17:30:37Z

Stack from ghstack (oldest at bottom):

pytorch-bot · 2025-01-16T17:30:40Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7703

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 1d4dfab with merge base 1b7b10e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mergennachin

See inline

mergennachin · 2025-01-16T17:50:00Z

- elif arg == "--use-pt-pinned-commit":
+ for pybind_arg in args.pybind:
+ if pybind_arg not in ["coreml", "mps", "xnnpack"]:
+ continue


raise exception here?

whoops! I misinterpreted the original code after I'd made some modifications to it. will fix.

mergennachin · 2025-01-16T17:50:36Z

+ EXECUTORCH_BUILD_PYBIND = "ON"
+ CMAKE_ARGS += f" -DEXECUTORCH_BUILD_{pybind_arg.upper()}=ON"
+
+ if args.clean:


do this if statement first?

[ghstack-poisoned]

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

This reverts commit 007ea3e.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself. Test Plan: (with debug print of args.pybind to save time) install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml install_requirements.sh --pybind xnnpack mps coreml install_requirements.sh --clean CI should cover use-pt-pinned-commit ghstack-source-id: dff674a ghstack-comment-id: 2596312894 Pull Request resolved: pytorch/executorch#7703

swolchok · 2025-01-16T17:30:36Z

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Test Plan: (with debug print of args.pybind to save time)
install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml
install_requirements.sh --pybind xnnpack mps coreml
install_requirements.sh --clean

CI should cover use-pt-pinned-commit

[ghstack-poisoned]

swolchok · 2025-01-16T17:30:37Z

Stack from ghstack (oldest at bottom):

pytorch-bot · 2025-01-16T17:30:40Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7703

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 1d4dfab with merge base 1b7b10e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mergennachin

See inline

mergennachin · 2025-01-16T17:50:00Z

- elif arg == "--use-pt-pinned-commit":
+ for pybind_arg in args.pybind:
+ if pybind_arg not in ["coreml", "mps", "xnnpack"]:
+ continue


raise exception here?

whoops! I misinterpreted the original code after I'd made some modifications to it. will fix.

mergennachin · 2025-01-16T17:50:36Z

+ EXECUTORCH_BUILD_PYBIND = "ON"
+ CMAKE_ARGS += f" -DEXECUTORCH_BUILD_{pybind_arg.upper()}=ON"
+
+ if args.clean:


do this if statement first?

[ghstack-poisoned]

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

This reverts commit 007ea3e.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself. Test Plan: (with debug print of args.pybind to save time) install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml install_requirements.sh --pybind xnnpack mps coreml install_requirements.sh --clean CI should cover use-pt-pinned-commit ghstack-source-id: dff674a ghstack-comment-id: 2596312894 Pull Request resolved: pytorch/executorch#7703

swolchok · 2025-01-16T17:30:36Z

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Test Plan: (with debug print of args.pybind to save time)
install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml
install_requirements.sh --pybind xnnpack mps coreml
install_requirements.sh --clean

CI should cover use-pt-pinned-commit

[ghstack-poisoned]

swolchok · 2025-01-16T17:30:37Z

Stack from ghstack (oldest at bottom):

pytorch-bot · 2025-01-16T17:30:40Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7703

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 1d4dfab with merge base 1b7b10e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mergennachin

See inline

mergennachin · 2025-01-16T17:50:00Z

- elif arg == "--use-pt-pinned-commit":
+ for pybind_arg in args.pybind:
+ if pybind_arg not in ["coreml", "mps", "xnnpack"]:
+ continue


raise exception here?

whoops! I misinterpreted the original code after I'd made some modifications to it. will fix.

mergennachin · 2025-01-16T17:50:36Z

+ EXECUTORCH_BUILD_PYBIND = "ON"
+ CMAKE_ARGS += f" -DEXECUTORCH_BUILD_{pybind_arg.upper()}=ON"
+
+ if args.clean:


do this if statement first?

[ghstack-poisoned]

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

This reverts commit 007ea3e.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself. Test Plan: (with debug print of args.pybind to save time) install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml install_requirements.sh --pybind xnnpack mps coreml install_requirements.sh --clean CI should cover use-pt-pinned-commit ghstack-source-id: dff674a ghstack-comment-id: 2596312894 Pull Request resolved: pytorch/executorch#7703

swolchok · 2025-01-16T17:30:36Z

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Test Plan: (with debug print of args.pybind to save time)
install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml
install_requirements.sh --pybind xnnpack mps coreml
install_requirements.sh --clean

CI should cover use-pt-pinned-commit

[ghstack-poisoned]

swolchok · 2025-01-16T17:30:37Z

Stack from ghstack (oldest at bottom):

pytorch-bot · 2025-01-16T17:30:40Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7703

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 1d4dfab with merge base 1b7b10e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mergennachin

See inline

mergennachin · 2025-01-16T17:50:00Z

- elif arg == "--use-pt-pinned-commit":
+ for pybind_arg in args.pybind:
+ if pybind_arg not in ["coreml", "mps", "xnnpack"]:
+ continue


raise exception here?

whoops! I misinterpreted the original code after I'd made some modifications to it. will fix.

mergennachin · 2025-01-16T17:50:36Z

+ EXECUTORCH_BUILD_PYBIND = "ON"
+ CMAKE_ARGS += f" -DEXECUTORCH_BUILD_{pybind_arg.upper()}=ON"
+
+ if args.clean:


do this if statement first?

[ghstack-poisoned]

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

This reverts commit 007ea3e.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself. Test Plan: (with debug print of args.pybind to save time) install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml install_requirements.sh --pybind xnnpack mps coreml install_requirements.sh --clean CI should cover use-pt-pinned-commit ghstack-source-id: dff674a ghstack-comment-id: 2596312894 Pull Request resolved: pytorch/executorch#7703

swolchok · 2025-01-16T17:30:36Z

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Test Plan: (with debug print of args.pybind to save time)
install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml
install_requirements.sh --pybind xnnpack mps coreml
install_requirements.sh --clean

CI should cover use-pt-pinned-commit

[ghstack-poisoned]

swolchok · 2025-01-16T17:30:37Z

Stack from ghstack (oldest at bottom):

pytorch-bot · 2025-01-16T17:30:40Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7703

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 1d4dfab with merge base 1b7b10e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mergennachin

See inline

mergennachin · 2025-01-16T17:50:00Z

- elif arg == "--use-pt-pinned-commit":
+ for pybind_arg in args.pybind:
+ if pybind_arg not in ["coreml", "mps", "xnnpack"]:
+ continue


raise exception here?

whoops! I misinterpreted the original code after I'd made some modifications to it. will fix.

mergennachin · 2025-01-16T17:50:36Z

+ EXECUTORCH_BUILD_PYBIND = "ON"
+ CMAKE_ARGS += f" -DEXECUTORCH_BUILD_{pybind_arg.upper()}=ON"
+
+ if args.clean:


do this if statement first?

[ghstack-poisoned]

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

This reverts commit 007ea3e.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself. Test Plan: (with debug print of args.pybind to save time) install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml install_requirements.sh --pybind xnnpack mps coreml install_requirements.sh --clean CI should cover use-pt-pinned-commit ghstack-source-id: dff674a ghstack-comment-id: 2596312894 Pull Request resolved: pytorch/executorch#7703

swolchok · 2025-01-16T17:30:36Z

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Test Plan: (with debug print of args.pybind to save time)
install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml
install_requirements.sh --pybind xnnpack mps coreml
install_requirements.sh --clean

CI should cover use-pt-pinned-commit

[ghstack-poisoned]

swolchok · 2025-01-16T17:30:37Z

Stack from ghstack (oldest at bottom):

pytorch-bot · 2025-01-16T17:30:40Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7703

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 1d4dfab with merge base 1b7b10e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mergennachin

See inline

mergennachin · 2025-01-16T17:50:00Z

- elif arg == "--use-pt-pinned-commit":
+ for pybind_arg in args.pybind:
+ if pybind_arg not in ["coreml", "mps", "xnnpack"]:
+ continue


raise exception here?

whoops! I misinterpreted the original code after I'd made some modifications to it. will fix.

mergennachin · 2025-01-16T17:50:36Z

+ EXECUTORCH_BUILD_PYBIND = "ON"
+ CMAKE_ARGS += f" -DEXECUTORCH_BUILD_{pybind_arg.upper()}=ON"
+
+ if args.clean:


do this if statement first?

[ghstack-poisoned]

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

This reverts commit 007ea3e.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself. Test Plan: (with debug print of args.pybind to save time) install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml install_requirements.sh --pybind xnnpack mps coreml install_requirements.sh --clean CI should cover use-pt-pinned-commit ghstack-source-id: dff674a ghstack-comment-id: 2596312894 Pull Request resolved: pytorch/executorch#7703

swolchok · 2025-01-16T17:30:36Z

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Test Plan: (with debug print of args.pybind to save time)
install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml
install_requirements.sh --pybind xnnpack mps coreml
install_requirements.sh --clean

CI should cover use-pt-pinned-commit

[ghstack-poisoned]

swolchok · 2025-01-16T17:30:37Z

Stack from ghstack (oldest at bottom):

pytorch-bot · 2025-01-16T17:30:40Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7703

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 1d4dfab with merge base 1b7b10e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mergennachin

See inline

mergennachin · 2025-01-16T17:50:00Z

- elif arg == "--use-pt-pinned-commit":
+ for pybind_arg in args.pybind:
+ if pybind_arg not in ["coreml", "mps", "xnnpack"]:
+ continue


raise exception here?

whoops! I misinterpreted the original code after I'd made some modifications to it. will fix.

mergennachin · 2025-01-16T17:50:36Z

+ EXECUTORCH_BUILD_PYBIND = "ON"
+ CMAKE_ARGS += f" -DEXECUTORCH_BUILD_{pybind_arg.upper()}=ON"
+
+ if args.clean:


do this if statement first?

[ghstack-poisoned]

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

This reverts commit 007ea3e.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself. Test Plan: (with debug print of args.pybind to save time) install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml install_requirements.sh --pybind xnnpack mps coreml install_requirements.sh --clean CI should cover use-pt-pinned-commit ghstack-source-id: dff674a ghstack-comment-id: 2596312894 Pull Request resolved: pytorch/executorch#7703

Update
da1df94
[ghstack-poisoned]

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025

This was referenced Jan 16, 2025
install_requirements.py: refactor: extract install_requirements() function #7704
Merged
install_requirements.py: reorganize requirements #7705
Merged

swolchok requested review from dbort, mcr229 and mergennachin January 16, 2025 17:31

mergennachin approved these changes Jan 16, 2025
View reviewed changes

swolchok mentioned this pull request Jan 16, 2025
rename top-level install_requirements.{py,sh,bat} to install_executorch #7708
Merged

swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 16, 2025

swolchok added 2 commits January 16, 2025 13:35

Update
9a1ddde
[ghstack-poisoned]

Update
bf753a8
[ghstack-poisoned]

This was referenced Jan 16, 2025
Add install_requirements.{sh,py} that only install requirements #7715
Merged
don't touch CMAKE_BUILD_ARGS in install_executorch.py #7716
Merged

swolchok added 2 commits January 16, 2025 14:46

Update
e089ac5
[ghstack-poisoned]

Update
1d4dfab
[ghstack-poisoned]

swolchok merged commit 007ea3e into mainJan 17, 2025

swolchok deleted the gh/swolchok/134/head branch January 17, 2025 00:37

huydhn added a commit that referenced this pull request Jan 24, 2025
Revert "install_requirements.py: use argparse, minor cleanup (#7703)"
a393272
This reverts commit 007ea3e.

YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
install_requirements.py: use argparse, minor cleanup (#7703)
011f4c6
Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Update
da1df94
[ghstack-poisoned]

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025

This was referenced Jan 16, 2025
install_requirements.py: refactor: extract install_requirements() function #7704
Merged
install_requirements.py: reorganize requirements #7705
Merged

swolchok requested review from dbort, mcr229 and mergennachin January 16, 2025 17:31

mergennachin approved these changes Jan 16, 2025
View reviewed changes

swolchok mentioned this pull request Jan 16, 2025
rename top-level install_requirements.{py,sh,bat} to install_executorch #7708
Merged

swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 16, 2025

swolchok added 2 commits January 16, 2025 13:35

Update
9a1ddde
[ghstack-poisoned]

Update
bf753a8
[ghstack-poisoned]

This was referenced Jan 16, 2025
Add install_requirements.{sh,py} that only install requirements #7715
Merged
don't touch CMAKE_BUILD_ARGS in install_executorch.py #7716
Merged

swolchok added 2 commits January 16, 2025 14:46

Update
e089ac5
[ghstack-poisoned]

Update
1d4dfab
[ghstack-poisoned]

swolchok merged commit 007ea3e into mainJan 17, 2025

swolchok deleted the gh/swolchok/134/head branch January 17, 2025 00:37

huydhn added a commit that referenced this pull request Jan 24, 2025
Revert "install_requirements.py: use argparse, minor cleanup (#7703)"
a393272
This reverts commit 007ea3e.

YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
install_requirements.py: use argparse, minor cleanup (#7703)
011f4c6
Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Update
da1df94
[ghstack-poisoned]

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025

This was referenced Jan 16, 2025
install_requirements.py: refactor: extract install_requirements() function #7704
Merged
install_requirements.py: reorganize requirements #7705
Merged

swolchok requested review from dbort, mcr229 and mergennachin January 16, 2025 17:31

mergennachin approved these changes Jan 16, 2025
View reviewed changes

swolchok mentioned this pull request Jan 16, 2025
rename top-level install_requirements.{py,sh,bat} to install_executorch #7708
Merged

swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 16, 2025

swolchok added 2 commits January 16, 2025 13:35

Update
9a1ddde
[ghstack-poisoned]

Update
bf753a8
[ghstack-poisoned]

This was referenced Jan 16, 2025
Add install_requirements.{sh,py} that only install requirements #7715
Merged
don't touch CMAKE_BUILD_ARGS in install_executorch.py #7716
Merged

swolchok added 2 commits January 16, 2025 14:46

Update
e089ac5
[ghstack-poisoned]

Update
1d4dfab
[ghstack-poisoned]

swolchok merged commit 007ea3e into mainJan 17, 2025

swolchok deleted the gh/swolchok/134/head branch January 17, 2025 00:37

huydhn added a commit that referenced this pull request Jan 24, 2025
Revert "install_requirements.py: use argparse, minor cleanup (#7703)"
a393272
This reverts commit 007ea3e.

YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
install_requirements.py: use argparse, minor cleanup (#7703)
011f4c6
Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Update
da1df94
[ghstack-poisoned]

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025

This was referenced Jan 16, 2025
install_requirements.py: refactor: extract install_requirements() function #7704
Merged
install_requirements.py: reorganize requirements #7705
Merged

swolchok requested review from dbort, mcr229 and mergennachin January 16, 2025 17:31

mergennachin approved these changes Jan 16, 2025
View reviewed changes

swolchok mentioned this pull request Jan 16, 2025
rename top-level install_requirements.{py,sh,bat} to install_executorch #7708
Merged

swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 16, 2025

swolchok added 2 commits January 16, 2025 13:35

Update
9a1ddde
[ghstack-poisoned]

Update
bf753a8
[ghstack-poisoned]

This was referenced Jan 16, 2025
Add install_requirements.{sh,py} that only install requirements #7715
Merged
don't touch CMAKE_BUILD_ARGS in install_executorch.py #7716
Merged

swolchok added 2 commits January 16, 2025 14:46

Update
e089ac5
[ghstack-poisoned]

Update
1d4dfab
[ghstack-poisoned]

swolchok merged commit 007ea3e into mainJan 17, 2025

swolchok deleted the gh/swolchok/134/head branch January 17, 2025 00:37

huydhn added a commit that referenced this pull request Jan 24, 2025
Revert "install_requirements.py: use argparse, minor cleanup (#7703)"
a393272
This reverts commit 007ea3e.

YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
install_requirements.py: use argparse, minor cleanup (#7703)
011f4c6
Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Update
da1df94
[ghstack-poisoned]

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025

This was referenced Jan 16, 2025
install_requirements.py: refactor: extract install_requirements() function #7704
Merged
install_requirements.py: reorganize requirements #7705
Merged

swolchok requested review from dbort, mcr229 and mergennachin January 16, 2025 17:31

mergennachin approved these changes Jan 16, 2025
View reviewed changes

swolchok mentioned this pull request Jan 16, 2025
rename top-level install_requirements.{py,sh,bat} to install_executorch #7708
Merged

swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 16, 2025

swolchok added 2 commits January 16, 2025 13:35

Update
9a1ddde
[ghstack-poisoned]

Update
bf753a8
[ghstack-poisoned]

This was referenced Jan 16, 2025
Add install_requirements.{sh,py} that only install requirements #7715
Merged
don't touch CMAKE_BUILD_ARGS in install_executorch.py #7716
Merged

swolchok added 2 commits January 16, 2025 14:46

Update
e089ac5
[ghstack-poisoned]

Update
1d4dfab
[ghstack-poisoned]

swolchok merged commit 007ea3e into mainJan 17, 2025

swolchok deleted the gh/swolchok/134/head branch January 17, 2025 00:37

huydhn added a commit that referenced this pull request Jan 24, 2025
Revert "install_requirements.py: use argparse, minor cleanup (#7703)"
a393272
This reverts commit 007ea3e.

YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
install_requirements.py: use argparse, minor cleanup (#7703)
011f4c6
Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Update
da1df94
[ghstack-poisoned]

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025

This was referenced Jan 16, 2025
install_requirements.py: refactor: extract install_requirements() function #7704
Merged
install_requirements.py: reorganize requirements #7705
Merged

swolchok requested review from dbort, mcr229 and mergennachin January 16, 2025 17:31

mergennachin approved these changes Jan 16, 2025
View reviewed changes

swolchok mentioned this pull request Jan 16, 2025
rename top-level install_requirements.{py,sh,bat} to install_executorch #7708
Merged

swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 16, 2025

swolchok added 2 commits January 16, 2025 13:35

Update
9a1ddde
[ghstack-poisoned]

Update
bf753a8
[ghstack-poisoned]

This was referenced Jan 16, 2025
Add install_requirements.{sh,py} that only install requirements #7715
Merged
don't touch CMAKE_BUILD_ARGS in install_executorch.py #7716
Merged

swolchok added 2 commits January 16, 2025 14:46

Update
e089ac5
[ghstack-poisoned]

Update
1d4dfab
[ghstack-poisoned]

swolchok merged commit 007ea3e into mainJan 17, 2025

swolchok deleted the gh/swolchok/134/head branch January 17, 2025 00:37

huydhn added a commit that referenced this pull request Jan 24, 2025
Revert "install_requirements.py: use argparse, minor cleanup (#7703)"
a393272
This reverts commit 007ea3e.

YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
install_requirements.py: use argparse, minor cleanup (#7703)
011f4c6
Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Update
da1df94
[ghstack-poisoned]

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025

This was referenced Jan 16, 2025
install_requirements.py: refactor: extract install_requirements() function #7704
Merged
install_requirements.py: reorganize requirements #7705
Merged

swolchok requested review from dbort, mcr229 and mergennachin January 16, 2025 17:31

mergennachin approved these changes Jan 16, 2025
View reviewed changes

swolchok mentioned this pull request Jan 16, 2025
rename top-level install_requirements.{py,sh,bat} to install_executorch #7708
Merged

swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 16, 2025

swolchok added 2 commits January 16, 2025 13:35

Update
9a1ddde
[ghstack-poisoned]

Update
bf753a8
[ghstack-poisoned]

This was referenced Jan 16, 2025
Add install_requirements.{sh,py} that only install requirements #7715
Merged
don't touch CMAKE_BUILD_ARGS in install_executorch.py #7716
Merged

swolchok added 2 commits January 16, 2025 14:46

Update
e089ac5
[ghstack-poisoned]

Update
1d4dfab
[ghstack-poisoned]

swolchok merged commit 007ea3e into mainJan 17, 2025

swolchok deleted the gh/swolchok/134/head branch January 17, 2025 00:37

huydhn added a commit that referenced this pull request Jan 24, 2025
Revert "install_requirements.py: use argparse, minor cleanup (#7703)"
a393272
This reverts commit 007ea3e.

YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
install_requirements.py: use argparse, minor cleanup (#7703)
011f4c6
Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Update
da1df94
[ghstack-poisoned]

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025

This was referenced Jan 16, 2025
install_requirements.py: refactor: extract install_requirements() function #7704
Merged
install_requirements.py: reorganize requirements #7705
Merged

swolchok requested review from dbort, mcr229 and mergennachin January 16, 2025 17:31

mergennachin approved these changes Jan 16, 2025
View reviewed changes

swolchok mentioned this pull request Jan 16, 2025
rename top-level install_requirements.{py,sh,bat} to install_executorch #7708
Merged

swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 16, 2025

swolchok added 2 commits January 16, 2025 13:35

Update
9a1ddde
[ghstack-poisoned]

Update
bf753a8
[ghstack-poisoned]

This was referenced Jan 16, 2025
Add install_requirements.{sh,py} that only install requirements #7715
Merged
don't touch CMAKE_BUILD_ARGS in install_executorch.py #7716
Merged

swolchok added 2 commits January 16, 2025 14:46

Update
e089ac5
[ghstack-poisoned]

Update
1d4dfab
[ghstack-poisoned]

swolchok merged commit 007ea3e into mainJan 17, 2025

swolchok deleted the gh/swolchok/134/head branch January 17, 2025 00:37

huydhn added a commit that referenced this pull request Jan 24, 2025
Revert "install_requirements.py: use argparse, minor cleanup (#7703)"
a393272
This reverts commit 007ea3e.

YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
install_requirements.py: use argparse, minor cleanup (#7703)
011f4c6
Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.

Uh oh!

Conversation

swolchok commented Jan 16, 2025

Uh oh!

swolchok commented Jan 16, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-botBot commented Jan 16, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7703

⏳ No Failures, 1 Pending

Uh oh!

mergennachin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

swolchok commented Jan 16, 2025

Uh oh!

swolchok commented Jan 16, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-botBot commented Jan 16, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7703

⏳ No Failures, 1 Pending

Uh oh!

mergennachin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

swolchok commented Jan 16, 2025

Uh oh!

swolchok commented Jan 16, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-botBot commented Jan 16, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7703

⏳ No Failures, 1 Pending

Uh oh!

mergennachin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

swolchok commented Jan 16, 2025•
edited
Loading

pytorch-botBot commented Jan 16, 2025•
edited
Loading

swolchok commented Jan 16, 2025•
edited
Loading

pytorch-botBot commented Jan 16, 2025•
edited
Loading

swolchok commented Jan 16, 2025•
edited
Loading

pytorch-botBot commented Jan 16, 2025•
edited
Loading

swolchok commented Jan 16, 2025•
edited
Loading

pytorch-botBot commented Jan 16, 2025•
edited
Loading