Skip to content

Update documentation flow and add placeholders - #8287

Merged
GregoryComer merged 1 commit into
pytorch:executorch-just-worksfrom
GregoryComer:doc-structure
Feb 7, 2025
Merged

Update documentation flow and add placeholders#8287
GregoryComer merged 1 commit into
pytorch:executorch-just-worksfrom
GregoryComer:doc-structure

Conversation

@GregoryComer

@GregoryComerGregoryComer commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

Summary

This PR makes some high-level updates to the documentation TOC layout and creates placeholders for a number of documentation pages. Most notably, the following has changed:

  • Re-ordered the TOC to pull the most relevant sections up to the top
  • Add placeholders for top-level usage docs for export, android, ios, c++, and troubleshooting
  • Split out docs related to developing new backends into a separate "Backend Development" section
  • Added placeholder docs for all major backends
  • Shorten some page links to avoid repeating ExecuTorch constantly in the TOC

Test plan

Built docs locally and validated.

@pytorch-bot

pytorch-botBot commented Feb 6, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8287

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2025
@GregoryComer
GregoryComer marked this pull request as ready for review February 6, 2025 21:00
@GregoryComer
GregoryComerforce-pushed the doc-structure branch 2 times, most recently from dae67b0 to 270569aCompareFebruary 6, 2025 21:14
@@ -0,0 +1,3 @@
# ARM Backend

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM -> Arm EthosU Backend

ARM is too broad... Is it Cortex-A, Cortex-M?

In this case, we're only talking about running on Cortex Ethos-U backend for acceleration.

Comment threaddocs/source/index.rst Outdated
.. toctree::
:glob:
:maxdepth: 1
:caption: Backend Delegates

@mergennachinmergennachinFeb 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to "Backends"

the reason is that Cadence is not really a delegate

@@ -0,0 +1,3 @@
# Qualcomm Backend

Placeholder No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you basically moving contents over from https://pytorch.org/executorch/stable/build-run-qualcomm-ai-engine-direct-backend.html to this? And do adjustments, along the way?

Comment threaddocs/source/index.rst
:glob:
:maxdepth: 1
:caption: Kernel Library
:caption: Backend Development

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, i like it

Comment threaddocs/source/index.rst
memory-planning-inspection
delegate-debugging
devtools-tutorial
compiler-delegate-and-partitioner

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first one can actually go to "Backend Development" section

Comment threaddocs/source/index.rst
native-delegates-executorch-mediatek-delegate
native-delegates-executorch-cadence-delegate

.. toctree::

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have too many tutorials here

can we remove everything in Tutorials section, and gradually increase if necessary?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I 100% agree on the tutorials. A lot of what's in there is really reference material and not a tutorial. I'm happy to remove them for now.

@GregoryComer
GregoryComer merged commit d60e12d into pytorch:executorch-just-worksFeb 7, 2025
GregoryComer added a commit to GregoryComer/executorch that referenced this pull request Feb 12, 2025
GregoryComer added a commit to GregoryComer/executorch that referenced this pull request Feb 23, 2025
GregoryComer added a commit that referenced this pull request Feb 23, 2025
GregoryComer added a commit that referenced this pull request Feb 26, 2025
GregoryComer added a commit that referenced this pull request Feb 26, 2025
* New Getting Started documentation (#8179)
WIP New getting started
* Update documentation flow and add placeholders (#8287)
Add placeholder top-level doc pages
* Add new export + lowering docs, update getting started (#8412)
Write new top-level export and lowering documentation
* More doc placeholders (#8523)
* Move cmake and faq docs to new location
* Rename CMake build to Building from Source
* Move backend docs to new locations (#8413)
* Temporarily remove new backend pages
* Move backend docs to new locations
* Update backend titles and inline contents
* Backend doc template (#8524)
Add backend template, update XNNPACK docs
* Add runtime integration documentation (#8516)
Add runtime integration doc
* Move iOS docs to top, add Android placeholders (#8511)
* Temporarily remove using-executorch-ios.md
* Move Apple runtime docs to new location
* Clean up documentation placeholders and links, add top-level docs for C++ APIs, Android, and troubleshooting (#8618)
* Clean up getting-started.md, remove placeholders
* Move Android pre-built AAR info into top-level Android page
* Add placeholder backend overview
* Add placeholder troubleshooting docs
* Populate top-level C++ API doc
* Clean up additional doc placeholders and fix broken links
* Add env setup instructions for source build
* Fix getting started code snippet (#8637)
Fix quotes in getting started code snippets
* Clean up a few more doc sections and links (#8672)
Clean up a few more broken links and sections in new doc flow
* Fix QNN link, typo (#8729)
* Add a CMake snippet to the XNNPACK backend doc build section (#8730)
Add CMake example to xnnpack backend doc
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@GregoryComer@mergennachin@byjlw@facebook-github-bot