Uh oh!
There was an error while loading. Please reload this page.
Address various warnings as errors - #8581
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8581
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit b3e022a with merge base 9841e54 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
commented
Feb 19, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens
commented
Feb 19, 2025
ContributorAuthor
Contributor
A few remaining errors in OSS CI: hhttps://github.com/pytorch/executorch/actions/runs/13422197087/job/37540258041 and also lint error: https://github.com/pytorch/executorch/actions/runs/13422197104/job/37540247065?pr=8581 |
facebook-github-bot
commented
Feb 20, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevensforce-pushed
the
export-D69139962
branch
from
February 20, 2025 15:31
e1bd3ea to
34c5662CompareJakeStevens
requested review from
kirklandsign and larryliu0820
as code ownersFebruary 20, 2025 15:31
JakeStevens added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 20, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevens
requested review from
JacobSzwejbka, lucylq and manuelcandales
as code ownersFebruary 20, 2025 15:31
JakeStevens
commented
Feb 20, 2025
ContributorAuthor
@pytorchbot label "topic: not user facing |
❌ 🤖 pytorchbot command failed: |
facebook-github-bot
commented
Feb 20, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevensforce-pushed
the
export-D69139962
branch
from
February 20, 2025 16:10
34c5662 to
de3bf42CompareJakeStevens added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 20, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
facebook-github-bot
commented
Feb 20, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 20, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevensforce-pushed
the
export-D69139962
branch
from
February 20, 2025 16:16
de3bf42 to
eb5aab3Comparefacebook-github-bot
commented
Feb 20, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 20, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevensforce-pushed
the
export-D69139962
branch
from
February 20, 2025 16:36
eb5aab3 to
e1dd14eComparefacebook-github-bot
commented
Feb 21, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 21, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevensforce-pushed
the
export-D69139962
branch
from
February 21, 2025 22:29
0dc65a2 to
bf4c172Comparefacebook-github-bot
commented
Feb 21, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 21, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevensforce-pushed
the
export-D69139962
branch
from
February 21, 2025 22:52
bf4c172 to
006df4eComparefacebook-github-bot
commented
Feb 22, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 22, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevensforce-pushed
the
export-D69139962
branch
from
February 22, 2025 02:22
006df4e to
2eb3f10Comparefacebook-github-bot
commented
Feb 22, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 22, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevensforce-pushed
the
export-D69139962
branch
from
February 22, 2025 02:30
2eb3f10 to
d463d14Comparefacebook-github-bot
commented
Feb 22, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 22, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevensforce-pushed
the
export-D69139962
branch
from
February 22, 2025 02:45
d463d14 to
f684260Comparefacebook-github-bot
commented
Feb 22, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 22, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevensforce-pushed
the
export-D69139962
branch
from
February 22, 2025 03:04
f684260 to
54fe659Comparefacebook-github-bot
commented
Feb 22, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevens added a commit
to JakeStevens/executorch
that referenced
this pull request
Feb 22, 2025
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
JakeStevensforce-pushed
the
export-D69139962
branch
from
February 22, 2025 03:15
54fe659 to
c6e9f7dComparefacebook-github-bot
commented
Feb 27, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevensforce-pushed
the
export-D69139962
branch
from
February 27, 2025 20:46
c6e9f7d to
022df06Comparemergennachin
commented
Feb 27, 2025
Contributor
Summary: Pull Request resolved: pytorch#8581 Some projects uses more restrictive build options than currently used in ET CI. This means we encountered a number of errors when enabling for a microcontroller. Reviewed By: digantdesai, swolchok Differential Revision: D69139962
facebook-github-bot
commented
Mar 3, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D69139962 |
JakeStevensforce-pushed
the
export-D69139962
branch
from
March 3, 2025 15:49
022df06 to
b3e022aCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Some projects uses more restrictive build options than currently used in ET CI.
This means we encountered a number of errors when enabling for a microcontroller.
Reviewed By: digantdesai, swolchok
Differential Revision: D69139962