Skip to content

[Android] Rename build script - #8747

Merged
kirklandsign merged 1 commit into
mainfrom
rename-script
Feb 26, 2025
Merged

[Android] Rename build script#8747
kirklandsign merged 1 commit into
mainfrom
rename-script

Conversation

@kirklandsign

Copy link
Copy Markdown
Contributor

Summary

build_android_llm_demo.sh -> build_android_library.sh
It's not only for LLM demo, but for general use case as well

Test plan

CI

@pytorch-bot

pytorch-botBot commented Feb 26, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8747

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 8 Pending

As of commit f6c75be with merge base 50fb8a9 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2025
It's not only for LLM demo, but for general use case as well
@GregoryComer

GregoryComer commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

Thanks! We'll also probably want to document usage under using-executorch-android.md and using-executorch-building-from-source as a follow-up.

@kirklandsignkirklandsign added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Feb 26, 2025
@kirklandsign

Copy link
Copy Markdown
ContributorAuthor

Thanks! We'll also probably want to document usage under using-executorch-android.md and using-executorch-building-from-source as a follow-up.

Thank you. Mind sharing the PR or issue number so we can remind ourself later?

@GregoryComer

Copy link
Copy Markdown
Contributor

Thanks! We'll also probably want to document usage under using-executorch-android.md and using-executorch-building-from-source as a follow-up.

Thank you. Mind sharing the PR or issue number so we can remind ourself later?

Sure. We can track in #8261.

@kirklandsign
kirklandsign merged commit afcec1d into mainFeb 26, 2025
@kirklandsign
kirklandsign deleted the rename-script branch February 26, 2025 23:15
@kirklandsign
kirklandsigntemporarily deployed to upload-benchmark-results February 26, 2025 23:18 — with GitHub Actions Inactive
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kirklandsign@GregoryComer@facebook-github-bot