Skip to content

Migrate pybind11 external deps to regular third-party deps#8837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
facebook-github-bot merged 1 commit into from
Mar 3, 2025
Merged

Migrate pybind11 external deps to regular third-party deps #8837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions backends/apple/coreml/TARGETS
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,10 +14,10 @@ runtime.python_library(
"@EXECUTORCH_CLIENTS",
],
deps = [
"fbsource//third-party/pypi/coremltools:coremltools",
":executorchcoreml",
"//executorch/exir/backend:backend_details",
"//executorch/exir/backend:compile_spec_schema",
"fbsource//third-party/pypi/coremltools:coremltools",
],
)

Expand All@@ -30,13 +30,13 @@ runtime.python_library(
"@EXECUTORCH_CLIENTS",
],
deps = [
"fbsource//third-party/pypi/coremltools:coremltools",
":backend",
"//caffe2:torch",
"//executorch/exir:lib",
"//executorch/exir/backend:compile_spec_schema",
"//executorch/exir/backend:partitioner",
"//executorch/exir/backend:utils",
"fbsource//third-party/pypi/coremltools:coremltools",
],
)

Expand DownExpand Up@@ -64,25 +64,23 @@ runtime.cxx_python_extension(
headers = glob([
"runtime/inmemoryfs/**/*.hpp",
]),
base_module = "",
compiler_flags = [
"-std=c++17",
],
preprocessor_flags = [
"-Iexecutorch/backends/apple/coreml/runtime/util",
],
types = [
"executorchcoreml.pyi",
],
compiler_flags = [
"-std=c++17",
],
base_module = "",
visibility = [
"//executorch/examples/apple/coreml/...",
"@EXECUTORCH_CLIENTS",
],
external_deps = [
"pybind11",
],
deps = [
"fbsource//third-party/nlohmann-json:nlohmann-json",
"fbsource//third-party/pybind11:pybind11",
],
)

Expand All@@ -92,10 +90,10 @@ runtime.python_test(
"test/*.py",
]),
deps = [
"fbsource//third-party/pypi/pytest:pytest",
":partitioner",
":quantizer",
"//caffe2:torch",
"//pytorch/vision:torchvision",
"fbsource//third-party/pypi/pytest:pytest",
],
)
8 changes: 3 additions & 5 deletions backends/qualcomm/aot/python/targets.bzl
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,10 +33,10 @@ def define_common_targets():
"//executorch/backends/qualcomm:schema",
"//executorch/backends/qualcomm/aot/ir:qcir_utils",
"//executorch/backends/qualcomm/runtime:runtime",
"fbsource//third-party/pybind11:pybind11",
"fbsource//third-party/qualcomm/qnn/qnn-{0}:api".format(get_qnn_library_verision()),
],
external_deps = [
"pybind11",
"libtorch_python",
],
use_static_deps = True,
Expand DownExpand Up@@ -66,10 +66,10 @@ def define_common_targets():
"//executorch/backends/qualcomm:schema",
"//executorch/backends/qualcomm/aot/ir:qcir_utils",
"//executorch/backends/qualcomm/runtime:runtime",
"fbsource//third-party/pybind11:pybind11",
"fbsource//third-party/qualcomm/qnn/qnn-{0}:api".format(get_qnn_library_verision()),
],
external_deps = [
"pybind11",
"libtorch_python",
],
use_static_deps = True,
Expand All@@ -93,9 +93,7 @@ def define_common_targets():
"//executorch/backends/qualcomm:schema",
"//executorch/backends/qualcomm/aot/ir:qcir_utils",
"//executorch/backends/qualcomm/runtime:runtime",
"fbsource//third-party/pybind11:pybind11",
"fbsource//third-party/qualcomm/qnn/qnn-{0}:api".format(get_qnn_library_verision()),
],
external_deps = [
"pybind11",
],
)
4 changes: 1 addition & 3 deletions exir/verification/TARGETS
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,13 +10,11 @@ cpp_python_extension(
"bindings.cpp",
],
deps = [
"fbsource//third-party/pybind11:pybind11",
"//caffe2:torch-cpp-cpu",
"//caffe2:torch_extension",
"//caffe2/c10:c10",
],
external_deps = [
"pybind11",
],
)

python_library(
Expand Down
8 changes: 2 additions & 6 deletions extension/pytree/TARGETS
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,11 +16,9 @@ cpp_python_extension(
],
base_module = "executorch.extension.pytree",
deps = [
"fbsource//third-party/pybind11:pybind11",
":pytree",
],
external_deps = [
"pybind11",
],
)

cpp_python_extension(
Expand All@@ -30,11 +28,9 @@ cpp_python_extension(
],
base_module = "executorch.extension.pytree",
deps = [
"fbsource//third-party/pybind11:pybind11",
":pytree",
],
external_deps = [
"pybind11",
],
)

python_library(
Expand Down
6 changes: 2 additions & 4 deletions extension/training/pybindings/TARGETS
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,13 +17,11 @@ runtime.cxx_python_extension(
types = ["_training_lib.pyi"],
visibility = ["//executorch/extension/training/..."],
deps = [
"fbsource//third-party/pybind11:pybind11",
"//executorch/extension/aten_util:aten_bridge",
"//executorch/extension/training/optimizer:sgd",
],
external_deps = [
"pybind11",
"libtorch_python",
],
external_deps = ["libtorch_python"],
)

runtime.python_library(
Expand Down