Uh oh!
There was an error while loading. Please reload this page.
add merge function for NamedDataStore - #8850
Merged
Merged
Conversation
lucylq
requested review from
JacobSzwejbka, larryliu0820 and tarun292
as code ownersFebruary 28, 2025 22:10
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8850
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 2c5ed91 with merge base a5f9210 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
commented
Feb 28, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D70409078 |
facebook-github-bot
commented
Feb 28, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D70409078 |
lucylqforce-pushed
the
export-D70409078
branch
from
February 28, 2025 22:14
e60b911 to
11df4f4Comparemcr229
reviewed
Feb 28, 2025
Uh oh!
There was an error while loading. Please reload this page.
Summary: Allow us to change the NamedDataStore model. Usage will now be: ``` named_data_store for backend in backends: bytes, named_data_store = backend.preprocess() named_data_store.merge(named_data_store) ``` Note: - named_data_store is held by edge program manager - preprocess returns the named data store as part of PreprocessResult Differential Revision: D70409078
lucylqforce-pushed
the
export-D70409078
branch
from
February 28, 2025 22:42
11df4f4 to
2c5ed91Comparefacebook-github-bot
commented
Feb 28, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D70409078 |
mcr229
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Allow us to change the NamedDataStore model. Usage will now be:
Note:
Differential Revision: D70409078