Skip to content

[ExecuTorch][XNNPACK] Don't partition per_tensor weights with qd8 - #8891

Merged
digantdesai merged 1 commit into
gh/digantdesai/19/basefrom
gh/digantdesai/19/head
Mar 4, 2025
Merged

[ExecuTorch][XNNPACK] Don't partition per_tensor weights with qd8#8891
digantdesai merged 1 commit into
gh/digantdesai/19/basefrom
gh/digantdesai/19/head

Conversation

@digantdesai

@digantdesaidigantdesai commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

This is not supported, so we shouldn't partition it.

Add an expectedFailure test to indicate that this is not supported

Differential Revision: D70343584

This is not supported, so we shouldn't partition it.
Add an expectedFailure test to indicate that this is not supported
Differential Revision: [D70343584](https://our.internmc.facebook.com/intern/diff/D70343584/)
[ghstack-poisoned]
@digantdesai
digantdesai requested a review from mcr229 as a code ownerMarch 3, 2025 19:45
@pytorch-bot

pytorch-botBot commented Mar 3, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8891

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ec4ce9f with merge base 542480c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D70343584

@digantdesai
digantdesai merged commit adcd607 into gh/digantdesai/19/baseMar 4, 2025
@digantdesai
digantdesai deleted the gh/digantdesai/19/head branch March 4, 2025 15:40
cccclai pushed a commit that referenced this pull request Mar 4, 2025
)
This is not supported, so we shouldn't partition it.
Add an expectedFailure test to indicate that this is not supported
Differential Revision: [D70343584](https://our.internmc.facebook.com/intern/diff/D70343584/)
ghstack-source-id: 269356867
Pull Request resolved: #8891
Co-authored-by: Digant Desai <digantdesai@meta.com>
zonglinpeng pushed a commit that referenced this pull request Mar 6, 2025
)
This is not supported, so we shouldn't partition it.
Add an expectedFailure test to indicate that this is not supported
Differential Revision: [D70343584](https://our.internmc.facebook.com/intern/diff/D70343584/)
ghstack-source-id: 269356867
Pull Request resolved: #8891
Co-authored-by: Digant Desai <digantdesai@meta.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedtopic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@digantdesai@facebook-github-bot@mcr229