Link xnn_executor_runner with optimized op library - #8901

Merged
swolchok merged 23 commits into
mainfrom
gh/swolchok/304/head
Mar 4, 2025
Merged

Link xnn_executor_runner with optimized op library#8901
swolchok merged 23 commits into
mainfrom
gh/swolchok/304/head

Conversation

@swolchok

@swolchokswolchok commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

Doesn't seem to be any reason not to allow optimized ops for this one.

@swolchok
Update
f1ace77
[ghstack-poisoned]
@swolchok
Update
d3a0f67
[ghstack-poisoned]
@swolchok
Update
a78277d
[ghstack-poisoned]
@swolchok
Update
6b6180c
[ghstack-poisoned]
@swolchok
Update
7cbe7a1
[ghstack-poisoned]
@swolchok
Update
8e8ce33
[ghstack-poisoned]
@swolchok
Update
093a6d3
[ghstack-poisoned]
@swolchok
Update
77f039c
[ghstack-poisoned]
@swolchok
Update
c4e4541
[ghstack-poisoned]
@swolchok
Update
18583c3
[ghstack-poisoned]
@swolchok

swolchok commented Mar 3, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-botBot commented Mar 3, 2025•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8901

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 18c64ad with merge base 09ad20a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchokswolchok mentioned this pull request Mar 3, 2025
Closed
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2025
This was referenced Mar 3, 2025
Closed
Closed
Closed
swolchok added a commit that referenced this pull request Mar 3, 2025
@swolchok
Link xnn_executor_runner with optimized op library
03e0582
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: aaf6617
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchokswolchok mentioned this pull request Mar 3, 2025
Merged
@swolchok
Update
d3edbcb
[ghstack-poisoned]
@swolchok
Update
bf96b84
[ghstack-poisoned]
@swolchok
Update
fe126ae
[ghstack-poisoned]
@swolchok
swolchok changed the base branch from gh/swolchok/302/head to gh/swolchok/299/headMarch 3, 2025 23:41
@kirklandsign

kirklandsign commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

Thanks @swolchok!

Ideally in OSS world we also have a executor_runner with optimized kernels, and use it as a test runner for all models. Maybe we can promote xnn_executor_runner to be this general runner.

BTW this PR has diff from other commits?

@swolchok

swolchok commented Mar 4, 2025

Copy link
Copy Markdown
ContributorAuthor

I'm having trouble exporting my stack; getting GitHub rate limits. Hopefully folks will review the bottom PR or two soon.

@swolchok
Update
a93cd69
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 4, 2025
@swolchok
Link xnn_executor_runner with optimized op library
59b32c3
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: 85e31ee
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchok

swolchok commented Mar 4, 2025

Copy link
Copy Markdown
ContributorAuthor

this PR has diff from other commits?

fixed, please review

@swolchok
swolchokforce-pushed the gh/swolchok/299/head branch from 7cbe7a1 to 7bc4529CompareMarch 4, 2025 00:28
@swolchok
Update
764977b
[ghstack-poisoned]
@swolchok
swolchokforce-pushed the gh/swolchok/299/head branch from 7bc4529 to 764977bCompareMarch 4, 2025 16:11
digantdesai
digantdesai reviewed Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt Outdated

target_link_libraries(
xnn_executor_runner gflags portable_ops_lib ${xnn_executor_runner_libs}
xnn_executor_runner gflags optimized_native_cpu_ops_lib ${xnn_executor_runner_libs}

@digantdesaidigantdesaiMar 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! So many perf cliffs because of this.

@swolchok
Update
c7d57ee
[ghstack-poisoned]
@swolchok
Update
fa09b62
[ghstack-poisoned]
@swolchok
Update
58f544f
[ghstack-poisoned]
@swolchok
Update
fd6a085
[ghstack-poisoned]
@swolchok
Update
3143085
[ghstack-poisoned]
@swolchok
Update
deb1934
[ghstack-poisoned]
@swolchok
Update
80589b0
[ghstack-poisoned]
@swolchok
swolchok changed the base branch from gh/swolchok/299/head to mainMarch 4, 2025 17:47
@swolchokswolchok added the release notes: devtools Changes to dev tooling, for example the debugger & profiler label Mar 4, 2025
@swolchok
Update
18c64ad
[ghstack-poisoned]
swolchok
swolchok commented Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
target_compile_options(xnnpack_backend PUBLIC ${_common_compile_options})
target_link_options_shared_lib(xnnpack_backend)

if(EXECUTORCH_BUILD_KERNELS_OPTIMIZED)

@swolchokswolchokMar 4, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed build when XNNPACK is on but optimized lib is off. everything else (except corresponding change to line 149 below) is just cmake-format.

@swolchok
swolchok merged commit 6caefc3 into mainMar 4, 2025
@swolchok
swolchok deleted the gh/swolchok/304/head branch March 4, 2025 19:17
zonglinpeng pushed a commit that referenced this pull request Mar 6, 2025
@swolchokZonglin Peng
Link xnn_executor_runner with optimized op library (#8901)
a78101b
Doesn't seem to be any reason not to allow optimized ops for this one.
@github-actionsgithub-actionsBot mentioned this pull request Mar 10, 2025
Open
This was referenced Mar 17, 2025
Open
Open
@github-actionsgithub-actionsBot mentioned this pull request Mar 31, 2025
Open
@github-actionsgithub-actionsBot mentioned this pull request Apr 7, 2025
Open
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
@swolchok
Link xnn_executor_runner with optimized op library
97f8d6a
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: a8d06d4
ghstack-comment-id: 2695738759
Pull Request resolved: pytorch/executorch#8901
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes
@kirklandsignkirklandsignkirklandsign approved these changes
@mcr229mcr229Awaiting requested review from mcr229
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandales

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: devtoolsChanges to dev tooling, for example the debugger & profiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@kirklandsign@digantdesai@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Link xnn_executor_runner with optimized op library - #8901
Merged
swolchok merged 23 commits into
mainfrom 
gh/swolchok/304/head
Mar 4, 2025
Merged
Link xnn_executor_runner with optimized op library#8901
swolchok merged 23 commits into
mainfrom 
gh/swolchok/304/head
Conversation
@swolchok
@swolchokswolchok
commented
Mar 3, 2025

Copy link


Copy Markdown

Contributor
Doesn't seem to be any reason not to allow optimized ops for this one.
@swolchok
Update
f1ace77
[ghstack-poisoned]
@swolchok
Update
d3a0f67
[ghstack-poisoned]
@swolchok
Update
a78277d
[ghstack-poisoned]
@swolchok
Update
6b6180c
[ghstack-poisoned]
@swolchok
Update
7cbe7a1
[ghstack-poisoned]
@swolchok
Update
8e8ce33
[ghstack-poisoned]
@swolchok
Update
093a6d3
[ghstack-poisoned]
@swolchok
Update
77f039c
[ghstack-poisoned]
@swolchok
Update
c4e4541
[ghstack-poisoned]
@swolchok
Update
18583c3
[ghstack-poisoned]
@swolchok
swolchok
commented
Mar 3, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Stack from ghstack (oldest at bottom):
@pytorch-bot
pytorch-botBot
commented
Mar 3, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8901
Note: Links to docs will display an error until the docs builds have been completed.
⏳ No Failures, 2 Pending
As of commit 18c64ad with merge base 09ad20a (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@swolchokswolchok
mentioned this pull request
Mar 3, 2025
 Closed

@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Mar 3, 2025

This was referenced Mar 3, 2025
 Closed

 Closed

 Closed

swolchok added a commit
that referenced
this pull request
Mar 3, 2025
@swolchok
Link xnn_executor_runner with optimized op library
03e0582
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: aaf6617
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchokswolchok
mentioned this pull request
Mar 3, 2025
 Merged

@swolchok
Update
d3edbcb
[ghstack-poisoned]
@swolchok
Update
bf96b84
[ghstack-poisoned]
@swolchok
Update
fe126ae
[ghstack-poisoned]
@swolchok
swolchok
changed the base branch from
gh/swolchok/302/head
to
gh/swolchok/299/headMarch 3, 2025 23:41
@kirklandsign
kirklandsign
commented
Mar 4, 2025

Copy link


Copy Markdown

Contributor
Thanks @swolchok!
Ideally in OSS world we also have a executor_runner with optimized kernels, and use it as a test runner for all models. Maybe we can promote xnn_executor_runner to be this general runner.
BTW this PR has diff from other commits?
@swolchok
swolchok
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
I'm having trouble exporting my stack; getting GitHub rate limits. Hopefully folks will review the bottom PR or two soon.
@swolchok
Update
a93cd69
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Mar 4, 2025
@swolchok
Link xnn_executor_runner with optimized op library
59b32c3
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: 85e31ee
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchok
swolchok
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
this PR has diff from other commits?
fixed, please review
@swolchok
swolchokforce-pushed
the
gh/swolchok/299/head
branch
from
7cbe7a1 to
7bc4529CompareMarch 4, 2025 00:28
@swolchok
Update
764977b
[ghstack-poisoned]
@swolchok
swolchokforce-pushed
the
gh/swolchok/299/head
branch
from
7bc4529 to
764977bCompareMarch 4, 2025 16:11
digantdesai
digantdesai
reviewed
Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
Outdated


 target_link_libraries(
 xnn_executor_runner gflags portable_ops_lib ${xnn_executor_runner_libs}
 xnn_executor_runner gflags optimized_native_cpu_ops_lib ${xnn_executor_runner_libs}
@digantdesaidigantdesaiMar 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! So many perf cliffs because of this.
@swolchok
Update
c7d57ee
[ghstack-poisoned]
@swolchok
Update
fa09b62
[ghstack-poisoned]
@swolchok
Update
58f544f
[ghstack-poisoned]
@swolchok
Update
fd6a085
[ghstack-poisoned]
@swolchok
Update
3143085
[ghstack-poisoned]
@swolchok
Update
deb1934
[ghstack-poisoned]
@swolchok
Update
80589b0
[ghstack-poisoned]
@swolchok
swolchok
changed the base branch from
gh/swolchok/299/head
to
mainMarch 4, 2025 17:47
@swolchokswolchok
added
the 
release notes: devtools
Changes to dev tooling, for example the debugger & profiler
label
Mar 4, 2025
@swolchok
Update
18c64ad
[ghstack-poisoned]
swolchok
swolchok
commented
Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
target_compile_options(xnnpack_backend PUBLIC ${_common_compile_options})
target_link_options_shared_lib(xnnpack_backend)

if(EXECUTORCH_BUILD_KERNELS_OPTIMIZED)
@swolchokswolchokMar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed build when XNNPACK is on but optimized lib is off. everything else (except corresponding change to line 149 below) is just cmake-format.
@swolchok
swolchok
merged commit 6caefc3
into
mainMar 4, 2025
@swolchok
swolchok
deleted the

gh/swolchok/304/head

branch
March 4, 2025 19:17
zonglinpeng pushed a commit
that referenced
this pull request
Mar 6, 2025
@swolchokZonglin Peng
Link xnn_executor_runner with optimized op library (#8901)
a78101b
Doesn't seem to be any reason not to allow optimized ops for this one.
@github-actionsgithub-actionsBot
mentioned this pull request
Mar 10, 2025

Open


This was referenced Mar 17, 2025

Open


Open

@github-actionsgithub-actionsBot
mentioned this pull request
Mar 31, 2025

Open

@github-actionsgithub-actionsBot
mentioned this pull request
Apr 7, 2025

Open

kedarnath03 pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
@swolchok
Link xnn_executor_runner with optimized op library
97f8d6a
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: a8d06d4
ghstack-comment-id: 2695738759
Pull Request resolved: pytorch/executorch#8901
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes
@kirklandsignkirklandsignkirklandsign approved these changes
@mcr229mcr229Awaiting requested review from mcr229
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandales

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: devtoolsChanges to dev tooling, for example the debugger & profiler

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@kirklandsign@digantdesai@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Link xnn_executor_runner with optimized op library - #8901
Merged
swolchok merged 23 commits into
mainfrom 
gh/swolchok/304/head
Mar 4, 2025
Merged
Link xnn_executor_runner with optimized op library#8901
swolchok merged 23 commits into
mainfrom 
gh/swolchok/304/head
Conversation
@swolchok
@swolchokswolchok
commented
Mar 3, 2025

Copy link


Copy Markdown

Contributor
Doesn't seem to be any reason not to allow optimized ops for this one.
@swolchok
Update
f1ace77
[ghstack-poisoned]
@swolchok
Update
d3a0f67
[ghstack-poisoned]
@swolchok
Update
a78277d
[ghstack-poisoned]
@swolchok
Update
6b6180c
[ghstack-poisoned]
@swolchok
Update
7cbe7a1
[ghstack-poisoned]
@swolchok
Update
8e8ce33
[ghstack-poisoned]
@swolchok
Update
093a6d3
[ghstack-poisoned]
@swolchok
Update
77f039c
[ghstack-poisoned]
@swolchok
Update
c4e4541
[ghstack-poisoned]
@swolchok
Update
18583c3
[ghstack-poisoned]
@swolchok
swolchok
commented
Mar 3, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Stack from ghstack (oldest at bottom):
@pytorch-bot
pytorch-botBot
commented
Mar 3, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8901
Note: Links to docs will display an error until the docs builds have been completed.
⏳ No Failures, 2 Pending
As of commit 18c64ad with merge base 09ad20a (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@swolchokswolchok
mentioned this pull request
Mar 3, 2025
 Closed

@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Mar 3, 2025

This was referenced Mar 3, 2025
 Closed

 Closed

 Closed

swolchok added a commit
that referenced
this pull request
Mar 3, 2025
@swolchok
Link xnn_executor_runner with optimized op library
03e0582
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: aaf6617
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchokswolchok
mentioned this pull request
Mar 3, 2025
 Merged

@swolchok
Update
d3edbcb
[ghstack-poisoned]
@swolchok
Update
bf96b84
[ghstack-poisoned]
@swolchok
Update
fe126ae
[ghstack-poisoned]
@swolchok
swolchok
changed the base branch from
gh/swolchok/302/head
to
gh/swolchok/299/headMarch 3, 2025 23:41
@kirklandsign
kirklandsign
commented
Mar 4, 2025

Copy link


Copy Markdown

Contributor
Thanks @swolchok!
Ideally in OSS world we also have a executor_runner with optimized kernels, and use it as a test runner for all models. Maybe we can promote xnn_executor_runner to be this general runner.
BTW this PR has diff from other commits?
@swolchok
swolchok
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
I'm having trouble exporting my stack; getting GitHub rate limits. Hopefully folks will review the bottom PR or two soon.
@swolchok
Update
a93cd69
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Mar 4, 2025
@swolchok
Link xnn_executor_runner with optimized op library
59b32c3
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: 85e31ee
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchok
swolchok
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
this PR has diff from other commits?
fixed, please review
@swolchok
swolchokforce-pushed
the
gh/swolchok/299/head
branch
from
7cbe7a1 to
7bc4529CompareMarch 4, 2025 00:28
@swolchok
Update
764977b
[ghstack-poisoned]
@swolchok
swolchokforce-pushed
the
gh/swolchok/299/head
branch
from
7bc4529 to
764977bCompareMarch 4, 2025 16:11
digantdesai
digantdesai
reviewed
Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
Outdated


 target_link_libraries(
 xnn_executor_runner gflags portable_ops_lib ${xnn_executor_runner_libs}
 xnn_executor_runner gflags optimized_native_cpu_ops_lib ${xnn_executor_runner_libs}
@digantdesaidigantdesaiMar 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! So many perf cliffs because of this.
@swolchok
Update
c7d57ee
[ghstack-poisoned]
@swolchok
Update
fa09b62
[ghstack-poisoned]
@swolchok
Update
58f544f
[ghstack-poisoned]
@swolchok
Update
fd6a085
[ghstack-poisoned]
@swolchok
Update
3143085
[ghstack-poisoned]
@swolchok
Update
deb1934
[ghstack-poisoned]
@swolchok
Update
80589b0
[ghstack-poisoned]
@swolchok
swolchok
changed the base branch from
gh/swolchok/299/head
to
mainMarch 4, 2025 17:47
@swolchokswolchok
added
the 
release notes: devtools
Changes to dev tooling, for example the debugger & profiler
label
Mar 4, 2025
@swolchok
Update
18c64ad
[ghstack-poisoned]
swolchok
swolchok
commented
Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
target_compile_options(xnnpack_backend PUBLIC ${_common_compile_options})
target_link_options_shared_lib(xnnpack_backend)

if(EXECUTORCH_BUILD_KERNELS_OPTIMIZED)
@swolchokswolchokMar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed build when XNNPACK is on but optimized lib is off. everything else (except corresponding change to line 149 below) is just cmake-format.
@swolchok
swolchok
merged commit 6caefc3
into
mainMar 4, 2025
@swolchok
swolchok
deleted the

gh/swolchok/304/head

branch
March 4, 2025 19:17
zonglinpeng pushed a commit
that referenced
this pull request
Mar 6, 2025
@swolchokZonglin Peng
Link xnn_executor_runner with optimized op library (#8901)
a78101b
Doesn't seem to be any reason not to allow optimized ops for this one.
@github-actionsgithub-actionsBot
mentioned this pull request
Mar 10, 2025

Open


This was referenced Mar 17, 2025

Open


Open

@github-actionsgithub-actionsBot
mentioned this pull request
Mar 31, 2025

Open

@github-actionsgithub-actionsBot
mentioned this pull request
Apr 7, 2025

Open

kedarnath03 pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
@swolchok
Link xnn_executor_runner with optimized op library
97f8d6a
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: a8d06d4
ghstack-comment-id: 2695738759
Pull Request resolved: pytorch/executorch#8901
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes
@kirklandsignkirklandsignkirklandsign approved these changes
@mcr229mcr229Awaiting requested review from mcr229
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandales

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: devtoolsChanges to dev tooling, for example the debugger & profiler

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@kirklandsign@digantdesai@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Link xnn_executor_runner with optimized op library - #8901
Merged
swolchok merged 23 commits into
mainfrom 
gh/swolchok/304/head
Mar 4, 2025
Merged
Link xnn_executor_runner with optimized op library#8901
swolchok merged 23 commits into
mainfrom 
gh/swolchok/304/head
Conversation
@swolchok
@swolchokswolchok
commented
Mar 3, 2025

Copy link


Copy Markdown

Contributor
Doesn't seem to be any reason not to allow optimized ops for this one.
@swolchok
Update
f1ace77
[ghstack-poisoned]
@swolchok
Update
d3a0f67
[ghstack-poisoned]
@swolchok
Update
a78277d
[ghstack-poisoned]
@swolchok
Update
6b6180c
[ghstack-poisoned]
@swolchok
Update
7cbe7a1
[ghstack-poisoned]
@swolchok
Update
8e8ce33
[ghstack-poisoned]
@swolchok
Update
093a6d3
[ghstack-poisoned]
@swolchok
Update
77f039c
[ghstack-poisoned]
@swolchok
Update
c4e4541
[ghstack-poisoned]
@swolchok
Update
18583c3
[ghstack-poisoned]
@swolchok
swolchok
commented
Mar 3, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Stack from ghstack (oldest at bottom):
@pytorch-bot
pytorch-botBot
commented
Mar 3, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8901
Note: Links to docs will display an error until the docs builds have been completed.
⏳ No Failures, 2 Pending
As of commit 18c64ad with merge base 09ad20a (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@swolchokswolchok
mentioned this pull request
Mar 3, 2025
 Closed

@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Mar 3, 2025

This was referenced Mar 3, 2025
 Closed

 Closed

 Closed

swolchok added a commit
that referenced
this pull request
Mar 3, 2025
@swolchok
Link xnn_executor_runner with optimized op library
03e0582
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: aaf6617
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchokswolchok
mentioned this pull request
Mar 3, 2025
 Merged

@swolchok
Update
d3edbcb
[ghstack-poisoned]
@swolchok
Update
bf96b84
[ghstack-poisoned]
@swolchok
Update
fe126ae
[ghstack-poisoned]
@swolchok
swolchok
changed the base branch from
gh/swolchok/302/head
to
gh/swolchok/299/headMarch 3, 2025 23:41
@kirklandsign
kirklandsign
commented
Mar 4, 2025

Copy link


Copy Markdown

Contributor
Thanks @swolchok!
Ideally in OSS world we also have a executor_runner with optimized kernels, and use it as a test runner for all models. Maybe we can promote xnn_executor_runner to be this general runner.
BTW this PR has diff from other commits?
@swolchok
swolchok
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
I'm having trouble exporting my stack; getting GitHub rate limits. Hopefully folks will review the bottom PR or two soon.
@swolchok
Update
a93cd69
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Mar 4, 2025
@swolchok
Link xnn_executor_runner with optimized op library
59b32c3
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: 85e31ee
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchok
swolchok
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
this PR has diff from other commits?
fixed, please review
@swolchok
swolchokforce-pushed
the
gh/swolchok/299/head
branch
from
7cbe7a1 to
7bc4529CompareMarch 4, 2025 00:28
@swolchok
Update
764977b
[ghstack-poisoned]
@swolchok
swolchokforce-pushed
the
gh/swolchok/299/head
branch
from
7bc4529 to
764977bCompareMarch 4, 2025 16:11
digantdesai
digantdesai
reviewed
Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
Outdated


 target_link_libraries(
 xnn_executor_runner gflags portable_ops_lib ${xnn_executor_runner_libs}
 xnn_executor_runner gflags optimized_native_cpu_ops_lib ${xnn_executor_runner_libs}
@digantdesaidigantdesaiMar 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! So many perf cliffs because of this.
@swolchok
Update
c7d57ee
[ghstack-poisoned]
@swolchok
Update
fa09b62
[ghstack-poisoned]
@swolchok
Update
58f544f
[ghstack-poisoned]
@swolchok
Update
fd6a085
[ghstack-poisoned]
@swolchok
Update
3143085
[ghstack-poisoned]
@swolchok
Update
deb1934
[ghstack-poisoned]
@swolchok
Update
80589b0
[ghstack-poisoned]
@swolchok
swolchok
changed the base branch from
gh/swolchok/299/head
to
mainMarch 4, 2025 17:47
@swolchokswolchok
added
the 
release notes: devtools
Changes to dev tooling, for example the debugger & profiler
label
Mar 4, 2025
@swolchok
Update
18c64ad
[ghstack-poisoned]
swolchok
swolchok
commented
Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
target_compile_options(xnnpack_backend PUBLIC ${_common_compile_options})
target_link_options_shared_lib(xnnpack_backend)

if(EXECUTORCH_BUILD_KERNELS_OPTIMIZED)
@swolchokswolchokMar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed build when XNNPACK is on but optimized lib is off. everything else (except corresponding change to line 149 below) is just cmake-format.
@swolchok
swolchok
merged commit 6caefc3
into
mainMar 4, 2025
@swolchok
swolchok
deleted the

gh/swolchok/304/head

branch
March 4, 2025 19:17
zonglinpeng pushed a commit
that referenced
this pull request
Mar 6, 2025
@swolchokZonglin Peng
Link xnn_executor_runner with optimized op library (#8901)
a78101b
Doesn't seem to be any reason not to allow optimized ops for this one.
@github-actionsgithub-actionsBot
mentioned this pull request
Mar 10, 2025

Open


This was referenced Mar 17, 2025

Open


Open

@github-actionsgithub-actionsBot
mentioned this pull request
Mar 31, 2025

Open

@github-actionsgithub-actionsBot
mentioned this pull request
Apr 7, 2025

Open

kedarnath03 pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
@swolchok
Link xnn_executor_runner with optimized op library
97f8d6a
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: a8d06d4
ghstack-comment-id: 2695738759
Pull Request resolved: pytorch/executorch#8901
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes
@kirklandsignkirklandsignkirklandsign approved these changes
@mcr229mcr229Awaiting requested review from mcr229
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandales

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: devtoolsChanges to dev tooling, for example the debugger & profiler

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@kirklandsign@digantdesai@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Link xnn_executor_runner with optimized op library - #8901
Merged
swolchok merged 23 commits into
mainfrom 
gh/swolchok/304/head
Mar 4, 2025
Merged
Link xnn_executor_runner with optimized op library#8901
swolchok merged 23 commits into
mainfrom 
gh/swolchok/304/head
Conversation
@swolchok
@swolchokswolchok
commented
Mar 3, 2025

Copy link


Copy Markdown

Contributor
Doesn't seem to be any reason not to allow optimized ops for this one.
@swolchok
Update
f1ace77
[ghstack-poisoned]
@swolchok
Update
d3a0f67
[ghstack-poisoned]
@swolchok
Update
a78277d
[ghstack-poisoned]
@swolchok
Update
6b6180c
[ghstack-poisoned]
@swolchok
Update
7cbe7a1
[ghstack-poisoned]
@swolchok
Update
8e8ce33
[ghstack-poisoned]
@swolchok
Update
093a6d3
[ghstack-poisoned]
@swolchok
Update
77f039c
[ghstack-poisoned]
@swolchok
Update
c4e4541
[ghstack-poisoned]
@swolchok
Update
18583c3
[ghstack-poisoned]
@swolchok
swolchok
commented
Mar 3, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Stack from ghstack (oldest at bottom):
@pytorch-bot
pytorch-botBot
commented
Mar 3, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8901
Note: Links to docs will display an error until the docs builds have been completed.
⏳ No Failures, 2 Pending
As of commit 18c64ad with merge base 09ad20a (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@swolchokswolchok
mentioned this pull request
Mar 3, 2025
 Closed

@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Mar 3, 2025

This was referenced Mar 3, 2025
 Closed

 Closed

 Closed

swolchok added a commit
that referenced
this pull request
Mar 3, 2025
@swolchok
Link xnn_executor_runner with optimized op library
03e0582
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: aaf6617
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchokswolchok
mentioned this pull request
Mar 3, 2025
 Merged

@swolchok
Update
d3edbcb
[ghstack-poisoned]
@swolchok
Update
bf96b84
[ghstack-poisoned]
@swolchok
Update
fe126ae
[ghstack-poisoned]
@swolchok
swolchok
changed the base branch from
gh/swolchok/302/head
to
gh/swolchok/299/headMarch 3, 2025 23:41
@kirklandsign
kirklandsign
commented
Mar 4, 2025

Copy link


Copy Markdown

Contributor
Thanks @swolchok!
Ideally in OSS world we also have a executor_runner with optimized kernels, and use it as a test runner for all models. Maybe we can promote xnn_executor_runner to be this general runner.
BTW this PR has diff from other commits?
@swolchok
swolchok
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
I'm having trouble exporting my stack; getting GitHub rate limits. Hopefully folks will review the bottom PR or two soon.
@swolchok
Update
a93cd69
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Mar 4, 2025
@swolchok
Link xnn_executor_runner with optimized op library
59b32c3
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: 85e31ee
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchok
swolchok
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
this PR has diff from other commits?
fixed, please review
@swolchok
swolchokforce-pushed
the
gh/swolchok/299/head
branch
from
7cbe7a1 to
7bc4529CompareMarch 4, 2025 00:28
@swolchok
Update
764977b
[ghstack-poisoned]
@swolchok
swolchokforce-pushed
the
gh/swolchok/299/head
branch
from
7bc4529 to
764977bCompareMarch 4, 2025 16:11
digantdesai
digantdesai
reviewed
Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
Outdated


 target_link_libraries(
 xnn_executor_runner gflags portable_ops_lib ${xnn_executor_runner_libs}
 xnn_executor_runner gflags optimized_native_cpu_ops_lib ${xnn_executor_runner_libs}
@digantdesaidigantdesaiMar 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! So many perf cliffs because of this.
@swolchok
Update
c7d57ee
[ghstack-poisoned]
@swolchok
Update
fa09b62
[ghstack-poisoned]
@swolchok
Update
58f544f
[ghstack-poisoned]
@swolchok
Update
fd6a085
[ghstack-poisoned]
@swolchok
Update
3143085
[ghstack-poisoned]
@swolchok
Update
deb1934
[ghstack-poisoned]
@swolchok
Update
80589b0
[ghstack-poisoned]
@swolchok
swolchok
changed the base branch from
gh/swolchok/299/head
to
mainMarch 4, 2025 17:47
@swolchokswolchok
added
the 
release notes: devtools
Changes to dev tooling, for example the debugger & profiler
label
Mar 4, 2025
@swolchok
Update
18c64ad
[ghstack-poisoned]
swolchok
swolchok
commented
Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
target_compile_options(xnnpack_backend PUBLIC ${_common_compile_options})
target_link_options_shared_lib(xnnpack_backend)

if(EXECUTORCH_BUILD_KERNELS_OPTIMIZED)
@swolchokswolchokMar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed build when XNNPACK is on but optimized lib is off. everything else (except corresponding change to line 149 below) is just cmake-format.
@swolchok
swolchok
merged commit 6caefc3
into
mainMar 4, 2025
@swolchok
swolchok
deleted the

gh/swolchok/304/head

branch
March 4, 2025 19:17
zonglinpeng pushed a commit
that referenced
this pull request
Mar 6, 2025
@swolchokZonglin Peng
Link xnn_executor_runner with optimized op library (#8901)
a78101b
Doesn't seem to be any reason not to allow optimized ops for this one.
@github-actionsgithub-actionsBot
mentioned this pull request
Mar 10, 2025

Open


This was referenced Mar 17, 2025

Open


Open

@github-actionsgithub-actionsBot
mentioned this pull request
Mar 31, 2025

Open

@github-actionsgithub-actionsBot
mentioned this pull request
Apr 7, 2025

Open

kedarnath03 pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
@swolchok
Link xnn_executor_runner with optimized op library
97f8d6a
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: a8d06d4
ghstack-comment-id: 2695738759
Pull Request resolved: pytorch/executorch#8901
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes
@kirklandsignkirklandsignkirklandsign approved these changes
@mcr229mcr229Awaiting requested review from mcr229
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandales

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: devtoolsChanges to dev tooling, for example the debugger & profiler

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@kirklandsign@digantdesai@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Link xnn_executor_runner with optimized op library - #8901
Merged
swolchok merged 23 commits into
mainfrom 
gh/swolchok/304/head
Mar 4, 2025
Merged
Link xnn_executor_runner with optimized op library#8901
swolchok merged 23 commits into
mainfrom 
gh/swolchok/304/head
Conversation
@swolchok
@swolchokswolchok
commented
Mar 3, 2025

Copy link


Copy Markdown

Contributor
Doesn't seem to be any reason not to allow optimized ops for this one.
@swolchok
Update
f1ace77
[ghstack-poisoned]
@swolchok
Update
d3a0f67
[ghstack-poisoned]
@swolchok
Update
a78277d
[ghstack-poisoned]
@swolchok
Update
6b6180c
[ghstack-poisoned]
@swolchok
Update
7cbe7a1
[ghstack-poisoned]
@swolchok
Update
8e8ce33
[ghstack-poisoned]
@swolchok
Update
093a6d3
[ghstack-poisoned]
@swolchok
Update
77f039c
[ghstack-poisoned]
@swolchok
Update
c4e4541
[ghstack-poisoned]
@swolchok
Update
18583c3
[ghstack-poisoned]
@swolchok
swolchok
commented
Mar 3, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Stack from ghstack (oldest at bottom):
@pytorch-bot
pytorch-botBot
commented
Mar 3, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8901
Note: Links to docs will display an error until the docs builds have been completed.
⏳ No Failures, 2 Pending
As of commit 18c64ad with merge base 09ad20a (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@swolchokswolchok
mentioned this pull request
Mar 3, 2025
 Closed

@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Mar 3, 2025

This was referenced Mar 3, 2025
 Closed

 Closed

 Closed

swolchok added a commit
that referenced
this pull request
Mar 3, 2025
@swolchok
Link xnn_executor_runner with optimized op library
03e0582
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: aaf6617
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchokswolchok
mentioned this pull request
Mar 3, 2025
 Merged

@swolchok
Update
d3edbcb
[ghstack-poisoned]
@swolchok
Update
bf96b84
[ghstack-poisoned]
@swolchok
Update
fe126ae
[ghstack-poisoned]
@swolchok
swolchok
changed the base branch from
gh/swolchok/302/head
to
gh/swolchok/299/headMarch 3, 2025 23:41
@kirklandsign
kirklandsign
commented
Mar 4, 2025

Copy link


Copy Markdown

Contributor
Thanks @swolchok!
Ideally in OSS world we also have a executor_runner with optimized kernels, and use it as a test runner for all models. Maybe we can promote xnn_executor_runner to be this general runner.
BTW this PR has diff from other commits?
@swolchok
swolchok
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
I'm having trouble exporting my stack; getting GitHub rate limits. Hopefully folks will review the bottom PR or two soon.
@swolchok
Update
a93cd69
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Mar 4, 2025
@swolchok
Link xnn_executor_runner with optimized op library
59b32c3
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: 85e31ee
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchok
swolchok
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
this PR has diff from other commits?
fixed, please review
@swolchok
swolchokforce-pushed
the
gh/swolchok/299/head
branch
from
7cbe7a1 to
7bc4529CompareMarch 4, 2025 00:28
@swolchok
Update
764977b
[ghstack-poisoned]
@swolchok
swolchokforce-pushed
the
gh/swolchok/299/head
branch
from
7bc4529 to
764977bCompareMarch 4, 2025 16:11
digantdesai
digantdesai
reviewed
Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
Outdated


 target_link_libraries(
 xnn_executor_runner gflags portable_ops_lib ${xnn_executor_runner_libs}
 xnn_executor_runner gflags optimized_native_cpu_ops_lib ${xnn_executor_runner_libs}
@digantdesaidigantdesaiMar 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! So many perf cliffs because of this.
@swolchok
Update
c7d57ee
[ghstack-poisoned]
@swolchok
Update
fa09b62
[ghstack-poisoned]
@swolchok
Update
58f544f
[ghstack-poisoned]
@swolchok
Update
fd6a085
[ghstack-poisoned]
@swolchok
Update
3143085
[ghstack-poisoned]
@swolchok
Update
deb1934
[ghstack-poisoned]
@swolchok
Update
80589b0
[ghstack-poisoned]
@swolchok
swolchok
changed the base branch from
gh/swolchok/299/head
to
mainMarch 4, 2025 17:47
@swolchokswolchok
added
the 
release notes: devtools
Changes to dev tooling, for example the debugger & profiler
label
Mar 4, 2025
@swolchok
Update
18c64ad
[ghstack-poisoned]
swolchok
swolchok
commented
Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
target_compile_options(xnnpack_backend PUBLIC ${_common_compile_options})
target_link_options_shared_lib(xnnpack_backend)

if(EXECUTORCH_BUILD_KERNELS_OPTIMIZED)
@swolchokswolchokMar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed build when XNNPACK is on but optimized lib is off. everything else (except corresponding change to line 149 below) is just cmake-format.
@swolchok
swolchok
merged commit 6caefc3
into
mainMar 4, 2025
@swolchok
swolchok
deleted the

gh/swolchok/304/head

branch
March 4, 2025 19:17
zonglinpeng pushed a commit
that referenced
this pull request
Mar 6, 2025
@swolchokZonglin Peng
Link xnn_executor_runner with optimized op library (#8901)
a78101b
Doesn't seem to be any reason not to allow optimized ops for this one.
@github-actionsgithub-actionsBot
mentioned this pull request
Mar 10, 2025

Open


This was referenced Mar 17, 2025

Open


Open

@github-actionsgithub-actionsBot
mentioned this pull request
Mar 31, 2025

Open

@github-actionsgithub-actionsBot
mentioned this pull request
Apr 7, 2025

Open

kedarnath03 pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
@swolchok
Link xnn_executor_runner with optimized op library
97f8d6a
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: a8d06d4
ghstack-comment-id: 2695738759
Pull Request resolved: pytorch/executorch#8901
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes
@kirklandsignkirklandsignkirklandsign approved these changes
@mcr229mcr229Awaiting requested review from mcr229
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandales

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: devtoolsChanges to dev tooling, for example the debugger & profiler

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@kirklandsign@digantdesai@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Link xnn_executor_runner with optimized op library - #8901
Merged
swolchok merged 23 commits into
mainfrom 
gh/swolchok/304/head
Mar 4, 2025
Merged
Link xnn_executor_runner with optimized op library#8901
swolchok merged 23 commits into
mainfrom 
gh/swolchok/304/head
Conversation
@swolchok
@swolchokswolchok
commented
Mar 3, 2025

Copy link


Copy Markdown

Contributor
Doesn't seem to be any reason not to allow optimized ops for this one.
@swolchok
Update
f1ace77
[ghstack-poisoned]
@swolchok
Update
d3a0f67
[ghstack-poisoned]
@swolchok
Update
a78277d
[ghstack-poisoned]
@swolchok
Update
6b6180c
[ghstack-poisoned]
@swolchok
Update
7cbe7a1
[ghstack-poisoned]
@swolchok
Update
8e8ce33
[ghstack-poisoned]
@swolchok
Update
093a6d3
[ghstack-poisoned]
@swolchok
Update
77f039c
[ghstack-poisoned]
@swolchok
Update
c4e4541
[ghstack-poisoned]
@swolchok
Update
18583c3
[ghstack-poisoned]
@swolchok
swolchok
commented
Mar 3, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Stack from ghstack (oldest at bottom):
@pytorch-bot
pytorch-botBot
commented
Mar 3, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8901
Note: Links to docs will display an error until the docs builds have been completed.
⏳ No Failures, 2 Pending
As of commit 18c64ad with merge base 09ad20a (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@swolchokswolchok
mentioned this pull request
Mar 3, 2025
 Closed

@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Mar 3, 2025

This was referenced Mar 3, 2025
 Closed

 Closed

 Closed

swolchok added a commit
that referenced
this pull request
Mar 3, 2025
@swolchok
Link xnn_executor_runner with optimized op library
03e0582
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: aaf6617
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchokswolchok
mentioned this pull request
Mar 3, 2025
 Merged

@swolchok
Update
d3edbcb
[ghstack-poisoned]
@swolchok
Update
bf96b84
[ghstack-poisoned]
@swolchok
Update
fe126ae
[ghstack-poisoned]
@swolchok
swolchok
changed the base branch from
gh/swolchok/302/head
to
gh/swolchok/299/headMarch 3, 2025 23:41
@kirklandsign
kirklandsign
commented
Mar 4, 2025

Copy link


Copy Markdown

Contributor
Thanks @swolchok!
Ideally in OSS world we also have a executor_runner with optimized kernels, and use it as a test runner for all models. Maybe we can promote xnn_executor_runner to be this general runner.
BTW this PR has diff from other commits?
@swolchok
swolchok
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
I'm having trouble exporting my stack; getting GitHub rate limits. Hopefully folks will review the bottom PR or two soon.
@swolchok
Update
a93cd69
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Mar 4, 2025
@swolchok
Link xnn_executor_runner with optimized op library
59b32c3
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: 85e31ee
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchok
swolchok
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
this PR has diff from other commits?
fixed, please review
@swolchok
swolchokforce-pushed
the
gh/swolchok/299/head
branch
from
7cbe7a1 to
7bc4529CompareMarch 4, 2025 00:28
@swolchok
Update
764977b
[ghstack-poisoned]
@swolchok
swolchokforce-pushed
the
gh/swolchok/299/head
branch
from
7bc4529 to
764977bCompareMarch 4, 2025 16:11
digantdesai
digantdesai
reviewed
Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
Outdated


 target_link_libraries(
 xnn_executor_runner gflags portable_ops_lib ${xnn_executor_runner_libs}
 xnn_executor_runner gflags optimized_native_cpu_ops_lib ${xnn_executor_runner_libs}
@digantdesaidigantdesaiMar 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! So many perf cliffs because of this.
@swolchok
Update
c7d57ee
[ghstack-poisoned]
@swolchok
Update
fa09b62
[ghstack-poisoned]
@swolchok
Update
58f544f
[ghstack-poisoned]
@swolchok
Update
fd6a085
[ghstack-poisoned]
@swolchok
Update
3143085
[ghstack-poisoned]
@swolchok
Update
deb1934
[ghstack-poisoned]
@swolchok
Update
80589b0
[ghstack-poisoned]
@swolchok
swolchok
changed the base branch from
gh/swolchok/299/head
to
mainMarch 4, 2025 17:47
@swolchokswolchok
added
the 
release notes: devtools
Changes to dev tooling, for example the debugger & profiler
label
Mar 4, 2025
@swolchok
Update
18c64ad
[ghstack-poisoned]
swolchok
swolchok
commented
Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
target_compile_options(xnnpack_backend PUBLIC ${_common_compile_options})
target_link_options_shared_lib(xnnpack_backend)

if(EXECUTORCH_BUILD_KERNELS_OPTIMIZED)
@swolchokswolchokMar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed build when XNNPACK is on but optimized lib is off. everything else (except corresponding change to line 149 below) is just cmake-format.
@swolchok
swolchok
merged commit 6caefc3
into
mainMar 4, 2025
@swolchok
swolchok
deleted the

gh/swolchok/304/head

branch
March 4, 2025 19:17
zonglinpeng pushed a commit
that referenced
this pull request
Mar 6, 2025
@swolchokZonglin Peng
Link xnn_executor_runner with optimized op library (#8901)
a78101b
Doesn't seem to be any reason not to allow optimized ops for this one.
@github-actionsgithub-actionsBot
mentioned this pull request
Mar 10, 2025

Open


This was referenced Mar 17, 2025

Open


Open

@github-actionsgithub-actionsBot
mentioned this pull request
Mar 31, 2025

Open

@github-actionsgithub-actionsBot
mentioned this pull request
Apr 7, 2025

Open

kedarnath03 pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
@swolchok
Link xnn_executor_runner with optimized op library
97f8d6a
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: a8d06d4
ghstack-comment-id: 2695738759
Pull Request resolved: pytorch/executorch#8901
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes
@kirklandsignkirklandsignkirklandsign approved these changes
@mcr229mcr229Awaiting requested review from mcr229
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandales

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: devtoolsChanges to dev tooling, for example the debugger & profiler

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@kirklandsign@digantdesai@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Link xnn_executor_runner with optimized op library - #8901
Merged
swolchok merged 23 commits into
mainfrom 
gh/swolchok/304/head
Mar 4, 2025
Merged
Link xnn_executor_runner with optimized op library#8901
swolchok merged 23 commits into
mainfrom 
gh/swolchok/304/head
Conversation
@swolchok
@swolchokswolchok
commented
Mar 3, 2025

Copy link


Copy Markdown

Contributor
Doesn't seem to be any reason not to allow optimized ops for this one.
@swolchok
Update
f1ace77
[ghstack-poisoned]
@swolchok
Update
d3a0f67
[ghstack-poisoned]
@swolchok
Update
a78277d
[ghstack-poisoned]
@swolchok
Update
6b6180c
[ghstack-poisoned]
@swolchok
Update
7cbe7a1
[ghstack-poisoned]
@swolchok
Update
8e8ce33
[ghstack-poisoned]
@swolchok
Update
093a6d3
[ghstack-poisoned]
@swolchok
Update
77f039c
[ghstack-poisoned]
@swolchok
Update
c4e4541
[ghstack-poisoned]
@swolchok
Update
18583c3
[ghstack-poisoned]
@swolchok
swolchok
commented
Mar 3, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Stack from ghstack (oldest at bottom):
@pytorch-bot
pytorch-botBot
commented
Mar 3, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8901
Note: Links to docs will display an error until the docs builds have been completed.
⏳ No Failures, 2 Pending
As of commit 18c64ad with merge base 09ad20a (image):

💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@swolchokswolchok
mentioned this pull request
Mar 3, 2025
 Closed

@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Mar 3, 2025

This was referenced Mar 3, 2025
 Closed

 Closed

 Closed

swolchok added a commit
that referenced
this pull request
Mar 3, 2025
@swolchok
Link xnn_executor_runner with optimized op library
03e0582
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: aaf6617
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchokswolchok
mentioned this pull request
Mar 3, 2025
 Merged

@swolchok
Update
d3edbcb
[ghstack-poisoned]
@swolchok
Update
bf96b84
[ghstack-poisoned]
@swolchok
Update
fe126ae
[ghstack-poisoned]
@swolchok
swolchok
changed the base branch from
gh/swolchok/302/head
to
gh/swolchok/299/headMarch 3, 2025 23:41
@kirklandsign
kirklandsign
commented
Mar 4, 2025

Copy link


Copy Markdown

Contributor
Thanks @swolchok!
Ideally in OSS world we also have a executor_runner with optimized kernels, and use it as a test runner for all models. Maybe we can promote xnn_executor_runner to be this general runner.
BTW this PR has diff from other commits?
@swolchok
swolchok
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
I'm having trouble exporting my stack; getting GitHub rate limits. Hopefully folks will review the bottom PR or two soon.
@swolchok
Update
a93cd69
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Mar 4, 2025
@swolchok
Link xnn_executor_runner with optimized op library
59b32c3
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: 85e31ee
ghstack-comment-id: 2695738759
Pull Request resolved: #8901
@swolchok
swolchok
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
this PR has diff from other commits?
fixed, please review
@swolchok
swolchokforce-pushed
the
gh/swolchok/299/head
branch
from
7cbe7a1 to
7bc4529CompareMarch 4, 2025 00:28
@swolchok
Update
764977b
[ghstack-poisoned]
@swolchok
swolchokforce-pushed
the
gh/swolchok/299/head
branch
from
7bc4529 to
764977bCompareMarch 4, 2025 16:11
digantdesai
digantdesai
reviewed
Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
Outdated


 target_link_libraries(
 xnn_executor_runner gflags portable_ops_lib ${xnn_executor_runner_libs}
 xnn_executor_runner gflags optimized_native_cpu_ops_lib ${xnn_executor_runner_libs}
@digantdesaidigantdesaiMar 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! So many perf cliffs because of this.
@swolchok
Update
c7d57ee
[ghstack-poisoned]
@swolchok
Update
fa09b62
[ghstack-poisoned]
@swolchok
Update
58f544f
[ghstack-poisoned]
@swolchok
Update
fd6a085
[ghstack-poisoned]
@swolchok
Update
3143085
[ghstack-poisoned]
@swolchok
Update
deb1934
[ghstack-poisoned]
@swolchok
Update
80589b0
[ghstack-poisoned]
@swolchok
swolchok
changed the base branch from
gh/swolchok/299/head
to
mainMarch 4, 2025 17:47
@swolchokswolchok
added
the 
release notes: devtools
Changes to dev tooling, for example the debugger & profiler
label
Mar 4, 2025
@swolchok
Update
18c64ad
[ghstack-poisoned]
swolchok
swolchok
commented
Mar 4, 2025
View reviewed changes
Comment threadbackends/xnnpack/CMakeLists.txt
target_compile_options(xnnpack_backend PUBLIC ${_common_compile_options})
target_link_options_shared_lib(xnnpack_backend)

if(EXECUTORCH_BUILD_KERNELS_OPTIMIZED)
@swolchokswolchokMar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed build when XNNPACK is on but optimized lib is off. everything else (except corresponding change to line 149 below) is just cmake-format.
@swolchok
swolchok
merged commit 6caefc3
into
mainMar 4, 2025
@swolchok
swolchok
deleted the

gh/swolchok/304/head

branch
March 4, 2025 19:17
zonglinpeng pushed a commit
that referenced
this pull request
Mar 6, 2025
@swolchokZonglin Peng
Link xnn_executor_runner with optimized op library (#8901)
a78101b
Doesn't seem to be any reason not to allow optimized ops for this one.
@github-actionsgithub-actionsBot
mentioned this pull request
Mar 10, 2025

Open


This was referenced Mar 17, 2025

Open


Open

@github-actionsgithub-actionsBot
mentioned this pull request
Mar 31, 2025

Open

@github-actionsgithub-actionsBot
mentioned this pull request
Apr 7, 2025

Open

kedarnath03 pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
@swolchok
Link xnn_executor_runner with optimized op library
97f8d6a
Doesn't seem to be any reason not to allow optimized ops for this one.
ghstack-source-id: a8d06d4
ghstack-comment-id: 2695738759
Pull Request resolved: pytorch/executorch#8901
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@digantdesaidigantdesaidigantdesai approved these changes
@kirklandsignkirklandsignkirklandsign approved these changes
@mcr229mcr229Awaiting requested review from mcr229
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandales

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: devtoolsChanges to dev tooling, for example the debugger & profiler

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@kirklandsign@digantdesai@facebook-github-bot