[Windows] [mmap_data_loader.cpp] mmap equivalent for Windows by SamGondelman · Pull Request #8916 · pytorch/executorch

SamGondelman · 2025-03-04T03:54:10Z

Summary

#5164 with the code suggestions applied.

Test plan

I am not familiar with how to test this area of the code. On non-Windows systems, it should be functionally the same.
#5164 suggests a command to run some relevant tests?

There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests.

pytorch-bot · 2025-03-04T03:54:13Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8916

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4e6b973 with merge base 24671a9 ():

NEW FAILURE - The following job has failed:

pull / test-llava-runner-linux / linux-job (gh)
RuntimeError: Command docker exec -t 24875dbbbd4d37b7f8c13a9084ba3222d6540f83f900bf4aff304dbe359a3800 /exec failed with exit code 139

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SamGondelman · 2025-03-04T03:56:45Z

 // safe (though it will return an error).
- ::close(fd_);
+ if (fd_ != -1) {
+ ::close(fd_);


I'm surprised this (and open, etc.) works, since it was the problem in #8913. I haven't built this file on Windows myself yet, but maybe a similar fix is necessary?

SamGondelman · 2025-03-05T07:36:41Z

hm:

/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `vtable for executorch::extension::MmapDataLoader'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::~MmapDataLoader()'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::from(char const*, executorch::extension::MmapDataLoader::MlockConfig)'

SS-JIA

@SamGondelman figured out what was causing the linker error you're seeing.

Btw, if you want to repro it yourself, you can do so on a linux machine (e.g. Devserver). You can follow https://pytorch.org/executorch/main/getting-started-setup.html on how to set up the repo. Then

First, build/install ExecuTorch libraries

(rm -rf cmake-out && \
pp cmake . \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
-DEXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL=ON \
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \
-DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON \
-DEXECUTORCH_BUILD_KERNELS_CUSTOM=ON \
-DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON \
-DEXECUTORCH_BUILD_VULKAN=ON \
-Bcmake-out && \
cmake --build cmake-out -j64 --target install)

The above command should work.

Next, try to build the Llama runner binary. This is where it will fail because the binary will try to link the data loader

(rm -rf cmake-out/examples/models/llama && \
pp cmake examples/models/llama \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-Bcmake-out/examples/models/llama && \
cmake --build cmake-out/examples/models/llama -j16)

The pp in my commands are to set up fwdproxy.

SS-JIA · 2025-03-05T23:51:40Z

LGTM. The one test failure does not appear to be related...

…8916)" This reverts commit 286f1fe.

* [Windows Build] Implement MMAP for mmap_data_loader.cpp There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests. * apply code suggestions * fix src -> srcs typo * try to fix build * fix src/headers brackets --------- Co-authored-by: Jeff Whiteside <jwhites@microsoft.com>

SamGondelman · 2025-03-04T03:54:10Z

Summary

#5164 with the code suggestions applied.

Test plan

I am not familiar with how to test this area of the code. On non-Windows systems, it should be functionally the same.
#5164 suggests a command to run some relevant tests?

There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests.

pytorch-bot · 2025-03-04T03:54:13Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8916

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4e6b973 with merge base 24671a9 ():

NEW FAILURE - The following job has failed:

pull / test-llava-runner-linux / linux-job (gh)
RuntimeError: Command docker exec -t 24875dbbbd4d37b7f8c13a9084ba3222d6540f83f900bf4aff304dbe359a3800 /exec failed with exit code 139

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SamGondelman · 2025-03-04T03:56:45Z

 // safe (though it will return an error).
- ::close(fd_);
+ if (fd_ != -1) {
+ ::close(fd_);


I'm surprised this (and open, etc.) works, since it was the problem in #8913. I haven't built this file on Windows myself yet, but maybe a similar fix is necessary?

SamGondelman · 2025-03-05T07:36:41Z

hm:

/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `vtable for executorch::extension::MmapDataLoader'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::~MmapDataLoader()'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::from(char const*, executorch::extension::MmapDataLoader::MlockConfig)'

SS-JIA

@SamGondelman figured out what was causing the linker error you're seeing.

Btw, if you want to repro it yourself, you can do so on a linux machine (e.g. Devserver). You can follow https://pytorch.org/executorch/main/getting-started-setup.html on how to set up the repo. Then

First, build/install ExecuTorch libraries

(rm -rf cmake-out && \
pp cmake . \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
-DEXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL=ON \
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \
-DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON \
-DEXECUTORCH_BUILD_KERNELS_CUSTOM=ON \
-DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON \
-DEXECUTORCH_BUILD_VULKAN=ON \
-Bcmake-out && \
cmake --build cmake-out -j64 --target install)

The above command should work.

Next, try to build the Llama runner binary. This is where it will fail because the binary will try to link the data loader

(rm -rf cmake-out/examples/models/llama && \
pp cmake examples/models/llama \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-Bcmake-out/examples/models/llama && \
cmake --build cmake-out/examples/models/llama -j16)

The pp in my commands are to set up fwdproxy.

SS-JIA · 2025-03-05T23:51:40Z

LGTM. The one test failure does not appear to be related...

…8916)" This reverts commit 286f1fe.

* [Windows Build] Implement MMAP for mmap_data_loader.cpp There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests. * apply code suggestions * fix src -> srcs typo * try to fix build * fix src/headers brackets --------- Co-authored-by: Jeff Whiteside <jwhites@microsoft.com>

SamGondelman · 2025-03-04T03:54:10Z

Summary

#5164 with the code suggestions applied.

Test plan

I am not familiar with how to test this area of the code. On non-Windows systems, it should be functionally the same.
#5164 suggests a command to run some relevant tests?

There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests.

pytorch-bot · 2025-03-04T03:54:13Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8916

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4e6b973 with merge base 24671a9 ():

NEW FAILURE - The following job has failed:

pull / test-llava-runner-linux / linux-job (gh)
RuntimeError: Command docker exec -t 24875dbbbd4d37b7f8c13a9084ba3222d6540f83f900bf4aff304dbe359a3800 /exec failed with exit code 139

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SamGondelman · 2025-03-04T03:56:45Z

 // safe (though it will return an error).
- ::close(fd_);
+ if (fd_ != -1) {
+ ::close(fd_);


I'm surprised this (and open, etc.) works, since it was the problem in #8913. I haven't built this file on Windows myself yet, but maybe a similar fix is necessary?

SamGondelman · 2025-03-05T07:36:41Z

hm:

/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `vtable for executorch::extension::MmapDataLoader'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::~MmapDataLoader()'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::from(char const*, executorch::extension::MmapDataLoader::MlockConfig)'

SS-JIA

@SamGondelman figured out what was causing the linker error you're seeing.

Btw, if you want to repro it yourself, you can do so on a linux machine (e.g. Devserver). You can follow https://pytorch.org/executorch/main/getting-started-setup.html on how to set up the repo. Then

First, build/install ExecuTorch libraries

(rm -rf cmake-out && \
pp cmake . \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
-DEXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL=ON \
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \
-DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON \
-DEXECUTORCH_BUILD_KERNELS_CUSTOM=ON \
-DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON \
-DEXECUTORCH_BUILD_VULKAN=ON \
-Bcmake-out && \
cmake --build cmake-out -j64 --target install)

The above command should work.

Next, try to build the Llama runner binary. This is where it will fail because the binary will try to link the data loader

(rm -rf cmake-out/examples/models/llama && \
pp cmake examples/models/llama \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-Bcmake-out/examples/models/llama && \
cmake --build cmake-out/examples/models/llama -j16)

The pp in my commands are to set up fwdproxy.

SS-JIA · 2025-03-05T23:51:40Z

LGTM. The one test failure does not appear to be related...

…8916)" This reverts commit 286f1fe.

* [Windows Build] Implement MMAP for mmap_data_loader.cpp There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests. * apply code suggestions * fix src -> srcs typo * try to fix build * fix src/headers brackets --------- Co-authored-by: Jeff Whiteside <jwhites@microsoft.com>

SamGondelman · 2025-03-04T03:54:10Z

Summary

#5164 with the code suggestions applied.

Test plan

I am not familiar with how to test this area of the code. On non-Windows systems, it should be functionally the same.
#5164 suggests a command to run some relevant tests?

There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests.

pytorch-bot · 2025-03-04T03:54:13Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8916

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4e6b973 with merge base 24671a9 ():

NEW FAILURE - The following job has failed:

pull / test-llava-runner-linux / linux-job (gh)
RuntimeError: Command docker exec -t 24875dbbbd4d37b7f8c13a9084ba3222d6540f83f900bf4aff304dbe359a3800 /exec failed with exit code 139

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SamGondelman · 2025-03-04T03:56:45Z

 // safe (though it will return an error).
- ::close(fd_);
+ if (fd_ != -1) {
+ ::close(fd_);


I'm surprised this (and open, etc.) works, since it was the problem in #8913. I haven't built this file on Windows myself yet, but maybe a similar fix is necessary?

SamGondelman · 2025-03-05T07:36:41Z

hm:

/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `vtable for executorch::extension::MmapDataLoader'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::~MmapDataLoader()'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::from(char const*, executorch::extension::MmapDataLoader::MlockConfig)'

SS-JIA

@SamGondelman figured out what was causing the linker error you're seeing.

Btw, if you want to repro it yourself, you can do so on a linux machine (e.g. Devserver). You can follow https://pytorch.org/executorch/main/getting-started-setup.html on how to set up the repo. Then

First, build/install ExecuTorch libraries

(rm -rf cmake-out && \
pp cmake . \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
-DEXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL=ON \
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \
-DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON \
-DEXECUTORCH_BUILD_KERNELS_CUSTOM=ON \
-DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON \
-DEXECUTORCH_BUILD_VULKAN=ON \
-Bcmake-out && \
cmake --build cmake-out -j64 --target install)

The above command should work.

Next, try to build the Llama runner binary. This is where it will fail because the binary will try to link the data loader

(rm -rf cmake-out/examples/models/llama && \
pp cmake examples/models/llama \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-Bcmake-out/examples/models/llama && \
cmake --build cmake-out/examples/models/llama -j16)

The pp in my commands are to set up fwdproxy.

SS-JIA · 2025-03-05T23:51:40Z

LGTM. The one test failure does not appear to be related...

…8916)" This reverts commit 286f1fe.

* [Windows Build] Implement MMAP for mmap_data_loader.cpp There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests. * apply code suggestions * fix src -> srcs typo * try to fix build * fix src/headers brackets --------- Co-authored-by: Jeff Whiteside <jwhites@microsoft.com>

SamGondelman · 2025-03-04T03:54:10Z

Summary

#5164 with the code suggestions applied.

Test plan

I am not familiar with how to test this area of the code. On non-Windows systems, it should be functionally the same.
#5164 suggests a command to run some relevant tests?

There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests.

pytorch-bot · 2025-03-04T03:54:13Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8916

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4e6b973 with merge base 24671a9 ():

NEW FAILURE - The following job has failed:

pull / test-llava-runner-linux / linux-job (gh)
RuntimeError: Command docker exec -t 24875dbbbd4d37b7f8c13a9084ba3222d6540f83f900bf4aff304dbe359a3800 /exec failed with exit code 139

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SamGondelman · 2025-03-04T03:56:45Z

 // safe (though it will return an error).
- ::close(fd_);
+ if (fd_ != -1) {
+ ::close(fd_);


I'm surprised this (and open, etc.) works, since it was the problem in #8913. I haven't built this file on Windows myself yet, but maybe a similar fix is necessary?

SamGondelman · 2025-03-05T07:36:41Z

hm:

/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `vtable for executorch::extension::MmapDataLoader'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::~MmapDataLoader()'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::from(char const*, executorch::extension::MmapDataLoader::MlockConfig)'

SS-JIA

@SamGondelman figured out what was causing the linker error you're seeing.

Btw, if you want to repro it yourself, you can do so on a linux machine (e.g. Devserver). You can follow https://pytorch.org/executorch/main/getting-started-setup.html on how to set up the repo. Then

First, build/install ExecuTorch libraries

(rm -rf cmake-out && \
pp cmake . \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
-DEXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL=ON \
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \
-DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON \
-DEXECUTORCH_BUILD_KERNELS_CUSTOM=ON \
-DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON \
-DEXECUTORCH_BUILD_VULKAN=ON \
-Bcmake-out && \
cmake --build cmake-out -j64 --target install)

The above command should work.

Next, try to build the Llama runner binary. This is where it will fail because the binary will try to link the data loader

(rm -rf cmake-out/examples/models/llama && \
pp cmake examples/models/llama \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-Bcmake-out/examples/models/llama && \
cmake --build cmake-out/examples/models/llama -j16)

The pp in my commands are to set up fwdproxy.

SS-JIA · 2025-03-05T23:51:40Z

LGTM. The one test failure does not appear to be related...

…8916)" This reverts commit 286f1fe.

* [Windows Build] Implement MMAP for mmap_data_loader.cpp There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests. * apply code suggestions * fix src -> srcs typo * try to fix build * fix src/headers brackets --------- Co-authored-by: Jeff Whiteside <jwhites@microsoft.com>

SamGondelman · 2025-03-04T03:54:10Z

Summary

#5164 with the code suggestions applied.

Test plan

I am not familiar with how to test this area of the code. On non-Windows systems, it should be functionally the same.
#5164 suggests a command to run some relevant tests?

There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests.

pytorch-bot · 2025-03-04T03:54:13Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8916

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4e6b973 with merge base 24671a9 ():

NEW FAILURE - The following job has failed:

pull / test-llava-runner-linux / linux-job (gh)
RuntimeError: Command docker exec -t 24875dbbbd4d37b7f8c13a9084ba3222d6540f83f900bf4aff304dbe359a3800 /exec failed with exit code 139

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SamGondelman · 2025-03-04T03:56:45Z

 // safe (though it will return an error).
- ::close(fd_);
+ if (fd_ != -1) {
+ ::close(fd_);


I'm surprised this (and open, etc.) works, since it was the problem in #8913. I haven't built this file on Windows myself yet, but maybe a similar fix is necessary?

SamGondelman · 2025-03-05T07:36:41Z

hm:

/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `vtable for executorch::extension::MmapDataLoader'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::~MmapDataLoader()'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::from(char const*, executorch::extension::MmapDataLoader::MlockConfig)'

SS-JIA

@SamGondelman figured out what was causing the linker error you're seeing.

Btw, if you want to repro it yourself, you can do so on a linux machine (e.g. Devserver). You can follow https://pytorch.org/executorch/main/getting-started-setup.html on how to set up the repo. Then

First, build/install ExecuTorch libraries

(rm -rf cmake-out && \
pp cmake . \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
-DEXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL=ON \
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \
-DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON \
-DEXECUTORCH_BUILD_KERNELS_CUSTOM=ON \
-DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON \
-DEXECUTORCH_BUILD_VULKAN=ON \
-Bcmake-out && \
cmake --build cmake-out -j64 --target install)

The above command should work.

Next, try to build the Llama runner binary. This is where it will fail because the binary will try to link the data loader

(rm -rf cmake-out/examples/models/llama && \
pp cmake examples/models/llama \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-Bcmake-out/examples/models/llama && \
cmake --build cmake-out/examples/models/llama -j16)

The pp in my commands are to set up fwdproxy.

SS-JIA · 2025-03-05T23:51:40Z

LGTM. The one test failure does not appear to be related...

…8916)" This reverts commit 286f1fe.

* [Windows Build] Implement MMAP for mmap_data_loader.cpp There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests. * apply code suggestions * fix src -> srcs typo * try to fix build * fix src/headers brackets --------- Co-authored-by: Jeff Whiteside <jwhites@microsoft.com>

SamGondelman · 2025-03-04T03:54:10Z

Summary

#5164 with the code suggestions applied.

Test plan

I am not familiar with how to test this area of the code. On non-Windows systems, it should be functionally the same.
#5164 suggests a command to run some relevant tests?

There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests.

pytorch-bot · 2025-03-04T03:54:13Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8916

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4e6b973 with merge base 24671a9 ():

NEW FAILURE - The following job has failed:

pull / test-llava-runner-linux / linux-job (gh)
RuntimeError: Command docker exec -t 24875dbbbd4d37b7f8c13a9084ba3222d6540f83f900bf4aff304dbe359a3800 /exec failed with exit code 139

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SamGondelman · 2025-03-04T03:56:45Z

 // safe (though it will return an error).
- ::close(fd_);
+ if (fd_ != -1) {
+ ::close(fd_);


I'm surprised this (and open, etc.) works, since it was the problem in #8913. I haven't built this file on Windows myself yet, but maybe a similar fix is necessary?

SamGondelman · 2025-03-05T07:36:41Z

hm:

/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `vtable for executorch::extension::MmapDataLoader'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::~MmapDataLoader()'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::from(char const*, executorch::extension::MmapDataLoader::MlockConfig)'

SS-JIA

@SamGondelman figured out what was causing the linker error you're seeing.

Btw, if you want to repro it yourself, you can do so on a linux machine (e.g. Devserver). You can follow https://pytorch.org/executorch/main/getting-started-setup.html on how to set up the repo. Then

First, build/install ExecuTorch libraries

(rm -rf cmake-out && \
pp cmake . \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
-DEXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL=ON \
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \
-DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON \
-DEXECUTORCH_BUILD_KERNELS_CUSTOM=ON \
-DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON \
-DEXECUTORCH_BUILD_VULKAN=ON \
-Bcmake-out && \
cmake --build cmake-out -j64 --target install)

The above command should work.

Next, try to build the Llama runner binary. This is where it will fail because the binary will try to link the data loader

(rm -rf cmake-out/examples/models/llama && \
pp cmake examples/models/llama \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-Bcmake-out/examples/models/llama && \
cmake --build cmake-out/examples/models/llama -j16)

The pp in my commands are to set up fwdproxy.

SS-JIA · 2025-03-05T23:51:40Z

LGTM. The one test failure does not appear to be related...

…8916)" This reverts commit 286f1fe.

* [Windows Build] Implement MMAP for mmap_data_loader.cpp There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests. * apply code suggestions * fix src -> srcs typo * try to fix build * fix src/headers brackets --------- Co-authored-by: Jeff Whiteside <jwhites@microsoft.com>

SamGondelman · 2025-03-04T03:54:10Z

Summary

#5164 with the code suggestions applied.

Test plan

I am not familiar with how to test this area of the code. On non-Windows systems, it should be functionally the same.
#5164 suggests a command to run some relevant tests?

There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests.

pytorch-bot · 2025-03-04T03:54:13Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8916

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4e6b973 with merge base 24671a9 ():

NEW FAILURE - The following job has failed:

pull / test-llava-runner-linux / linux-job (gh)
RuntimeError: Command docker exec -t 24875dbbbd4d37b7f8c13a9084ba3222d6540f83f900bf4aff304dbe359a3800 /exec failed with exit code 139

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SamGondelman · 2025-03-04T03:56:45Z

 // safe (though it will return an error).
- ::close(fd_);
+ if (fd_ != -1) {
+ ::close(fd_);


I'm surprised this (and open, etc.) works, since it was the problem in #8913. I haven't built this file on Windows myself yet, but maybe a similar fix is necessary?

SamGondelman · 2025-03-05T07:36:41Z

hm:

/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `vtable for executorch::extension::MmapDataLoader'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::~MmapDataLoader()'
/usr/bin/ld: /pytorch/executorch/build-x86/lib/libextension_module.so: undefined reference to `executorch::extension::MmapDataLoader::from(char const*, executorch::extension::MmapDataLoader::MlockConfig)'

SS-JIA

@SamGondelman figured out what was causing the linker error you're seeing.

Btw, if you want to repro it yourself, you can do so on a linux machine (e.g. Devserver). You can follow https://pytorch.org/executorch/main/getting-started-setup.html on how to set up the repo. Then

First, build/install ExecuTorch libraries

(rm -rf cmake-out && \
pp cmake . \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
-DEXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL=ON \
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \
-DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON \
-DEXECUTORCH_BUILD_KERNELS_CUSTOM=ON \
-DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON \
-DEXECUTORCH_BUILD_VULKAN=ON \
-Bcmake-out && \
cmake --build cmake-out -j64 --target install)

The above command should work.

Next, try to build the Llama runner binary. This is where it will fail because the binary will try to link the data loader

(rm -rf cmake-out/examples/models/llama && \
pp cmake examples/models/llama \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-Bcmake-out/examples/models/llama && \
cmake --build cmake-out/examples/models/llama -j16)

The pp in my commands are to set up fwdproxy.

SS-JIA · 2025-03-05T23:51:40Z

LGTM. The one test failure does not appear to be related...

…8916)" This reverts commit 286f1fe.

* [Windows Build] Implement MMAP for mmap_data_loader.cpp There is no sys/mman.h or posix-compatible mmap() implementation on Windows. The extension data loaders use it to map in data files, so adding an implementation. Test-run, & .\cmake-out\extension\data_loader\test\Debug\extension_data_loader_test.exe --gtest_brief=1 --gtest_filter=MmapDataLoader* Running main() from ...\executorch\third-party\googletest\googletest\src\gtest_main.cc [==========] 8 tests from 1 test suite ran. (50 ms total) [ PASSED ] 8 tests. * apply code suggestions * fix src -> srcs typo * try to fix build * fix src/headers brackets --------- Co-authored-by: Jeff Whiteside <jwhites@microsoft.com>

jsidewhiteand others added 2 commits March 3, 2025 19:38

apply code suggestions
197e198

SamGondelman requested review from JacobSzwejbka, dbort and lucylq as code owners March 4, 2025 03:54

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2025

SamGondelman commented Mar 4, 2025
View reviewed changes

JacobSzwejbka assigned tarun292 and SS-JIA Mar 4, 2025

SS-JIA reviewed Mar 4, 2025
View reviewed changes

Comment threadextension/data_loader/targets.bzl Outdated

fix src -> srcs typo
aac6b5d

SamGondelman added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Mar 5, 2025

try to fix build
5c4e93f

SS-JIA reviewed Mar 5, 2025
View reviewed changes

Comment threadextension/data_loader/targets.bzl Outdated
Comment threadextension/data_loader/targets.bzl Outdated

fix src/headers brackets
4e6b973

SS-JIA approved these changes Mar 5, 2025
View reviewed changes

SS-JIA merged commit 286f1fe into pytorch:mainMar 5, 2025

SamGondelman deleted the windows-mmap-data-loader branch March 6, 2025 00:04

SamGondelman mentioned this pull request Mar 6, 2025
fix mman header issues #8989
Merged

SamGondelman added a commit that referenced this pull request Mar 6, 2025
Revert "[Windows] [mmap_data_loader.cpp] mmap equivalent for Windows (#…
c14622a
…8916)" This reverts commit 286f1fe.

SamGondelman mentioned this pull request Mar 6, 2025
Revert "[Windows] [mmap_data_loader.cpp] mmap equivalent for Windows" #8991
Closed

github-actionsBot mentioned this pull request Mar 10, 2025
Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#16
Open

This was referenced Mar 17, 2025
Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#18
Open
Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#20
Open

github-actionsBot mentioned this pull request Mar 31, 2025
Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#22
Open

github-actionsBot mentioned this pull request Apr 7, 2025
Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#26
Open

nil-is-all mentioned this pull request Dec 18, 2025
[Windows Build] Implement MMAP for mmap_data_loader.cpp #5164
Closed