Skip to content

introduce file_data_sink - #8921

Merged
facebook-github-bot merged 1 commit into
pytorch:mainfrom
Gasoonjia:export-D70541550
Mar 5, 2025
Merged

introduce file_data_sink#8921
facebook-github-bot merged 1 commit into
pytorch:mainfrom
Gasoonjia:export-D70541550

Conversation

@Gasoonjia

@GasoonjiaGasoonjia commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

Summary: This diff introduces a new data sink called file_data_sink to the Executorch runtime to have a data logging pipeline into file.

Differential Revision: D70541550

@Gasoonjia
Gasoonjia requested a review from tarun292 as a code ownerMarch 4, 2025 06:26
@pytorch-bot

pytorch-botBot commented Mar 4, 2025•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8921

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit e71f360 with merge base 9ab5c15 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2025
@github-actions

github-actionsBot commented Mar 4, 2025

Copy link
Copy Markdown

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot

facebook-github-bot commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D70541550

@facebook-github-bot

facebook-github-bot commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D70541550

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Mar 4, 2025
@Gasoonjia@facebook-github-bot
introduce file_data_sink (pytorch#8921)
98c7116
Summary:
This diff introduces a new data sink called `file_data_sink` to the Executorch runtime to have a data logging pipeline into file.
Differential Revision: D70541550
@facebook-github-bot

facebook-github-bot commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D70541550

@Gasoonjia

Gasoonjia commented Mar 4, 2025

Copy link
Copy Markdown
ContributorAuthor

RuntimeError: Error checking labels: PR does not have required labels

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Mar 4, 2025
@Gasoonjia@facebook-github-bot
introduce file_data_sink (pytorch#8921)
f23eb72
Summary:
This diff introduces a new data sink called `file_data_sink` to the Executorch runtime to have a data logging pipeline into file.
Differential Revision: D70541550
@facebook-github-bot

facebook-github-bot commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D70541550

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Mar 4, 2025
@Gasoonjia@facebook-github-bot
introduce file_data_sink (pytorch#8921)
ead2c3c
Summary:
Pull Request resolved: pytorch#8921
This diff introduces a new data sink called `file_data_sink` to the Executorch runtime to have a data logging pipeline into file.
Differential Revision: D70541550
Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Mar 4, 2025
@Gasoonjia@facebook-github-bot
introduce file_data_sink (pytorch#8921)
eba680c
Summary:
This diff introduces a new data sink called `file_data_sink` to the Executorch runtime to have a data logging pipeline into file.
Differential Revision: D70541550
@facebook-github-bot

facebook-github-bot commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D70541550

@Gasoonjia@facebook-github-bot
introduce file_data_sink (pytorch#8921)
e71f360
Summary:
This diff introduces a new data sink called `file_data_sink` to the Executorch runtime to have a data logging pipeline into file.
Reviewed By: tarun292
Differential Revision: D70541550
@facebook-github-bot

facebook-github-bot commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D70541550

@facebook-github-bot
facebook-github-bot merged commit 262f0f1 into pytorch:mainMar 5, 2025
zonglinpeng pushed a commit that referenced this pull request Mar 6, 2025
@GasoonjiaZonglin Peng
introduce file_data_sink
d5dfaac
Differential Revision: D70541550
Pull Request resolved: #8921
@github-actionsgithub-actionsBot mentioned this pull request Mar 10, 2025
Open
This was referenced Mar 17, 2025
Open
Open
@github-actionsgithub-actionsBot mentioned this pull request Mar 31, 2025
Open
@github-actionsgithub-actionsBot mentioned this pull request Apr 7, 2025
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tarun292tarun292tarun292 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gasoonjia@facebook-github-bot@tarun292