Skip to content

[ExecuTorch][XNNPACK] Don't partition per_tensor weights with qd8 - #8926

Closed
digantdesai wants to merge 1 commit into
gh/digantdesai/27/basefrom
gh/digantdesai/27/head
Closed

[ExecuTorch][XNNPACK] Don't partition per_tensor weights with qd8#8926
digantdesai wants to merge 1 commit into
gh/digantdesai/27/basefrom
gh/digantdesai/27/head

Conversation

@digantdesai

@digantdesaidigantdesai commented Mar 4, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

This is not supported, so we shouldn't partition it.

Add an expectedFailure test to indicate that this is not supported

Differential Revision: D70343584

@digantdesai
[ExecuTorch][XNNPACK] Don't partition per_tensor weights with qd8
2ae7232
This is not supported, so we shouldn't partition it.
Add an expectedFailure test to indicate that this is not supported
Differential Revision: [D70343584](https://our.internmc.facebook.com/intern/diff/D70343584/)
[ghstack-poisoned]
@digantdesai
digantdesai requested a review from mcr229 as a code ownerMarch 4, 2025 15:38
@pytorch-bot

pytorch-botBot commented Mar 4, 2025•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8926

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 34 Pending

As of commit 2ae7232 with merge base 2ee3ffa (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2025
@digantdesaidigantdesai mentioned this pull request Mar 3, 2025
Merged
@facebook-github-bot

facebook-github-bot commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D70343584

@github-actions

github-actionsBot commented Mar 4, 2025

Copy link
Copy Markdown

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@github-actionsgithub-actionsBot mentioned this pull request Mar 10, 2025
Open
This was referenced Mar 17, 2025
Open
Open
@github-actionsgithub-actionsBot mentioned this pull request Mar 31, 2025
Open
@github-actionsgithub-actionsBot mentioned this pull request Apr 7, 2025
Open
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
@digantdesai
[ExecuTorch][XNNPACK] Don't partition per_tensor weights with qd8
af51930
This is not supported, so we shouldn't partition it.
Add an expectedFailure test to indicate that this is not supported
Differential Revision: [D70343584](https://our.internmc.facebook.com/intern/diff/D70343584/)
ghstack-source-id: 269599294
Pull Request resolved: pytorch/executorch#8926
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcr229mcr229Awaiting requested review from mcr229

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@digantdesai@facebook-github-bot