Uh oh!
There was an error while loading. Please reload this page.
Use NDM in backend init context - #8945
Merged
Merged
Conversation
Add NDM to backend init context, so backends have access to it at init time. Add to backend init context instead of as an argument to backend.init, as it's easier to add/deprecate an arg there rather than in the init/execute interface. TODO: add a merge/union method to named_data_map.h interface. If there is an external file (or multiple), and/or named_segments in the PTE, these should be merged into one. Differential Revision: [D70279622](https://our.internmc.facebook.com/intern/diff/D70279622/) [ghstack-poisoned]
This was referenced Mar 4, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8945
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 56182a8 with merge base 2ee3ffa ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lucylq added a commit
that referenced
this pull request
Mar 4, 2025
Add NDM to backend init context, so backends have access to it at init time. Add to backend init context instead of as an argument to backend.init, as it's easier to add/deprecate an arg there rather than in the init/execute interface. TODO: add a merge/union method to named_data_map.h interface. If there is an external file (or multiple), and/or named_segments in the PTE, these should be merged into one. Differential Revision: [D70279622](https://our.internmc.facebook.com/intern/diff/D70279622/) ghstack-source-id: 269693069 Pull Request resolved: #8945
facebook-github-bot
commented
Mar 4, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D70279622 |
mcr229
approved these changes
Mar 4, 2025
facebook-github-bothad a problem deploying
to
cherry-pick-bot
March 6, 2025 04:57 — with 
GitHub Actions
Failure
This was referenced Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add NDM to backend init context, so backends have access to it at init time.
Add to backend init context instead of as an argument to backend.init, as it's easier to add/deprecate an arg there rather than in the init/execute interface.
TODO: add a merge/union method to named_data_map.h interface. If there is an external file (or multiple), and/or named_segments in the PTE, these should be merged into one.
Differential Revision: D70279622