Skip to content

Split & remove extension_parallel - #8983

Merged
swolchok merged 44 commits into
mainfrom
gh/swolchok/315/head
Mar 11, 2025
Merged

Split & remove extension_parallel#8983
swolchok merged 44 commits into
mainfrom
gh/swolchok/315/head

Conversation

@swolchok

Copy link
Copy Markdown
Contributor

As per plan in #8932, we want to be able to include thread_parallel.h to build
libraries that are capable of parallelization, but don't require it. So, we
move the header to ExecuTorch core and add a fallback implementation (with
tests!) of parallel_for that just does a regular for loop. Then, targets
that link extension_threadpool will get parallelization automagically.

This PR doesn't add any optionally-parallelized code; that will be in the next
PR.

swolchok added 23 commits March 4, 2025 11:35
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Comment threadextension/threadpool/test/thread_parallel_test.cpp Outdated
[ghstack-poisoned]
@JacobSzwejbka
JacobSzwejbka removed their request for review March 10, 2025 18:20
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
swolchok removed the request for review from dbortMarch 11, 2025 01:50
@swolchok

Copy link
Copy Markdown
ContributorAuthor

[ghstack-poisoned]
@swolchok
swolchok merged commit 2889483 into mainMar 11, 2025
@swolchok
swolchok deleted the gh/swolchok/315/head branch March 11, 2025 18:14
swolchok added a commit that referenced this pull request Mar 12, 2025
This reverts commit 2889483.
ghstack-source-id: d44d019
ghstack-comment-id: 2718557885
Pull Request resolved: #9189
swolchok added a commit that referenced this pull request Mar 12, 2025
This reverts commit 05a160e.
Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)""
This reverts commit 815eaff.
Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)""
This reverts commit 10bb615.
ghstack-source-id: 2c4a363
ghstack-comment-id: 2718584686
Pull Request resolved: #9190
swolchok added a commit that referenced this pull request Mar 12, 2025
This reverts commit 05a160e.
Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)""
This reverts commit 815eaff.
Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)""
This reverts commit 10bb615.
ghstack-source-id: 2c4a363
ghstack-comment-id: 2718584686
Pull Request resolved: #9190
SS-JIA pushed a commit that referenced this pull request Mar 12, 2025
swolchok added a commit that referenced this pull request Mar 12, 2025
This reverts commit 05a160e.
Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)""
This reverts commit 815eaff.
Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)""
This reverts commit 10bb615.
ghstack-source-id: 2c4a363
ghstack-comment-id: 2718584686
Pull Request resolved: #9190
swolchok added a commit that referenced this pull request Mar 12, 2025
This reverts commit 05a160e.
Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in
debug builds (#9044)""
This reverts commit 815eaff.
Revert "Revert "Unbreak optimized kernels buck build (and check it in
unittest-buck) (#9159)""
This reverts commit 10bb615.
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
As per plan in #8932, we want to be able to include thread_parallel.h to build
libraries that are *capable* of parallelization, but don't *require* it. So, we
move the header to ExecuTorch core and add a fallback implementation (with
tests!) of `parallel_for` that just does a regular `for` loop. Then, targets
that link `extension_threadpool` will get parallelization automagically.
This PR doesn't add any optionally-parallelized code; that will be in the next
PR.
ghstack-source-id: 816b4cd
ghstack-comment-id: 2702414287
Pull Request resolved: pytorch/executorch#8983
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
As per plan in #8932, we want to be able to include thread_parallel.h to build
libraries that are *capable* of parallelization, but don't *require* it. So, we
move the header to ExecuTorch core and add a fallback implementation (with
tests!) of `parallel_for` that just does a regular `for` loop. Then, targets
that link `extension_threadpool` will get parallelization automagically.
This PR doesn't add any optionally-parallelized code; that will be in the next
PR.
ghstack-source-id: 4c2c9ed
ghstack-comment-id: 2702414287
Pull Request resolved: pytorch/executorch#8983
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: miscMiscellaneous

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@kimishpatel@JacobSzwejbka@facebook-github-bot