Uh oh!
There was an error while loading. Please reload this page.
Arm backend: Move ReplaceScalarTensorWithFullPass to transforms - #8998
Arm backend: Move ReplaceScalarTensorWithFullPass to transforms#8998mansnils wants to merge 11 commits into
Conversation
The pass is general and can be used by multiple backends. The aten.scalar_tensor is replaced by a aten.full which is already supported by Arm backend. Adds new method to Arm tester for getting output as the nn.module in the unit test does not take any input. The output is then manually compared within the unit test. Change-Id: I2bf211a2ce561d53e8a6cf683fdbda58e675938e
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8998
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit 69879d5 with merge base 043c7a0 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mansnils
commented
Mar 6, 2025
@pytorchbot label ciflow/trunk |
shoumikhin
commented
Mar 17, 2025
@digantdesai, @kimishpatel can you take a look please? |
kimishpatel
left a comment
There was a problem hiding this comment.
Looks like just moving a pass around. Didnt fully follow but accepting it. cc @mcremon-meta for cadence related code movement. Bunch of tests are failing though. @tarun292 does it need to be imported internally to validate? Please wait for @tarun292 's answer before landing
mcremon-meta
commented
Mar 17, 2025
looks fine to share the code from our end! We would just ask that (like in this PR) the passes are not modified at least in the PR that moves them so that we can keep track of changes :) |
kimishpatel
commented
Mar 18, 2025
Looks like you are ok with landing these then. |
mcremon-meta
commented
Mar 18, 2025
yes no blocker from our side if CI etc is alright! |
| @@ -0,0 +1,42 @@ | |||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | |||
There was a problem hiding this comment.
Thank you this is the right thing to do.
byjlw
commented
Mar 31, 2025
@mansnils this branch needs to be rebased so and conflicts need to be resolved so we can merge |
mansnils
commented
Apr 7, 2025
This has been replaced with another PR, so closing this |
The pass is general and can be used by multiple backends. The aten.scalar_tensor is replaced by a aten.full which is already supported by Arm backend.
Adds new method to Arm tester for getting output as the nn.module in the unit test does not take any input. The output is then manually compared within the unit test.
cc @digantdesai@freddan80@per@zingo@oscarandersson8218