Skip to content

Arm backend: Move ReplaceScalarTensorWithFullPass to transforms - #8998

Closed
mansnils wants to merge 11 commits into
pytorch:mainfrom
mansnils:ops
Closed

Arm backend: Move ReplaceScalarTensorWithFullPass to transforms#8998
mansnils wants to merge 11 commits into
pytorch:mainfrom
mansnils:ops

Conversation

@mansnils

@mansnilsmansnils commented Mar 6, 2025

Copy link
Copy Markdown
Collaborator

The pass is general and can be used by multiple backends. The aten.scalar_tensor is replaced by a aten.full which is already supported by Arm backend.
Adds new method to Arm tester for getting output as the nn.module in the unit test does not take any input. The output is then manually compared within the unit test.

cc @digantdesai@freddan80@per@zingo@oscarandersson8218

The pass is general and can be used by multiple backends.
The aten.scalar_tensor is replaced by a aten.full which is already
supported by Arm backend.
Adds new method to Arm tester for getting output as the nn.module in
the unit test does not take any input. The output is then
manually compared within the unit test.
Change-Id: I2bf211a2ce561d53e8a6cf683fdbda58e675938e
@mansnilsmansnils added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing labels Mar 6, 2025
@pytorch-bot

pytorch-botBot commented Mar 6, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8998

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit 69879d5 with merge base 043c7a0 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2025
@mansnils

Copy link
Copy Markdown
CollaboratorAuthor

@pytorchbot label ciflow/trunk

@shoumikhin

Copy link
Copy Markdown
Contributor

@digantdesai, @kimishpatel can you take a look please?

@kimishpatelkimishpatel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like just moving a pass around. Didnt fully follow but accepting it. cc @mcremon-meta for cadence related code movement. Bunch of tests are failing though. @tarun292 does it need to be imported internally to validate? Please wait for @tarun292 's answer before landing

@mcremon-meta

Copy link
Copy Markdown
Contributor

looks fine to share the code from our end! We would just ask that (like in this PR) the passes are not modified at least in the PR that moves them so that we can keep track of changes :)

@kimishpatel

Copy link
Copy Markdown
Contributor

looks fine to share the code from our end! We would just ask that (like in this PR) the passes are not modified at least in the PR that moves them so that we can keep track of changes :)

Looks like you are ok with landing these then.

@mcremon-meta

Copy link
Copy Markdown
Contributor

looks fine to share the code from our end! We would just ask that (like in this PR) the passes are not modified at least in the PR that moves them so that we can keep track of changes :)

Looks like you are ok with landing these then.

yes no blocker from our side if CI etc is alright!

@@ -0,0 +1,42 @@
# Copyright (c) Meta Platforms, Inc. and affiliates.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you this is the right thing to do.

@byjlw

Copy link
Copy Markdown
Contributor

@mansnils this branch needs to be rebased so and conflicts need to be resolved so we can merge

@mansnils

Copy link
Copy Markdown
CollaboratorAuthor

This has been replaced with another PR, so closing this

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.partner: armFor backend delegation, kernels, demo, etc. from the 3rd-party partner, Armtopic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@mansnils@shoumikhin@mcremon-meta@kimishpatel@byjlw@digantdesai@facebook-github-bot@zingo