Remove explicit descriptor - #9001

Closed

harishs88ss wants to merge 1 commit into

pytorch:mainfrom

harishs88ss:export-D70630711

harishs88ss commented Mar 6, 2025

Summary: we only need this for constructors with one param

Differential Revision: D70630711

harishs88ss requested a review from JacobSzwejbka as a code owner

March 6, 2025 16:48

pytorch-botBot commented Mar 6, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9001

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 48fa78d with merge base e673f7c ():

NEW FAILURES - The following jobs have failed:

Lint / lintrunner / linux-job (gh)
>>> Lint for extension/training/optimizer/sgd.h:
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 127

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

harishs88ss force-pushed the export-D70630711 branch from a990095 to 70a62f2Compare

March 6, 2025 17:10

facebook-github-bot added the fb-exported label

facebook-github-bot commented Mar 6, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

5 similar comments

facebook-github-bot commented Mar 6, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

facebook-github-bot commented Mar 6, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

facebook-github-bot commented Mar 6, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

facebook-github-bot commented Mar 6, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

facebook-github-bot commented Mar 6, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

JacobSzwejbka approved these changes

View reviewed changes

harishs88ss commented Mar 6, 2025

Author

@pytorchbot label "topic: not user facing"

pytorch-botBot added the topic: not user facing label

Remove explicit descriptor (pytorch#9001)

48fa78d

Summary:
we only need this for constructors with one param
Reviewed By: JacobSzwejbka
Differential Revision: D70630711

harishs88ss force-pushed the export-D70630711 branch from 70a62f2 to 48fa78dCompare

March 7, 2025 15:09

facebook-github-bot commented Mar 7, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

3 similar comments

facebook-github-bot commented Mar 7, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

facebook-github-bot commented Mar 7, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

facebook-github-bot commented Mar 7, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

github-actionsBot mentioned this pull request

Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#16

Open

This was referenced Mar 17, 2025

Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#18

Open

Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#20

Open

github-actionsBot mentioned this pull request

Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#22

Open

github-actionsBot mentioned this pull request

Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#26

Open

github-actionsBot commented Aug 31, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actionsBot added the Stale label

github-actionsBot commented Oct 30, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

2 similar comments

github-actionsBot commented Dec 29, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actionsBot commented Feb 27, 2026

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actionsBot commented Apr 28, 2026

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actionsBot closed this

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment