Skip to content

Set oss.folly_cxx_tests buckconfig to false - #9088

Merged
swolchok merged 2 commits into
mainfrom
gh/swolchok/333/head
Mar 10, 2025
Merged

Set oss.folly_cxx_tests buckconfig to false#9088
swolchok merged 2 commits into
mainfrom
gh/swolchok/333/head

Conversation

@swolchok

@swolchokswolchok commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

This is an option in the Buck shims that controls whether cxx_tests automatically depend on folly. ExecuTorch doesn't use folly.

@swolchok
Update
47e7d4a
[ghstack-poisoned]
@swolchok
Update
0b1f85e
[ghstack-poisoned]
@swolchok

swolchok commented Mar 10, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-botBot commented Mar 10, 2025•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9088

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 0b1f85e with merge base 1d34caf (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchokswolchok mentioned this pull request Mar 10, 2025
Merged
swolchok added a commit that referenced this pull request Mar 10, 2025
@swolchok
Set oss.folly_cxx_tests buckconfig to false
d7d6a88
This is an option in the Buck shims that controls whether cxx_tests automatically depend on folly. ExecuTorch doesn't use folly.
ghstack-source-id: dd4cc59
ghstack-comment-id: 2711214717
Pull Request resolved: #9088
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 10, 2025
Base automatically changed from gh/swolchok/332/head to mainMarch 10, 2025 22:29
@swolchok
swolchok merged commit 68259f5 into mainMar 10, 2025
@swolchok
swolchok deleted the gh/swolchok/333/head branch March 10, 2025 22:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
1 more reviewer
@GregoryComerGregoryComerGregoryComer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@GregoryComer@facebook-github-bot