Uh oh!
There was an error while loading. Please reload this page.
Fix static attention mask update - #9101
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9101
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dd04ea9 with merge base d71f54a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
commented
Mar 10, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D70914174 |
facebook-github-bot
commented
Mar 10, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D70914174 |
sxu added a commit
to sxu/executorch
that referenced
this pull request
Mar 10, 2025
Summary: The range based for loop was making a copy of the mask, and thus the updates did not take effect. Remove the copy and move constructors of StaticKVCache and StaticAttention as they are not needed. Also add the missing deallocate call in mask's destructor. Differential Revision: D70914174
sxu added a commit
to sxu/executorch
that referenced
this pull request
Mar 10, 2025
Summary: The range based for loop was making a copy of the mask, and thus the updates did not take effect. Remove the copy and move constructors of StaticKVCache and StaticAttention as they are not needed. Also add the missing deallocate call in mask's destructor. Differential Revision: D70914174
facebook-github-bot
commented
Mar 10, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D70914174 |
1 similar comment
facebook-github-bot
commented
Mar 10, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D70914174 |
sxu added a commit
to sxu/executorch
that referenced
this pull request
Mar 10, 2025
Summary: Pull Request resolved: pytorch#9101 The range based for loop was making a copy of the mask, and thus the updates did not take effect. Remove the copy and move constructors of StaticKVCache and StaticAttention as they are not needed. Also add the missing deallocate call in mask's destructor. Differential Revision: D70914174
billmguo
approved these changes
Mar 11, 2025
sxu added a commit
to sxu/executorch
that referenced
this pull request
Mar 11, 2025
Summary: The range based for loop was making a copy of the mask, and thus the updates did not take effect. Remove the copy and move constructors of StaticKVCache and StaticAttention as they are not needed. Also add the missing deallocate call in mask's destructor. Reviewed By: billmguo Differential Revision: D70914174
sxu added a commit
to sxu/executorch
that referenced
this pull request
Mar 11, 2025
Summary: The range based for loop was making a copy of the mask, and thus the updates did not take effect. Remove the copy and move constructors of StaticKVCache and StaticAttention as they are not needed. Also add the missing deallocate call in mask's destructor. Reviewed By: billmguo Differential Revision: D70914174
facebook-github-bot
commented
Mar 11, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D70914174 |
Summary: Pull Request resolved: pytorch#9101 The range based for loop was making a copy of the mask, and thus the updates did not take effect. Remove the copy and move constructors of StaticKVCache and StaticAttention as they are not needed. Also add the missing deallocate call in mask's destructor. Reviewed By: billmguo Differential Revision: D70914174
facebook-github-bot
commented
Mar 11, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D70914174 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The range based for loop was making a copy of the mask, and thus the updates did not take effect. Remove the copy and move constructors of StaticKVCache and StaticAttention as they are not needed. Also add the missing deallocate call in mask's destructor.
Differential Revision: D70914174