Alternative approach to handling memory offset shift by JakeStevens · Pull Request #9406 · pytorch/executorch

JakeStevens · 2025-03-19T19:12:50Z

Summary:
To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to:

 memory_offset |= static_cast<size_t>(memory_offset_high)
<< (sizeof(size_t) - sizeof(uint32_t));

This fails for build of OSS qwen example however.

Instead, we modify to add a check for

sizeof(size_t) > sizeof(uint32_t)

in the conditional instead of changing the computation.

In our builds of interest, this compiles away the if branch

Reviewed By: digantdesai, dpalmasan

Differential Revision: D71488571

pytorch-bot · 2025-03-19T19:12:53Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9406

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7cdc42b with merge base 7159650 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-03-19T19:13:02Z

This pull request was exported from Phabricator. Differential Revision: D71488571

swolchok · 2025-03-19T19:14:32Z

this looks fine, but I'll be surprised if it continues to get rid of the warning

JakeStevens · 2025-03-19T19:18:26Z

@pytorchbot label "topic: not user facing"

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-21T13:54:51Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:28:15Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:46:12Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-25T19:39:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-26T13:49:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, dpalmasan Differential Revision: D71488571

JakeStevens · 2025-03-19T19:12:50Z

Summary:
To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to:

 memory_offset |= static_cast<size_t>(memory_offset_high)
<< (sizeof(size_t) - sizeof(uint32_t));

This fails for build of OSS qwen example however.

Instead, we modify to add a check for

sizeof(size_t) > sizeof(uint32_t)

in the conditional instead of changing the computation.

In our builds of interest, this compiles away the if branch

Reviewed By: digantdesai, dpalmasan

Differential Revision: D71488571

pytorch-bot · 2025-03-19T19:12:53Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9406

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7cdc42b with merge base 7159650 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-03-19T19:13:02Z

This pull request was exported from Phabricator. Differential Revision: D71488571

swolchok · 2025-03-19T19:14:32Z

this looks fine, but I'll be surprised if it continues to get rid of the warning

JakeStevens · 2025-03-19T19:18:26Z

@pytorchbot label "topic: not user facing"

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-21T13:54:51Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:28:15Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:46:12Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-25T19:39:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-26T13:49:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, dpalmasan Differential Revision: D71488571

JakeStevens · 2025-03-19T19:12:50Z

Summary:
To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to:

 memory_offset |= static_cast<size_t>(memory_offset_high)
<< (sizeof(size_t) - sizeof(uint32_t));

This fails for build of OSS qwen example however.

Instead, we modify to add a check for

sizeof(size_t) > sizeof(uint32_t)

in the conditional instead of changing the computation.

In our builds of interest, this compiles away the if branch

Reviewed By: digantdesai, dpalmasan

Differential Revision: D71488571

pytorch-bot · 2025-03-19T19:12:53Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9406

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7cdc42b with merge base 7159650 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-03-19T19:13:02Z

This pull request was exported from Phabricator. Differential Revision: D71488571

swolchok · 2025-03-19T19:14:32Z

this looks fine, but I'll be surprised if it continues to get rid of the warning

JakeStevens · 2025-03-19T19:18:26Z

@pytorchbot label "topic: not user facing"

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-21T13:54:51Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:28:15Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:46:12Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-25T19:39:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-26T13:49:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, dpalmasan Differential Revision: D71488571

JakeStevens · 2025-03-19T19:12:50Z

Summary:
To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to:

 memory_offset |= static_cast<size_t>(memory_offset_high)
<< (sizeof(size_t) - sizeof(uint32_t));

This fails for build of OSS qwen example however.

Instead, we modify to add a check for

sizeof(size_t) > sizeof(uint32_t)

in the conditional instead of changing the computation.

In our builds of interest, this compiles away the if branch

Reviewed By: digantdesai, dpalmasan

Differential Revision: D71488571

pytorch-bot · 2025-03-19T19:12:53Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9406

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7cdc42b with merge base 7159650 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-03-19T19:13:02Z

This pull request was exported from Phabricator. Differential Revision: D71488571

swolchok · 2025-03-19T19:14:32Z

this looks fine, but I'll be surprised if it continues to get rid of the warning

JakeStevens · 2025-03-19T19:18:26Z

@pytorchbot label "topic: not user facing"

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-21T13:54:51Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:28:15Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:46:12Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-25T19:39:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-26T13:49:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, dpalmasan Differential Revision: D71488571

JakeStevens · 2025-03-19T19:12:50Z

Summary:
To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to:

 memory_offset |= static_cast<size_t>(memory_offset_high)
<< (sizeof(size_t) - sizeof(uint32_t));

This fails for build of OSS qwen example however.

Instead, we modify to add a check for

sizeof(size_t) > sizeof(uint32_t)

in the conditional instead of changing the computation.

In our builds of interest, this compiles away the if branch

Reviewed By: digantdesai, dpalmasan

Differential Revision: D71488571

pytorch-bot · 2025-03-19T19:12:53Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9406

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7cdc42b with merge base 7159650 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-03-19T19:13:02Z

This pull request was exported from Phabricator. Differential Revision: D71488571

swolchok · 2025-03-19T19:14:32Z

this looks fine, but I'll be surprised if it continues to get rid of the warning

JakeStevens · 2025-03-19T19:18:26Z

@pytorchbot label "topic: not user facing"

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-21T13:54:51Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:28:15Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:46:12Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-25T19:39:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-26T13:49:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, dpalmasan Differential Revision: D71488571

JakeStevens · 2025-03-19T19:12:50Z

Summary:
To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to:

 memory_offset |= static_cast<size_t>(memory_offset_high)
<< (sizeof(size_t) - sizeof(uint32_t));

This fails for build of OSS qwen example however.

Instead, we modify to add a check for

sizeof(size_t) > sizeof(uint32_t)

in the conditional instead of changing the computation.

In our builds of interest, this compiles away the if branch

Reviewed By: digantdesai, dpalmasan

Differential Revision: D71488571

pytorch-bot · 2025-03-19T19:12:53Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9406

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7cdc42b with merge base 7159650 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-03-19T19:13:02Z

This pull request was exported from Phabricator. Differential Revision: D71488571

swolchok · 2025-03-19T19:14:32Z

this looks fine, but I'll be surprised if it continues to get rid of the warning

JakeStevens · 2025-03-19T19:18:26Z

@pytorchbot label "topic: not user facing"

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-21T13:54:51Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:28:15Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:46:12Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-25T19:39:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-26T13:49:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, dpalmasan Differential Revision: D71488571

JakeStevens · 2025-03-19T19:12:50Z

Summary:
To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to:

 memory_offset |= static_cast<size_t>(memory_offset_high)
<< (sizeof(size_t) - sizeof(uint32_t));

This fails for build of OSS qwen example however.

Instead, we modify to add a check for

sizeof(size_t) > sizeof(uint32_t)

in the conditional instead of changing the computation.

In our builds of interest, this compiles away the if branch

Reviewed By: digantdesai, dpalmasan

Differential Revision: D71488571

pytorch-bot · 2025-03-19T19:12:53Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9406

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7cdc42b with merge base 7159650 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-03-19T19:13:02Z

This pull request was exported from Phabricator. Differential Revision: D71488571

swolchok · 2025-03-19T19:14:32Z

this looks fine, but I'll be surprised if it continues to get rid of the warning

JakeStevens · 2025-03-19T19:18:26Z

@pytorchbot label "topic: not user facing"

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-21T13:54:51Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:28:15Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:46:12Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-25T19:39:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-26T13:49:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, dpalmasan Differential Revision: D71488571

JakeStevens · 2025-03-19T19:12:50Z

Summary:
To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to:

 memory_offset |= static_cast<size_t>(memory_offset_high)
<< (sizeof(size_t) - sizeof(uint32_t));

This fails for build of OSS qwen example however.

Instead, we modify to add a check for

sizeof(size_t) > sizeof(uint32_t)

in the conditional instead of changing the computation.

In our builds of interest, this compiles away the if branch

Reviewed By: digantdesai, dpalmasan

Differential Revision: D71488571

pytorch-bot · 2025-03-19T19:12:53Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9406

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7cdc42b with merge base 7159650 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-03-19T19:13:02Z

This pull request was exported from Phabricator. Differential Revision: D71488571

swolchok · 2025-03-19T19:14:32Z

this looks fine, but I'll be surprised if it continues to get rid of the warning

JakeStevens · 2025-03-19T19:18:26Z

@pytorchbot label "topic: not user facing"

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-21T13:54:51Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:28:15Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-24T14:46:12Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-25T19:39:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

Summary: Pull Request resolved: pytorch#9406 To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, swolchok, dpalmasan Differential Revision: D71488571

facebook-github-bot · 2025-03-26T13:49:48Z

This pull request was exported from Phabricator. Differential Revision: D71488571

Summary: To support embedded system builds which threw an error on the warning for left shift by 32 on a 32 bit dtype, the code was modified to: ``` memory_offset |= static_cast<size_t>(memory_offset_high) << (sizeof(size_t) - sizeof(uint32_t)); ``` This fails for build of OSS qwen example however. Instead, we modify to add a check for ``` sizeof(size_t) > sizeof(uint32_t) ``` in the conditional instead of changing the computation. In our builds of interest, this compiles away the if branch Reviewed By: digantdesai, dpalmasan Differential Revision: D71488571

JakeStevens requested review from JacobSzwejbka, lucylq and swolchok as code owners March 19, 2025 19:12

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2025

facebook-github-bot added the fb-exported label Mar 19, 2025

swolchok approved these changes Mar 19, 2025
View reviewed changes

pytorch-botBot added the topic: not user facing label Mar 19, 2025

JakeStevens force-pushed the export-D71488571 branch from 0583a8b to 65e5b87Compare March 21, 2025 13:51

JakeStevens force-pushed the export-D71488571 branch 2 times, most recently from c6c43b5 to da6c3e3Compare March 24, 2025 14:25

JakeStevens force-pushed the export-D71488571 branch from da6c3e3 to 8dbe71fCompare March 24, 2025 14:28

JakeStevens force-pushed the export-D71488571 branch from 8dbe71f to d6c9092Compare March 24, 2025 14:45

JakeStevens force-pushed the export-D71488571 branch from d6c9092 to 9f274c3Compare March 25, 2025 19:36

JakeStevens force-pushed the export-D71488571 branch 2 times, most recently from 53db757 to fc27c40Compare March 26, 2025 13:46

JakeStevens force-pushed the export-D71488571 branch from fc27c40 to 7cdc42bCompare March 26, 2025 13:49

JakeStevens merged commit c43d5ad into pytorch:mainMar 26, 2025