Skip to content

Refactor serialize.py - #9579

Merged
lucylq merged 1 commit into
mainfrom
lfq.refactor-serialize
Mar 25, 2025
Merged

Refactor serialize.py#9579
lucylq merged 1 commit into
mainfrom
lfq.refactor-serialize

Conversation

@lucylq

Copy link
Copy Markdown
Contributor

Pull Request resolved: #9124

Refactor _extract_tensors out of serialize.py, simplify before serializing named_data ghstack-source-id: 273798696

Differential Revision: D70752429

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

Pull Request resolved: #9124
Refactor `_extract_tensors` out of serialize.py, simplify before serializing named_data
ghstack-source-id: 273798696
Differential Revision: [D70752429](https://our.internmc.facebook.com/intern/diff/D70752429/)
@pytorch-bot

pytorch-botBot commented Mar 25, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9579

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 1 Unrelated Failure

As of commit 259f4b3 with merge base 12f4431 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2025
@lucylq
lucylq marked this pull request as ready for review March 25, 2025 16:12
@lucylqlucylq mentioned this pull request Mar 25, 2025
@lucylq

Copy link
Copy Markdown
ContributorAuthor

retake of #9572

@lucylqlucylq added the release notes: exir Changes to any dialects and passes on these dialects, such as memory planning label Mar 25, 2025
@lucylq
lucylq merged commit 644b7dd into mainMar 25, 2025
@lucylq
lucylq deleted the lfq.refactor-serialize branch March 25, 2025 17:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: exirChanges to any dialects and passes on these dialects, such as memory planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lucylq@kirklandsign@facebook-github-bot