Skip to content

Fix dir(torch) for python 3.7 - #10271

Closed
li-roy wants to merge 2 commits into
pytorch:masterfrom
li-roy:dir
Closed

li-roy wants to merge 2 commits into
pytorch:masterfrom
li-roy:dir

Conversation

@li-roy

@li-roy li-roy commented Aug 6, 2018

Copy link
Copy Markdown
Contributor

fixes #10160.

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple test that calls dir(torch) in test_torch.py would be good

@facebook-github-bot facebook-github-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

li-roy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

PenghuiCheng pushed a commit to PenghuiCheng/pytorch that referenced this pull request Aug 10, 2018
Summary:
fixes pytorch#10160.
Pull Request resolved: pytorch#10271

Differential Revision: D9188031

Pulled By: li-roy

fbshipit-source-id: a3620553a8ba2b7391acdf78dbe58afcdb6c5f7f
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
Summary:
fixes pytorch#10160.
Pull Request resolved: pytorch#10271

Differential Revision: D9188031

Pulled By: li-roy

fbshipit-source-id: a3620553a8ba2b7391acdf78dbe58afcdb6c5f7f
@ezyang ezyang added the merged label Jun 26, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
fixes pytorch#10160.
Pull Request resolved: pytorch#10271

Differential Revision: D9188031

Pulled By: li-roy

fbshipit-source-id: a3620553a8ba2b7391acdf78dbe58afcdb6c5f7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dir(torch) fails in python3.7, pytorch0.4.1, breaks tab completion in IDEs

4 participants