Skip to content

Move dropout and alpha dropout to ATen - #10384

Closed
apaszke wants to merge 2 commits into
pytorch:masterfrom
apaszke:aten-dropout
Closed

Move dropout and alpha dropout to ATen#10384
apaszke wants to merge 2 commits into
pytorch:masterfrom
apaszke:aten-dropout

Conversation

@apaszke

@apaszke apaszke commented Aug 9, 2018

Copy link
Copy Markdown
Contributor

ssnl
ssnl reviewed Aug 9, 2018
View reviewed changes
Comment thread test/expect/TestJit.test_alexnet.expect Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Aug 10, 2018
View reviewed changes
Comment thread aten/src/ATen/native/Dropout.cpp
auto input_sizes = input.sizes();
AT_CHECK(input.dim() >= 2, "Feature dropout requires at least 2 dimensions in the input");
std::vector<int64_t> sizes;
sizes.reserve(input.dim());

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Aug 10, 2018
View reviewed changes
Comment thread torch/nn/functional.py
# Activation functions
def dropout(input, p=0.5, training=False, inplace=False):
return _functions.dropout.Dropout.apply(input, p, training, inplace)
if p < 0 or p > 1:

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

facebook-github-bot
facebook-github-bot reviewed Aug 10, 2018
View reviewed changes

@facebook-github-bot facebook-github-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Aug 10, 2018
@apaszke @facebook-github-bot
Move dropout and alpha dropout to ATen (#10384)
215d883 
Summary:
zdevito ezyang
Pull Request resolved: pytorch/pytorch#10384

Reviewed By: ezyang

Differential Revision: D9272583

Pulled By: apaszke

fbshipit-source-id: ed5d37b28ce9ff25800bbaa0daf066cfbf1f9921
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
@apaszke Rob Kunkle
Move dropout and alpha dropout to ATen (pytorch#10384)
543faed 
Summary:
zdevito ezyang
Pull Request resolved: pytorch#10384

Reviewed By: ezyang

Differential Revision: D9272583

Pulled By: apaszke

fbshipit-source-id: ed5d37b28ce9ff25800bbaa0daf066cfbf1f9921
@li-roy li-roy mentioned this pull request Aug 21, 2018
Closed
@dzhulgakov dzhulgakov mentioned this pull request Jan 30, 2019
Closed
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@apaszke @facebook-github-bot
Move dropout and alpha dropout to ATen (pytorch#10384)
88471bf 
Summary:
zdevito ezyang
Pull Request resolved: pytorch#10384

Reviewed By: ezyang

Differential Revision: D9272583

Pulled By: apaszke

fbshipit-source-id: ed5d37b28ce9ff25800bbaa0daf066cfbf1f9921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssnl ssnl ssnl left review comments
@ezyang ezyang ezyang approved these changes
@anderspapitto anderspapitto Awaiting requested review from anderspapitto
@bddppq bddppq Awaiting requested review from bddppq
@colesbury colesbury Awaiting requested review from colesbury
@dzhulgakov dzhulgakov Awaiting requested review from dzhulgakov
@gchanan gchanan Awaiting requested review from gchanan
@houseroad houseroad Awaiting requested review from houseroad
@jamesr66a jamesr66a Awaiting requested review from jamesr66a
@smessmer smessmer Awaiting requested review from smessmer
@soumith soumith Awaiting requested review from soumith
@Yangqing Yangqing Awaiting requested review from Yangqing
@zdevito zdevito Awaiting requested review from zdevito
+1 more reviewer
@facebook-github-bot facebook-github-bot facebook-github-bot left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@apaszke @ezyang @ssnl @facebook-github-bot