Skip to content

[c10d] flaky test fix trial - #11391

Closed
teng-li wants to merge 1 commit into
pytorch:masterfrom
teng-li:flaky_test
Closed

teng-li wants to merge 1 commit into
pytorch:masterfrom
teng-li:flaky_test

Conversation

@teng-li

@teng-li teng-li commented Sep 7, 2018

Copy link
Copy Markdown
Contributor

Add a barrier() to wait for all PG created before destroy

@teng-li
teng-li requested a review from pietern September 7, 2018 18:30
@teng-li teng-li added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Sep 7, 2018
@pietern

pietern commented Sep 7, 2018

Copy link
Copy Markdown
Contributor

LGTM

@facebook-github-bot facebook-github-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teng-li is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

PenghuiCheng pushed a commit to PenghuiCheng/pytorch that referenced this pull request Sep 11, 2018
Summary:
Add a barrier() to wait for all PG created before destroy
Pull Request resolved: pytorch#11391

Differential Revision: D9727383

Pulled By: teng-li

fbshipit-source-id: 689d62c978e642b68f4949dcf29982e34869ada4
@ezyang ezyang added the merged label Jun 26, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Add a barrier() to wait for all PG created before destroy
Pull Request resolved: pytorch#11391

Differential Revision: D9727383

Pulled By: teng-li

fbshipit-source-id: 689d62c978e642b68f4949dcf29982e34869ada4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants