Skip to content

Remove deprecated factory functions from Type. - #11583

Closed
ezyang wants to merge 12 commits into
masterfrom
export-D9792800
Closed

ezyang wants to merge 12 commits into
masterfrom
export-D9792800

Conversation

@ezyang

@ezyang ezyang commented Sep 12, 2018

Copy link
Copy Markdown
Contributor

Stack:
    :black_circle:  #11583 Remove deprecated factory functions from Type.  💚

Differential Revision: D9792800

Differential Revision: D9790187
Differential Version: 57609071
Differential Revision: D9792800
Differential Version: 57621323
@cpuhrsch

Copy link
Copy Markdown
Contributor

Blocked on #11489 ?

@gchanan gchanan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might also be codegen we can remove...

Differential Revision: D9792800
Differential Version: 57641431
Differential Revision: D9790187
Differential Version: 57641656
Differential Revision: D9792800
Differential Version: 57641653
@gchanan

gchanan commented Sep 12, 2018

Copy link
Copy Markdown
Contributor

what about here:

if not is_factory_method:
if option['deprecated']:
# Deprecated functions are always non-extended,
# because they need to be made available from Type
# (the public interface) so that code like
# tensor.type().arange(...) keeps working. Once
# we remove the deprecated functions, we can eliminate
# these methods entirely.
top_env['pure_virtual_type_method_declarations'].append(
DEPRECATED_PURE_VIRTUAL_TYPE_METHOD_DECLARATION.substitute(env))
? Can that go?

Differential Revision: D9792800
Differential Version: 57648333
Differential Revision: D9790187
Differential Version: 57784244
Differential Revision: D9792800
Differential Version: 57784242
Differential Revision: D9792800
Differential Version: 57802525
Differential Revision: D9790187
Differential Version: 57805354
Differential Revision: D9792800
Differential Version: 57805356
@ssnl

ssnl commented Sep 18, 2018

Copy link
Copy Markdown
Collaborator

@ezyang this seems mergeable

Differential Revision: D9792800
Differential Version: 58423817
@ezyang
ezyang changed the base branch from export-D9790187 to master September 20, 2018 14:55
@ssnl
ssnl deleted the export-D9792800 branch September 20, 2018 18:56
zdevito pushed a commit to zdevito/ATen that referenced this pull request Sep 20, 2018
Summary: Pull Request resolved: pytorch/pytorch#11583

Reviewed By: SsnL

Differential Revision: D9792800

fbshipit-source-id: 9af46d577911ff38647790169df66aa5d0379dd9
@ezyang ezyang added the merged label Jun 26, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary: Pull Request resolved: pytorch#11583

Reviewed By: SsnL

Differential Revision: D9792800

fbshipit-source-id: 9af46d577911ff38647790169df66aa5d0379dd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants