Skip to content

Back out "[pytorch][PR] Revert "Move CreateContext to global registry (#11688)"" - #12121

Closed
jerryzh168 wants to merge 1 commit into
pytorch:masterfrom
jerryzh168:export-D10033396
Closed

jerryzh168 wants to merge 1 commit into
pytorch:masterfrom
jerryzh168:export-D10033396

Conversation

@jerryzh168

@jerryzh168 jerryzh168 commented Sep 26, 2018

Copy link
Copy Markdown
Contributor

Stack:
    :black_circle:  #12121 Back out "[pytorch][PR] Revert "Move CreateContext to global registry (#11688)""  💚
    :white_circle:  #12029 [pt1][tensor] New in StaticContext returns at::DataPtr  💛

Original commit changeset: 6ca9de65b707

Differential Revision: D10033396

@ezyang ezyang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via ghapprove D10033396

@ezyang ezyang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via ghapprove D10033396

@ezyang ezyang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via ghapprove -s D10033396

@ezyang ezyang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via ghapprove -s D10033396

@jerryzh168 jerryzh168 changed the title Back out "[pytorch][PR] Revert "Move CreateContext to global registry (#11688)"" (#12055) Back out "[pytorch][PR] Revert "Move CreateContext to global registry (#11688)"" Sep 27, 2018
@jerryzh168

Copy link
Copy Markdown
Contributor Author

@pytorchbot retest this please

@jerryzh168

Copy link
Copy Markdown
Contributor Author

@pytorchbot retest this please

1 similar comment
@jerryzh168

Copy link
Copy Markdown
Contributor Author

@pytorchbot retest this please

…pytorch#11688)"" (pytorch#12121)

Summary:
Pull Request resolved: pytorch#12121

Pull Request resolved: pytorch#12055

Original commit changeset: 6ca9de65b707

Reviewed By: ezyang

Differential Revision: D10033396

fbshipit-source-id: 0936ccbeae529119586e41dd1a687f5ef1f85c8f
zdevito pushed a commit to zdevito/ATen that referenced this pull request Oct 1, 2018
… (#11688)"" (#12121)

Summary:
Pull Request resolved: pytorch/pytorch#12121

Pull Request resolved: pytorch/pytorch#12055

Original commit changeset: 6ca9de65b707

Reviewed By: ezyang

Differential Revision: D10033396

fbshipit-source-id: ca9f4b2f7ef0561f619b833415d394a8b9972bf4
@ezyang ezyang added the merged label Jun 26, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
…pytorch#11688)"" (pytorch#12121)

Summary:
Pull Request resolved: pytorch#12121

Pull Request resolved: pytorch#12055

Original commit changeset: 6ca9de65b707

Reviewed By: ezyang

Differential Revision: D10033396

fbshipit-source-id: ca9f4b2f7ef0561f619b833415d394a8b9972bf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants