Skip to content

fix(settings): correct privacy/voice copy + remove dead Privacy toggles - #218

Merged
qnbs merged 2 commits into
mainfrom
feat/settings-correctness-i18n
Jun 24, 2026
Merged

fix(settings): correct privacy/voice copy + remove dead Privacy toggles#218
qnbs merged 2 commits into
mainfrom
feat/settings-correctness-i18n

Conversation

@qnbs

@qnbsqnbs commented Jun 24, 2026

Copy link
Copy Markdown
Owner

User description

PR C — Settings truthfulness (Privacy) + copy corrections

First of the per-section toggle-truthfulness PRs from the Settings audit, plus two copy fixes.

Copy corrections (19 locales, core-5 translated)

  • voice.privacyNotice was misleading: "Voice data is processed locally… no audio sent to the cloud unless you enable cloud fallback" — but the default Web Speech engine sends audio to Google/Microsoft (the consent dialog itself says so). Now: the on-device WASM engine is what keeps audio local.
  • privacy.analyticsHint sharpened for SEC-6 — the toggle gates all analytics persistence + AI telemetry, not just "collection".

Removed two dead Privacy toggles

crashReporting and shareUsageData wrote a persisted value that no service/hook ever reads (verified by bare-word search across the whole codebase — they appear only in types.ts + the settings persistence store). An offline-first app has no crash-reporting or usage-data backend, so these were WebNN-style ghost toggles. Removed from PrivacySettings, slice defaults, normalizePersistedSettings, PrivacySection, the i18n labels (19 locales) and the test mocks/assertions. Kept (all functionally wired): analyticsEnabled (analyticsGate/SEC-6), localStorageOnly (aiPolicy/languageTool), euDataResidency (aiPolicy), dataEncryption (encryption read-through).

Audit context

A full toggle audit found 19 no-op toggles across 6 sections (Notifications, Performance, Collaboration, Integrations, Backup, Privacy). Per decision, they're removed one section per PR (stacked) to bound i18n fan-out — this is the Privacy slice; the rest follow.

Local gate green: lint, typecheck, i18n parity, and the affected suites (settingsSlice, PrivacySection, PrivacyAndNotifications, aiPolicy ×3, languageTool — 118 tests).

🤖 Generated with Claude Code


CodeAnt-AI Description

Correct privacy settings and voice privacy copy

What Changed

  • Removed two Privacy toggles that had no effect, so the Settings page now shows only the controls that actually change app behavior
  • Updated the analytics hint to say it stops all analytics storage, including dashboard data and AI telemetry
  • Reworded the voice privacy notice to say the default Web Speech engine sends audio to Google or Microsoft, and only the on-device WASM engine keeps audio local
  • Updated the affected translations so the same Privacy and Voice messages match in all supported locales

Impact

✅ Fewer misleading privacy controls
✅ Clearer voice privacy warnings
✅ More accurate translated settings text

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Settings truthfulness pass (Privacy section):
- Corrected misleading copy: voice.privacyNotice claimed audio is 'processed
locally... unless you enable cloud fallback', but the DEFAULT Web Speech engine
sends audio to Google/Microsoft (the consent dialog says so) — now states the
on-device WASM engine is what keeps audio local. analyticsHint sharpened for
SEC-6 (the toggle gates all analytics persistence + AI telemetry).
- Removed two no-op Privacy toggles: crashReporting and shareUsageData wrote a
persisted value that NO service/hook ever reads (offline-first app has no crash
reporting or usage-data backend) — exactly the WebNN-style ghost toggle. Dropped
from PrivacySettings, slice defaults, normalizePersistedSettings, PrivacySection,
the i18n labels (19 locales) and the test mocks/assertions.
First of the per-section toggle-truthfulness PRs; analytics / localStorageOnly /
euDataResidency / dataEncryption stay (all functionally wired).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@qnbs

qnbs commented Jun 24, 2026

Copy link
Copy Markdown
OwnerAuthor

@CodeAnt-AI review

@codeant-ai

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@vercel

vercelBot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
worldscript-studioReadyReadyPreview, CommentJun 24, 2026 4:37am

@codeant-ai

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-aicodeant-aiBot added the size:L This PR changes 100-499 lines, ignoring generated files label Jun 24, 2026
Comment threadlocales/el/settings.json Outdated
Comment threadlocales/el/settings.json Outdated
Comment threadlocales/fa/settings.json Outdated
Comment threadlocales/fa/settings.json Outdated
@codecov

codecovBot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

…ta locales
CodeAnt flagged the English-seeded Beta-locale values (corrections to keys that
previously had translations). Provided proper translations of voice.privacyNotice
and privacy.analyticsHint for all 14 Beta/RTL locales (el/ja/zh/pt/fi/sv/hu/is/eu/
ar/he/fa/ko/ru) instead of the English seed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@qnbs

qnbs commented Jun 24, 2026

Copy link
Copy Markdown
OwnerAuthor

@CodeAnt-AI review

@codeant-ai

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-aicodeant-aiBot added size:L This PR changes 100-499 lines, ignoring generated files and removed size:L This PR changes 100-499 lines, ignoring generated files labels Jun 24, 2026
@codeant-ai

Copy link
Copy Markdown

Sequence Diagram

This PR cleans up the Privacy settings by removing unused crash and usage data toggles, clarifies that the remaining privacy toggles gate analytics persistence and cloud AI usage, and updates voice privacy text to explain when audio is sent to providers versus kept on device.

sequenceDiagram
participant User
participant Settings
participant Analytics
participant AIPolicy as AI policy
participant Voice
User->>Settings: Open Privacy settings
Settings-->>User: Show four active privacy toggles
User->>Settings: Change analytics toggle
Settings->>Analytics: Enable or disable analytics persistence and AI telemetry
User->>Settings: Change local-only or EU residency toggles
Settings->>AIPolicy: Apply privacy flags when allowing or blocking cloud AI providers
User->>Settings: Open Voice settings
Settings-->>User: Show updated notice about web speech vs on-device engine
User->>Settings: Select speech engine
Settings->>Voice: Configure engine so audio goes to cloud only for web speech engine
Loading

Generated by CodeAnt AI

@qnbs
qnbs merged commit 93d861e into mainJun 24, 2026
19 checks passed
@qnbs
qnbs deleted the feat/settings-correctness-i18n branch June 24, 2026 04:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:LThis PR changes 100-499 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@qnbs