Skip to content

build(deps-dev): bump @biomejs/biome from 2.4.16 to 2.5.4 - #252

Merged
qnbs merged 3 commits into
mainfrom
dependabot/npm_and_yarn/biomejs/biome-2.5.0
Jul 28, 2026
Merged

build(deps-dev): bump @biomejs/biome from 2.4.16 to 2.5.4#252
qnbs merged 3 commits into
mainfrom
dependabot/npm_and_yarn/biomejs/biome-2.5.0

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubJun 29, 2026

Copy link
Copy Markdown
Contributor

Bumps @biomejs/biome from 2.4.16 to 2.5.4.

Release notes

Sourced from @​biomejs/biome's releases.

Biome CLI v2.5.4

2.5.4

Patch Changes

What's Changed

... (truncated)

Changelog

Sourced from @​biomejs/biome's changelog.

2.5.4

Patch Changes

2.5.3

Patch Changes

  • #1081586613d5 Thanks @​WaterWhisperer! - Fixed a parser panic reported in #10708: Biome now recovers when unsupported CSS Modules @value rules or scoped @keyframes names end at EOF.

  • #10534da9b403 Thanks @​Mokto! - Fixed noUnusedVariables false positives in Svelte files: Svelte store subscriptions ($store references in templates now keep the underlying store binding from being flagged), and $bindable() props that are only written to in the script block (write-only is intentional for bindable props) are no longer reported as unused.

  • #10827098ba41 Thanks @​Aqu1bp! - Fixed #10698: The noUnsafeOptionalChaining rule now reports unsafe optional chains wrapped in TypeScript as, satisfies, type assertion, and instantiation expressions, such as new (value?.constructor as Constructor)().

  • #107733c6513d Thanks @​otkrickey! - Fixed #10772: useVueValidVOn no longer reports a missing handler for v-on directives using a verb modifier (.stop / .prevent) without an expression, e.g. <div @click.stop></div>. The rule also accepts the arg-less object syntax <div v-on="$listeners"></div> instead of reporting a missing event name.

  • #10721d83c66b Thanks @​minseong0324! - Improved type-aware lint rule inference for built-in globals and indexed function calls. Biome now resolves Error(...), new Error(...), optional Error#stack, and calls through indexed function values such as handlers[0](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome/issues/0) more accurately.

  • #108656450276 Thanks @​ematipico! - Fixed #10845. Biome Language Server no longer goes in deadlock when the scanner is enabled.

... (truncated)

Commits

@dependabotdependabotBot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jun 29, 2026
@dependabot
dependabotBot requested a review from qnbs as a code ownerJune 29, 2026 23:50
@dependabotdependabotBot added the javascript Pull requests that update javascript code label Jun 29, 2026
@vercel

vercelBot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
worldscript-studioReadyReadyPreview, CommentJul 28, 2026 8:27am

@deepsource-io

deepsource-ioBot commented Jun 29, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 79aace8...f98fbb2 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall GradeSecurity

Reliability

Complexity

Hygiene

Code Review Summary

AnalyzerStatusUpdated (UTC)Details
DockerJun 29, 2026 11:50p.m.Review ↗
JavaScriptJun 29, 2026 11:50p.m.Review ↗
CSSJun 29, 2026 11:50p.m.Review ↗
RustJun 29, 2026 11:50p.m.Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@socket-security

socket-securityBot commented Jun 29, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

DiffPackageSupply Chain
Security
VulnerabilityQualityMaintenanceLicense
Addednpm/​@​biomejs/​biome@​2.5.410010010099100

View full report

@codeant-ai

Copy link
Copy Markdown

🏁 CodeAnt Quality Gate Results

Commit:f98fbb29
Scan Time: 2026-07-26 17:42:24 UTC

✅ Overall Status: PASSED

Quality Gate Details

Quality GateStatusDetails
Secrets✅ PASSED0 secrets found
Duplicate Code✅ PASSED0.0% duplicated
SAST✅ PASSEDNo security issues
Bugs✅ PASSEDRating S: No bugs
IAC✅ PASSEDRating S: No issues

View Full Results

@dependabotdependabotBot changed the title build(deps-dev): bump @biomejs/biome from 2.4.16 to 2.5.0build(deps-dev): bump @biomejs/biome from 2.4.16 to 2.5.4Jul 26, 2026
@dependabot
dependabotBotforce-pushed the dependabot/npm_and_yarn/biomejs/biome-2.5.0 branch from f98fbb2 to a8815d0CompareJuly 26, 2026 17:43
@qnbs

qnbs commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Pushed a fix for the immediate CI failure: `biome.json`'s `$schema` still pointed at 2.4.16 while the bumped CLI is 2.5.4 — biome's own parser flags that mismatch as a warning, escalated to a hard failure by `--error-on-warnings`.

That fix alone isn't enough to merge, though. Biome 2.5.x enables/tightens two rules this repo doesn't yet satisfy:

  • `lint/correctness/noUnsafeOptionalChaining` (4 errors) — in `tests/unit/collaborationService.test.ts`, `tests/unit/hooks/useManuscriptView.test.ts` (×2), `tests/unit/ragVectorMigration.test.ts`. Pattern: `(x?.[n] as (...) => T)()` — optional chaining protects the property access but not the subsequent call; biome now flags that as unsafe even where the mock assertion above guarantees the value is defined.
  • `lint/suspicious/noUndeclaredEnvVars` (21 warnings) — across `vite.config.ts`, `app/store.ts`, `services/logger.ts`, several scripts, and more. This is a new rule requiring declared env vars (likely needs a biome.json config entry or equivalent, not a per-call fix).

Both need real fixes (or, for the env-var rule, a deliberate config decision), not a suppression — leaving this open rather than merging with new lint debt or a fresh `biome-ignore`. Full list reproducible locally with `pnpm exec biome lint --max-diagnostics=200` after this branch's schema fix.

@qnbs

qnbs commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Pushed the remaining fixes — this should now be fully mergeable:

  • lint/correctness/noUnsafeOptionalChaining (4 errors): fixed in tests/unit/collaborationService.test.ts, tests/unit/hooks/useManuscriptView.test.ts (×2), tests/unit/ragVectorMigration.test.ts — each was an optional-chain result immediately cast+called/accessed outside the chain; extracted to its own variable first, which is both safe and satisfies the rule.
  • lint/suspicious/noUndeclaredEnvVars (16 warnings, escalated to failures): declared all 16 env vars in turbo.json's globalEnv so Turborepo's cache correctness accounts for them.
  • Also ran biome migrate for the linter.rules.recommendedlinter.rules.preset rename (deprecation notice from 2.5.x).

Verified locally: pnpm run lint clean, pnpm run typecheck clean, pnpm run suppressions:check (52/52, no new suppressions), and all previously-failing test files passing (81 tests). No suppressions added anywhere.

@codecov

codecovBot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@qnbs

qnbs commented Jul 28, 2026

Copy link
Copy Markdown
Owner

@CodeAnt-AI review

dependabotBotand others added 3 commits July 28, 2026 10:26
Bumps [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome) from 2.4.16 to 2.5.4.
- [Release notes](https://github.com/biomejs/biome/releases)
- [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md)
- [Commits](https://github.com/biomejs/biome/commits/@biomejs/biome@2.5.4/packages/@biomejs/biome)
---
updated-dependencies:
- dependency-name: "@biomejs/biome"
dependency-version: 2.5.0
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Dependabot's version bump didn't update the config schema reference,
which biome's own parser flags as a warning -- escalated to a hard
lint failure by --error-on-warnings.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…essions)
Biome 2.5.4 (bumped from 2.4.16 by Dependabot) enables two rules the
codebase didn't yet satisfy:
- lint/correctness/noUnsafeOptionalChaining (4 errors): each was the
pattern `(x?.[n] as T).prop` / `(x?.[n] as (...) => T)()` -- optional
chaining protects the property access but not the subsequent cast +
call/access, which throws at runtime if the chain short-circuits.
Fixed by extracting the optional-chain result into its own variable
first (a separate statement), which is both safe and satisfies the
rule, in tests/unit/collaborationService.test.ts,
tests/unit/hooks/useManuscriptView.test.ts (x2), and
tests/unit/ragVectorMigration.test.ts.
- lint/suspicious/noUndeclaredEnvVars (16 warnings, escalated to
failures by --error-on-warnings): env vars used across scripts,
config files, and tests weren't declared in turbo.json's globalEnv,
so Turborepo's cache correctness couldn't account for them. Declared
all 16 (ANALYZE, BASE_URL, CF_PAGES*, CLOUDFLARE_*, DEPLOY_TARGET,
DEV, GRAPHIFY_SKIP, PLAYWRIGHT_*, RUN_*_E2E, SMOKE_PORT).
Also ran `biome migrate` for the linter.rules.recommended ->
linter.rules.preset config rename (deprecation notice, not
error-level, but biome's own suggested fix and trivial).
Verified: pnpm run lint (clean), pnpm run typecheck (clean),
pnpm run suppressions:check (52/52, no new suppressions), and the 3
affected test files (81 tests passing).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@qnbs
qnbsforce-pushed the dependabot/npm_and_yarn/biomejs/biome-2.5.0 branch from 739bc53 to 297a104CompareJuly 28, 2026 08:26
@qnbs
qnbs merged commit d4418c0 into mainJul 28, 2026
18 checks passed
@qnbs
qnbs deleted the dependabot/npm_and_yarn/biomejs/biome-2.5.0 branch July 28, 2026 08:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filejavascriptPull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@qnbs