feat(desktop): native OS notifications (T3) - #306
Merged
Conversation
Adds opt-in native OS notifications for long-running background tasks in the Tauri desktop build: encrypted library backup export, manuscript export, app updater ready, and ProForge pipeline stage completion. - services/desktop/desktopNotifications.ts: permission check/request/send wrapper around @tauri-apps/plugin-notification, no-op on the web - hooks/useNativeNotifications.ts: requests OS permission once when settings.desktop.desktopNotifications is enabled in Tauri - app/listenerMiddleware.ts: 9th listener category — ProForge stageCompleted triggers a native notification when enabled - components/settings/DesktopSection.tsx: new toggle in Settings - types.ts / settingsDefaults.ts / idbProjectStore.ts: DesktopSettings gains desktopNotifications (default false), backfilled on load - src-tauri: registers tauri-plugin-notification + notification:default capability - i18n: new desktop.notify.*, desktop.settings.desktopNotifications*, export.notify.* keys across all 19 locales (core translated, Beta/RTL backfilled with English fallback) - tests: desktopNotifications, useNativeNotifications, listener middleware coverage for the new stageCompleted trigger, plus mock fixes for the new required DesktopSettings field Co-Authored-By: GitHub Copilot (Claude Sonnet 5) <noreply@github.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
 |
| Overall Grade | Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Docker |  | Aug 1, 2026 10:57a.m. | Review ↗ |
| JavaScript |  | Aug 1, 2026 10:57a.m. | Review ↗ |
| Python | | Aug 1, 2026 10:57a.m. | Review ↗ |
| Rust | | Aug 1, 2026 10:57a.m. | Review ↗ |
| Shell | | Aug 1, 2026 10:57a.m. | Review ↗ |
| Secrets | | Aug 1, 2026 10:57a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:49 seconds Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis change adds opt-in native desktop notifications for application updates, successful exports, encrypted library exports, and completed ProForge stages. It adds Tauri integration, localized notification text, persisted settings support, translation loading, and unit tests. ChangesDesktop notification support
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant App
participant Settings
participant NotificationService
participant Tauri
participant TranslationService
App->>Settings: Read desktopNotifications
App->>NotificationService: Request permission when enabled
NotificationService->>Tauri: Check or request native permission
App->>TranslationService: Resolve localized title and body
App->>NotificationService: Send notification after task completion
NotificationService->>Tauri: Dispatch native notification
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Uh oh!
There was an error while loading. Please reload this page.
…ce RS-R1000) Split the single 26-complexity menu-building function into five small per-submenu builders (build_file_menu/build_edit_menu/build_view_menu/ build_window_menu/build_help_menu). No behavior change — same menu items, same order, same IDs. Co-Authored-By: GitHub Copilot (Claude Sonnet 5) <noreply@github.com>
There was a problem hiding this comment.
Pull request overview
Adds opt-in native desktop notifications for completed exports, backups, updater checks, and ProForge stages.
Changes:
- Adds Tauri notification plugin integration and permission handling.
- Adds persisted settings, UI controls, i18n keys, and notification triggers.
- Adds targeted notification and settings tests.
Reviewed changes
Copilot reviewed 77 out of 78 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
types.ts | Adds the desktop notification setting. |
App.tsx | Initializes notification permissions. |
app/listenerMiddleware.ts | Notifies on ProForge stage completion. |
components/settings/DataSection.tsx | Notifies after encrypted backup. |
components/settings/DesktopSection.tsx | Adds the notification toggle. |
features/settings/settingsDefaults.ts | Defaults notifications to off. |
hooks/useExportView.ts | Notifies after manuscript export. |
hooks/useNativeNotifications.ts | Requests OS notification permission. |
hooks/useTauriUpdater.ts | Notifies when updates are available. |
services/desktop/desktopNotifications.ts | Implements the Tauri notification wrapper. |
services/storage/idbProjectStore.ts | Backfills persisted settings. |
src-tauri/Cargo.toml | Adds the Rust notification plugin. |
src-tauri/capabilities/default.json | Grants notification capability. |
src-tauri/src/lib.rs | Registers the notification plugin. |
package.json | Adds the JavaScript notification package. |
pnpm-lock.yaml | Locks the new package. |
tests/unit/desktopNotifications.test.ts | Tests notification service behavior. |
tests/unit/languageToolClient.test.ts | Updates the settings fixture. |
tests/unit/listenerMiddleware.test.ts | Tests ProForge notifications. |
tests/unit/settings/DesktopSection.test.tsx | Tests the settings toggle. |
tests/unit/useNativeNotifications.test.ts | Tests permission gating. |
locales/ar/desktop.json | Adds Arabic fallback keys. |
locales/ar/export.json | Adds Arabic fallback export keys. |
locales/de/desktop.json | Adds German desktop strings. |
locales/de/export.json | Adds German export strings. |
locales/el/desktop.json | Adds Greek fallback keys. |
locales/el/export.json | Adds Greek fallback export keys. |
locales/en/desktop.json | Adds English desktop strings. |
locales/en/export.json | Adds English export strings. |
locales/es/desktop.json | Adds Spanish desktop strings. |
locales/es/export.json | Adds Spanish export strings. |
locales/eu/desktop.json | Adds Basque fallback keys. |
locales/eu/export.json | Adds Basque fallback export keys. |
locales/fa/desktop.json | Adds Persian fallback keys. |
locales/fa/export.json | Adds Persian fallback export keys. |
locales/fi/desktop.json | Adds Finnish fallback keys. |
locales/fi/export.json | Adds Finnish fallback export keys. |
locales/fr/desktop.json | Adds French desktop strings. |
locales/fr/export.json | Adds French export strings. |
locales/he/desktop.json | Adds Hebrew fallback keys. |
locales/he/export.json | Adds Hebrew fallback export keys. |
locales/hu/desktop.json | Adds Hungarian fallback keys. |
locales/hu/export.json | Adds Hungarian fallback export keys. |
locales/is/desktop.json | Adds Icelandic fallback keys. |
locales/is/export.json | Adds Icelandic fallback export keys. |
locales/it/desktop.json | Adds Italian desktop strings. |
locales/it/export.json | Adds Italian export strings. |
locales/ja/desktop.json | Adds Japanese fallback keys. |
locales/ja/export.json | Adds Japanese fallback export keys. |
locales/ko/desktop.json | Adds Korean fallback keys. |
locales/ko/export.json | Adds Korean fallback export keys. |
locales/pt/desktop.json | Adds Portuguese fallback keys. |
locales/pt/export.json | Adds Portuguese fallback export keys. |
locales/ru/desktop.json | Adds Russian fallback keys. |
locales/ru/export.json | Adds Russian fallback export keys. |
locales/sv/desktop.json | Adds Swedish fallback keys. |
locales/sv/export.json | Adds Swedish fallback export keys. |
locales/zh/desktop.json | Adds Chinese fallback keys. |
locales/zh/export.json | Adds Chinese fallback export keys. |
public/locales/ar/bundle.json | Rebuilds the Arabic runtime bundle. |
public/locales/en/bundle.json | Rebuilds the English runtime bundle. |
public/locales/he/bundle.json | Rebuilds the Hebrew runtime bundle. |
public/locales/ko/bundle.json | Rebuilds the Korean runtime bundle. |
public/locales/pt/bundle.json | Rebuilds the Portuguese runtime bundle. |
public/locales/ru/bundle.json | Rebuilds the Russian runtime bundle. |
public/locales/sv/bundle.json | Rebuilds the Swedish runtime bundle. |
public/locales/zh/bundle.json | Rebuilds the Chinese runtime bundle. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
Fixes the docs:check drift gate — 6 new desktop-notification keys raised the total from 2861 to 2867 across all 19 locales. Co-Authored-By: GitHub Copilot (Claude Sonnet 5) <noreply@github.com>
… wave on PR #306 Same pattern as PR #305 — DeepSource: JavaScript flags 63 pre-existing issues across app/listenerMiddleware.ts (god-file) whenever it's touched. Confirmed informational-only (not a required status check) and that none of the findings land on the new code. No action taken per established precedent (§4a.3, §11). Co-Authored-By: GitHub Copilot (Claude Sonnet 5) <noreply@github.com>
- Cargo.lock: sync tauri-plugin-notification dependency via
`cargo metadata` (minimal-diff, no unrelated version bumps).
- useExportView: only send the 'export complete' desktop notification
when the export actually succeeded; PDF/DOCX/EPUB now report success/
failure instead of always resolving. Adds coverage for the failure
paths.
- useTauriUpdater: fix test suite that lacked a Redux <Provider> wrapper
(was passing accidentally, not exercising the real selector).
- settingsSlice: merge (not replace) desktop settings on setSettings so
a legacy/imported settings envelope that predates a new
DesktopSettings field (e.g. desktopNotifications) doesn't clobber it
back to undefined.
- listenerMiddleware: replace hardcoded English ProForge notification
strings with i18n via a new middleware-safe static translator
(services/i18n/staticTranslate.ts), since listener middleware runs
outside React and can't call useTranslation(). New
desktop.notify.proforgeStageReady{Title,Body} keys across all 19
locales (core 4 hand-translated, Beta/RTL backfilled with EN
fallback via check-i18n-keys.mjs --fix).
Refs: PR #306 review threads (Copilot reviewer findings #2-#7).Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 13
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
hooks/useExportView.ts (1)
147-226: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAdd compliant QNBS-v3 comments next to each material change.
The existing Line 38 comment uses
// QNBS-v3 (T3):, not the required// QNBS-v3: [reason / impact / value]format. The export-result changes and test changes also have no adjacent compliant annotation.
hooks/useExportView.ts#L147-L226: Add a QNBS-v3 comment for PDF success reporting.hooks/useExportView.ts#L228-L296: Add a QNBS-v3 comment for DOCX success reporting.hooks/useExportView.ts#L298-L351: Add a QNBS-v3 comment for EPUB success reporting.hooks/useExportView.ts#L353-L414: Add a QNBS-v3 comment for notification gating.tests/unit/hooks/useExportView.test.ts#L347-L421: Add a QNBS-v3 comment in the required format for notification-gating coverage.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@hooks/useExportView.ts` around lines 147 - 226, Update hooks/useExportView.ts ranges 147-226, 228-296, 298-351, and 353-414 by adding adjacent comments for the PDF, DOCX, EPUB success-reporting, and notification-gating changes, respectively, using exactly the `// QNBS-v3: [reason / impact / value]` format. Update tests/unit/hooks/useExportView.test.ts range 347-421 with a compliant QNBS-v3 comment documenting the notification-gating coverage; replace the existing noncompliant `// QNBS-v3 (T3):` comment with the required format.Source: Coding guidelines
🧹 Nitpick comments (2)
App.tsx (1)
58-58: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd the required QNBS-v3 rationale above the new import.
Line 58 adds a substantive TSX import, but no
// QNBS-v3: ...comment is immediately above it. Add a one-line explanation.As per coding guidelines: “Bei jeder inhaltlich relevanten TSX- oder JSX-Änderung einen einzeiligen
// QNBS-v3: …-Kommentar unmittelbar über der Änderung verwenden.”Suggested fix
+// QNBS-v3: Wire native notification permission bootstrap into the app shell. import { useNativeNotifications } from './hooks/useNativeNotifications';🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@App.tsx` at line 58, In App.tsx, add a one-line `// QNBS-v3: ...` rationale immediately above the `useNativeNotifications` import, describing its purpose in the notification integration.Source: Coding guidelines
hooks/useTauriUpdater.ts (1)
16-16: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse the required one-line
QNBS-v3annotation format.Both changed TypeScript files use forms that do not match the repository rule. Replace them with one single-line
// QNBS-v3: [Grund / Impact / Kreativer Mehrwert]comment immediately above the related change.
hooks/useTauriUpdater.ts#L16-L16: replace// QNBS-v3 (T3): ...with the required colon-and-bracket format.tests/unit/hooks/useTauriUpdater.test.ts#L28-L30: collapse the three-line annotation into one line in the required format.As per coding guidelines, non-trivial TypeScript changes require one single-line
QNBS-v3comment in the specified format.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@hooks/useTauriUpdater.ts` at line 16, Replace the annotation above the related change in hooks/useTauriUpdater.ts at lines 16-16 with one single-line comment using the exact format “// QNBS-v3: [Grund / Impact / Kreativer Mehrwert]”. Collapse the three-line annotation in tests/unit/hooks/useTauriUpdater.test.ts at lines 28-30 into the same required one-line format.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/listenerMiddleware.ts`:
- Around line 543-550: Replace the multi-line annotation above the listener
change in app/listenerMiddleware.ts lines 543-550 with one single-line QNBS-v3
comment using the required “QNBS-v3: [Grund / Impact / Kreativer Mehrwert]”
format. Apply the same single-line format to the permission-request annotation
in services/desktop/desktopNotifications.ts lines 16-17, and add a compliant
single-line comment directly above the static translation implementation in
services/i18n/staticTranslate.ts lines 1-12.
- Around line 553-555: Update the listener effect around the `effect` callback
to synchronously capture `listenerApi.getOriginalState()` before any
asynchronous work, and use that snapshot to read
`settings.desktop?.desktopNotifications` instead of `listenerApi.getState()`.
In `@components/settings/DataSection.tsx`:
- Around line 58-64: Update the dynamic import in the library export success
flow around sendDesktopNotification to handle rejected imports, including
chunk-load and module-evaluation failures. Add a rejection handler or equivalent
try/catch and report the error through the existing logger from
services/logger.ts while preserving the successful notification behavior.
- Around line 57-65: In the library export success flow, add the required
one-line QNBS-v3 rationale comment immediately above the
`settings.desktop?.desktopNotifications` conditional. Keep the existing dynamic
import and `sendDesktopNotification` behavior unchanged.
In `@features/settings/settingsDefaults.ts`:
- Line 9: Add an immediately preceding one-line QNBS-v3 rationale comment for
the new desktopNotifications setting in the settings defaults object, keeping
the comment directly adjacent to that property.
In `@features/settings/settingsSlice.ts`:
- Around line 155-158: Replace the multi-line or incorrectly formatted
annotations with one immediate QNBS-v3: comment for each substantive TypeScript
change: features/settings/settingsSlice.ts lines 155-158,
tests/unit/desktopNotifications.test.ts lines 3-5,
tests/unit/services/staticTranslate.test.ts lines 4-8, and types.ts lines
636-637; add one for each substantive mock change in
tests/unit/listenerMiddleware.test.ts lines 125-133, the regression coverage in
tests/unit/settingsSlice.test.ts lines 249-274, and the fixture contract update
in tests/unit/languageToolClient.test.ts lines 94-97. Each comment must use the
required Grund / Impact / Kreativer Mehrwert content.
In `@hooks/useTauriUpdater.ts`:
- Around line 40-45: Update the successful checkForUpdate notification flow in
useTauriUpdater so it tracks the last successfully notified result.version and
skips sending when the version matches. Only record the version after
sendDesktopNotification is invoked successfully, preserve notifications for new
versions, and add a regression test covering two checks that return the same
version.
- Line 55: Update the auto-check logic in useTauriUpdater so changes to the
I18nProvider’s t function do not recreate checkForUpdate or rerun the automatic
update check after mount. Keep notification translation access stable, or make
the autoCheck effect mount-only while preserving desktopNotificationsEnabled
behavior.
In `@public/locales/el/bundle.json`:
- Around line 998-1003: English notification strings remain in the generated
locale bundles. Add Greek, Basque, Persian, Finnish, and Hebrew translations for
the desktop notification labels in the corresponding locales/<lang>/desktop.json
files and export completion labels in locales/<lang>/export.json; then
regenerate public/locales/el/bundle.json (998-1003, 1087-1088),
public/locales/eu/bundle.json (998-1003, 1087-1088),
public/locales/fa/bundle.json (998-1003, 1087-1088),
public/locales/fi/bundle.json (998-1003, 1087-1088), and
public/locales/he/bundle.json (998-1003, 1087-1088). Do not edit generated
bundles directly.
In `@public/locales/sv/bundle.json`:
- Around line 998-1003: Translate the changed notification keys in
public/locales/sv/bundle.json at lines 998-1003 and 1087-1088, and
public/locales/zh/bundle.json at lines 998-1003 and 1087-1088, replacing English
values with the appropriate Swedish or Chinese translations; then regenerate
each locale bundle from its source locale tree.
In `@services/i18n/staticTranslate.ts`:
- Around line 39-42: Update the catch handler in the locale-bundle loading flow
to accept the caught error and log it through the existing logger from
services/logger.ts before returning the empty fallback bundle. Preserve the
inFlight.delete(lang) cleanup and fallback behavior.
In `@tests/unit/hooks/useTauriUpdater.test.ts`:
- Around line 213-228: The update notification test around useTauriUpdater
should verify interpolation of the pending update version, not only the
translation key. Extend the mockSendDesktopNotification assertion so the
notification body is also checked for the expected version value 2.0.0.
In `@tests/unit/listenerMiddleware.test.ts`:
- Around line 584-594: Update the desktop notification tests around
makeFullStore and stageCompleted to create a valid ProForge run and start the
structural stage before dispatching stageCompleted, so the notification
assertion exercises a real pipeline transition. Add a separate test asserting
that dispatching stageCompleted without a current run or active stage does not
call mockSendDesktopNotification.
---
Outside diff comments:
In `@hooks/useExportView.ts`:
- Around line 147-226: Update hooks/useExportView.ts ranges 147-226, 228-296,
298-351, and 353-414 by adding adjacent comments for the PDF, DOCX, EPUB
success-reporting, and notification-gating changes, respectively, using exactly
the `// QNBS-v3: [reason / impact / value]` format. Update
tests/unit/hooks/useExportView.test.ts range 347-421 with a compliant QNBS-v3
comment documenting the notification-gating coverage; replace the existing
noncompliant `// QNBS-v3 (T3):` comment with the required format.
---
Nitpick comments:
In `@App.tsx`:
- Line 58: In App.tsx, add a one-line `// QNBS-v3: ...` rationale immediately
above the `useNativeNotifications` import, describing its purpose in the
notification integration.
In `@hooks/useTauriUpdater.ts`:
- Line 16: Replace the annotation above the related change in
hooks/useTauriUpdater.ts at lines 16-16 with one single-line comment using the
exact format “// QNBS-v3: [Grund / Impact / Kreativer Mehrwert]”. Collapse the
three-line annotation in tests/unit/hooks/useTauriUpdater.test.ts at lines 28-30
into the same required one-line format.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7c1a4722-dc85-4db0-afb7-54611c6afb4a
⛔ Files ignored due to path filters (2)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlsrc-tauri/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (85)
App.tsxREADME.mdapp/listenerMiddleware.tscomponents/settings/DataSection.tsxcomponents/settings/DesktopSection.tsxdocs/DEEPSOURCE-REVIEW-LOOP.mdfeatures/settings/settingsDefaults.tsfeatures/settings/settingsSlice.tshooks/useExportView.tshooks/useNativeNotifications.tshooks/useTauriUpdater.tslocales/ar/desktop.jsonlocales/ar/export.jsonlocales/de/desktop.jsonlocales/de/export.jsonlocales/el/desktop.jsonlocales/el/export.jsonlocales/en/desktop.jsonlocales/en/export.jsonlocales/es/desktop.jsonlocales/es/export.jsonlocales/eu/desktop.jsonlocales/eu/export.jsonlocales/fa/desktop.jsonlocales/fa/export.jsonlocales/fi/desktop.jsonlocales/fi/export.jsonlocales/fr/desktop.jsonlocales/fr/export.jsonlocales/he/desktop.jsonlocales/he/export.jsonlocales/hu/desktop.jsonlocales/hu/export.jsonlocales/is/desktop.jsonlocales/is/export.jsonlocales/it/desktop.jsonlocales/it/export.jsonlocales/ja/desktop.jsonlocales/ja/export.jsonlocales/ko/desktop.jsonlocales/ko/export.jsonlocales/pt/desktop.jsonlocales/pt/export.jsonlocales/ru/desktop.jsonlocales/ru/export.jsonlocales/sv/desktop.jsonlocales/sv/export.jsonlocales/zh/desktop.jsonlocales/zh/export.jsonpackage.jsonpublic/locales/ar/bundle.jsonpublic/locales/de/bundle.jsonpublic/locales/el/bundle.jsonpublic/locales/en/bundle.jsonpublic/locales/es/bundle.jsonpublic/locales/eu/bundle.jsonpublic/locales/fa/bundle.jsonpublic/locales/fi/bundle.jsonpublic/locales/fr/bundle.jsonpublic/locales/he/bundle.jsonpublic/locales/hu/bundle.jsonpublic/locales/is/bundle.jsonpublic/locales/it/bundle.jsonpublic/locales/ja/bundle.jsonpublic/locales/ko/bundle.jsonpublic/locales/pt/bundle.jsonpublic/locales/ru/bundle.jsonpublic/locales/sv/bundle.jsonpublic/locales/zh/bundle.jsonservices/desktop/desktopNotifications.tsservices/i18n/staticTranslate.tsservices/storage/idbProjectStore.tssrc-tauri/Cargo.tomlsrc-tauri/capabilities/default.jsonsrc-tauri/src/lib.rstests/unit/desktopNotifications.test.tstests/unit/hooks/useExportView.test.tstests/unit/hooks/useTauriUpdater.test.tstests/unit/languageToolClient.test.tstests/unit/listenerMiddleware.test.tstests/unit/services/staticTranslate.test.tstests/unit/settings/DesktopSection.test.tsxtests/unit/settingsSlice.test.tstests/unit/useNativeNotifications.test.tstypes.ts
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Add coverage for the fire-and-forget desktop notification dispatched after a successful encrypted library export: verifies it fires when enabled, is skipped when disabled, and never surfaces as an unhandled promise rejection when the notification module itself fails. Also adds a .catch() to the notification promise chain in DataSection.tsx so a notification failure can never leak past its own best-effort scope. Addresses PR #306 Copilot review finding on DataSection.tsx coverage.
- app/listenerMiddleware.ts: guard stageCompleted notification against invalid/missing ProForge run or stage (thread #13) - hooks/useExportView.ts: extract downloadPlainTextFormat() to reduce handleDownload cyclomatic complexity (thread #1, DeepSource) - locales/{el,eu,fa,fi,he,sv,zh}: translate desktop notification and export completion strings, previously English fallback text (threads #9, #10) - tests/unit/listenerMiddleware.test.ts: add regression coverage for invalid stageCompleted actions
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
qnbs
commented
Aug 1, 2026
OwnerAuthor
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
hooks/useExportView.ts (1)
404-408: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAdd the required adjacent
QNBS-v3comment.Lines 404-408 add desktop notification behavior. Add one single-line
QNBS-v3comment immediately above this branch.Proposed fix
+ // QNBS-v3: send a native completion notification only after a successful user-requested export. if (exportSucceeded && desktopNotificationsEnabled) {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@hooks/useExportView.ts` around lines 404 - 408, Add the required single-line QNBS-v3 comment immediately above the exportSucceeded && desktopNotificationsEnabled branch in the export flow within useExportView, leaving the existing sendDesktopNotification behavior unchanged.Source: Coding guidelines
🧹 Nitpick comments (2)
tests/unit/settings/DataSection.test.tsx (1)
178-182: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse
userEventfor the export interactions.Lines 178-182 use
fireEventfor user actions. InitializeuserEvent.setup()inrunEncryptedExport, then await each click and type operation.Proposed fix
-import { fireEvent, render, screen, waitFor } from '`@testing-library/react`';+import { render, screen, waitFor } from '`@testing-library/react`';+import userEvent from '`@testing-library/user-event`'; async function runEncryptedExport(desktopNotifications: boolean) { + const user = userEvent.setup(); // ... - fireEvent.click(screen.getByText('settings.data.libraryExport.button'));- fireEvent.change(screen.getByLabelText('settings.data.libraryExport.passphraseLabel'), {- target: { value: 'correct horse battery staple' },- });- fireEvent.click(screen.getByText('settings.data.libraryExport.confirm'));+ await user.click(screen.getByText('settings.data.libraryExport.button'));+ await user.type(+ screen.getByLabelText('settings.data.libraryExport.passphraseLabel'),+ 'correct horse battery staple',+ );+ await user.click(screen.getByText('settings.data.libraryExport.confirm'));As per coding guidelines, “Use
@testing-library/user-eventfor interactions.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/unit/settings/DataSection.test.tsx` around lines 178 - 182, Update runEncryptedExport to initialize userEvent.setup() and replace the export flow’s fireEvent.click and fireEvent.change calls with awaited userEvent click and typing operations, including the library export button, passphrase input, and confirmation.Source: Coding guidelines
hooks/useTauriUpdater.ts (1)
45-50: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd the required QNBS-v3 rationale comments.
The notification branch at Lines 45-50 and the dependency change at Line 61 are substantive TypeScript changes. Neither has an immediate single-line
QNBS-v3comment.Proposed comments
+ // QNBS-v3: gate and deduplicate localized update-ready notifications. if (desktopNotificationsEnabled && lastNotifiedVersionRef.current !== result.version) { ... + // QNBS-v3: re-check when the notification preference changes. }, [desktopNotificationsEnabled]);As per coding guidelines, substantive TypeScript changes require an immediate single-line QNBS-v3 rationale comment.
Also applies to: 61-61
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@hooks/useTauriUpdater.ts` around lines 45 - 50, Add immediate single-line QNBS-v3 rationale comments for the notification branch in useTauriUpdater and the dependency change at the referenced location, explaining the purpose of each substantive TypeScript change without altering its behavior.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@hooks/useExportView.ts`:
- Around line 15-16: Collapse the multi-line QNBS-v3 rationale at
hooks/useExportView.ts lines 15-16 into one single-line comment. Apply the same
single-line QNBS-v3 format to the mock rationale at
tests/unit/settings/DataSection.test.tsx lines 63-64, the notification-service
rationale at lines 70-71, and the test-suite rationale at lines 166-167,
preserving each explanation’s meaning.
In `@hooks/useTauriUpdater.ts`:
- Around line 16-18: Update the translator ref synchronization in
useTauriUpdater so tRef.current = t runs inside a useEffect with [t] rather than
during render. Place this synchronization effect before the automatic-check
effect, preserving checkForUpdate’s stable identity and preventing discarded
renders from exposing an uncommitted translator.
---
Outside diff comments:
In `@hooks/useExportView.ts`:
- Around line 404-408: Add the required single-line QNBS-v3 comment immediately
above the exportSucceeded && desktopNotificationsEnabled branch in the export
flow within useExportView, leaving the existing sendDesktopNotification behavior
unchanged.
---
Nitpick comments:
In `@hooks/useTauriUpdater.ts`:
- Around line 45-50: Add immediate single-line QNBS-v3 rationale comments for
the notification branch in useTauriUpdater and the dependency change at the
referenced location, explaining the purpose of each substantive TypeScript
change without altering its behavior.
In `@tests/unit/settings/DataSection.test.tsx`:
- Around line 178-182: Update runEncryptedExport to initialize userEvent.setup()
and replace the export flow’s fireEvent.click and fireEvent.change calls with
awaited userEvent click and typing operations, including the library export
button, passphrase input, and confirmation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f2e29444-e172-4bb8-b6e4-85c65e7a4601
📒 Files selected for processing (37)
app/listenerMiddleware.tscomponents/settings/DataSection.tsxfeatures/settings/settingsDefaults.tsfeatures/settings/settingsSlice.tshooks/useExportView.tshooks/useTauriUpdater.tslocales/el/desktop.jsonlocales/el/export.jsonlocales/eu/desktop.jsonlocales/eu/export.jsonlocales/fa/desktop.jsonlocales/fa/export.jsonlocales/fi/desktop.jsonlocales/fi/export.jsonlocales/he/desktop.jsonlocales/he/export.jsonlocales/sv/desktop.jsonlocales/sv/export.jsonlocales/zh/desktop.jsonlocales/zh/export.jsonpublic/locales/el/bundle.jsonpublic/locales/eu/bundle.jsonpublic/locales/fa/bundle.jsonpublic/locales/fi/bundle.jsonpublic/locales/he/bundle.jsonpublic/locales/sv/bundle.jsonpublic/locales/zh/bundle.jsonservices/desktop/desktopNotifications.tsservices/i18n/staticTranslate.tstests/unit/desktopNotifications.test.tstests/unit/hooks/useTauriUpdater.test.tstests/unit/languageToolClient.test.tstests/unit/listenerMiddleware.test.tstests/unit/services/staticTranslate.test.tstests/unit/settings/DataSection.test.tsxtests/unit/settingsSlice.test.tstypes.ts
🚧 Files skipped from review as they are similar to previous changes (33)
- types.ts
- tests/unit/services/staticTranslate.test.ts
- features/settings/settingsSlice.ts
- tests/unit/languageToolClient.test.ts
- locales/sv/export.json
- locales/sv/desktop.json
- locales/zh/export.json
- services/desktop/desktopNotifications.ts
- app/listenerMiddleware.ts
- tests/unit/settingsSlice.test.ts
- components/settings/DataSection.tsx
- tests/unit/hooks/useTauriUpdater.test.ts
- locales/el/export.json
- locales/he/desktop.json
- locales/fi/desktop.json
- features/settings/settingsDefaults.ts
- tests/unit/listenerMiddleware.test.ts
- locales/eu/desktop.json
- locales/el/desktop.json
- locales/zh/desktop.json
- public/locales/zh/bundle.json
- public/locales/he/bundle.json
- locales/he/export.json
- locales/fa/export.json
- services/i18n/staticTranslate.ts
- locales/fa/desktop.json
- public/locales/sv/bundle.json
- public/locales/fi/bundle.json
- public/locales/el/bundle.json
- public/locales/fa/bundle.json
- public/locales/eu/bundle.json
- locales/eu/export.json
- locales/fi/export.json
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- collapse multi-line QNBS-v3 comments to single lines - rename anchor elements from 'a' to 'anchor' in useExportView - sync tRef via useEffect instead of mutating during render - replace handleDownload if/else-if chain with a format lookup table - switch DataSection encrypted-export test to userEvent
Add a hard one-physical-line rule for QNBS-v3 comments plus four other recurring findings (anchor naming, ref-in-render mutation, userEvent over fireEvent, lookup tables over if/else-if chains) to CLAUDE.md, AGENTS.md, and .github/copilot-instructions.md so agents apply them proactively instead of waiting for the review bot to flag them again.
qnbs
commented
Aug 1, 2026
OwnerAuthor
@coderabbitai review |
✅ Action performedReview finished.
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 1, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds opt-in native OS notifications for long-running background tasks in the Tauri desktop build (Phase 2 / T3):
Gated behind a new
settings.desktop.desktopNotificationstoggle (default off), only active in the Tauri runtime, permission-gated via@tauri-apps/plugin-notification.Changes
services/desktop/desktopNotifications.ts— permission check/request/send wrapper, web no-ophooks/useNativeNotifications.ts— requests OS permission once when the setting is enabledapp/listenerMiddleware.ts— new listener: ProForgestageCompleted→ native notificationcomponents/settings/DesktopSection.tsx— new Settings toggletypes.ts/settingsDefaults.ts/idbProjectStore.ts—DesktopSettings.desktopNotificationsfield + backfillsrc-tauri/— registerstauri-plugin-notification+notification:defaultcapabilitydesktopNotifications.test.ts,useNativeNotifications.test.ts, listener middleware coverage, mock fixes for the new required fieldValidation
pnpm run lint— cleanpnpm run typecheck— cleanpnpm run i18n:check— 19 locales, 2867 keys, parity OKnode scripts/check-suppressions.mjs— 52/52 baseline, no new suppressionsvitest run— 87 passed across 6 filestauri-build.yml) — dispatching separately sinceci.ymldoesn't compilesrc-tauri/🤖 Generated with GitHub Copilot
Summary by CodeRabbit