fix(worker-bus): make priority scheduler authoritative by qnbs · Pull Request #307 · qnbs/WorldScript-Studio

qnbs · 2026-08-01T13:13:08Z

Summary

dispatch WorkerBus tasks exclusively through the bounded priority scheduler
replace animation-frame pool polling with event-driven availability
cover queue wait and execution with the progress-rearmed inactivity watchdog
bound critical work with an eight-task reserve and centralize settlement cleanup

Verification

WorkerBus: 37 tests passed
WorkerPool: 14 tests passed
PriorityTaskQueue: 7 tests passed
DuckDB client: 23 tests passed
local embedding service: 18 tests passed
focused Biome and strict tsgo checks passed

Local environment note

The npm exec lint-staged wrapper hung on the constrained workstation. Its underlying Biome command was run directly and passed before the commit; the commit therefore used --no-verify.

vercel · 2026-08-01T13:13:14Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
worldscript-studio	Ready	Preview	Aug 1, 2026 3:23pm

coderabbitai · 2026-08-01T13:13:17Z

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:26 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d104f140-c051-42b3-93f5-8c1675878ae8

📥 Commits

Reviewing files that changed from the base of the PR and between 76d8cfa and 25df3d0.

📒 Files selected for processing (16)

AGENTS.md
AUDIT.md
CLAUDE.md
README.md
TODO.md
docs/adr/0015-worker-generation-consolidation.md
packages/worker-bus/src/progressEmitter.ts
packages/worker-bus/src/taskQueue.ts
packages/worker-bus/src/types.ts
packages/worker-bus/src/workerBus.ts
packages/worker-bus/src/workerPool.ts
packages/worker-bus/tests/progressEmitter.test.ts
packages/worker-bus/tests/taskQueue.test.ts
packages/worker-bus/tests/workerBus.test.ts
packages/worker-bus/tests/workerPool.test.ts
tests/e2e/helpers.ts

_{Comment @coderabbitai help to get the list of available commands.}

codeant-ai · 2026-08-01T13:13:37Z

🏁 CodeAnt Quality Gate Results

Commit:ddbdef83
Scan Time: 2026-08-01 13:13:37 UTC

✅ Overall Status: PASSED

Quality Gate Details

Quality Gate	Status	Details
Secrets	✅ PASSED	0 secrets found
Duplicate Code	✅ PASSED	0.0% duplicated
SAST	✅ PASSED	No security issues
Bugs	✅ PASSED	Rating S: No bugs
IAC	✅ PASSED	No IAC issues

View Full Results

deepsource-io · 2026-08-01T13:13:54Z

DeepSource Code Review

We reviewed changes in 76d8cfa...25df3d0 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Updated (UTC)	Details
Docker	Aug 1, 2026 3:22p.m.	Review ↗
JavaScript	Aug 1, 2026 3:22p.m.	Review ↗
Python	Aug 1, 2026 3:22p.m.	Review ↗
Rust	Aug 1, 2026 3:22p.m.	Review ↗
Shell	Aug 1, 2026 3:22p.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Copilot

Pull request overview

Makes WorkerBus’s bounded priority scheduler authoritative and replaces pool polling with event-driven dispatch.

Changes:

Adds priority/FIFO scheduling with bounded critical-task reserve.
Adds enqueue-to-completion inactivity watchdogs and centralized cleanup.
Expands regression tests and updates architecture documentation.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`packages/worker-bus/src/workerBus.ts`	Implements scheduler-driven dispatch and watchdog lifecycle.
`packages/worker-bus/src/workerPool.ts`	Adds non-blocking acquisition and availability notifications.
`packages/worker-bus/src/taskQueue.ts`	Adds runnable-task selection and critical reserve.
`packages/worker-bus/src/progressEmitter.ts`	Adds task progress cleanup.
`packages/worker-bus/src/types.ts`	Documents timeout semantics and adds saturation event.
`packages/worker-bus/tests/workerBus.test.ts`	Tests scheduling, saturation, cleanup, and timeouts.
`packages/worker-bus/tests/workerPool.test.ts`	Tests event-driven worker availability.
`packages/worker-bus/tests/taskQueue.test.ts`	Tests reserve limits and runnable selection.
`docs/adr/0015-worker-generation-consolidation.md`	Records scheduler follow-up resolution.
`README.md`	Updates WorkerBus feature description.
`TODO.md`	Records completed scheduler hotfix.
`AUDIT.md`	Updates release and audit status.
`AGENTS.md`	Updates agent architecture guidance.
`CLAUDE.md`	Updates WorkerBus guidance and removes resolved debt.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ddbdef834b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codecov · 2026-08-01T13:26:37Z

Codecov Report

❌ Patch coverage is 87.85047% with 39 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
packages/worker-bus/src/workerBus.ts	87.75%	6 Missing and 24 partials ⚠️
packages/worker-bus/src/workerPool.ts	84.21%	2 Missing and 4 partials ⚠️
packages/worker-bus/src/progressEmitter.ts	89.28%	0 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

qnbs · 2026-08-01T13:52:54Z

@CodeAnt-AI review\n@coderabbitai review

coderabbitai · 2026-08-01T13:53:07Z

@qnbs I will review pull request #307.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

codeant-ai · 2026-08-01T13:53:24Z

Question: review\n@coderabbitai review

Answer:

Review findings

[P1] Completed progress streams can remain pending forever

ProgressEmitter.complete() only deletes the listener set:

complete(taskId: string): void{this.listeners.delete(taskId);}

However, iterable(taskId) creates its own iterator state (done, resolveNext) and registers a listener. Deleting the listeners does not mark that iterator as complete or resolve a pending next() call. Consequently, consumers awaiting progress can hang indefinitely after the task settles:

constnext=handle.progress[Symbol.asyncIterator]().next();// task completesawaitnext;// remains pending

This is especially problematic because finalize() now explicitly calls this.progress.complete(...), so the new centralized cleanup path can strand progress consumers.

complete() should notify the per-task async iterable state and resolve any pending next() with { done: true, value: undefined }, while ensuring subsequent next() calls also return done. A regression test should cover both an iterator already waiting on next() and an iterator created after task completion.

qnbs · 2026-08-01T14:28:42Z

@CodeAnt-AI review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:31dffbf143

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

qnbs · 2026-08-01T14:55:05Z

@CodeAnt-AI review

qnbs · 2026-08-01T15:23:08Z

@CodeAnt-AI review

fix(worker-bus): make priority scheduler authoritative
ddbdef8

CopilotAI review requested due to automatic review settings August 1, 2026 13:13

Copilotstarted reviewing on behalf of qnbs August 1, 2026 13:13 View session

deepsource-ioBot reviewed Aug 1, 2026
View reviewed changes

CopilotAI reviewed Aug 1, 2026
View reviewed changes

Comment threadpackages/worker-bus/src/workerBus.ts Outdated
Comment threadpackages/worker-bus/src/progressEmitter.ts

chatgpt-codex-connectorBot reviewed Aug 1, 2026
View reviewed changes

Comment threadpackages/worker-bus/src/workerBus.ts Outdated
Comment threadpackages/worker-bus/src/workerBus.ts Outdated
Comment threadpackages/worker-bus/src/workerBus.ts Outdated
Comment threadpackages/worker-bus/src/workerBus.ts Outdated
Comment threadpackages/worker-bus/src/workerBus.ts Outdated

fix(worker-bus): harden scheduler retry cleanup
50bf65a

deepsource-ioBot reviewed Aug 1, 2026
View reviewed changes

Comment threadpackages/worker-bus/src/workerBus.ts
Comment threadpackages/worker-bus/src/workerBus.ts Outdated

qnbs added 2 commits August 1, 2026 16:20

fix(worker-bus): order listener cleanup safely
eabb7b8

refactor(worker-bus): simplify dispatch analysis
31dffbf

chatgpt-codex-connectorBot reviewed Aug 1, 2026
View reviewed changes

Comment threadpackages/worker-bus/src/workerBus.ts Outdated

test(e2e): disambiguate configured status
270e795

fix(worker-bus): settle timeout replacement failures
25df3d0

qnbs merged commit b4bfd7a into mainAug 1, 2026
27 checks passed

qnbs deleted the fix/workerbus-authoritative-scheduler branch August 1, 2026 15:47

This was referenced Aug 1, 2026
release: v1.25.1 WorkerBus reliability patch #308
Closed
release: v1.26.0 WorkerBus reliability and native notifications #309
Merged

This was referenced Aug 18, 2026
refactor(desktop): introduce renderer-neutral platform contracts #384
Merged
refactor(desktop): route Tauri consumers through the DesktopPlatform adapter #385
Merged

Conversation

qnbs commented Aug 1, 2026

Summary

Verification

Local environment note

Uh oh!

vercelBot commented Aug 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitaiBot commented Aug 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

codeant-aiBot commented Aug 1, 2026

🏁 CodeAnt Quality Gate Results

✅ Overall Status: PASSED

Quality Gate Details

Uh oh!

deepsource-ioBot commented Aug 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Aug 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

qnbs commented Aug 1, 2026

Uh oh!

coderabbitaiBot commented Aug 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codeant-aiBot commented Aug 1, 2026

Review findings

[P1] Completed progress streams can remain pending forever

Uh oh!

Uh oh!

Uh oh!

qnbs commented Aug 1, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

qnbs commented Aug 1, 2026

Uh oh!

qnbs commented Aug 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

vercelBot commented Aug 1, 2026•
edited
Loading

coderabbitaiBot commented Aug 1, 2026•
edited
Loading

deepsource-ioBot commented Aug 1, 2026•
edited
Loading

codecovBot commented Aug 1, 2026•
edited
Loading

coderabbitaiBot commented Aug 1, 2026•
edited
Loading