Skip to content

build(deps): bump the codeql-action group across 1 directory with 4 updates - #562

Merged
qnbs merged 1 commit into
mainfrom
dependabot/github_actions/codeql-action-0137bbe3c7
Sep 3, 2026
Merged

build(deps): bump the codeql-action group across 1 directory with 4 updates#562
qnbs merged 1 commit into
mainfrom
dependabot/github_actions/codeql-action-0137bbe3c7

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubAug 31, 2026

Copy link
Copy Markdown
Contributor

Bumps the codeql-action group with 4 updates in the / directory: github/codeql-action/init, github/codeql-action/autobuild, github/codeql-action/analyze and github/codeql-action/upload-sarif.

Updates github/codeql-action/init from 4.37.7 to 4.37.9

Release notes

Sourced from github/codeql-action/init's releases.

v4.37.9

v4.37.8

No user facing changes.

Changelog

Sourced from github/codeql-action/init's changelog.

CodeQL Action Changelog

See the releases page for the relevant changes to the CodeQL CLI and language packs.

[UNRELEASED]

No user facing changes.

4.37.9 - 26 Aug 2026

4.37.8 - 21 Aug 2026

No user facing changes.

4.37.7 - 13 Aug 2026

4.37.6 - 04 Aug 2026

  • Changed the default filepath for the new remote file address format that was introduced in CodeQL Action 4.37.0 / 3.37.0 to .github/codeql-config.yml to align it with the suggested path that is used elsewhere. #4070

4.37.5 - 03 Aug 2026

  • Fixed a bug where a network error while streaming the download of the CodeQL bundle could terminate the init Action instead of falling back to downloading the bundle before extracting it. #4061

4.37.4 - 29 Jul 2026

  • This version of the CodeQL Action adds support for the tools input for the codeql-action/init step to be specified using a github-codeql-toolsrepository property. This feature will gradually be rolled out following the release of this version. Once rolled out, this allows for the CodeQL CLI version that is used in GitHub-managed workflows, such as Default Setup, to be set to a custom value. For example, customers who run into issues with rate limits when a new CodeQL CLI version is released can set the value to toolcache to always use the CodeQL CLI version that is available in the runner toolcache. For Advanced Setup workflows, the value provided for tools in the workflow definition always takes precedence unless the value of the repository property starts with !. #4037
  • Update default CodeQL bundle version to 2.26.2. #4051

4.37.3 - 22 Jul 2026

No user facing changes.

4.37.2 - 21 Jul 2026

  • The new address format for the config-file input that was introduced in CodeQL Action 4.37.0 is now enabled by default. In addition to the format described there, the remote= prefix can now be used to explicitly indicate that the input refers to a remote file. All previous input formats continue to be accepted as well. #4023
  • The CodeQL Action can now make use of configured private registries in Default Setup to retrieve CodeQL configuration files from remote repositories that require authentication. This will allow customers to store their CodeQL configuration in a single repository that can then be referenced by Default Setup workflows in other repositories. We expect to roll this and other, related changes out to everyone in July. #4007

4.37.1 - 16 Jul 2026

  • Upcoming breaking change: Add a deprecation warning for customers using CodeQL version 2.20.6 and earlier. These versions of CodeQL were discontinued on 1 July 2026 alongside GitHub Enterprise Server 3.16, and will be unsupported by the next minor release of the CodeQL Action. #3956
  • Update default CodeQL bundle version to 2.26.1. #4019

4.37.0 - 08 Jul 2026

... (truncated)

Commits
  • cdf488f Merge pull request #4107 from github/update-v4.37.9-920ba7cd1
  • 7243f38 Update changelog for v4.37.9
  • 920ba7c Merge pull request #4106 from github/update-bundle/codeql-bundle-v2.26.4
  • ecfa6e1 Add changelog note
  • adcdf4a Update default bundle to codeql-bundle-v2.26.4
  • 486fec2 Merge pull request #4099 from github/update-supported-enterprise-server-versions
  • 134624c Merge pull request #4101 from github/dependabot/npm_and_yarn/npm-minor-457d82...
  • ff43db8 Merge pull request #4103 from github/mergeback/v4.37.8-to-main-db488dde
  • 4605e03 Rebuild
  • 099c869 Update changelog and version after v4.37.8
  • Additional commits viewable in compare view

Updates github/codeql-action/autobuild from 4.37.7 to 4.37.9

Release notes

Sourced from github/codeql-action/autobuild's releases.

v4.37.9

v4.37.8

No user facing changes.

Changelog

Sourced from github/codeql-action/autobuild's changelog.

CodeQL Action Changelog

See the releases page for the relevant changes to the CodeQL CLI and language packs.

[UNRELEASED]

No user facing changes.

4.37.9 - 26 Aug 2026

4.37.8 - 21 Aug 2026

No user facing changes.

4.37.7 - 13 Aug 2026

4.37.6 - 04 Aug 2026

  • Changed the default filepath for the new remote file address format that was introduced in CodeQL Action 4.37.0 / 3.37.0 to .github/codeql-config.yml to align it with the suggested path that is used elsewhere. #4070

4.37.5 - 03 Aug 2026

  • Fixed a bug where a network error while streaming the download of the CodeQL bundle could terminate the init Action instead of falling back to downloading the bundle before extracting it. #4061

4.37.4 - 29 Jul 2026

  • This version of the CodeQL Action adds support for the tools input for the codeql-action/init step to be specified using a github-codeql-toolsrepository property. This feature will gradually be rolled out following the release of this version. Once rolled out, this allows for the CodeQL CLI version that is used in GitHub-managed workflows, such as Default Setup, to be set to a custom value. For example, customers who run into issues with rate limits when a new CodeQL CLI version is released can set the value to toolcache to always use the CodeQL CLI version that is available in the runner toolcache. For Advanced Setup workflows, the value provided for tools in the workflow definition always takes precedence unless the value of the repository property starts with !. #4037
  • Update default CodeQL bundle version to 2.26.2. #4051

4.37.3 - 22 Jul 2026

No user facing changes.

4.37.2 - 21 Jul 2026

  • The new address format for the config-file input that was introduced in CodeQL Action 4.37.0 is now enabled by default. In addition to the format described there, the remote= prefix can now be used to explicitly indicate that the input refers to a remote file. All previous input formats continue to be accepted as well. #4023
  • The CodeQL Action can now make use of configured private registries in Default Setup to retrieve CodeQL configuration files from remote repositories that require authentication. This will allow customers to store their CodeQL configuration in a single repository that can then be referenced by Default Setup workflows in other repositories. We expect to roll this and other, related changes out to everyone in July. #4007

4.37.1 - 16 Jul 2026

  • Upcoming breaking change: Add a deprecation warning for customers using CodeQL version 2.20.6 and earlier. These versions of CodeQL were discontinued on 1 July 2026 alongside GitHub Enterprise Server 3.16, and will be unsupported by the next minor release of the CodeQL Action. #3956
  • Update default CodeQL bundle version to 2.26.1. #4019

4.37.0 - 08 Jul 2026

... (truncated)

Commits
  • cdf488f Merge pull request #4107 from github/update-v4.37.9-920ba7cd1
  • 7243f38 Update changelog for v4.37.9
  • 920ba7c Merge pull request #4106 from github/update-bundle/codeql-bundle-v2.26.4
  • ecfa6e1 Add changelog note
  • adcdf4a Update default bundle to codeql-bundle-v2.26.4
  • 486fec2 Merge pull request #4099 from github/update-supported-enterprise-server-versions
  • 134624c Merge pull request #4101 from github/dependabot/npm_and_yarn/npm-minor-457d82...
  • ff43db8 Merge pull request #4103 from github/mergeback/v4.37.8-to-main-db488dde
  • 4605e03 Rebuild
  • 099c869 Update changelog and version after v4.37.8
  • Additional commits viewable in compare view

Updates github/codeql-action/analyze from 4.37.7 to 4.37.9

Release notes

Sourced from github/codeql-action/analyze's releases.

v4.37.9

v4.37.8

No user facing changes.

Changelog

Sourced from github/codeql-action/analyze's changelog.

CodeQL Action Changelog

See the releases page for the relevant changes to the CodeQL CLI and language packs.

[UNRELEASED]

No user facing changes.

4.37.9 - 26 Aug 2026

4.37.8 - 21 Aug 2026

No user facing changes.

4.37.7 - 13 Aug 2026

4.37.6 - 04 Aug 2026

  • Changed the default filepath for the new remote file address format that was introduced in CodeQL Action 4.37.0 / 3.37.0 to .github/codeql-config.yml to align it with the suggested path that is used elsewhere. #4070

4.37.5 - 03 Aug 2026

  • Fixed a bug where a network error while streaming the download of the CodeQL bundle could terminate the init Action instead of falling back to downloading the bundle before extracting it. #4061

4.37.4 - 29 Jul 2026

  • This version of the CodeQL Action adds support for the tools input for the codeql-action/init step to be specified using a github-codeql-toolsrepository property. This feature will gradually be rolled out following the release of this version. Once rolled out, this allows for the CodeQL CLI version that is used in GitHub-managed workflows, such as Default Setup, to be set to a custom value. For example, customers who run into issues with rate limits when a new CodeQL CLI version is released can set the value to toolcache to always use the CodeQL CLI version that is available in the runner toolcache. For Advanced Setup workflows, the value provided for tools in the workflow definition always takes precedence unless the value of the repository property starts with !. #4037
  • Update default CodeQL bundle version to 2.26.2. #4051

4.37.3 - 22 Jul 2026

No user facing changes.

4.37.2 - 21 Jul 2026

  • The new address format for the config-file input that was introduced in CodeQL Action 4.37.0 is now enabled by default. In addition to the format described there, the remote= prefix can now be used to explicitly indicate that the input refers to a remote file. All previous input formats continue to be accepted as well. #4023
  • The CodeQL Action can now make use of configured private registries in Default Setup to retrieve CodeQL configuration files from remote repositories that require authentication. This will allow customers to store their CodeQL configuration in a single repository that can then be referenced by Default Setup workflows in other repositories. We expect to roll this and other, related changes out to everyone in July. #4007

4.37.1 - 16 Jul 2026

  • Upcoming breaking change: Add a deprecation warning for customers using CodeQL version 2.20.6 and earlier. These versions of CodeQL were discontinued on 1 July 2026 alongside GitHub Enterprise Server 3.16, and will be unsupported by the next minor release of the CodeQL Action. #3956
  • Update default CodeQL bundle version to 2.26.1. #4019

4.37.0 - 08 Jul 2026

... (truncated)

Commits
  • cdf488f Merge pull request #4107 from github/update-v4.37.9-920ba7cd1
  • 7243f38 Update changelog for v4.37.9
  • 920ba7c Merge pull request #4106 from github/update-bundle/codeql-bundle-v2.26.4
  • ecfa6e1 Add changelog note
  • adcdf4a Update default bundle to codeql-bundle-v2.26.4
  • 486fec2 Merge pull request #4099 from github/update-supported-enterprise-server-versions
  • 134624c Merge pull request #4101 from github/dependabot/npm_and_yarn/npm-minor-457d82...
  • ff43db8 Merge pull request #4103 from github/mergeback/v4.37.8-to-main-db488dde
  • 4605e03 Rebuild
  • 099c869 Update changelog and version after v4.37.8
  • Additional commits viewable in compare view

Updates github/codeql-action/upload-sarif from 4.37.7 to 4.37.9

Release notes

Sourced from github/codeql-action/upload-sarif's releases.

v4.37.9

v4.37.8

No user facing changes.

Changelog

Sourced from github/codeql-action/upload-sarif's changelog.

CodeQL Action Changelog

See the releases page for the relevant changes to the CodeQL CLI and language packs.

[UNRELEASED]

No user facing changes.

4.37.9 - 26 Aug 2026

4.37.8 - 21 Aug 2026

No user facing changes.

4.37.7 - 13 Aug 2026

4.37.6 - 04 Aug 2026

  • Changed the default filepath for the new remote file address format that was introduced in CodeQL Action 4.37.0 / 3.37.0 to .github/codeql-config.yml to align it with the suggested path that is used elsewhere. #4070

4.37.5 - 03 Aug 2026

  • Fixed a bug where a network error while streaming the download of the CodeQL bundle could terminate the init Action instead of falling back to downloading the bundle before extracting it. #4061

4.37.4 - 29 Jul 2026

  • This version of the CodeQL Action adds support for the tools input for the codeql-action/init step to be specified using a github-codeql-toolsrepository property. This feature will gradually be rolled out following the release of this version. Once rolled out, this allows for the CodeQL CLI version that is used in GitHub-managed workflows, such as Default Setup, to be set to a custom value. For example, customers who run into issues with rate limits when a new CodeQL CLI version is released can set the value to toolcache to always use the CodeQL CLI version that is available in the runner toolcache. For Advanced Setup workflows, the value provided for tools in the workflow definition always takes precedence unless the value of the repository property starts with !. #4037
  • Update default CodeQL bundle version to 2.26.2. #4051

4.37.3 - 22 Jul 2026

No user facing changes.

4.37.2 - 21 Jul 2026

  • The new address format for the config-file input that was introduced in CodeQL Action 4.37.0 is now enabled by default. In addition to the format described there, the remote= prefix can now be used to explicitly indicate that the input refers to a remote file. All previous input formats continue to be accepted as well. #4023
  • The CodeQL Action can now make use of configured private registries in Default Setup to retrieve CodeQL configuration files from remote repositories that require authentication. This will allow customers to store their CodeQL configuration in a single repository that can then be referenced by Default Setup workflows in other repositories. We expect to roll this and other, related changes out to everyone in July. #4007

4.37.1 - 16 Jul 2026

  • Upcoming breaking change: Add a deprecation warning for customers using CodeQL version 2.20.6 and earlier. These versions of CodeQL were discontinued on 1 July 2026 alongside GitHub Enterprise Server 3.16, and will be unsupported by the next minor release of the CodeQL Action. #3956
  • Update default CodeQL bundle version to 2.26.1. #4019

4.37.0 - 08 Jul 2026

... (truncated)

Commits
  • cdf488f Merge pull request #4107 from github/update-v4.37.9-920ba7cd1
  • 7243f38 Update changelog for v4.37.9
  • 920ba7c Merge pull request #4106 from github/update-bundle/codeql-bundle-v2.26.4
  • ecfa6e1 Add changelog note
  • adcdf4a Update default bundle to codeql-bundle-v2.26.4
  • 486fec2 Merge pull request #4099 from github/update-supported-enterprise-server-versions
  • 134624c Merge pull request #4101 from github/dependabot/npm_and_yarn/npm-minor-457d82...
  • ff43db8 Merge pull request #4103 from github/mergeback/v4.37.8-to-main-db488dde
  • 4605e03 Rebuild
  • 099c869 Update changelog and version after v4.37.8
  • Additional commits viewable in compare view

@dependabotdependabotBot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Aug 31, 2026
@dependabot
dependabotBot requested a review from qnbs as a code ownerAugust 31, 2026 23:48
@vercel

vercelBot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated
worldscript-studioReadyReadyPreviewSep 3, 2026 12:14pm UTC

@dependabotdependabotBot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Aug 31, 2026
@codeant-ai

Copy link
Copy Markdown

Skipping PR review because a bot author is detected.

If you want to trigger CodeAnt AI, comment @codeant-ai review to trigger a manual review.

@codeant-ai

codeant-aiBot commented Aug 31, 2026

Copy link
Copy Markdown

🏁 CodeAnt Quality Gate Results

Commit:81362cb0
Scan Time: 2026-09-03 12:13:21 UTC

βœ… Overall Status: PASSED

Quality Gate Details

Quality GateStatusDetails
Secretsβœ… PASSED0 secrets found
Duplicate Codeβœ… PASSED0.0% duplicated
SASTβœ… PASSEDNo security issues
Bugsβœ… PASSEDRating S: No bugs
IACβœ… PASSEDRating S: No issues

View Full Results

@codecov

codecovBot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.

πŸ“’ Thoughts on this report? Let us know!

@qnbs

qnbs commented Sep 3, 2026

Copy link
Copy Markdown
Owner

@dependabot rebase

…pdates
Bumps the codeql-action group with 4 updates in the / directory: [github/codeql-action/init](https://github.com/github/codeql-action), [github/codeql-action/autobuild](https://github.com/github/codeql-action), [github/codeql-action/analyze](https://github.com/github/codeql-action) and [github/codeql-action/upload-sarif](https://github.com/github/codeql-action).
Updates `github/codeql-action/init` from 4.37.7 to 4.37.9
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@ff2f1c6...cdf488f)
Updates `github/codeql-action/autobuild` from 4.37.7 to 4.37.9
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@ff2f1c6...cdf488f)
Updates `github/codeql-action/analyze` from 4.37.7 to 4.37.9
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@ff2f1c6...cdf488f)
Updates `github/codeql-action/upload-sarif` from 4.37.7 to 4.37.9
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@ff2f1c6...cdf488f)
---
updated-dependencies:
- dependency-name: github/codeql-action/analyze
dependency-version: 4.37.8
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: codeql-action
- dependency-name: github/codeql-action/autobuild
dependency-version: 4.37.8
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: codeql-action
- dependency-name: github/codeql-action/init
dependency-version: 4.37.8
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: codeql-action
- dependency-name: github/codeql-action/upload-sarif
dependency-version: 4.37.8
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: codeql-action
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabotBotforce-pushed the dependabot/github_actions/codeql-action-0137bbe3c7 branch from 7b81931 to 81362cbCompareSeptember 3, 2026 12:12
@dependabotdependabotBot changed the title build(deps): bump the codeql-action group with 4 updatesbuild(deps): bump the codeql-action group across 1 directory with 4 updatesSep 3, 2026

@codescene-accesscodescene-accessBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No application code in the PR β€” skipped Code Health checks.

See analysis details in CodeScene

Quality Gate Profile:The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@deepsource-io

deepsource-ioBot commented Sep 3, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 8af6fdf...81362cb on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSourceΒ β†—

PR Report Card

Overall GradeSecurity

Reliability

Complexity

Hygiene

Code Review Summary

AnalyzerStatusUpdated (UTC)Details
DockerSep 3, 2026 12:13p.m.ReviewΒ β†—
PythonSep 3, 2026 12:13p.m.ReviewΒ β†—
RustSep 3, 2026 12:13p.m.ReviewΒ β†—
ShellSep 3, 2026 12:13p.m.ReviewΒ β†—

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@qnbs
qnbs merged commit db1d1bd into mainSep 3, 2026
39 checks passed
@qnbs
qnbs deleted the dependabot/github_actions/codeql-action-0137bbe3c7 branch September 3, 2026 12:40
qnbs added a commit that referenced this pull request Sep 3, 2026
… check-pr-size.mjs exception-ceiling bug
Recomputed entirely from a genuine rebase of #583 onto current main
(which now carries #562, #592, and #594) rather than trusting the
historical 70 files / 1753 lines / 21 commits figures the earlier
commits on this branch carried forward.
The rebase itself revealed two things the prior estimate could not
have known:
1. #583 and #592 (the independent factory-reset persistence-admission
fix, issues #591/#593) touch overlapping files -- app/listenerMiddleware.ts,
services/factoryResetService.ts, services/crossProjectIndexService.ts,
and their tests. Reconciled by layering both mechanisms inside
wipeAllAppData(): #592's isFactoryResetInProgress()/coordinator-draining
gate runs first (blocks new Redux-listener writes, drains in-flight
ones), then #583's beginIdbReset() force-closes every other long-lived
IDB connection the coordinators do not track.
2. PR #590 (merged earlier, unrelated) had already independently shipped
the same locale-independent Settings/mobile-"More"-button navigation
fix#583 originally introduced across five files (components/SettingsView.tsx,
components/settings/SettingsModals.tsx, components/settings/DataSection.tsx,
components/Sidebar.tsx, tests/e2e/helpers.ts). Parallel convergent
evolution left #583's own changes to those files fully superseded --
zero net diff against current main -- so they are correctly absent
from allowedPaths.
Final measured diff: 65 governed files (84 incl. generated locale
bundles), 1611 meaningful lines, 14 commits -- exact ceilings, no
speculative headroom, computed directly via check-pr-size.mjs itself
against the real rebased branch.
That direct measurement also surfaced a latent bug in check-pr-size.mjs:
when an exception's own ceiling legitimately exceeds TIERS.absolute
(30 files/3000 lines/15 commits) -- the entire point of granting one --
evaluatePrSize() fell through to selectSeverity() against that fixed
tier instead of treating the exception's own ceiling as authoritative,
so a fully-satisfied wide exception still reported blocking:true.
Neither #539 (maxFiles:30, at the absolute tier's own boundary) nor
#564 (maxFiles:3, well under it) had ever exercised this path -- #583
is the first exception whose own scope is wide enough to expose it.
Fixed to short-circuit on exception.entry directly, verified against
a synthetic base commit carrying this fix plus the recomputed entry,
diffed against the actual rebased #583 branch (exit 0, PR_SIZE_EXCEPTION=APPLIED).
Added a regression test covering a wide exception ceiling that exceeds
the fixed absolute tier.
Squashes the prior five commits on this branch (four incremental
"recompute" attempts plus a stray temp commit), none of which had been
verified against a real rebase or the actual gate behavior.
qnbs added a commit that referenced this pull request Sep 3, 2026
… check-pr-size.mjs exception-ceiling bug
Recomputed entirely from a genuine rebase of #583 onto current main
(which now carries #562, #592, and #594) rather than trusting the
historical 70 files / 1753 lines / 21 commits figures the earlier
commits on this branch carried forward.
The rebase itself revealed two things the prior estimate could not
have known:
1. #583 and #592 (the independent factory-reset persistence-admission
fix, issues #591/#593) touch overlapping files -- app/listenerMiddleware.ts,
services/factoryResetService.ts, services/crossProjectIndexService.ts,
and their tests. Reconciled by layering both mechanisms inside
wipeAllAppData(): #592's isFactoryResetInProgress()/coordinator-draining
gate runs first (blocks new Redux-listener writes, drains in-flight
ones), then #583's beginIdbReset() force-closes every other long-lived
IDB connection the coordinators do not track.
2. PR #590 (merged earlier, unrelated) had already independently shipped
the same locale-independent Settings/mobile-"More"-button navigation
fix#583 originally introduced across five files (components/SettingsView.tsx,
components/settings/SettingsModals.tsx, components/settings/DataSection.tsx,
components/Sidebar.tsx, tests/e2e/helpers.ts). Parallel convergent
evolution left #583's own changes to those files fully superseded --
zero net diff against current main -- so they are correctly absent
from allowedPaths.
Final measured diff: 65 governed files (84 incl. generated locale
bundles), 1611 meaningful lines, 14 commits -- exact ceilings, no
speculative headroom, computed directly via check-pr-size.mjs itself
against the real rebased branch.
That direct measurement also surfaced a latent bug in check-pr-size.mjs:
when an exception's own ceiling legitimately exceeds TIERS.absolute
(30 files/3000 lines/15 commits) -- the entire point of granting one --
evaluatePrSize() fell through to selectSeverity() against that fixed
tier instead of treating the exception's own ceiling as authoritative,
so a fully-satisfied wide exception still reported blocking:true.
Neither #539 (maxFiles:30, at the absolute tier's own boundary) nor
#564 (maxFiles:3, well under it) had ever exercised this path -- #583
is the first exception whose own scope is wide enough to expose it.
Fixed to short-circuit on exception.entry directly, verified against
a synthetic base commit carrying this fix plus the recomputed entry,
diffed against the actual rebased #583 branch (exit 0, PR_SIZE_EXCEPTION=APPLIED).
Added a regression test covering a wide exception ceiling that exceeds
the fixed absolute tier.
Squashes the prior five commits on this branch (four incremental
"recompute" attempts plus a stray temp commit), none of which had been
verified against a real rebase or the actual gate behavior.
qnbs added a commit that referenced this pull request Sep 3, 2026
… check-pr-size.mjs exception-ceiling bug (#586)
Recomputed entirely from a genuine rebase of #583 onto current main
(which now carries #562, #592, and #594) rather than trusting the
historical 70 files / 1753 lines / 21 commits figures the earlier
commits on this branch carried forward.
The rebase itself revealed two things the prior estimate could not
have known:
1. #583 and #592 (the independent factory-reset persistence-admission
fix, issues #591/#593) touch overlapping files -- app/listenerMiddleware.ts,
services/factoryResetService.ts, services/crossProjectIndexService.ts,
and their tests. Reconciled by layering both mechanisms inside
wipeAllAppData(): #592's isFactoryResetInProgress()/coordinator-draining
gate runs first (blocks new Redux-listener writes, drains in-flight
ones), then #583's beginIdbReset() force-closes every other long-lived
IDB connection the coordinators do not track.
2. PR #590 (merged earlier, unrelated) had already independently shipped
the same locale-independent Settings/mobile-"More"-button navigation
fix#583 originally introduced across five files (components/SettingsView.tsx,
components/settings/SettingsModals.tsx, components/settings/DataSection.tsx,
components/Sidebar.tsx, tests/e2e/helpers.ts). Parallel convergent
evolution left #583's own changes to those files fully superseded --
zero net diff against current main -- so they are correctly absent
from allowedPaths.
Final measured diff: 65 governed files (84 incl. generated locale
bundles), 1611 meaningful lines, 14 commits -- exact ceilings, no
speculative headroom, computed directly via check-pr-size.mjs itself
against the real rebased branch.
That direct measurement also surfaced a latent bug in check-pr-size.mjs:
when an exception's own ceiling legitimately exceeds TIERS.absolute
(30 files/3000 lines/15 commits) -- the entire point of granting one --
evaluatePrSize() fell through to selectSeverity() against that fixed
tier instead of treating the exception's own ceiling as authoritative,
so a fully-satisfied wide exception still reported blocking:true.
Neither #539 (maxFiles:30, at the absolute tier's own boundary) nor
#564 (maxFiles:3, well under it) had ever exercised this path -- #583
is the first exception whose own scope is wide enough to expose it.
Fixed to short-circuit on exception.entry directly, verified against
a synthetic base commit carrying this fix plus the recomputed entry,
diffed against the actual rebased #583 branch (exit 0, PR_SIZE_EXCEPTION=APPLIED).
Added a regression test covering a wide exception ceiling that exceeds
the fixed absolute tier.
Squashes the prior five commits on this branch (four incremental
"recompute" attempts plus a stray temp commit), none of which had been
verified against a real rebase or the actual gate behavior.
qnbs added a commit that referenced this pull request Sep 5, 2026
* chore(release): bump version to v1.28.4
Patch release reconciling release-truth documentation with everything
merged to main since v1.28.3 (62 commits / ~40 PRs, audited against
live GitHub state, not assumed from commit subjects):
- fix: PWA first-install unprompted reload (#585, PR #613)
- fix: shared-origin service-worker cache-read isolation (#514, PR #612)
- fix: Factory Reset could reboot into Settings instead of Welcome
Portal (PR #592)
- fix: preserve-first desktop corruption recovery (PR #542) and a
distinct filesystem-I/O recovery action (PR #545)
- fix: intentionally cleared project metadata no longer reappears
(PR #546)
- a11y: Welcome/Home dashboard WCAG AA contrast + reduced-motion
cascade fix + default appearance preset change (#565, PR #609);
ManuscriptEditor contrast (PR #560)
- security: fflate ZIP64-parsing DoS override (PR #595); routine
dependency floor bumps (PR #587, #561, #562, #594)
- docs: R-15 secure desktop storage design contract admitted (PRs
#564, #580, #581, #582, #584) β€” design only, no implementation yet
- tests: visual regression testing repaired β€” baselines were directory
listings, not the application (PR #610); IDB reset-quiescence
hardening (PR #596); WelcomePortal E2E navigation made
locale-independent (PR #590)
Everything classified as pure internal/CI-governance churn (PR-size
exception plumbing, dual-graph tooling, toolchain pins) is omitted from
CHANGELOG.md as non-user-facing.
Version bumped via the existing sync scripts (sync-tauri-version.mjs,
sync-sw-version.mjs) across package.json, src-tauri/Cargo.toml,
src-tauri/tauri.conf.json, src-tauri/Cargo.lock, AGENTS.md, and
public/sw.js's APP_VERSION.
CHANGELOG.md and README.md use the established release-candidate
marker convention (<!-- release-candidate: v1.28.4 -->) so the dated
entry and version badge are truthful before the v1.28.4 tag exists;
both markers are removed in a follow-up post-release truth-sync once
the tag and GitHub Release are published, matching the v1.28.2/v1.28.3
precedent.
TODO.md's Current Sprint section was archived (its final "release cut
remains open" bullet is now resolved β€” v1.28.2 and v1.28.3 both
shipped) and replaced with the actual current sprint: this release cut
followed by the R-15 desktop at-rest encryption priority program.
AUDIT.md is intentionally not touched here β€” its release-gate entry
requires real post-merge CI/CodeQL run evidence that doesn't exist
until after this PR merges and the tag is cut, matching how every
prior release's AUDIT.md entry was written (a follow-up commit, not
part of the release-prep PR itself).
* docs(release): correct premature done-marker on the v1.28.4 TODO item
TODO.md's Current Sprint marked the release cut as done (checked
'v1.28.4' release cut, reconciling ... AUDIT.md truth ...) while this
same PR's own Non-goals section correctly states AUDIT.md is not
touched here, and while no tag, GitHub Release, or release artifacts
exist yet. Corrected to in-progress language naming PR #615 directly
and listing what actually remains pending (tag, release, artifacts,
post-release AUDIT.md evidence).
* docs(release): correct R-15 gate language and credit PR #596's real fix
Two corrections from review, verified against live evidence before
fixing:
1. TODO.md's Current Sprint claimed R-15 desktop at-rest encryption
implementation was being prioritized now. docs/native/DESKTOP-
MIGRATION-ROADMAP-REV3.md explicitly forbids pulling Wave 3/4 R-15
implementation ahead of unresolved Wave 2 authority prerequisites,
and CORE-MIGRATION-LEDGER.md row 10 records
S5_IMPLEMENTATION_READY=NO. Corrected to state R-15 design is
complete but implementation stays gated behind the still-open Wave
2 prerequisite (ledger row 9: the project state-shape compatibility
adapter), which is what this sprint's desktop-storage work actually
is.
2. CHANGELOG.md listed PR #596 only as generic IDB test hardening
under Tests. Verified against its actual diff: deleteDatabase()
previously resolved on a genuine onerror or an onblocked event as
if deletion succeeded, so wipeAllAppData() could report Factory
Reset complete while a database was never actually deleted. onerror
now rejects; onblocked waits for the connection to close before
giving up. This is a real production data-integrity fix, not test
hardening, and now has its own Fixed entry.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filegithub_actionsPull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@qnbs