chore(governance): add scoped PR-size exception for PR #564 - #576
Conversation
The R-15 secure storage contract (docs/native/R15-SECURE-STORAGE-CONTRACT.md) grew past the absolute meaningful-line ceiling through iterative security, durability, migration, recovery, and data-integrity review convergence. check-pr-size.mjs loads config/pr-size-exceptions.json from the PR's base ref, so PR #564 cannot self-authorize this exception -- it must land on main first. Scoped narrowly to PR #564 / design/445-r15-storage-contract: 3 allowed paths (all docs, no executables), a 10-line non-exempt ceiling for the two minimal ledger/classification touch-ups, and a 3200-line supplemental allowance for the contract document itself as a hard ceiling, not a new target.
🤖 CodeAnt AI — Review Status
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR adds a base-ref-loaded, narrowly scoped size exception for PR #564, allowing its 3138-line iterative design diff to pass the documented governance ceiling while preserving strict path, file-type, and line-count limits. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
 |
| Overall Grade | Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Docker |  | Sep 1, 2026 10:29p.m. | Review ↗ |
| JavaScript | | Sep 1, 2026 10:29p.m. | Review ↗ |
| Python | | Sep 1, 2026 10:29p.m. | Review ↗ |
| Rust | | Sep 1, 2026 10:29p.m. | Review ↗ |
| Shell | | Sep 1, 2026 10:29p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
There was a problem hiding this comment.
Review Summary
This PR adds a narrowly-scoped exception to the PR size governance for PR #564. The configuration change is clean and follows the established pattern.
Findings:
- ✅ JSON syntax is valid and well-formed
- ✅ Exception structure is consistent with existing entry (PR #539)
- ✅ Scope is appropriately restrictive (3 markdown files only, no executables)
- ✅ Line limits align with PR description (10 non-exempt lines, 3200 supplemental for contract)
- ✅ Clear justification provided in the
reasonfield
Test Coverage:
Per the PR description, unit tests pass (56/56) and the exception was validated against PR #564's actual SHAs.
No blocking issues identified. The change is ready for merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe change adds a one-time PR-size exception for the R15 secure-storage contract review. The exception defines file, commit, line, and documentation limits and restricts changes to three documentation files. ChangesSecure-storage contract review
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk:⚪ Minimal · up to This change adds a narrowly scoped documentation-only PR-size exception without modifying production code or existing exceptions; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
User description
Summary
config/pr-size-exceptions.jsonfor PR docs(core): define R-15 secure storage contract (#445) #564 (design/445-r15-storage-contract), the R-15 secure storage contract design PR.scripts/check-pr-size.mjsloads the exception registry from the PR's base ref, so PR docs(core): define R-15 secure storage contract (#445) #564 cannot self-authorize this exception — it must land onmainfirst..md, no executables), a 10-line non-exempt ceiling for two minor ledger/classification touch-ups, and a 3200-line supplemental allowance for the contract document itself (a hard ceiling, not a new target). No existing exception (PR chore(graphs): harden dual-graph tooling with pinned versions and fingerprint-based freshness #539) is modified or generalized.Why
PR #564's cumulative diff across its 15-commit iterative security/durability/migration/recovery review-convergence history reached 3138 meaningful lines, just over the docs/governance absolute ceiling (3000). Splitting the contract now, or compressing content merely to fit under the limit, was rejected as worse for review and security quality than a transparent, narrowly-scoped, documented exception — exactly the case this exception mechanism exists for.
Test plan
pnpm exec vitest run tests/unit/tooling/checkPrSize.test.ts— 56/56 passingPR_SIZE_EXCEPTION=APPLIED outcome=within target ... NON_EXEMPT_MEANINGFUL_LINES=3/10 SUPPLEMENTAL_REPORT_LINES=docs/native/R15-SECURE-STORAGE-CONTRACT.md=3135/3200 commits=15/15pnpm run ci:prepush— all local admission checks passSummary by Sourcery
Chores:
CodeAnt-AI Description
Allow the secure-storage contract review PR to pass size checks under a narrowly scoped exception
What Changed
Impact
✅ Secure-storage documentation can complete review without being rejected for size✅ PR-size checks retain strict limits on unrelated changes✅ Production code remains subject to the standard size rules💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit