Ensure installation directory exists before installation - #113
Merged
Merged
Conversation
Added checks to create the installation directory if it does not exist.
Removed redundant definition of INSTALL_DIR.
peterjaap
added a commit
that referenced
this pull request
May 13, 2026
* main: Upload PR build binaries as artifacts and comment links Release v1.17.0 Start only this project's services on magebox start Ensure installation directory exists before installation (#113)
peterjaap
added a commit
that referenced
this pull request
May 13, 2026
* main: Upload PR build binaries as artifacts and comment links Release v1.17.0 Start only this project's services on magebox start Ensure installation directory exists before installation (#113)
peterjaap
added a commit
that referenced
this pull request
May 13, 2026
* main: Upload PR build binaries as artifacts and comment links Release v1.17.0 Start only this project's services on magebox start Ensure installation directory exists before installation (#113)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added checks to create the installation directory if it does not exist.
When I first tried to install it failed and wasn't immediately obvious why.
It will now create the default location and install successfully
